Page MenuHomePhabricator
Create Task
Maniphest T27372

DataNode uses itkCloneMacro(Self) but does not implement a clone method
Closed, ResolvedPublic
Actions

Description

DataNode uses itkCloneMacro(Self) but does not implement the InternalClone methods. Therefore using Clone() defaults to itk::LightObject::InternalClone, thus a nwe instance is created.

Either we should allow cloning but then implement it correctly (with a specific DataNode::InternalClone) or we should not allow it at all.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK1e46d7cea901 Fixed T27372
Restricted Differential RevisionrMITKe3c69e5155fb Fixed T27372

Related Objects

Event Timeline

floca created this task.May 4 2020, 8:25 PM
floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.May 8 2020, 11:02 AM
floca triaged this task as High priority.May 8 2020, 11:48 AM
floca edited projects, added MITK (v2021.02), Noteworthy, Cleared; removed Request for Discussion, MITK.

Discussion results: check in our code base of someone uses the method. If not: Just remove it. If Yes: Look how they used/need it.

floca claimed this task.May 22 2020, 10:40 AM
floca added a project: Request for Discussion.May 22 2020, 11:00 AM
floca removed a project: Request for Discussion.May 22 2020, 1:06 PM
floca added subscribers: franza, seitela.

I have now removed the dysfunctional Clone for now. See D303

The only usages that I have found in the code base where in IGT:

  • QmitkUltrasoundCalibration::OnStartCalibrationProcess()
  • mitk::NavigationTool::NavigationTool(const NavigationTool &other)

I have replaced them with new()/CreatAnother() because this it was Clone() currently was doing.
@seitela @franza : I think it would be good if some one from IGT would check somewhen if there is maybe slumbering an error for long, because you had realy expected a clone (e.g. copied properties, which was never done). If so this could cause new tasks to emerge.

floca closed this task as Resolved by committing rMITKe3c69e5155fb: Fixed T27372.May 23 2020, 11:43 AM
floca added a commit: rMITKe3c69e5155fb: Fixed T27372.
floca added a commit: rMITK1e46d7cea901: Fixed T27372.
floca mentioned this in T27486: Prepare changelog and migration guide for upcoming master merge.Jun 22 2020, 9:57 PM
MITK · MIC · IMSY · DKFZ