Opened this (sub) task to discuss if we should have such an unsave construct in the class. I would judge it as premature optimization. The savest way is to over a getter that always casts the BaseData::Geometry to plane geometry and skip the unmanaed member completly. Was there an known issue, explicit plan why the current pattern was chosen?
Description
Description
Revisions and Commits
Revisions and Commits
| rMITK MITK | |||
| Restricted Differential Revision | rMITKdde92852c0d3 Fixed review remarks | ||
| Restricted Differential Revision | rMITK3679ac58bd8c T27442 Removed unmanaged geometry | ||
| Restricted Differential Revision | rMITK5fbf4a6c399b Deleted unnecessary file | ||
| Restricted Differential Revision | rMITKcf8af6dd2e78 Containes some missed review (D321) changes | ||
| Restricted Differential Revision | rMITK7ad532360885 Removed unmanaged geometry | ||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | floca | T27441 PlanarFigure clone is in invalid state due to copy of unmanged/uncontrolled pointer for PlaneGeometry | ||
| Resolved | floca | T27442 PlanarFigure uses unmanged/uncontrolled pointer for PlaneGeometry |
Event Timeline
Comment Actions
Discussion result: We deem it premature optimization and the unmanaged raw pointer should be removed. Get the geometry from base data and cast it where needed. If the cust does not work. Throw an exception, because it is an exceptional state.