Page MenuHomePhabricator

ImageStatistic check for same geometry is to pedantic
Closed, ResolvedPublic

Description

Currently QmitkImageStatisticsView::CheckForSameGeometry and QmitkImageStatisticsView::GenerateROIPredicate check to pendantic for same geometry (default mitk::eps == 1e10^-14). This e.g. leads to exclusion of images that differ only in the tenth decimal place of an axis vector, which can happen due to rounding effect when storing and loading data. E.g. in one case the parameter fits could not be analysed together with the input image as the differ like noted above.

Proposed solution: Lower the demanded precision used in the named function.
E.g. MaskUtilities that is used by the statistic calculator internally uses only a precision of 0.001 for direction and coordination tolerance in its checks and filters. Spacing is there still checked with mitk::eps but I think thats also to pendantic.
If we use a value it shouldn't be a magic number, but a public constant(s), that is used in the view as well in MaskUtilities to be sure that all use the same and it is clear what they use.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

floca triaged this task as High priority.Tue, Jul 21, 6:21 PM
floca created this task.
floca moved this task from Backlog to Statistics on the MITK (2020) board.
floca claimed this task.Thu, Jul 23, 11:43 AM
floca added a revision: Restricted Differential Revision.Thu, Jul 23, 5:14 PM