Page MenuHomePhabricator
Create Task
Maniphest T2849

TotalVariationFilter used in BasicImageProcessing is internal
Closed, ResolvedPublic
Actions

Description

After removing internal dependencies in Cmake, BasicImageProcessing does not link any more. Clear, because TotalVariationImageFilter is internal.

There was no problem before until I changed this line in CMakeLists.txt:
From: MACRO_CREATE_MITK_PLUGIN(MitkSB MitkSB QmitkExt MitkDiffusionImagingMBI) To: MACRO_CREATE_MITK_PLUGIN(QmitkExt MitkDiffusionImaging)

I will revert these changes for the sake of a green dashboard.

But, Marco: How could the external Continuous DartClient have ever linked against the internal libraries???

Klaus, please have a look at this.

Related Objects
Search...

Event Timeline

• schwarzt added projects: MITK, Bugzilla.Nov 4 2009, 8:57 PM
• schwarzt added a subscriber: • schwarzt.Nov 4 2009, 9:09 PM

Okay, bad documentation.
SVN Rev. 19899 (and Rev. 19900) show the problem.

Removing the internal dependencies (in 19899) of BasicImageProcessing (public MITK)lead to a (correct) error:
/QmitkBasicImageProcessingView.cpp:61:51: error: itkTotalVariationDenoisingImageFilter.h: No such file or directory

This is correct because itkTotalVariationDenoisingImageFilter.h is in \mbi-sb\Core\Algorithms.

Windows does not show this error.

fritzsck added a subscriber: fritzsck.Nov 12 2009, 9:43 AM

No idea how this can work, external dependencies to MitkSB should crash, I would suppose.

I would suggest moving all filters to the public repository. Seven files are affected:

/mbi-sb/Core/Algorithms:

  • itkLocalVariationImageFilter.h
  • itkLocalVariationImageFilter.txx
  • itkTotalVariationDenoisingImageFilter.h
  • itkTotalVariationDenoisingImageFilter.txx
  • itkTotalVariationSingleIterationImageFilter.h
  • itkTotalVariationSingleIterationImageFilter.txx

mbi-sb/Testing

  • itkTotalVariationDenoisingImageFilterTest.cpp

They should be moved to

mitk/Core/Code/Algorithms and mitk/Core/Code/Testing respectively.

maleike added a subscriber: maleike.Nov 12 2009, 10:02 AM

Could you please also open a new bug, that someone submits this filter to ITK?

fritzsck added a comment.Nov 12 2009, 10:06 AM

I am working on this. Code and documentation is all lined up, just need some time to write a little paper for the Insight-Journal.

Bug created (#2932)

fritzsck added a comment.Nov 12 2009, 10:36 AM

[SVN revision 20061]
FIX (#2849): moved to from sandbox to core

• schwarzt added a comment.Nov 12 2009, 10:37 AM

I will check it.

fritzsck added a comment.Nov 12 2009, 10:37 AM

[SVN revision 20062]
FIX (#2849): removed unneccessary dependencies to sandbox

fritzsck added a comment.Nov 12 2009, 10:38 AM

done

fritzsck added a comment.Nov 12 2009, 11:04 AM

Linux machines don't like the test and bring up some singular matrix error.. trying to resolve this.

muellerm added a subscriber: muellerm.Nov 12 2009, 11:14 AM

[SVN revision 20063]
COMP (#2849): Fixed itkTotalVariationDenoisingImageFilterTest.cpp spacing errors

• schwarzt added a comment.Nov 12 2009, 2:46 PM

Seems to work.
Let's check tomorrows dart client, then close.

nolden added a subscriber: nolden.Nov 12 2009, 4:38 PM

just discussed this with tobi: the MACRO_CREATE_MITK_PLUGIN checks whether the necessary modules exist. If they don't exist, like in the open source version, the bundle is not build and a configure warning is issued which should appear on the dashboard.

• schwarzt added a comment.Nov 12 2009, 4:40 PM

Just found it:
Warning: org.mitk.gui.qt.basicimageprocessing is missing requirements and won't be built. Missing: MitkSB;MitkDiffusionImagingMBI

nolden added a comment.Jul 27 2011, 11:43 AM

Merging "applicazion modules" component with "ExtApp plugins"

MITK · MIC · IMSY · DKFZ