In rMITK53805c223beb: marked unused overwrite filters as deprecated two classes (mitkOverwriteDirectedPlaneImageFilter, mitkOverwriteSliceImageFilter) were marked as deprecated. This happened in 2012.
In rMITKc9037280cb9f: made otsu action deprecated and removed it from DataManager QmitkOtsuAction inside the org.mitk.gui.qt.segmentation plugin, which is not listed in the files.cmake-file, was marked deprecated and is not used anywhere anymore. This happened in 2013.
In rMITKfcb31c986f70: Merge branch 'bug-15172-fixes-3Dthreshold' into bug-15068-segmentation-UI… QmitkThresholdAction inside the org.mitk.gui.qt.segmentation plugin was removed and is not used anywhere anymore. This happened in 2013.
Description
Revisions and Commits
rMITK MITK | |||
Restricted Differential Revision | rMITKb963a9fe4f47 Remove deprecated classes related to segmentation. | ||
Restricted Differential Revision | rMITKb95801f76874 Remove unused QmitkThresholdAction | ||
Restricted Differential Revision | rMITK696294086464 Update undo/redo description | ||
Restricted Differential Revision | rMITKc8043fb0b8bb Remove deprecated QmitkOtsuAction | ||
Restricted Differential Revision | rMITK2f4a2d1e5abc Remove deprecated OverwriteDirectedPlaneImageFilter | ||
Restricted Differential Revision | rMITK8431213e6e67 Remove deprecated OverwriteSliceImageFilter |
Related Objects
- Mentioned In
- T28713: 2021 Week 39 (Very Early October)
- Mentioned Here
- rMITKfcb31c986f70: Merge branch 'bug-15172-fixes-3Dthreshold' into bug-15068-segmentation-UI…
rMITKc9037280cb9f: made otsu action deprecated and removed it from DataManager
rMITK53805c223beb: marked unused overwrite filters as deprecated
Event Timeline
When deprecated classes are still around for a long time it is a valid base assumption that the reason is just that they were either forgotten since they weren't used or seen for a long time, or that it is surprisingly difficult to actually get rid of them since there's no real replacement for example but they are still in heavy use. The latter reason is something seen rather often in the core unfortunately.
Another deprecated class: Just found out there is a QmitkOtsuAction inside the org.mitk.gui.qt.segmentation, which is not listed in the files.cmake-file. It was deprecated in rMITKc9037280cb9f: made otsu action deprecated and removed it from DataManager and it's not used anywhere anymore.
When I look for occurrences of mitkOverwriteSliceImageFilter, I see a description inside ApplyDiffImageOperation and DiffImageApplier that says
At the moment, ApplyDiffImageOperations are only created by OverwriteSliceImageFilter.
or
Instances of this class are created e.g. by OverwriteSliceImageFilter.
However, the mentioned mitkOverwriteSliceImageFilter is nowhere used and was replaced by mitkVtkImageOverwrite. I found occurrences of ApplyDiffImageOperation and DiffImageApplier inside QmitkSlicesInterpolator.cpp, so I changed the description accordingly.
A first differential was created. There is another class QmitkThresholdAction that is not included anywhere and has not been touched for a long time. I don't see any reason for keeping this class. So I updated the differential with the removal of this class as well.