Page MenuHomePhabricator

Use NodePredicates for the render window data node selector
Closed, ResolvedPublic

Description

Using the "Data" drop down menu inside a render window widget always shows the helper-nodes that form the crosshair. We should add a NodePredicate, similar to the DataManager, to only show the important data nodes.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kalali triaged this task as Normal priority.Oct 7 2022, 10:48 AM
kalali created this task.

I looked into this and I was confused: the used QmitkRenderWindowDataStorageTreeModel already contains a node predicate for filtering out the helper nodes. When creating the mxnmultiwidget (or a new render window) there are no plane geometries (the crosshair) being added to the storage model.

When I looked a bit deeper, I found the following:

  • the NodeAdded function of the QmitkAbstractDataStorageModel is connected to the AddNodeEvent of the data storage
  • this is a pure virtual function and needs to be implemented by subclasses
    • in this case it is implemented via the QmitkRenderWindowDataStorageTreeModel
  • here no predicate is checked
    • this also holds true for QmitkDataStorageSimpleTreeModel::NodeAdded
kalali renamed this task from Use NodePreidcates for the render window data node selector to Use NodePredicates for the render window data node selector.Oct 7 2022, 5:33 PM
kalali added a revision: Restricted Differential Revision.Oct 7 2022, 5:47 PM
kalali claimed this task.
kalali edited projects, added MITK (v2022.10); removed MITK.