Since mitk::DataStorage MITK does not need mitk::DataTree anymore. However the source files remain in the repository and DataTree is referenced in a couple of classes. Should this be cleaned up for the 1.0 release?
Description
Description
Event Timeline
Comment Actions
From the 'MITK is ExtApp' point of view, I agree.
From a 'MITK is a toolkit full of builing blocks that each developer can use to create his own application' point of view, I think, it would not hurt if we offer the DataTree as an alternative to the DataStorage.
From a software engineer point of view, I think the current double-integration of DataStorage & DataTree in the rendering component is a big mess that needs to be cleaned up.
Comment Actions
(In reply to comment #1)
From the 'MITK is ExtApp' point of view, I agree.
From a 'MITK is a toolkit full of builing blocks that each developer can use to
create his own application' point of view, I think, it would not hurt if we
offer the DataTree as an alternative to the DataStorage.
Currently DataTree is ONLY a container with hierarchy and a couple of iterators. It is not used or tested anymore.
From a software engineer point of view, I think the current double-integration
of DataStorage & DataTree in the rendering component is a big mess that needs
to be cleaned up.
This was already cleaned up. There is currently no reference to DataTree in rendering. However there are lots of files including mitkDataTree.h or and DataTreeIteratorClone things. I'll attach a patch that shows which classes would be affected.
Comment Actions
These are the changes for removing DataTree (plus a couple of my local modificatios, so this patch should not applied as it is).
There some more similar changes in DKFZ internal code: /home/maleike/patches/patch-datatree-complete.patch
Comment Actions
Update of the patch for removal. Not much left to do now, only
(removed)
mitkDataTree.*
mitkDataTreeHelper.*
mitkDataTreeStorage.*
(modified)
mitkCommonFunctionality.*
Comment Actions
[SVN revision 21362]
FIX (#3293): removed unnecessary function OnImageSelected() in QmitkPathPlanningView and QmitkPathPlanningWidget to remove dependencies to DataTree