Page MenuHomePhabricator

Tab rendering in the workbench is ugly on MacOS
Closed, ResolvedPublic

Description

Using a QTabBar and a QWidget vertically looks strange on MacOS.

Related Objects

Event Timeline

Resetting all bugs without active assignee flag to "CONFIRMED". Change status to IN_PROGRESS if you are working on it.

This bug could not be fixed within the 2013-06 release and has medium severity. Setting target milestone to unspecified.

This bug could not be fixed within the release 2013-06. Setting its target milestone to unspecified

The initial widget displacement could be forced by the qt osx tab layout.

Screen Shot 2015-03-25 at 16.16.00.png (842×715 px, 81 KB)

User fetzer has pushed new remote branch:

bug-5922-coronal-shift-blueberry-tab-issue-macosx

In the branch some obsolete fixes for Mac OS X were removed, which seem to fix this issue.
Now the layout is slightly different:

  • The WorkbenchPage has a bigger margin
  • The statusbar look slightly different

However compared to the previous issues (overlapping tabs and the coronal shift) I can live with that.

Would be great if any other Mac user could test the provided fix.

[7fb5c8]: Merge branch 'bug-5922-coronal-shift-blueberry-tab-issue-macosx'

Merged commits:

2015-05-28 13:38:08 Andreas Fetzer [99cf7b]
Fixed ugly tab layout and resulting coronal shift

Removed some unused apple specific fixes which seems to be obsolete
due to the recent blueberry changes

I tested the recent changes and it looks good. The shift isn't and the tabs are correctly initialized. The statusbar changes and the bigger margin are inconspicuous.