In it's current version, superbuild does not allow to define custom compiler-debug-flags to be used for compiling dependencies like ITK and VTK.
However, this might be necessary in order to ensure compiler-flag consistency between QT and the rest of the dependencies.
I pushed a fix for this issue to remotes/origin/bug-7035-superbuild-custom-compiler-flags
Marco, could you have a brief look at this? The changes are minimal but should do the trick.
I tested the branch on linux, looks ok. But could you please add the other flags as well: release etc. And we should wait for a final ok from Sascha, cc.
Are the quotes around the arguments not necessary any more? I thought Marco had problems without them. Otherwise looks fine to me, just two things:
1.) Could you do the same for CMAKE_<lang>_FLAGS_RELEASE to avoid surprises with custom release flags in the future?
2.) You could use the existing T6517 and its branch for your modifications (rebase your local branch on bug-6517-mitk-superbuild, optionally rename your local branch, amend any changes to your locally rebased commit(s) and push to origin/bug-6517-mitk-superbuild)
Ok, I added the flags for release and relwithdebinfo and rebased the commits to the bug-6517-mitk-superbuild branch.
Looking fit to merge to master now or did I miss something?
Looks pretty good to me, thanks!
If you want to beautify it a little more, you could group the compiler flags according to your comments (release flags are below the "# debug flags" comment and vice versa)... :-)
Thanks for taking care of it.
Fixes fot this bug have been committed in push [c356cc] with branch 'bug-6517-mitk-superbuild'
-> this bug can be closed