Page MenuHomePhabricator

It's possible to create an invalid PlanarCross
Closed, ResolvedPublic

Description

It's currently possible to create an invalid PlanarCross.

Create one normally, modify one control-point set the third control-point and do not move the mouse.
-> The fourth control-point is positioned falsely the position it was located at before resetting.

The porblem behind this is the a bug in the new control-point datatypes. A new control-point is appended to the list. However, this point is at control-point list position 5 instead of 4 because of the previously set point

-> simply resize the list if the maximum number of control-points would be overrun...

Event Timeline

[4c5691]: Merge branch 'bug-8185-invalid-planarcross'

  • bug-8185-invalid-planar

Merged commits:

2011-05-24 14:10:23 Markus Engel [b65481]
resetting m_ControlPoints to ensure correctness of PlanarCross


2011-05-17 19:53:19 Markus Engel [e741d8]
Merge branch 'bug-8134-statistics-refresh-planarfigure' into releases/snapshot-201105-preparation

  • bug-8134-statistics-refresh-planarfigure: replaced const pointer with normal pointer in imagestatistics removed unnecessary includes

2011-05-16 17:32:30 Daniel Maleike [6bae87]
Merge remote branch 'remotes/origin/bug-8078-snapshot-integration' into releases/snapshot-201105-preparation


2011-05-16 17:31:18 Daniel Maleike [09e894]
Merge branch 'bug-7285-ensure-correct-slice-positions' into releases/snapshot-201105-preparation


2011-05-13 19:26:31 Daniel Maleike [336df5]
Merge remote branch 'remotes/origin/bug-8052-snapshot-integration' into releases/snapshot-201105-preparation


2011-05-13 19:24:46 Daniel Maleike [49f47f]
Merge remote branch 'remotes/origin/bug-7807-planararrow-tip-size' into releases/snapshot-201105-preparation


2011-05-13 19:24:32 Daniel Maleike [346320]
Merge remote branch 'remotes/origin/bug-7802-planarfigure-shadow' into releases/snapshot-201105-preparation


2011-05-11 12:00:15 Markus Engel [52c0fe]
Merge branch 'bug-8048-snapshot-integration' into releases/snapshot-201105-preparation

  • bug-8048-snapshot-integration: removing unnecessary itkWarning

2011-05-06 18:18:38 Daniel Maleike [f50049]
Merge branch 'bug-7285-ensure-correct-slice-positions' into releases/snapshot-201105-preparation


2011-05-05 16:24:42 Daniel Maleike [82a964]
Merge branch 'bug-7285-ensure-correct-slice-positions' into releases/snapshot-201105-preparation

Conflicts:
Core/Code/IO/mitkDicomSeriesReader.h


2011-05-05 15:41:17 Daniel Maleike [fd63d0]
Merge branch 'bug-8052-snapshot-integration' into releases/snapshot-201105-preparation


2011-05-05 15:40:53 Daniel Maleike [7bcf31]
Merge branch 'bug-8048-snapshot-integration' into releases/snapshot-201105-preparation

Review:

Fehler ist behoben, tritt nun nicht mehr auf. Codeänderung ist klar und einfach, alles okay.