Page MenuHomePhabricator

Clarify meaning of Global Reinit vs Reinit
Closed, ResolvedPublic

Description

The behaviour of global reinit and reinit is unclear.

e.g.

  • load a rotated 2D image (find one at T:\temp\Extracted2DMitralValve.nrrd)
  • perform global reinit
  • perform reinit on this image

Once the image is rotated 180° and the other time it is not. Is this a normal behaviour? Somebody please specify exactly what Global Reinit and Reinit should do.

possible connections:
T6278 ?
T6509

Event Timeline

We decided to declare the following behaviour as desired behaviour:

Reinit: Orient camera viewport (position and axis) so that the selected datanode is fully displayed. Camera axis are oriented respective to node geometry.

Global Reinit: Orient camera viewport so that all datanodes are fully displayed. Camera axis is oriented to standard world geometry.

A proper documentation for this is needed! It might also be a good idea to rename the functions:

Reinit : Camera reinit to node axis
Global Reinit : Camera reinit to world axis

just a suggestion

There exists another Reinit-Type: You can perform a "Reset View" via the RenderWindowMenue.

This makes exactly the same as the Global Reinit except that the Global Reinit additionally reopens the MultiWidgetEditor if it has been closed before.

When someone fixes this bug:

Please have a look at T15429 where I mention naming issues:
-Reinit (in GUI) is not named "Reinit()" in the code and thus hard to find for programmers
-The names are confusing for programmers (in the code) and for (medical!) users in the GUI

Is this still valid? I'm currently reworking the context menu and the multi widget editor and don't fully understand the problem. Maybe the bug is invalid since a long time?

kislinsk claimed this task.
kislinsk added a subscriber: kislinsk.

Yes, there was quite some work on Reinit in the meantime.