Page MenuHomePhabricator
Create Task
Maniphest T9739

Discuss and create a new module for "ImageFilters"
Closed, DuplicatePublic
Actions

Description

Currently, there are two image denoising filters located in Core\Core\Algorithms. The total variation and the bilateral filter.

We have some more denoising filters in ToFProcessingMBI:
-adaptive bilateral, gauss, median, fast bilateral etc.

Furthermore, the module "ImageExtraction" is quite small.

Marcos suggestion is to create a module for "ImageToImage", name it ImageFiltering and move all those filters there.

Another possibility is to create a module just for "ImageDenoising" and keep "ImageExtraction".

Related Objects

Event Timeline

• kilgus added projects: MITK, Bugzilla.Oct 13 2011, 5:38 PM
• kilgus added a subscriber: • kilgus.Jun 4 2012, 7:19 PM

I think this bug is actually a crucial built-time issue. Since the mitkBilateralFilter is a call of many macros to generate lots of different function calls to itk templated methods, its compile time is very high. I realize that escpecially on my new machine where the mitkBilateralFilter takes extremely long to build.

As this is mostly clean-up work and build-performance-related i put a party flag her and alfred in cc.

We only have to decide which filters to put in the module! Afterwads we can even declare this a party_easy bug.

maleike added a subscriber: maleike.Jun 21 2012, 1:12 PM

Removing the flag because I don't understand the issue. Assigned to Marco, Thomas reports, Christoph requests flag, solution still to be discussed.

I wouldn't mind Marco's suggestion, sounds reasonable. Would be helpful to see the dependency graphs for both options, though.

• kolbch added a subscriber: • kolbch.Jun 27 2012, 1:35 PM

We have pushed the changes Marco suggested into the branch "bug-9739-NewModuleForImageFilters".
The changes in mitk are very minor, because the BilateralFilter is not used in mitk and the ImageExtraction module was only used in the ImageStatistics module.

kislinsk closed this task as a duplicate of T17349: Module ImageDenoising.Aug 1 2016, 10:47 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ