Page MenuHomePhabricator
Feed All Stories

Aug 26 2019

kalali added a comment to T24358: Rework QmitkMouseModeSwitcher.

Pushed new branch T24358-Remove-QmitkMouseModeSwitcher.

Aug 26 2019, 12:44 PM · MITK
kalali added a comment to T24358: Rework QmitkMouseModeSwitcher.

A new class, the QmitkInteractionSchemeToolBar has already been introduced in 9ab09bff137b. This class is used as a replacement for the QmitkMouseModeSwitcher. It it a simplified version which does not observe the mouse mode switcher / interaction scheme switcher. There is no observer tag and no block-functionality.
Additionally, the tool bar is adjusted to match the new InteractionSchemeSwitcher (see T24357): There is no difference anymore between a mouse mode and an interaction scheme (see T24368).
The new toolbar is used for the mxnmulwiwidgeteditor and is currently tested with the stdmultiwidgeteditor (see 732f754ad203).

Aug 26 2019, 12:39 PM · MITK
kalali closed T24368: Interaction scheme has different level of interaction, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Aug 26 2019, 11:39 AM · MITK
kalali closed T24368: Interaction scheme has different level of interaction as Resolved.

Has been solved on top of T26476.

Aug 26 2019, 11:39 AM · MITK
kalali added a comment to T24368: Interaction scheme has different level of interaction.

Pushed new branch T24368-Adjust-display-config-files.

Aug 26 2019, 11:34 AM · MITK
kalali added a comment to T24368: Interaction scheme has different level of interaction.

I decided to go for having an own complete .xml-file for each mode, so I added the full definition for the different PACS modes.
The reason is that we want to have a consistent interaction scheme-handling which means either having full definition for both MITK and PACS modes or having base- and additional definition (like the original PACS modes). But changing the MITK configuration files to the base- and extra-mode variant requires event_variants to be empty in order to disable certain mouse events. Additionally any implementation needs to do two calls, one for setting the base-mode and one for adding the extra mode to make sure the correct base-mode is always set (e.g. switching from MITK to PACS). This was undesirable.

Aug 26 2019, 11:16 AM · MITK
reicht closed T26308: Encrypt tranfers as Resolved.

encryption works as expected

Aug 26 2019, 10:23 AM · CSI-HD

Aug 24 2019

alenauus triaged T26643: Compilation errors (QT5): "error: 'trUtf8' is deprecated" as Unbreak Now! priority.
Aug 24 2019, 9:04 PM · MITK

Aug 23 2019

kalali closed T19643: Interaction problems occur between segmentation tools and renderwindow menu as Invalid.

I'm not sure if this is a valid issue.
I can reproduce the observable result if I don't disable the segmentation tool. I'm still in the drawing mode if the segmentation tool is enabled. If I change the display interaction mode now (by enabling Crosshair rotation (or any other mode - also No crosshair rotation), the MITK interaction scheme is enabled and both interactions happen at the same time (navigating and drawing).
Disabling and re-enabling the tool will again overwrite the navigation interaction and allow to draw the segmentation without any problems.

Aug 23 2019, 6:09 PM · MITK, Bugzilla
kalali closed T19118: Scroll mode in PACS like mouse interaction not re-enabled after using segmentation tool as Invalid.

I can not reproduce this.
After having deselected the Region Growing tool, I can use the left mouse button and move the mouse to scroll through the slices. "Normal" scrolling (does this mean scrolling using the mouse wheel?) does not work. Notice that you can always scroll by pressing the middle mouse and moving the mouse (regardless of the selected PACS mode).
However, in T26486 I changed the PACS mode such that you can always scroll through the slices using the mouse wheel (regardless of the selected PACS mode). The special PACS scroll mode still works for fast scrolling (left mouse button and mouse moving).

Aug 23 2019, 5:58 PM · Bugzilla, MITK
kalali closed T24635: PACS scroll leads to an infinite loop if no image is loaded as Resolved.

Has been solved on top of T26476.

Aug 23 2019, 5:39 PM · MITK
kalali added a comment to T24635: PACS scroll leads to an infinite loop if no image is loaded.

Pushed new branch T24635-Prevent-infinite-scroll-loop.

Aug 23 2019, 5:39 PM · MITK
kalali claimed T24635: PACS scroll leads to an infinite loop if no image is loaded.
Aug 23 2019, 5:16 PM · MITK
kalali closed T26486: PACS mouse mode does not allow scrolling with mouse wheel as Resolved.
Aug 23 2019, 5:10 PM · Breaking Change, MITK (v2021.10)
kalali added a comment to T26486: PACS mouse mode does not allow scrolling with mouse wheel.

Pushed new branch T26486-PACS-mouse-mode-with-mouse-wheel-scrolling.

Aug 23 2019, 5:09 PM · Breaking Change, MITK (v2021.10)
kalali closed T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions as Resolved.
Aug 23 2019, 4:46 PM · Restricted Project, MITK
kalali added a comment to T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions.

Pushed new branch T26642-Restore-original-interactions.

Aug 23 2019, 4:34 PM · Restricted Project, MITK
kalali added a parent task for T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions: Unknown Object (Maniphest Task).
Aug 23 2019, 3:53 PM · Restricted Project, MITK
kalali triaged T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions as Normal priority.
Aug 23 2019, 3:53 PM · Restricted Project, MITK
metzger removed a watcher for Kaapana (internal): metzger.
Aug 23 2019, 12:20 PM

Aug 22 2019

kalali added a comment to T26486: PACS mouse mode does not allow scrolling with mouse wheel.

Combine with T24356 (esp. T24368).

Aug 22 2019, 5:50 PM · Breaking Change, MITK (v2021.10)

Aug 21 2019

floca added a comment to T25804: [Selection concept] Set 'selected' property when using the new selection concept.

OK. But we definetly should talk about it before it is approached.

Aug 21 2019, 7:10 PM · MITK (v2024.06), Request for Discussion
reicht added a comment to T26308: Encrypt tranfers.
  1. encoding File/Blob object to ArrayBuffer (needed as input for AES encryption) crashes browser (tested on Chrome) if file is bigger 1GB:
    • check chunking
Aug 21 2019, 3:22 PM · CSI-HD
neher closed T26421: [CmdInterface] process special characters as Wontfix.
Aug 21 2019, 2:21 PM

Aug 20 2019

reicht updated the task description for T26308: Encrypt tranfers.
Aug 20 2019, 10:46 AM · CSI-HD
reicht changed the visibility for T26299: [Webbased DICOM parsing and file handling].
Aug 20 2019, 10:31 AM · CSI-HD
reicht assigned T26301: Browserbased parsing and identification of DICOM files to d485r.
Aug 20 2019, 10:24 AM · CSI-HD

Aug 19 2019

floca added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

@kalali: Sharp eyes and good work. As far as I can see this is a proper solution to fix a state I had not covered in my implementation. The handling of invalid timepoints is still okay. As the documentation only guaranties that negative invalids will be 0. For all others there are no garanties and developers should use GetTimeBounds() to check wether they request legal time points or not.

Aug 19 2019, 2:07 PM · MITK
kraeuter added a comment to T26269: [image statistics plugin] refactor to use new node selection widget.

Pushed new branch T26269-ChangeSelectionInStatisticsPlugin.

Aug 19 2019, 12:07 PM · MITK

Aug 17 2019

reicht added a comment to T26308: Encrypt tranfers.

ToDos

  • implement final caseID socketbased
  • port encryptData to socketbased
  • distinguish between uploading sites (such as CSI, E010, etc.)
  • when decrypting, differentiate between files and string
  • include IV of encrypted file
  • include client PublicKey
  • can formData be transported by websockets
    • compile needed socket.emit statement. emit supports Buffer
Aug 17 2019, 11:08 PM · CSI-HD
reicht changed the visibility for T26308: Encrypt tranfers.
Aug 17 2019, 11:07 PM · CSI-HD
reicht reopened T26308: Encrypt tranfers as "Open".
Aug 17 2019, 11:07 PM · CSI-HD
reicht changed the visibility for T26306: Identify a web-framework to operate a Server.
Aug 17 2019, 11:05 PM · CSI-HD
reicht changed the visibility for T26301: Browserbased parsing and identification of DICOM files.
Aug 17 2019, 11:05 PM · CSI-HD
reicht changed the visibility for T26308: Encrypt tranfers.
Aug 17 2019, 11:04 PM · CSI-HD
reicht closed T26308: Encrypt tranfers as Resolved.

First initialize a TLS based websocket connection between browser and server. In addition encrypt the files using AES-GCM 256. Key to encrypt files is computed using ECDH P-384. Private/Public Key for ECDH is generated independently from the TLS secured websocket connection.

Aug 17 2019, 11:04 PM · CSI-HD
reicht closed T26306: Identify a web-framework to operate a Server as Resolved.

Koa.js is the way to go in this case

Aug 17 2019, 11:03 PM · CSI-HD
reicht closed T26307: Identify a proper Transfer technology as Resolved.

First initialize a TLS based websocket connection between browser and server. In addition encrypt the files using AES-GCM 256. Key to encrypt files is computed using ECDH P-384. Private/Public Key for ECDH is generated independently from the TLS secured websocket connection.

Aug 17 2019, 11:02 PM · CSI-HD
reicht changed the visibility for T26307: Identify a proper Transfer technology.
Aug 17 2019, 10:58 PM · CSI-HD
reicht moved T26308: Encrypt tranfers from DKFZ ToDo to Doing on the CSI-HD board.
Aug 17 2019, 10:57 PM · CSI-HD
reicht moved T26306: Identify a web-framework to operate a Server from DKFZ ToDo to Doing on the CSI-HD board.
Aug 17 2019, 10:57 PM · CSI-HD
reicht moved T26307: Identify a proper Transfer technology from DKFZ ToDo to Doing on the CSI-HD board.
Aug 17 2019, 10:57 PM · CSI-HD
reicht changed the visibility for T26301: Browserbased parsing and identification of DICOM files.
Aug 17 2019, 10:56 PM · CSI-HD
reicht closed T26301: Browserbased parsing and identification of DICOM files, a subtask of T26299: [Webbased DICOM parsing and file handling], as Resolved.
Aug 17 2019, 10:56 PM · CSI-HD
reicht closed T26301: Browserbased parsing and identification of DICOM files as Resolved.

cannot be accomplished using cornerstone, since errors are thrown if non-dicom filesize is below "proper" DICOM file. Therefore we implemented our own routine to check if incoming filesize is below 132 bits, otherwise check if bits from 128 to 132 represent "DICM".

Aug 17 2019, 10:56 PM · CSI-HD
pfjaeger <p.jaeger@dkfz.de> committed rMDTPUBLIC5b6bea6884ec: fixed channel dimension in lidc dataloader. Fixed unknown input argument in… (authored by pfjaeger <p.jaeger@dkfz.de>).
fixed channel dimension in lidc dataloader. Fixed unknown input argument in…
Aug 17 2019, 3:55 PM

Aug 16 2019

eisenman closed T26632: Saved calibrated IGT tool cannot be loaded anymore as Resolved.
Aug 16 2019, 4:22 PM · IGT, MITK
eisenman committed rMITKdc8f1d5204b9: Merge branch 'T26632-EnsureFileSuffixForCalibratedTool' (authored by eisenman).
Merge branch 'T26632-EnsureFileSuffixForCalibratedTool'
Aug 16 2019, 4:21 PM
eisenman added a comment to T26632: Saved calibrated IGT tool cannot be loaded anymore.

Pushed new branch T26632-EnsureFileSuffixForCalibratedTool.

Aug 16 2019, 4:19 PM · IGT, MITK
kalali added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

I think the problem is here: https://phabricator.mitk.org/source/mitk/browse/master/Modules/Core/src/DataManagement/mitkArbitraryTimeGeometry.cpp$124
The m_MaximumTimePoints for the 3D+t-Heart image is [103, 160, 160]. The last timePoint argument is 160. So in the first iteration if (timePoint < *pos) will be false. Next two iterations it will be false as well since 160 is not less than 160. This will lead to result being 0 at the end of the function.
Normally the m_MaximumTimePoints for another time-image is something like [41, 46, 51] and the timePoint argument will be 46 for the last timestep.
This could be solved by using something like this:

mitk::TimeStepType mitk::ArbitraryTimeGeometry::TimePointToTimeStep(TimePointType timePoint) const
{
  mitk::TimeStepType result = 0;
Aug 16 2019, 4:00 PM · MITK
eisenman moved T26632: Saved calibrated IGT tool cannot be loaded anymore from Backlog to In Progress on the IGT board.
Aug 16 2019, 3:44 PM · IGT, MITK
eisenman closed T26635: IGT tools from loaded tool storage are not rendered automatically as Resolved.
Aug 16 2019, 3:43 PM · IGT, MITK
eisenman committed rMITKb434c99c6919: Merge branch 'T26635-RenderToolsLoadedFromToolStorageFile' (authored by eisenman).
Merge branch 'T26635-RenderToolsLoadedFromToolStorageFile'
Aug 16 2019, 3:42 PM
eisenman added a comment to T26635: IGT tools from loaded tool storage are not rendered automatically.

Pushed new branch T26635-RenderToolsLoadedFromToolStorageFile.

Aug 16 2019, 3:40 PM · IGT, MITK
steint reopened T18450: Inconsistent data selection between Measurement and Statistic as "Open".

Solved when T26269 is solved.

Aug 16 2019, 3:37 PM · Bugzilla, MITK
eisenman moved T26635: IGT tools from loaded tool storage are not rendered automatically from Backlog to In Progress on the IGT board.
Aug 16 2019, 3:33 PM · IGT, MITK
eisenman closed T26634: Loaded IGT tool is not rendered automatically as Resolved.
Aug 16 2019, 3:33 PM · IGT, MITK
kausch added a comment to T26630: Batchgenerators: Access transformation parameters used in batchgenerator augmentations.

It has been resolved in branch T26630-AccessAugmParams

Aug 16 2019, 3:22 PM · Deep Learning
eisenman committed rMITKd1d4ddab5760: Merge branch 'T26634-RenderLoadedIGTTool' (authored by eisenman).
Merge branch 'T26634-RenderLoadedIGTTool'
Aug 16 2019, 3:04 PM
eisenman added a comment to T26634: Loaded IGT tool is not rendered automatically.

Pushed new branch T26634-RenderLoadedIGTTool.

Aug 16 2019, 3:02 PM · IGT, MITK
eisenman moved T26634: Loaded IGT tool is not rendered automatically from Backlog to In Progress on the IGT board.
Aug 16 2019, 2:30 PM · IGT, MITK
eisenman triaged T26635: IGT tools from loaded tool storage are not rendered automatically as Normal priority.
Aug 16 2019, 2:17 PM · IGT, MITK
eisenman triaged T26634: Loaded IGT tool is not rendered automatically as Normal priority.
Aug 16 2019, 2:02 PM · IGT, MITK
kalali renamed T26633: [mxn multi widget] Show different time points of data from [mxn multi widget] Shof different time points of data to [mxn multi widget] Show different time points of data.
Aug 16 2019, 1:58 PM · Restricted Project, MITK
kalali added a project to T26633: [mxn multi widget] Show different time points of data: Restricted Project.
Aug 16 2019, 1:58 PM · Restricted Project, MITK
kalali triaged T26633: [mxn multi widget] Show different time points of data as Normal priority.
Aug 16 2019, 1:58 PM · Restricted Project, MITK
kalali added a comment to T25030: Image navigator time slider moves twice.

See T24766.
I also experienced the two-step when debugging but using only console-output this does not happen with other time-data than 3D+t-Heart.

Aug 16 2019, 1:41 PM · MITK (v2021.02)
eisenman added a comment to T26632: Saved calibrated IGT tool cannot be loaded anymore.

The issue with the missing file extension only occurs on Linux.

Aug 16 2019, 1:41 PM · IGT, MITK
kalali added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

This does not happen with the new mxn multi widget. Maybe connected to the render windows being synchronized / plane nodes when using the StdMultiWidget?

Aug 16 2019, 1:40 PM · MITK
kalali added a comment to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.

Is this still valid? I looked at it but couldn't reproduce the bug.
If you can reproduce it, could you try to reproduce it with Pic2DplusT and MITK-Data/3D+t-ITKIO-TestData as well?

Aug 16 2019, 12:36 PM · MITK, Restricted Project
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I created such a segmentation on the 3D+t-heart dataset and stored the segmentation as *.nrrd. The I loaded the *.nrrd-segmentation again and I now I can only see the segmentation on the first timestep.
Important: The timesteps of the *.nrrd-segmentation are now from 0 - 3 and with a duration of 1ms. The original 3D+t-Heart was [0,103] [103,160] [160, 160]. This was also true for the original segmentation. If I store the 3D+t-Heart image as *.nrrd and reopen it again the original timesteps are preserved.

Aug 16 2019, 12:19 PM · MITK
kraeuter claimed T26269: [image statistics plugin] refactor to use new node selection widget.
Aug 16 2019, 12:06 PM · MITK
kalali updated subscribers of T18450: Inconsistent data selection between Measurement and Statistic.

Please talk to @kraeuter to as she is currently working on T26269

Aug 16 2019, 12:04 PM · Bugzilla, MITK
eisenman triaged T26632: Saved calibrated IGT tool cannot be loaded anymore as Normal priority.
Aug 16 2019, 11:58 AM · IGT, MITK
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I also tried it with MITK-Data/3D+t-ITKIO-TestData and everything works fine (segmentation and time-slider). However, a difference between all these time-images and the 3D+t-Heart// image is, that the Heart-image does not actually have a third timepoint, as the third timepoint is of length 0ms.
So maybe there is a problem with the matching of time points and the segmentation is displayed for the last time point, as the lats time point is actually non-existent and wraps around to the time point 0.

Aug 16 2019, 11:49 AM · MITK
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I just tried this and I can reproduce it with MITK-Data/3D+t-Heart. But when I used Pic2DplusT the segmentation was only created on a single timestep.
Additionally, when I clicked on the arrows of the time-slider of the image navigation plugin the time slider sometimes wraps around the last time step and returns to timestep 0. This was already mentioned here T25030. However, this does not happen If I use the Pic2DplusT image so maybe the 3D+t-Heart image is corrupt?

Aug 16 2019, 11:40 AM · MITK
steint closed T18450: Inconsistent data selection between Measurement and Statistic as Resolved.

The new implementation of the image statistics plugin offers a pulldown menu for image and mask image. This avoids the inconsistent data selection.

Aug 16 2019, 11:22 AM · Bugzilla, MITK
eisenman triaged T26631: Tool not correctly visualized when tool tip edited in IGT Navigation Tool Manager as Normal priority.
Aug 16 2019, 10:57 AM · IGT, MITK
kausch created T26630: Batchgenerators: Access transformation parameters used in batchgenerator augmentations.
Aug 16 2019, 10:50 AM · Deep Learning
eisenman triaged T26629: Workbench in inconsistent state after trying to save a tool storage file with insufficient permissions as High priority.
Aug 16 2019, 10:31 AM · IGT, MITK

Aug 15 2019

neher closed T26628: IVIM View does not react to crosshair change as Resolved.
Aug 15 2019, 3:09 PM · MITK Diffusion
adler added a member for Deep Learning: d246a.
Aug 15 2019, 3:08 PM
adler added a member for IMSY: d246a.
Aug 15 2019, 3:08 PM
neher committed rMITKDIFF98e9a601a162: Merge branch 'T26628-Ivim' (authored by neher).
Merge branch 'T26628-Ivim'
Aug 15 2019, 3:03 PM
neher committed rMITKDIFF19e70e4317fc: App description (authored by neher).
App description
Aug 15 2019, 3:02 PM
neher committed rMITKDIFF3b9d6d0b49f0: Merge branch 'T26628-Ivim' (authored by neher).
Merge branch 'T26628-Ivim'
Aug 15 2019, 3:01 PM
neher committed rMITKDIFFd160ee880aff: IVIM cmd app (authored by neher).
IVIM cmd app
Aug 15 2019, 3:00 PM
neher added a comment to T26628: IVIM View does not react to crosshair change.

Pushed new branch T26628-Ivim.

Aug 15 2019, 3:00 PM · MITK Diffusion
neher triaged T26628: IVIM View does not react to crosshair change as Normal priority.
Aug 15 2019, 2:22 PM · MITK Diffusion
neher closed T26386: [MITK Diffusion] Reader should recognize bval and bvec files, not only bvals and bvecs as Resolved.

it actually does already

Aug 15 2019, 1:50 PM · MITK
bonekamp committed rPROUNET0810945924c4: updating README (authored by bonekamp).
updating README
Aug 15 2019, 1:25 PM
bonekamp committed rPROUNET47696e20d6d3: updating README (authored by bonekamp).
updating README
Aug 15 2019, 1:25 PM
neher closed T26602: Dipy reconstruction does not work as Resolved.
Aug 15 2019, 11:32 AM · MITK Diffusion
neher committed rMITKDIFF3b90a517f609: Merge branch 'T26602-DipyRecon' (authored by neher).
Merge branch 'T26602-DipyRecon'
Aug 15 2019, 11:25 AM
neher committed rMITKDIFFc78042aa846e: Correct file location. Use dipy SH convention (authored by neher).
Correct file location. Use dipy SH convention
Aug 15 2019, 11:18 AM
neher added a comment to T26602: Dipy reconstruction does not work.

Pushed new branch T26602-DipyRecon.

Aug 15 2019, 11:18 AM · MITK Diffusion
eisenman updated the task description for T24228: Restructure CreateTrackingDeviceSource method in TrackerDeviceTypeInformation implementations.
Aug 15 2019, 9:21 AM · MITK, IGT

Aug 14 2019

sridhara updated subscribers of T26611: Edit tool tip function in IGT Tracking doesn't apply the correction.

Compared ManualEditToolTip functions of IGTNavigationToolManager and IGTNavigationToolCalibration plugin which works correctly. In former, the storage is disconnected before editing the tool and when a new tracking connection is made the edited tool tip and orientation is lost. But in calibration plugin the editing of tool is done while tracking device is connected, so the information is preserved.
@eisenman @franza Can we remove the condition that the tracker has to disconnected before editing the tool or is there another work around for this.

Aug 14 2019, 5:51 PM · Restricted Project, MITK
bonekamp committed rPROUNET418ea14fd07a: updating README (authored by bonekamp).
updating README
Aug 14 2019, 5:13 PM
bonekamp committed rPROUNET0c10b1a6b666: nothing (authored by bonekamp).
nothing
Aug 14 2019, 2:13 PM