Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 1

kalali created T29222: SlicesCoordinator is not implemented / used and can be removed.
Fri, Jul 1, 2:35 PM · Request for Discussion, MITK

Thu, Jun 30

kalali added a comment to T29220: StatusBar info is dependent on the pointer position, not on the crosshair / mouse click.

I think this ultimately needs to these two tasks: T25105: UpdateStatusBar duplicates business logic and T19470: Cleanup DisplayInteractor with the goal to remove the UpdateStatusBar-function completely from the mentioned classes and handle the events correctly, e.g. inside the SliceNavigationController or similar. Not only would this remove the mentioned redundancy of the function but also take away the responsibility for updating from the mentioned classes and give it to a more related class.

Thu, Jun 30, 8:46 PM · Request for Discussion, MITK
kalali added a comment to T29220: StatusBar info is dependent on the pointer position, not on the crosshair / mouse click.

This is probably caused by DisplayActionEventBroadcast (was DisplayInteractor before).

Thu, Jun 30, 8:33 PM · Request for Discussion, MITK
s349i closed T29184: Replace itkContourExtractor2DImageFilter as Resolved.
Thu, Jun 30, 5:00 PM · MITK, Request for Discussion
s349i added a comment to T29184: Replace itkContourExtractor2DImageFilter .

I've replaced the function used from Modules/Segmentation/Algorithms/itkContourExtractor2DImageFilter.h with a Unary Functor that uses itk only. The file is no longer useful. Maybe I'll delete it and close this if no one objects. The itk file with the same name will be superseded by the one provided by itk with the same name.

Thu, Jun 30, 5:00 PM · MITK, Request for Discussion
kalali created T29220: StatusBar info is dependent on the pointer position, not on the crosshair / mouse click.
Thu, Jun 30, 1:31 PM · Request for Discussion, MITK
kalali created T29219: StatusBar / mouse scrolling is broken.
Thu, Jun 30, 1:23 PM · Request for Discussion, MITK
kalali created T29218: SetInputWorldGeometry3D / GetInputWorldGeometry3D of SliceNavigationController deprecated?.
Thu, Jun 30, 12:14 PM · Request for Discussion, MITK

Wed, Jun 29

kalali removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: Restricted Maniphest Task.
Wed, Jun 29, 3:18 PM · MITK
kalali closed T29207: Remove "Frontal" and "Transversal" as view direction from the code base, a subtask of T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations, as Resolved.
Wed, Jun 29, 9:58 AM · Request for Discussion, MITK

Fri, Jun 24

j762e claimed T28851: [SEG] Evaluate if we should add itkGrowCut as a tool.
Fri, Jun 24, 3:46 PM · MITK (v2022.10)
floca added a comment to T28851: [SEG] Evaluate if we should add itkGrowCut as a tool.

@j762e If you work in the task (which would be great ;), please claim it.

Fri, Jun 24, 2:27 PM · MITK (v2022.10)
j762e added a comment to T28851: [SEG] Evaluate if we should add itkGrowCut as a tool.

In newer versions of ITK the GrowCut.remote.cmake is added by default to Remote Modules (eg. https://github.com/InsightSoftwareConsortium/ITK/tree/master/Modules/Remote).
Our version of ITK (https://www.mitk.org/download/thirdparty/) doesn't include that yet.
c94224c7fe81 is a "workaround" to still add the Remote Module without changing the present version of ITK on our server and might be reverted in future.

Fri, Jun 24, 1:28 PM · MITK (v2022.10)
j762e added a comment to T28851: [SEG] Evaluate if we should add itkGrowCut as a tool.

Pushed new branch to rMITK MITK: feature/T28851-AddITKGrowCutTool.

Fri, Jun 24, 12:55 PM · MITK (v2022.10)

Thu, Jun 23

kalali added a revision to T27613: Improve reinit behavior: Restricted Differential Revision.
Thu, Jun 23, 6:54 PM · Request for Discussion, Next Milestone, MITK

Wed, Jun 15

kislinsk added a comment to T29213: [Levelwindow] Preset definition does not allow floating point numbers.

In case the number is already serialized as floating point instead of an integer it is probably an i18n issue regarding the difference of the decimal point . and , in English and German locales. We had these issues quite often in the past and the solution to such issues is to enforce the neutral locale while serializing/deserializing on the streams. Just search for "imbue" in all of MITK's .cpp files for examples. There's also the LocaleSwitch class but I think I can remember that there's an issue with it. Still both solutions can be found many times in MITK.

Wed, Jun 15, 11:05 AM · MITK (v2022.10)

Tue, Jun 14

kahl triaged T29213: [Levelwindow] Preset definition does not allow floating point numbers as High priority.
Tue, Jun 14, 6:50 PM · MITK (v2022.10)

Wed, Jun 8

franza added a comment to T29082: MITK-IGT: XML logging is broken.

There is a pull request with a fix of this bug: https://github.com/MITK/MITK/pull/258

Wed, Jun 8, 3:46 PM · MITK (v2022.10), Pull Request, IGT
franza moved T29082: MITK-IGT: XML logging is broken from Wishlist to Ready for merge on the IGT board.
Wed, Jun 8, 3:44 PM · MITK (v2022.10), Pull Request, IGT
franza moved T29082: MITK-IGT: XML logging is broken from Backlog to Wishlist on the IGT board.
Wed, Jun 8, 3:44 PM · MITK (v2022.10), Pull Request, IGT

Tue, Jun 7

kislinsk added a revision to T28230: Issue with DICOM SEG -> NIFTI conversion: missing empty slices: Restricted Differential Revision.
Tue, Jun 7, 2:32 PM · MITK
kislinsk added a comment to T28230: Issue with DICOM SEG -> NIFTI conversion: missing empty slices.

Deleted branch from rMITK MITK: feature/T28230-ResampleImageToReference.

Tue, Jun 7, 2:32 PM · MITK
kislinsk added a comment to T28230: Issue with DICOM SEG -> NIFTI conversion: missing empty slices.

Deleted branch from rMITK MITK: T28230-ResampleImageToReference.

Tue, Jun 7, 2:32 PM · MITK
kislinsk added a comment to T28406: [Segmentation] Examine Live-wire tool for different costfunctions/behavior.

Deleted branch from rMITK MITK: feature/T28406-PatchForTestingLiveWireBehavior.

Tue, Jun 7, 2:23 PM · MITK
kislinsk added a comment to T27701: Overhaul or remove PluginGenerator.

Deleted branch from rMITK MITK: bugfix/T27701-PluginGenerator.

Tue, Jun 7, 2:18 PM · MITK, Next Milestone
kislinsk added a comment to T28833: Label masks have wrong geometry.

Deleted branch from rMITK MITK: bugfix/T28833-FixGeometryOfLabelMaskImages.

Tue, Jun 7, 2:14 PM · MITK

Sun, Jun 5

HOUJF added a comment to T29189: Software crashes when launching python console.

I see,thank you for your prompt reply.

Sun, Jun 5, 8:43 AM · MITK

Jun 3 2022

floca closed T29183: [SEG] Removal of "create as new segmentation" as Resolved by committing rMITK7313be2dbf04: Merged class AutoSegmentationTool with AutoSegmentationWithPreviewTool.
Jun 3 2022, 12:22 PM · MITK

Jun 2 2022

kislinsk closed T29189: Software crashes when launching python console as Wontfix.

Thank you for the report. The Python plugin is labeled as experimental and is not used by us anymore since quite some time now. We don't recommend to use it anymore.

Jun 2 2022, 8:59 PM · MITK
kislinsk added a comment to T29195: Fix FlowBench argument parsing and icon resource access.

Deleted branch from rMITK MITK: bugfix/T29195-FixFlowBenchArgParsingAndIconLoading.

Jun 2 2022, 4:00 PM · MITK
kislinsk closed T29195: Fix FlowBench argument parsing and icon resource access as Resolved by committing rMITKc6183651ff3c: Fix FlowBench argument parsing and icon resource access.
Jun 2 2022, 3:59 PM · MITK
kislinsk added a revision to T29195: Fix FlowBench argument parsing and icon resource access: Restricted Differential Revision.
Jun 2 2022, 2:19 PM · MITK
kislinsk added a comment to T29195: Fix FlowBench argument parsing and icon resource access.

Pushed new branch to rMITK MITK: bugfix/T29195-FixFlowBenchArgParsingAndIconLoading.

Jun 2 2022, 2:17 PM · MITK
kislinsk triaged T29195: Fix FlowBench argument parsing and icon resource access as Normal priority.
Jun 2 2022, 2:14 PM · MITK
kalali added a parent task for T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView: T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Jun 2 2022, 1:04 PM · MITK (v2022.10)
kalali added a parent task for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: T25595: [Multi widget] Make classes work with the new render window access.
Jun 2 2022, 12:34 PM · Request for Discussion, MITK
kalali moved T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations from Backlog to MITK Meeting on the Request for Discussion board.
Jun 2 2022, 12:26 PM · Request for Discussion, MITK
kalali reopened T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations as "Open".
Jun 2 2022, 12:26 PM · Request for Discussion, MITK
kalali closed T27197: [Selection concept] Data storage inspector icons shift in node selection dialog as Wontfix.

I realized that this only happens for the second, third ... tab icon. Even if you change the order / number of tabs (and e.g. have the "Rendering tree" icon as the first icon tab) the first tab icon does not move. So I guess this is a Qt-issue and I would not deem this important enough, since this is barely visible and nondisruptive.

Jun 2 2022, 11:32 AM · MITK

Jun 1 2022

floca added a parent task for T28406: [Segmentation] Examine Live-wire tool for different costfunctions/behavior: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:06 PM · MITK
floca added a parent task for T28851: [SEG] Evaluate if we should add itkGrowCut as a tool: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:06 PM · MITK (v2022.10)
floca renamed T28851: [SEG] Evaluate if we should add itkGrowCut as a tool from [Segmentation] Evaluate if we should add itkGrowCut as a tool to [SEG] Evaluate if we should add itkGrowCut as a tool.
Jun 1 2022, 5:06 PM · MITK (v2022.10)

May 31 2022

HOUJF triaged T29189: Software crashes when launching python console as High priority.
May 31 2022, 5:31 PM · MITK

May 30 2022

floca closed T29182: Extend TransferLabelContent as Resolved.
May 30 2022, 8:55 AM · MITK
floca added a revision to T29183: [SEG] Removal of "create as new segmentation": Restricted Differential Revision.
May 30 2022, 8:52 AM · MITK

May 29 2022

kislinsk closed T28725: VTP files cannot be opened from paths with "special" characters as Resolved.

Resolved with T28285: DICOM with 'ä' in filename not readable on Windows.

May 29 2022, 8:48 PM · MITK, Next Milestone

May 27 2022

s434n closed T28481: [Checklist] [Test data] Define publicly available user test data as Resolved.
May 27 2022, 1:55 PM · MITK, Next Milestone

May 20 2022

floca added a project to T29000: [Otsu/Watershed Bug] Time points skipped while browsing segmentation Preview: Missing Info.

@a178n Could you check if the error still exists as soon as T29185 is landed?

May 20 2022, 2:44 PM · Missing Info, MITK

May 19 2022

kalali added a comment to T27613: Improve reinit behavior.

My changes related to this task were mainly to clear some classes and remove uncertainty (see T28617: Inconsistent view initialization in rendering manager).
As far as I see it some changes have been made in the subtask T28490: Segmentation plugin: "new" segmentation should not run reinit! and the respective D523: This was mainly concerned with NOT resetting the view / camera using a newly introduced parameter "resetCamera".

May 19 2022, 6:48 PM · Request for Discussion, Next Milestone, MITK
kalali added subtasks for T27613: Improve reinit behavior: T29094: Deleting a data node causes global reset, Restricted Maniphest Task.
May 19 2022, 6:48 PM · Request for Discussion, Next Milestone, MITK
kalali added a comment to T26958: LevelWindow Preset Dialog does not work correctly.

Deleted branch from rMITK MITK: T26958-MapToSource-in-level-window-preset-dialog.

May 19 2022, 10:58 AM · MITK
kalali added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

Deleted branch from rMITK MITK: T27049-Measurement-view-with-single-node-selection-widget.

May 19 2022, 10:33 AM · MITK
kalali added a comment to T27183: New signal type signature leads to undefined signals.

Deleted branch from rMITK MITK: T27183-Fix-segmentation-view.

May 19 2022, 10:25 AM · MITK
kalali removed a subtask for T15696: implement a multi-label segmentation functionality: T16153: [Segmentation] Jump to center of mass of segmentation on click.
May 19 2022, 9:00 AM · Bugzilla, MITK
kislinsk merged T28779: Saving projects with Umlauts uses wrong encoding for file name into T28285: DICOM with 'ä' in filename not readable on Windows.
May 19 2022, 6:16 AM · Checklist, MITK (v2022.10)

May 18 2022

floca claimed T29183: [SEG] Removal of "create as new segmentation".
May 18 2022, 6:33 PM · MITK
franza added a comment to T29082: MITK-IGT: XML logging is broken.

I would say some code in Modules\IGT\IO has to be adapted to fix this bug. Possibly the class mitk::NavigationDataRecorderDeprecated, if it is still in use.

May 18 2022, 3:33 PM · MITK (v2022.10), Pull Request, IGT
a178n edited projects for T29063: When all the folds are selected in "Folds" dropdown box, then show "All Folds" instead of "All", added: MITK; removed MITK (v2022.10).
May 18 2022, 2:15 PM · MITK (v2022.10)
s349i added a project to T29184: Replace itkContourExtractor2DImageFilter : MITK.
May 18 2022, 1:01 PM · MITK, Request for Discussion
floca removed a project from T29183: [SEG] Removal of "create as new segmentation": Request for Discussion.

Discussion result: yes makes sens.

May 18 2022, 11:50 AM · MITK
floca moved T29183: [SEG] Removal of "create as new segmentation" from Backlog to MITK Meeting on the Request for Discussion board.
May 18 2022, 8:17 AM · MITK
floca triaged T29183: [SEG] Removal of "create as new segmentation" as Normal priority.
May 18 2022, 8:17 AM · MITK

May 17 2022

floca created T29182: Extend TransferLabelContent.
May 17 2022, 2:38 PM · MITK

May 16 2022

floca closed T29139: [Image statistics] Warning is shown for 4D image with 3D mask as Resolved by committing rMITKb3e02403b5db: Fixed T29139 - Fixed warnings when creating a 4D statistic with a 3D mask….
May 16 2022, 11:51 AM · Next Milestone, MITK

May 13 2022

floca added a comment to T29139: [Image statistics] Warning is shown for 4D image with 3D mask.

In general yes, the behavior is correct if needed, but in this case it was caused by an incorrect/missing time point mapping between image and mask.

May 13 2022, 8:55 PM · Next Milestone, MITK
floca moved T27613: Improve reinit behavior from Backlog to MITK Meeting on the Request for Discussion board.
May 13 2022, 7:29 PM · Request for Discussion, Next Milestone, MITK
floca added a project to T27613: Improve reinit behavior: Request for Discussion.

What is here still open?

May 13 2022, 7:28 PM · Request for Discussion, Next Milestone, MITK
kalali added a comment to T29163: [XNAT] Opening XNAT session fails.

One difference that I saw: Two openssl-related files were added to the MITK-directory of the working version:

  • libcrypto-1_1-x64.dll
  • libssl-1_1-x64.dll
May 13 2022, 3:41 PM · MITK (v2022.10)
kalali added a comment to T29163: [XNAT] Opening XNAT session fails.

I met with Nikolas Stanczyk today and he showed me his working version of MITK, connecting to XNAT via the provided plugin. I also used my credentials and I was able to successfully login.
I copied his version to my laptop and here he was also able to login.
I just tested my credentials with this copy on my laptop and I was able to successfully login:

image.png (706×897 px, 35 KB)

May 13 2022, 3:22 PM · MITK (v2022.10)
kalali updated the task description for T29145: [Segmentation] Unused classes can be removed.
May 13 2022, 10:27 AM · MITK

May 12 2022

floca added a subtask for T27807: [MultiLabel Segmentation] Inspection of module and plugin: T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG).
May 12 2022, 5:50 PM · MITK, Next Milestone
floca added a parent task for T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG): T27807: [MultiLabel Segmentation] Inspection of module and plugin.
May 12 2022, 5:50 PM · MITK, Next Milestone
floca added a subtask for T27807: [MultiLabel Segmentation] Inspection of module and plugin: T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object.
May 12 2022, 5:50 PM · MITK, Next Milestone
floca added a parent task for T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object: T27807: [MultiLabel Segmentation] Inspection of module and plugin.
May 12 2022, 5:50 PM · MITK, Next Milestone
floca added a parent task for T23748: Image should have a valid DICOM.0008.0018 proprety: T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes).
May 12 2022, 5:46 PM · MITK
floca added a subtask for T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes): T23748: Image should have a valid DICOM.0008.0018 proprety.
May 12 2022, 5:46 PM · Auto-closed, MITK
floca closed T23746: MITK and DICOM (realization) as Resolved.
May 12 2022, 5:45 PM · MITK
floca added a subtask for T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes): T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG).
May 12 2022, 5:43 PM · Auto-closed, MITK
floca added a parent task for T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG): T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes).
May 12 2022, 5:43 PM · MITK, Next Milestone
floca closed T23754: DataStorage/Relationship clean up/refactoring as Resolved.
May 12 2022, 5:40 PM · MITK
floca closed T23742: Implement proof of concept for new segmentation data type as Resolved.

Close this task. The successor for our current planned implementation is T28524.

May 12 2022, 5:39 PM · MITK
floca added a parent task for T23742: Implement proof of concept for new segmentation data type: T28524: Refactor LabelSetImage and associated classes..
May 12 2022, 5:37 PM · MITK
kalali added a comment to T25753: Some refactoring of the selection classes.

Deleted branch from rMITK MITK: T25753-Refactor-selection-concept-classes.

May 12 2022, 1:23 PM · MITK
kalali added a comment to T27028: Add selection condition check for multi-node selection.

Deleted branch from rMITK MITK: T27028-Add-selection-condition.

May 12 2022, 1:22 PM · MITK
kalali added a comment to T27002: Refactor DICOM inspector plugin to use the new node selection widgets.

Deleted branch from rMITK MITK: T27002-DICOM-inspector-view-with-single-node-selection-widget.

May 12 2022, 1:20 PM · MITK
kalali added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

Deleted branch from rMITK MITK: T26475-Remove-node-change-reaction.

May 12 2022, 1:19 PM · Restricted Project, MITK
kalali added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

Deleted branch from rMITK MITK: T26998-Properties-view-with-single-node-selection-widget.

May 12 2022, 1:14 PM · MITK
kalali added a comment to T24659: Implement "Favorites" inspector.

Deleted branch from rMITK MITK: T24659-Implement-favorites-inspector.

May 12 2022, 1:12 PM · MITK
kalali added a comment to T24358: Rework QmitkMouseModeSwitcher.

Deleted branch from rMITK MITK: T24358-Remove-QmitkMouseModeSwitcher.

May 12 2022, 1:08 PM · MITK
kalali added a comment to T24357: Rework mitkMouseModeSwitcher.

Deleted branch from rMITK MITK: T24357-Remove-MouseModeSwitcher.

May 12 2022, 1:04 PM · MITK
kalali added a comment to T26269: [image statistics plugin] refactor to use new node selection widget.

Deleted branch from rMITK MITK: T26269-ChangeSelectionInStatisticsPlugin.

May 12 2022, 10:52 AM · MITK
floca removed a project from T29082: MITK-IGT: XML logging is broken: Next Milestone.
May 12 2022, 10:37 AM · MITK (v2022.10), Pull Request, IGT
kalali reopened T25604: New concept for switching between different render windows, a subtask of T25603: Combine render window manager with custom multi widget, as Open.
May 12 2022, 9:46 AM · Restricted Project, MITK
kalali reopened T25604: New concept for switching between different render windows as "Open".
May 12 2022, 9:46 AM · Auto-closed, Request for Discussion, Restricted Project, MITK
kalali added a project to T19470: Cleanup DisplayInteractor: Next Milestone.
May 12 2022, 9:43 AM · Next Milestone, MITK, Bugzilla

May 11 2022

kalali added a comment to T27297: Add tests for ImageStatisticsContainer.

Deleted branch from rMITK MITK: T27297-Add_tests_for_ImageStatisticsContainer.

May 11 2022, 3:40 PM · MITK
kalali added a comment to T27067: ImageCropper cannot crop some images (4d?).

Deleted branch from rMITK MITK: T27067-ImageCropperCorrect4D.

May 11 2022, 3:22 PM · MITK
floca closed T29169: [Segmentation] Extract TransferLabelToImage from Tool class as Resolved by committing rMITK2f29b4b8f9f4: Fixed T29169.
May 11 2022, 3:09 PM · MITK
floca closed T29170: [Segmentation] Extract GetImageByTimePoint/TimeStep from tool class, a subtask of T29171: Replace redundant ImageTimeSelector code by SelectImageByTimeStep/TimePoint, as Resolved.
May 11 2022, 3:09 PM · Restricted Project, MITK
floca closed T29170: [Segmentation] Extract GetImageByTimePoint/TimeStep from tool class as Resolved by committing rMITK3938c5d445ba: Fixed T29170.
May 11 2022, 3:09 PM · MITK