Page MenuHomePhabricator | MITK
Feed Advanced Search

Today

kalali closed T19643: Interaction problems occur between segmentation tools and renderwindow menu as Invalid.

I'm not sure if this is a valid issue.
I can reproduce the observable result if I don't disable the segmentation tool. I'm still in the drawing mode if the segmentation tool is enabled. If I change the display interaction mode now (by enabling Crosshair rotation (or any other mode - also No crosshair rotation), the MITK interaction scheme is enabled and both interactions happen at the same time (navigating and drawing).
Disabling and re-enabling the tool will again overwrite the navigation interaction and allow to draw the segmentation without any problems.

Fri, Aug 23, 6:09 PM · MITK, Bugzilla
kalali closed T19118: Scroll mode in PACS like mouse interaction not re-enabled after using segmentation tool as Invalid.

I can not reproduce this.
After having deselected the Region Growing tool, I can use the left mouse button and move the mouse to scroll through the slices. "Normal" scrolling (does this mean scrolling using the mouse wheel?) does not work. Notice that you can always scroll by pressing the middle mouse and moving the mouse (regardless of the selected PACS mode).
However, in T26486 I changed the PACS mode such that you can always scroll through the slices using the mouse wheel (regardless of the selected PACS mode). The special PACS scroll mode still works for fast scrolling (left mouse button and mouse moving).

Fri, Aug 23, 5:58 PM · Bugzilla, MITK
kalali closed T24635: PACS scroll leads to an infinite loop if no image is loaded as Resolved.

Has been solved on top of T26476.

Fri, Aug 23, 5:39 PM · MITK
kalali added a comment to T24635: PACS scroll leads to an infinite loop if no image is loaded.

Pushed new branch T24635-Prevent-infinite-scroll-loop.

Fri, Aug 23, 5:39 PM · MITK
kalali claimed T24635: PACS scroll leads to an infinite loop if no image is loaded.
Fri, Aug 23, 5:16 PM · MITK
kalali closed T26486: PACS mouse mode does not allow scrolling with mouse wheel as Resolved.
Fri, Aug 23, 5:10 PM · Restricted Project, MITK
kalali added a comment to T26486: PACS mouse mode does not allow scrolling with mouse wheel.

Pushed new branch T26486-PACS-mouse-mode-with-mouse-wheel-scrolling.

Fri, Aug 23, 5:09 PM · Restricted Project, MITK
kalali closed T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions as Resolved.
Fri, Aug 23, 4:46 PM · Restricted Project, MITK
kalali added a comment to T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions.

Pushed new branch T26642-Restore-original-interactions.

Fri, Aug 23, 4:34 PM · Restricted Project, MITK
kalali added a parent task for T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions: Unknown Object (Maniphest Task).
Fri, Aug 23, 3:53 PM · Restricted Project, MITK
kalali triaged T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions as Normal priority.
Fri, Aug 23, 3:53 PM · Restricted Project, MITK

Yesterday

kalali added a comment to T26486: PACS mouse mode does not allow scrolling with mouse wheel.

Combine with T24356 (esp. T24368).

Thu, Aug 22, 5:50 PM · Restricted Project, MITK

Wed, Aug 21

floca added a comment to T25804: Set 'selected' property when using the new selection concept.

OK. But we definetly should talk about it before it is approached.

Wed, Aug 21, 7:10 PM · MITK

Mon, Aug 19

floca added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

@kalali: Sharp eyes and good work. As far as I can see this is a proper solution to fix a state a had not covered in my implementation. The handling of invalid timepoints is still okay. As the documentation only guaranties that negative invalids will be 0. For all others there are no garanties and developers use GetTimeBounds() to check wether they request legal time points or not.

Mon, Aug 19, 2:07 PM · MITK
kraeuter added a comment to T26269: [image statistics plugin] refactor to use new node selection widget.

Pushed new branch T26269-ChangeSelectionInStatisticsPlugin.

Mon, Aug 19, 12:07 PM · MITK

Fri, Aug 16

eisenman closed T26632: Saved calibrated IGT tool cannot be loaded anymore as Resolved.
Fri, Aug 16, 4:22 PM · IGT, MITK
eisenman added a comment to T26632: Saved calibrated IGT tool cannot be loaded anymore.

Pushed new branch T26632-EnsureFileSuffixForCalibratedTool.

Fri, Aug 16, 4:19 PM · IGT, MITK
kalali added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

I think the problem is here: https://phabricator.mitk.org/source/mitk/browse/master/Modules/Core/src/DataManagement/mitkArbitraryTimeGeometry.cpp$124
The m_MaximumTimePoints for the 3D+t-Heart image is [103, 160, 160]. The last timePoint argument is 160. So in the first iteration if (timePoint < *pos) will be false. Next two iterations it will be false as well since 160 is not less than 160. This will lead to result being 0 at the end of the function.
Normally the m_MaximumTimePoints for another time-image is something like [41, 46, 51] and the timePoint argument will be 46 for the last timestep.
This could be solved by using something like this:

mitk::TimeStepType mitk::ArbitraryTimeGeometry::TimePointToTimeStep(TimePointType timePoint) const
{
  mitk::TimeStepType result = 0;
Fri, Aug 16, 4:00 PM · MITK
eisenman moved T26632: Saved calibrated IGT tool cannot be loaded anymore from Backlog to In Progress on the IGT board.
Fri, Aug 16, 3:44 PM · IGT, MITK
eisenman closed T26635: IGT tools from loaded tool storage are not rendered automatically as Resolved.
Fri, Aug 16, 3:43 PM · IGT, MITK
eisenman added a comment to T26635: IGT tools from loaded tool storage are not rendered automatically.

Pushed new branch T26635-RenderToolsLoadedFromToolStorageFile.

Fri, Aug 16, 3:40 PM · IGT, MITK
steint reopened T18450: Inconsistent data selection between Measurement and Statistic as "Open".

Solved when T26269 is solved.

Fri, Aug 16, 3:37 PM · Bugzilla, MITK
eisenman moved T26635: IGT tools from loaded tool storage are not rendered automatically from Backlog to In Progress on the IGT board.
Fri, Aug 16, 3:33 PM · IGT, MITK
eisenman closed T26634: Loaded IGT tool is not rendered automatically as Resolved.
Fri, Aug 16, 3:33 PM · IGT, MITK
eisenman added a comment to T26634: Loaded IGT tool is not rendered automatically.

Pushed new branch T26634-RenderLoadedIGTTool.

Fri, Aug 16, 3:02 PM · IGT, MITK
eisenman moved T26634: Loaded IGT tool is not rendered automatically from Backlog to In Progress on the IGT board.
Fri, Aug 16, 2:30 PM · IGT, MITK
eisenman triaged T26635: IGT tools from loaded tool storage are not rendered automatically as Normal priority.
Fri, Aug 16, 2:17 PM · IGT, MITK
eisenman triaged T26634: Loaded IGT tool is not rendered automatically as Normal priority.
Fri, Aug 16, 2:02 PM · IGT, MITK
kalali renamed T26633: [mxn multi widget] Show different time points of data from [mxn multi widget] Shof different time points of data to [mxn multi widget] Show different time points of data.
Fri, Aug 16, 1:58 PM · Restricted Project, MITK
kalali added a project to T26633: [mxn multi widget] Show different time points of data: Restricted Project.
Fri, Aug 16, 1:58 PM · Restricted Project, MITK
kalali triaged T26633: [mxn multi widget] Show different time points of data as Normal priority.
Fri, Aug 16, 1:58 PM · Restricted Project, MITK
kalali added a comment to T25030: Image navigator time slider moves twice.

See T24766.
I also experienced the two-step when debugging but using only console-output this does not happen with other time-data than 3D+t-Heart

Fri, Aug 16, 1:41 PM · Restricted Project, MITK
eisenman added a comment to T26632: Saved calibrated IGT tool cannot be loaded anymore.

The issue with the missing file extension only occurs on Linux.

Fri, Aug 16, 1:41 PM · IGT, MITK
kalali added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

This does not happen with the new mxn multi widget. Maybe connected to the render windows being synchronized / plane nodes when using the StdMultiWidget?

Fri, Aug 16, 1:40 PM · MITK
kraeuter claimed T26269: [image statistics plugin] refactor to use new node selection widget.
Fri, Aug 16, 12:06 PM · MITK
kalali updated subscribers of T18450: Inconsistent data selection between Measurement and Statistic.

Please talk to @kraeuter to as she is currently working on T26269

Fri, Aug 16, 12:04 PM · Bugzilla, MITK
eisenman triaged T26632: Saved calibrated IGT tool cannot be loaded anymore as Normal priority.
Fri, Aug 16, 11:58 AM · IGT, MITK
steint closed T18450: Inconsistent data selection between Measurement and Statistic as Resolved.

The new implementation of the image statistics plugin offers a pulldown menu for image and mask image. This avoids the inconsistent data selection.

Fri, Aug 16, 11:22 AM · Bugzilla, MITK
eisenman triaged T26631: Tool not correctly visualized when tool tip edited in IGT Navigation Tool Manager as Normal priority.
Fri, Aug 16, 10:57 AM · IGT, MITK
eisenman triaged T26629: Workbench in inconsistent state after trying to save a tool storage file with insufficient permissions as High priority.
Fri, Aug 16, 10:31 AM · IGT, MITK

Thu, Aug 15

neher closed T26386: [MITK Diffusion] Reader should recognize bval and bvec files, not only bvals and bvecs as Resolved.

it actually does already

Thu, Aug 15, 1:50 PM · MITK
eisenman updated the task description for T24228: Restructure CreateTrackingDeviceSource method in TrackerDeviceTypeInformation implementations.
Thu, Aug 15, 9:21 AM · MITK, IGT

Wed, Aug 14

sridhara updated subscribers of T26611: Edit tool tip function in IGT Tracking doesn't apply the correction.

Compared ManualEditToolTip functions of IGTNavigationToolManager and IGTNavigationToolCalibration plugin which works correctly. In former, the storage is disconnected before editing the tool and when a new tracking connection is made the edited tool tip and orientation is lost. But in calibration plugin the editing of tool is done while tracking device is connected, so the information is preserved.
@eisenman @franza Can we remove the condition that the tracker has to disconnected before editing the tool or is there another work around for this.

Wed, Aug 14, 5:51 PM · Restricted Project, MITK
sridhara triaged T26611: Edit tool tip function in IGT Tracking doesn't apply the correction as Normal priority.
Wed, Aug 14, 10:59 AM · Restricted Project, MITK

Tue, Aug 13

franza added a comment to T26609: US Navigation / Tracked US: CT Registration Demo.

T26609-2018.04.beta.CT-Registration-Demo is based on a old 2018.04.beta version, CT registration is working.

Tue, Aug 13, 6:56 PM · IGT, MITK
franza added a comment to T26609: US Navigation / Tracked US: CT Registration Demo.

Pushed new branch T26609-2018.04.beta.CT-Registration-Demo.

Tue, Aug 13, 6:55 PM · IGT, MITK
franza added a comment to T26609: US Navigation / Tracked US: CT Registration Demo.

T26609-2019-08-USNavigationFix is based on 2019-05 MITK master, US Navigation is working, but CT registration is buggy.

Tue, Aug 13, 6:54 PM · IGT, MITK
franza added a comment to T26609: US Navigation / Tracked US: CT Registration Demo.

Pushed new branch T26609-2019-08-USNavigationFix.

Tue, Aug 13, 6:53 PM · IGT, MITK
franza triaged T26609: US Navigation / Tracked US: CT Registration Demo as Wishlist priority.
Tue, Aug 13, 6:28 PM · IGT, MITK
kalali added a revision to T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor): Unknown Object (Differential Revision).
Tue, Aug 13, 3:06 PM · Noteworthy, MITK

Mon, Aug 12

kalali closed T26495: [mxn multi widget] Not able to chose level-window presets as Resolved.
Mon, Aug 12, 3:51 PM · Restricted Project, MITK
kalali added a comment to T26495: [mxn multi widget] Not able to chose level-window presets.

Level window widget has been added to both multi widget editors, presets work.
Using the context-menu of the level window slider the user can select the node he or she wants to modify. Using the multi-node selection approach from T25804 requires the selected-property to be set by the render window manager.
However, the multi-node-selection approach is included as the data manager is currently always available.

Mon, Aug 12, 3:50 PM · Restricted Project, MITK
kalali added a comment to T26495: [mxn multi widget] Not able to chose level-window presets.

Pushed new branch T26495-Enable-level-window-slider-and-presets.

Mon, Aug 12, 3:50 PM · Restricted Project, MITK
kalali added a comment to T25804: Set 'selected' property when using the new selection concept.

I came across this as I re-added the level window slider to the MxNMultiWidget (we didn't include this before as we used the PACS mode inside the MxNMultiWidget - which allows to change the level window via mouse moving). Now our user wants to use the level-window-presets available from the context menu of the level window slider.

Mon, Aug 12, 3:25 PM · MITK
floca added a comment to T25804: Set 'selected' property when using the new selection concept.

This would be necessary if we want to use the render window manager with the mxnmultiwidget and the mentioned task (T25483).

Mon, Aug 12, 3:22 PM · MITK
kalali added a comment to T25804: Set 'selected' property when using the new selection concept.

This would be necessary if we want to use the render window manager with the mxnmultiwidget and the mentioned task (T25483).

Mon, Aug 12, 3:11 PM · MITK
kalali moved T26485: PACS mode is active while segmentation is drawn from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mon, Aug 12, 1:52 PM · Restricted Project, MITK
kalali added a comment to T26485: PACS mode is active while segmentation is drawn.

For test purposes this has been solved for the segmentation module / plugin in 450d57dd of T24215.

Mon, Aug 12, 1:51 PM · Restricted Project, MITK
kalali claimed T26485: PACS mode is active while segmentation is drawn.
Mon, Aug 12, 1:15 PM · Restricted Project, MITK
kalali added a comment to T26485: PACS mode is active while segmentation is drawn.

Also when changing the interaction mode (PACS <-> MITK) while the segmentation tool (e.g. Add) is active, the changed interaction mode will overwrite the segmentation interaction and the render window changes again while drawing the segmentation.

Mon, Aug 12, 1:14 PM · Restricted Project, MITK
kalali added a comment to T26485: PACS mode is active while segmentation is drawn.

There seems to be a problem with the mitkDisplayActionEventBroadcast-class in general. Some classes have legacy code that disables the default display interactor to load a scenario-specific state machine and config file (see e.g. https://phabricator.mitk.org/source/mitk/browse/master/Modules/Segmentation/Interactions/mitkTool.cpp$121).
This is done in other classes. The problem is that the function does not reset the display action event broadcast instance but only display interactor instances.

Mon, Aug 12, 11:22 AM · Restricted Project, MITK

Fri, Aug 9

kalali raised the priority of T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor) from Wishlist to Normal.
Fri, Aug 9, 4:11 PM · Noteworthy, MITK
kalali closed T25605: New concept for changing the view direction of render windows, a subtask of T25603: Combine render window manager with custom multi widget, as Resolved.
Fri, Aug 9, 4:00 PM · Restricted Project, MITK
kalali closed T25605: New concept for changing the view direction of render windows as Resolved.

The modified render window has been added and can be used by the StdMultiWidget and the MxNMulwiWidget (see T24215).
This is used here and a new entry for the render window menu has been added.

Fri, Aug 9, 4:00 PM · Restricted Project, MITK
kalali added a comment to T25605: New concept for changing the view direction of render windows.

Pushed new branch T25605-View-direction-change-in-render-window-menu.

Fri, Aug 9, 3:56 PM · Restricted Project, MITK
schererj moved T24447: CommonWL profiles for our MiniApps/Container from Backlog to Discussion on the d:cipher board.
Fri, Aug 9, 12:21 PM · Request for Discussion, d:cipher, MITK
neher added a comment to T26559: Improve Python 3 integration.

Missed it. "improve python 3 integration", "migrate to improved python 3 integration". Potato, Potahto

Fri, Aug 9, 10:38 AM · MITK Diffusion, Noteworthy, MITK

Thu, Aug 8

kislinsk added a comment to T26559: Improve Python 3 integration.

@neher What's wrong with T26566: Migrate to improved Python 3 integration?

Thu, Aug 8, 7:41 PM · MITK Diffusion, Noteworthy, MITK
neher closed T26559: Improve Python 3 integration as Resolved.
Thu, Aug 8, 9:34 AM · MITK Diffusion, Noteworthy, MITK
neher added a comment to T26559: Improve Python 3 integration.

Pushed new branch T26559-Python3.

Thu, Aug 8, 9:28 AM · MITK Diffusion, Noteworthy, MITK
neher added a project to T26559: Improve Python 3 integration: MITK Diffusion.
Thu, Aug 8, 9:26 AM · MITK Diffusion, Noteworthy, MITK
neher reopened T26559: Improve Python 3 integration as "Open".
Thu, Aug 8, 9:26 AM · MITK Diffusion, Noteworthy, MITK

Wed, Aug 7

kislinsk added a project to T26559: Improve Python 3 integration: Noteworthy.

It's MITK_USE_Python3 now instead of MITK_USE_Python. On macOS CMAKE_FRAMEWORK_PATH can be used to hint our CMake script to find a specific version of Python as Python 3.7 does not work at the moment.

Wed, Aug 7, 9:41 PM · MITK Diffusion, Noteworthy, MITK
kalali added a comment to T25595: Make classes work with the new render window access.

Pushed new branch T25595-New-render-window-access.

Wed, Aug 7, 12:53 PM · Restricted Project, MITK
kalali updated the task description for T25595: Make classes work with the new render window access.
Wed, Aug 7, 10:22 AM · Restricted Project, MITK
kalali renamed T25595: Make classes work with the new render window access from Make ImageNavigator work with the custom multi widget editor to Make classes work with the new render window access.
Wed, Aug 7, 9:56 AM · Restricted Project, MITK
kalali updated the task description for T24211: Multi widget editor responsibilities.
Wed, Aug 7, 9:46 AM · MITK
kalali added a comment to T24211: Multi widget editor responsibilities.

LayoutManager has been added in T24215.

Wed, Aug 7, 9:45 AM · MITK

Tue, Aug 6

kalali closed T26493: [mxn multi widget] Allow render window resizing as Resolved.

Render window menu is now available (T24215).
However, QSplitter were added to the MxNMultiWidget so that resizing via mouse-dragging is also possible.

Tue, Aug 6, 7:00 PM · Restricted Project, MITK
kalali added a comment to T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor).

Pushed new branch T24215-Remove-stdmultiwidget-dependency.

Tue, Aug 6, 6:59 PM · Noteworthy, MITK
kalali closed T24367: SetWidgetPlane-functions in QmitkStdMultiWidget not used, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Tue, Aug 6, 6:57 PM · MITK
kalali closed T24367: SetWidgetPlane-functions in QmitkStdMultiWidget not used as Resolved.

Functions have been removed in T24215.
Additional functions to be removed: see T26542

Tue, Aug 6, 6:57 PM · Noteworthy, MITK
kalali updated the task description for T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor).
Tue, Aug 6, 6:56 PM · Noteworthy, MITK
kalali claimed T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor).
Tue, Aug 6, 6:53 PM · Noteworthy, MITK
kalali renamed T24215: Refactor classes to use the QmitkAbstractMultiWidget(Editor) from QmitkRenderWindow needs a StdMultiWidget to Refactor classes to use the QmitkAbstractMultiWidget(Editor).
Tue, Aug 6, 6:53 PM · Noteworthy, MITK
kalali added a project to T26572: Allow extension of QmitkRenderWindowMenu with custom layouts: Restricted Project.
Tue, Aug 6, 2:31 PM · Restricted Project, Restricted Project, MITK
kalali triaged T26572: Allow extension of QmitkRenderWindowMenu with custom layouts as Low priority.
Tue, Aug 6, 2:30 PM · Restricted Project, Restricted Project, MITK
kislinsk closed T26559: Improve Python 3 integration as Resolved.
Tue, Aug 6, 8:17 AM · MITK Diffusion, Noteworthy, MITK

Mon, Aug 5

eisenman closed T26561: Workbench in inconsistent state after the file dialog for selecting a phantom configuration is canceled as Resolved.
Mon, Aug 5, 2:47 PM · IGT, MITK
eisenman added a comment to T26561: Workbench in inconsistent state after the file dialog for selecting a phantom configuration is canceled.

Pushed new branch T26561-FixPhantomConfigurationCancelation.

Mon, Aug 5, 2:44 PM · IGT, MITK
eisenman triaged T26565: Workbench crashes when 'Stop Calibration with PLUS' button in PLUS Connection tab is clicked twice as High priority.
Mon, Aug 5, 1:58 PM · IGT, MITK
eisenman triaged T26564: Workbench crashes when calibrate button in point-based calibration tab is clicked as High priority.
Mon, Aug 5, 1:52 PM · IGT, MITK
eisenman added a project to T26563: Workbench crashes when freeze button in spacing calibration tab is clicked: IGT.
Mon, Aug 5, 1:48 PM · IGT, MITK
eisenman triaged T26563: Workbench crashes when freeze button in spacing calibration tab is clicked as High priority.
Mon, Aug 5, 1:48 PM · IGT, MITK
eisenman moved T26277: Add phantom-based calibration to USCalibration plugin from In Progress to Finished on the IGT board.
Mon, Aug 5, 1:42 PM · MITK, IGT
eisenman moved T26464: Incorporate distortion sensing information in tracking data from In Progress to Finished on the IGT board.
Mon, Aug 5, 1:40 PM · Restricted Project, IGT, MITK
eisenman moved T26562: Fix typos in IGT USTrackingNavigation Calibration view from In Progress to Finished on the IGT board.
Mon, Aug 5, 1:39 PM · IGT, MITK
eisenman closed T26562: Fix typos in IGT USTrackingNavigation Calibration view as Resolved.
Mon, Aug 5, 1:35 PM · IGT, MITK
eisenman added a comment to T26562: Fix typos in IGT USTrackingNavigation Calibration view.

Pushed new branch T26562-FixTyposInIGTUSTrackingNavigationCalibrationView.

Mon, Aug 5, 1:30 PM · IGT, MITK
kislinsk closed T26546: Upgrade Boost from version 1.68 to version 1.70 as Resolved.
Mon, Aug 5, 1:17 PM · MITK