Page MenuHomePhabricator
Feed Advanced Search

Feb 12 2019

hentsch added a comment to T25833: Leak/Debugbreak when closing workbench related to MitkChart.

Is most probably a Qt bug:
https://bugreports.qt.io/browse/QTBUG-69030
Should be fixed with Qt 5.12
The QtWebEngineView is full of bugs 😠

Feb 12 2019, 2:48 PM · Restricted Project, MITK
neher added a comment to T26024: [MITK Diffusion] Head motion with volume fraction maps causes holes.

Pushed new branch T26024-FiberfoxMotionHoles.

Feb 12 2019, 2:28 PM · MITK
hentsch triaged T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work as Normal priority.
Feb 12 2019, 2:25 PM · Restricted Project, MITK
hentsch updated subscribers of T25180: ImageStatistics timestep segmentation bug.

@steint Can't reproduce it with the current master. Can you try it again?

Feb 12 2019, 2:17 PM · MITK
hentsch closed T25851: [image statistics plugin] Mask image is not cleared on image change as Resolved.

part of T25785

Feb 12 2019, 2:01 PM · Restricted Project, MITK
hentsch added a comment to T19124: When selecting more than one measurement, statistics aren't calculated.

This feature has to be implemented in MaskGenerator, where the functionality of adding multiple masks could be given.

Feb 12 2019, 11:56 AM · Bugzilla, MITK
hentsch added a parent task for T23191: Image Statistics plugin: 4D data + intensity profile does not work: Unknown Object (Maniphest Task).
Feb 12 2019, 11:53 AM · MITK
neher triaged T26024: [MITK Diffusion] Head motion with volume fraction maps causes holes as High priority.
Feb 12 2019, 9:14 AM · MITK

Feb 11 2019

kalali added a project to T25483: Apply level window to multiple selected images: Noteworthy.
NOTE: API change: RecaluclateLevelWindowForSelectedComponent was renamed to RecalculateLevelWindowForSelectedComponent
Feb 11 2019, 7:12 PM · Noteworthy, Restricted Project, MITK
kraeuter added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

The tests show unreliable errors.
Testing a few times in a row, sometimes the tests runs through without any problems, sometimes they fail.
Looking at the logs there are two tests that can fail.
-> TestRecomputeOnModifiedMask
-> TestImageMaskingEmpty
There is nothing written at the tests about failing any conditions, but they display an error called "unknown label"

Feb 11 2019, 11:52 AM · Restricted Project, MITK
kraeuter added a comment to T26011: Update TestingMacros.

I read through the logs after testing and the tests now fail completely when on of the conditions isn´t met.
I compared the testing logs with the master and noticed, that the fails existed before but the test didn´t notify accordingly.

Feb 11 2019, 11:33 AM · Restricted Project, MITK
neher closed T26008: [MITK Diffusion] QmitkChartWidget not found as Resolved.
Feb 11 2019, 8:58 AM · MITK
kraeuter added a comment to T26009: Find smaller images for MitkImageStatisticsCalculatorTest.

I looked through MITK-Data for smaller images that could be used for the test.
Found some that seemed noteworthy:

Feb 11 2019, 8:49 AM · Restricted Project, MITK

Feb 8 2019

reicht added a comment to T19999: DICOM CGet and CMove don't work correctly.

I can setup a Horos instance (=OsiriX fork since free edition of osirix is limited and not userfriendly anymore) if needed. This can be done in the science network to avoid any firewall issues when trying to QR from a SIDT computer.

Feb 8 2019, 6:07 PM · Restricted Project, Restricted Project, MITK
kraeuter added a comment to T26011: Update TestingMacros.

Pushed new branch T26011-UpdateTestingMacros.

Feb 8 2019, 4:07 PM · Restricted Project, MITK
neher triaged T26017: [MITK Diffusion] Somehow mark input and output of cmdapps as Wishlist priority.
Feb 8 2019, 3:20 PM · MITK
hentsch added a comment to T26011: Update TestingMacros.

This old macros could be the reason for T25716

Feb 8 2019, 2:32 PM · Restricted Project, MITK
hentsch closed T25743: ImageStatisticsCalculator bug: 4D image + planarFigure lead to same results for each timestep as Resolved.
Feb 8 2019, 2:30 PM · MITK
hentsch closed T25743: ImageStatisticsCalculator bug: 4D image + planarFigure lead to same results for each timestep, a subtask of T25512: Restructure image statistics calculator, as Resolved.
Feb 8 2019, 2:30 PM · MITK
kraeuter triaged T26013: Define ground truth as Normal priority.
Feb 8 2019, 2:10 PM · Restricted Project, MITK
kraeuter triaged T26012: Define test cases as Normal priority.
Feb 8 2019, 2:08 PM · Restricted Project, MITK
kraeuter triaged T26011: Update TestingMacros as Normal priority.
Feb 8 2019, 1:58 PM · Restricted Project, MITK
kraeuter triaged T26010: Avoid loading all data before each test as Normal priority.
Feb 8 2019, 1:48 PM · Restricted Project, MITK
kraeuter triaged T26009: Find smaller images for MitkImageStatisticsCalculatorTest as Normal priority.
Feb 8 2019, 1:44 PM · Restricted Project, MITK
neher added a comment to T26008: [MITK Diffusion] QmitkChartWidget not found.

Pushed new branch T26008-ChartWidget.

Feb 8 2019, 11:08 AM · MITK
neher triaged T26008: [MITK Diffusion] QmitkChartWidget not found as Normal priority.
Feb 8 2019, 11:02 AM · MITK
neher closed T26003: [MITK Diffusion] bad any cast in streamlinetractography as Resolved.
Feb 8 2019, 11:02 AM · MITK
neher added a comment to T26003: [MITK Diffusion] bad any cast in streamlinetractography.

Pushed new branch T26003-StreamlineBadCast.

Feb 8 2019, 10:03 AM · MITK
neher triaged T26003: [MITK Diffusion] bad any cast in streamlinetractography as Normal priority.
Feb 8 2019, 10:02 AM · MITK
nolden added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Looks like the Slicer warning is important, but still it succeeds in loading the data. The numerical error is rather low. Found this discussion which also links to the python code Slicer is using and which emits the warning. Could be of some use for further investigations. https://discourse.slicer.org/t/dicom-scalar-volume-load-irregular-geometry-warning-overly-stringent/3761/14

Feb 8 2019, 8:39 AM · MITK

Feb 7 2019

milano updated the task description for T26002: Unhandled exception in mitkNDITrackingDevice::ThreadStartTracking.
Feb 7 2019, 9:02 PM · Auto-closed, Pull Request, MITK
hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

I guess there's something wrong with the original image matrix.
MITK tries to fix the normal to be perpendicular, which leads to a matrix that can't be inverted anymore.

Feb 7 2019, 5:31 PM · MITK
milano updated the task description for T26002: Unhandled exception in mitkNDITrackingDevice::ThreadStartTracking.
Feb 7 2019, 4:44 PM · Auto-closed, Pull Request, MITK
milano triaged T26002: Unhandled exception in mitkNDITrackingDevice::ThreadStartTracking as Low priority.
Feb 7 2019, 4:44 PM · Auto-closed, Pull Request, MITK
hentsch added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

In m_Pic3DImageMask2, only one label is used whereas 2 are used in m_Pic3DImageMask.
And the test is supposed to test the second label: ComputeStatisticsNew(m_Pic3DImage, imgMaskGen.GetPointer(), nullptr, 2);, where 2 is the label.

Feb 7 2019, 4:14 PM · Restricted Project, MITK
kraeuter added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

Is there a specific reason why the test TestPic3DImageMaskStatistics_label2 sets m_Pic3DImageMask instead of m_Pic3DImageMask2?

Feb 7 2019, 4:00 PM · Restricted Project, MITK
milano updated the task description for T26001: The return value in mitkSerialCommunication::Send is inconsistent under Microsoft Windows Platforms.
Feb 7 2019, 3:54 PM · Pull Request, MITK
milano triaged T26001: The return value in mitkSerialCommunication::Send is inconsistent under Microsoft Windows Platforms as Low priority.
Feb 7 2019, 3:33 PM · Pull Request, MITK
hentsch added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

I have the issue again with other data data from a cooperation partner. Also Slicer has issues with the original DICOM data set:

Feb 7 2019, 3:22 PM · MITK
hentsch closed T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests as Resolved.
Feb 7 2019, 3:04 PM · Restricted Project, MITK
hentsch closed T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Feb 7 2019, 3:03 PM · Restricted Project, MITK
kraeuter added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

Tested again on release mode, all tests work as intended

Feb 7 2019, 1:46 PM · Restricted Project, MITK
floca added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

Hail to the new statistics plugin! One more reason why your epic effort was well invested 😄

Feb 7 2019, 1:40 PM · Restricted Project, MITK
hentsch added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

Only the old statistics plugin was affected. In the new plugin, all is ok.

Feb 7 2019, 1:38 PM · Restricted Project, MITK
floca added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

@hentsch So does that mean it was false alarm or do I missinterpret something?

Feb 7 2019, 1:29 PM · Restricted Project, MITK
hentsch added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

I checked TestPic3DImageMaskStatistics_label2 and TestUS4DCylImageMaskStatistics_time1_label_2 via code changes (not possible via GUI). The values are consistent between test and GUI.
I can confirm that in TestUS4DCylAxialPlanarFigureMaskStatistics_time1 everything is the same too (see T24653)

Feb 7 2019, 1:05 PM · Restricted Project, MITK
kraeuter added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

Breaking down the tests to avoid a timeout I noticed that a lot of these test fail
Right now the only test I can confirm passing are the several TestCase-tests and TestUnitializedImage

Feb 7 2019, 10:44 AM · Restricted Project, MITK
neher closed T25999: mitkCommandLineParser type in help text as Resolved.
Feb 7 2019, 10:43 AM · MITK
kraeuter added a comment to T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.

Looking at the code I didn´t see the results of the GUI differing from the expected values of the test, maybe you looked at the wrong timestep because your GUI data matches with timestep 0.
Setting the US4D label1 is possible right now, but the GUI fails at label2.
But there are still results not matching up:
TestPic3DImageMaskStatistics_label2´s expected results and GUI data don´t add up.

Feb 7 2019, 10:40 AM · Restricted Project, MITK
neher added a comment to T25999: mitkCommandLineParser type in help text.

Pushed new branch T25999-CmdParserTypes.

Feb 7 2019, 10:20 AM · MITK
neher triaged T25999: mitkCommandLineParser type in help text as Wishlist priority.
Feb 7 2019, 10:11 AM · MITK

Feb 6 2019

hentsch updated subscribers of T25998: Compilation errors in Diffusion plugins due to changes in MitkChart.
Feb 6 2019, 1:50 PM · MITK
hentsch closed T25998: Compilation errors in Diffusion plugins due to changes in MitkChart as Resolved by committing rMITK859cc610f63d: resolved T25998.
Feb 6 2019, 1:49 PM · MITK
hentsch added a comment to T25998: Compilation errors in Diffusion plugins due to changes in MitkChart.

Pushed new branch T25998-compilationErrorsDiffusion.

Feb 6 2019, 1:48 PM · MITK
hentsch triaged T25998: Compilation errors in Diffusion plugins due to changes in MitkChart as Normal priority.
Feb 6 2019, 1:36 PM · MITK
nolden added projects to T25984: add Meaning of dicom tags to data (node) properties: MITK, DICOM.
Feb 6 2019, 11:01 AM · DICOM, MITK, Restricted Project

Feb 5 2019

eisenman added a comment to T25979: Linux compiler error in ImageStatisticsContainer.

Thank you for clarification! Indeed, this is an important remark! Seems that we checked on an outdated website for minimum compiler version before fixing this.

Feb 5 2019, 6:56 PM · Restricted Project, MITK
hentsch updated subscribers of T23331: Replace deprecated mitkExtractImageFilter in PlanarFigureMaskGenerator.
Feb 5 2019, 2:56 PM · Auto-closed, Restricted Project, MITK
hentsch updated subscribers of T23104: Deprecate QmitkPlotWidget.
Feb 5 2019, 2:51 PM · Restricted Project, MITK
hentsch updated subscribers of T25683: Chart Example Plugin.
Feb 5 2019, 2:50 PM · MITK
hentsch updated subscribers of T25715: VerifyStatistics should use epsilon instead of boiler plate code to handle small differences.
Feb 5 2019, 2:49 PM · MITK
hentsch updated subscribers of T25697: Optimization of MitkImageStatisticsCalculatorTest.
Feb 5 2019, 2:49 PM · Restricted Project, MITK
hentsch updated subscribers of T25704: Difference between GUI and expected values MitkImageStatisticsCalculatorTests.
Feb 5 2019, 2:48 PM · Restricted Project, MITK
hentsch closed T25989: Displaying line chart does not work anymore as Resolved by committing rMITKecbc32119bf8: resolved T25989.
Feb 5 2019, 12:03 PM · Restricted Project, MITK
hentsch closed T25989: Displaying line chart does not work anymore, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 5 2019, 12:03 PM · Restricted Project, MITK
hentsch added a comment to T25989: Displaying line chart does not work anymore.

Pushed new branch T25989-displayingLineChart.

Feb 5 2019, 12:02 PM · Restricted Project, MITK
hentsch triaged T25989: Displaying line chart does not work anymore as Normal priority.
Feb 5 2019, 11:42 AM · Restricted Project, MITK
hentsch closed T25975: Migrate to newest plotly.js version, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 5 2019, 11:42 AM · Restricted Project, MITK
hentsch closed T25975: Migrate to newest plotly.js version as Resolved by committing rMITKfea713f26de7: resolved T25975 used new plotly version 1.44.1.
Feb 5 2019, 11:42 AM · Restricted Project, MITK
hentsch added a comment to T25975: Migrate to newest plotly.js version.

Pushed new branch T25975-newPlotlyVersion.

Feb 5 2019, 11:16 AM · Restricted Project, MITK
hentsch triaged T25987: Use AddData2D as Normal priority.
Feb 5 2019, 9:58 AM · MITK
kislinsk closed T25985: Make segmentation contour thickness customizable as Invalid.

There's already a property for this: labelset.contour.width.

Feb 5 2019, 9:39 AM · MITK
hentsch created T25985: Make segmentation contour thickness customizable.
Feb 5 2019, 8:54 AM · MITK
hentsch added a comment to T22533: rework RTSTRUCT visualization.

still relevant. Very annoying is the bug that contours are not visible in each slice

Feb 5 2019, 8:50 AM · MITK (v2024.06), Restricted Project

Feb 4 2019

floca added a project to T25981: ModelFit: actualize/fix wiki page: Restricted Project.
Feb 4 2019, 1:25 PM · Restricted Project, Restricted Project, MITK
floca created T25981: ModelFit: actualize/fix wiki page.
Feb 4 2019, 1:25 PM · Restricted Project, Restricted Project, MITK

Feb 3 2019

floca added a comment to T25979: Linux compiler error in ImageStatisticsContainer.

Just as a remark (but I think an important one).

Feb 3 2019, 11:19 AM · Restricted Project, MITK

Feb 1 2019

eisenman closed T25979: Linux compiler error in ImageStatisticsContainer as Resolved.
Feb 1 2019, 6:37 PM · Restricted Project, MITK
eisenman added a comment to T25979: Linux compiler error in ImageStatisticsContainer.

Pushed new branch T25979-FixImageStatisticsContainerCompilerError.

Feb 1 2019, 6:12 PM · Restricted Project, MITK
jungsi closed Restricted Maniphest Task, a subtask of T25683: Chart Example Plugin, as Resolved.
Feb 1 2019, 4:43 PM · MITK
kalali updated the task description for T25747: Things I came across when correcting fully automatic segmentations.
Feb 1 2019, 4:12 PM · MITK
kalali closed T25977: Shortcuts to simplify the segmentation process, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Resolved.
Feb 1 2019, 4:02 PM · MITK
kalali closed T25977: Shortcuts to simplify the segmentation process as Resolved.
Feb 1 2019, 4:01 PM · Restricted Project, MITK
kalali added a project to T25977: Shortcuts to simplify the segmentation process: Restricted Project.
Feb 1 2019, 4:00 PM · Restricted Project, MITK
kalali added a comment to T25977: Shortcuts to simplify the segmentation process.

Pushed new branch T25977-Shortcuts-for-multilabel-segmentation.

Feb 1 2019, 4:00 PM · Restricted Project, MITK
eisenman moved T25979: Linux compiler error in ImageStatisticsContainer from Backlog to Bugsquashing - In Progress on the MITK board.
Feb 1 2019, 3:59 PM · Restricted Project, MITK
eisenman triaged T25979: Linux compiler error in ImageStatisticsContainer as High priority.
Feb 1 2019, 3:58 PM · Restricted Project, MITK
kalali updated the task description for T25977: Shortcuts to simplify the segmentation process.
Feb 1 2019, 3:29 PM · Restricted Project, MITK
kalali triaged T25977: Shortcuts to simplify the segmentation process as Normal priority.
Feb 1 2019, 3:24 PM · Restricted Project, MITK
hentsch claimed T25975: Migrate to newest plotly.js version.
Feb 1 2019, 3:10 PM · Restricted Project, MITK
jungsi closed Restricted Maniphest Task, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 1 2019, 3:10 PM · Restricted Project, MITK
hentsch triaged T25975: Migrate to newest plotly.js version as Normal priority.
Feb 1 2019, 3:00 PM · Restricted Project, MITK
hentsch triaged T25974: add SetChartTypeForAllDataAndReload functionality as Normal priority.
Feb 1 2019, 2:59 PM · Auto-closed, MITK
hentsch triaged T25973: Add legend position as Normal priority.
Feb 1 2019, 2:58 PM · MITK
hentsch triaged T25972: Add title to plugin as Normal priority.
Feb 1 2019, 2:56 PM · MITK
hentsch closed T25873: [chart] Theme change does not work as Resolved.
Feb 1 2019, 2:51 PM · Restricted Project, MITK
hentsch closed T25873: [chart] Theme change does not work, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
Feb 1 2019, 2:51 PM · Restricted Project, MITK
hentsch closed T25962: Example chart plugin in Examples instead of Plugins as Resolved.

after discussion with @kislinsk
Is ok in Plugins directory

Feb 1 2019, 2:34 PM · Request for Discussion, MITK
hentsch closed T25966: implement function get color theme as Resolved.
Feb 1 2019, 2:33 PM · Request for Discussion, MITK
hentsch added a comment to T25873: [chart] Theme change does not work.

Pushed new branch T25873-themeChange.

Feb 1 2019, 2:00 PM · Restricted Project, MITK