Page MenuHomePhabricator
Feed Advanced Search

Apr 5 2019

floca removed a project from T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage: Request for Discussion.
Apr 5 2019, 2:28 PM · MITK
floca closed T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage as Resolved by committing rMITK4fd405cf0b4e: Fixed T26218.
Apr 5 2019, 2:28 PM · MITK
floca removed a project from T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget: Request for Discussion.
Apr 5 2019, 2:27 PM · MITK
floca closed T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget as Resolved by committing rMITK8dea40a4a757: Fixed T26219.
Apr 5 2019, 2:26 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

Pushed new branch T26219-Crash_by_selection_widget_after_close_project.

Apr 5 2019, 2:24 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

Found it.

Apr 5 2019, 2:14 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

OK, I have narrowed it further down.

Apr 5 2019, 2:10 PM · MITK
kislinsk closed T26224: Restructure CppRestSdk modules as Resolved.
Apr 5 2019, 2:09 PM · MITK
neher added a comment to T25779: [MITK Diffusion] Streamline tractography parameter files.

Pushed new branch T25779-StpFiles2.

Apr 5 2019, 1:28 PM · MITK

Apr 4 2019

traversaro added a comment to T24971: .zip files do not extract in superbuild (Windows non-NTFS file system).

I experienced a similar problem, and I opened an issue in CMake: https://gitlab.kitware.com/cmake/cmake/issues/19132 .

Apr 4 2019, 6:35 PM · Restricted Project, IGT, MITK
goetzm added a comment to T25826: Update Radiomics GUI.

Pushed new branch T25826-RadiomicsGUIUpdate-V2.

Apr 4 2019, 5:06 PM · Auto-closed, MITK
neher closed T26179: [MITK Diffusion] Fiberfox: account for partial fourier in ETL calculation as Invalid.
Apr 4 2019, 2:57 PM · MITK
neher closed T26123: [MITK Diffusion] Fiberfox output tick image as Resolved.
Apr 4 2019, 2:56 PM · MITK
neher closed T26234: [MITK Diffusion] Fiberfox TSE sequence as Resolved.
Apr 4 2019, 2:51 PM · MITK
neher added a comment to T26234: [MITK Diffusion] Fiberfox TSE sequence.

Pushed new branch T26234-TSE.

Apr 4 2019, 2:48 PM · MITK
neher triaged T26234: [MITK Diffusion] Fiberfox TSE sequence as Normal priority.
Apr 4 2019, 2:18 PM · MITK
espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Another place where inverse matrix calculation has been introduced:

Apr 4 2019, 1:26 PM · MITK
espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

As I see, the inverse matrix calculation came in with this commit of mine:

Apr 4 2019, 1:10 PM · MITK
floca updated subscribers of T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

@kalali @kislinsk , added you two has you have some experience with at least either rendering/mapper or selection concept. May be you have additional ideas.

Apr 4 2019, 12:52 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

The problem occured in context of selection widgets and may be could be patched for selection widgets in context of T26218.

This assumption was incorrect :(. Even if the widget properly release the node if it is deleted the problem still occures?!?

Apr 4 2019, 12:51 PM · MITK
floca updated the task description for T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.
Apr 4 2019, 12:28 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

The callstack as additional information:

Apr 4 2019, 12:27 PM · MITK
floca renamed T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget from Crash in rendering mappers when closing session after using a selection widget to Crash in rendering mappers when pressing "Close Project" after using a selection widget.
Apr 4 2019, 12:24 PM · MITK
floca updated the task description for T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.
Apr 4 2019, 12:12 PM · MITK
floca added a comment to T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.

Pushed an implementation for option 2. Widgets are now synced and remove selections that are not part of their datastorage any more.

Apr 4 2019, 12:11 PM · MITK
floca added a comment to T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.

Pushed new branch T26218-Sync_node_selection_widget_with_datastorage_node_delete.

Apr 4 2019, 12:09 PM · MITK
kalali closed T25483: Apply level window to multiple selected images as Resolved.
Apr 4 2019, 11:44 AM · Noteworthy, Restricted Project, MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

I just realized that it is actually checked in SetIndexToWorldTransform :-D

Apr 4 2019, 10:59 AM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

While I changed the matrix check, I left it at the current position in in the PlaneGeometry.
We should discuss if it is sensible to move this ckec and also it's applications to a different location, e.g. to SetIndexToWorldTransform of BaseGeometry.

Apr 4 2019, 10:45 AM · MITK
neher added a revision to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed.: Restricted Differential Revision.
Apr 4 2019, 10:42 AM · MITK
hentsch triaged T26230: Debug assertion failed in ImageStatistics as Low priority.
Apr 4 2019, 10:25 AM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Pushed new branch T25682-DominantAxesError.

Apr 4 2019, 10:01 AM · MITK
neher closed T26217: [MITK Diffusion] Diffusion function collection reference bvalue as Resolved.
Apr 4 2019, 9:29 AM · MITK
neher added a comment to T26217: [MITK Diffusion] Diffusion function collection reference bvalue.

Pushed new branch T26217-FfRefBval.

Apr 4 2019, 9:16 AM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Does anyone know why the inverse is always calculated and not simply set to the transpose? After all, we are talking about rotation matrices.
In this context, the EnsurePerpendicularNormal method (https://phabricator.mitk.org/source/mitk/browse/master/Modules/Core/src/DataManagement/mitkPlaneGeometry.cpp$37) seems rather complex and also does not catch all cases since it only checks if axis 3 is perpendicular to 1&2 but not if 1&2 are perpendicular to each other. I would prefer to simply check if the matrix R is a rotation matrix by checking

  1. det(R) == 1?
  2. R*R^T = ID?
Apr 4 2019, 8:16 AM · MITK

Apr 3 2019

espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

The meaning of the dominant axes is also documented here:

Apr 3 2019, 5:10 PM · MITK
hentsch added a comment to T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator.

Pushed new branch T26188-fixes.

Apr 3 2019, 4:57 PM · MITK
neher added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

It's apparently an issue of the "dominantAxis" calculation. In some cases this does not make sense and yields the same index twice. Not sure what this "dominantAxis" is supposed to be anyway. Supposedly related to T22254.

Apr 3 2019, 4:12 PM · MITK
kislinsk added a comment to T26224: Restructure CppRestSdk modules.

Pushed new branch T26224-RestructureCppRestSdkModule.

Apr 3 2019, 1:05 PM · MITK
hentsch placed T25831: [MITDoc][ImageStatistics] Improve documentation up for grabs.
Apr 3 2019, 11:31 AM · MITK
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.

Pushed new branch T25832-migrateModelFitToMitkCHart.

Apr 3 2019, 11:29 AM · Restricted Project, Restricted Project, MITK
hentsch reopened T25831: [MITDoc][ImageStatistics] Improve documentation as "Open".

after deleting the old plugin and renaming the new plugin, the documentation has to be fixed again.

Apr 3 2019, 11:25 AM · MITK
hentsch closed T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator as Resolved by committing rMITKb5560d6c33f2: fixed T26188.
Apr 3 2019, 11:16 AM · MITK
kislinsk triaged T26224: Restructure CppRestSdk modules as Normal priority.
Apr 3 2019, 9:28 AM · MITK

Apr 2 2019

floca added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.

If you have already an interim branch, could you push it, just to be sure that it doesn't get lost.

Apr 2 2019, 3:47 PM · Restricted Project, Restricted Project, MITK
hentsch placed T25832: Migrate ModelFit inspector plugin to MitkChart up for grabs.
Apr 2 2019, 3:21 PM · Restricted Project, Restricted Project, MITK
hentsch triaged T26222: [MitkChart] Maximizing mitkChartWidget does not lead to maximization of chart as Low priority.
Apr 2 2019, 11:07 AM · MITK

Apr 1 2019

eisenman added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

The migration of the code to OpenIGTLink v3 is done. The branch T24778-MigrationToOpenIGTLinkV3 compiles successfully on Ubuntu 18.04 now.

Apr 1 2019, 8:50 PM · Photoacoustics, Restricted Project, IGT, MITK
floca updated the task description for T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage.
Apr 1 2019, 5:10 PM · MITK
floca triaged T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget as High priority.
Apr 1 2019, 5:10 PM · MITK
floca triaged T26218: Sync NodeSelectionWidgets with data storage content if nodes are deleted from storage as Normal priority.
Apr 1 2019, 4:58 PM · MITK
neher triaged T26217: [MITK Diffusion] Diffusion function collection reference bvalue as Normal priority.
Apr 1 2019, 3:41 PM · MITK

Mar 29 2019

eisenman added a comment to T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].

Pushed new branch T24778-MigrationToOpenIGTLinkV3.

Mar 29 2019, 7:39 PM · Photoacoustics, Restricted Project, IGT, MITK
eisenman claimed T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04].
Mar 29 2019, 7:36 PM · Photoacoustics, Restricted Project, IGT, MITK
hentsch triaged T26216: Implement UpdateMinMaxValueYView for Y-Scaling of MITKChart as Normal priority.
Mar 29 2019, 3:55 PM · MITK
hentsch claimed T25832: Migrate ModelFit inspector plugin to MitkChart.
Mar 29 2019, 11:46 AM · Restricted Project, Restricted Project, MITK
hentsch added a comment to T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator.

Pushed new branch T26188-rawPointerInputImageStatistics.

Mar 29 2019, 11:43 AM · MITK
kislinsk closed T19056: MITK Crash with multiple Views as Wontfix.

Closing as Wontfix because it is probably obsolete with Amir's project.

Mar 29 2019, 8:50 AM · MITK, Bugzilla
kislinsk renamed T25835: Write migration guide for image statistics calculation from Write migration guide to Write migration guide for image statistics calculation.
Mar 29 2019, 8:43 AM · MITK
kislinsk triaged T26151: ImageGenerator::GenerateFromReference causes HEAP CORRUPTION as Normal priority.
Mar 29 2019, 8:42 AM · Auto-closed, Restricted Project, MITK
kislinsk closed T8909: Clarify meaning of Global Reinit vs Reinit as Resolved.

Yes, there was quite some work on Reinit in the meantime.

Mar 29 2019, 8:36 AM · Bugzilla, MITK
kislinsk closed T8909: Clarify meaning of Global Reinit vs Reinit, a subtask of T8477: Making Saving/Loading of 2D Images with 3D Geometry Information (e.g. 3D Rotation) possible, as Resolved.
Mar 29 2019, 8:35 AM · Bugzilla, MITK
kislinsk added a comment to T25798: Saving segmentations as .dcm (DICOM SEG) does not work.

Ah, I understand. 💡

Mar 29 2019, 8:33 AM · MITK

Mar 28 2019

kislinsk closed T23302: Build errors in MITK Utilities as Resolved.

I think this is fixed for quite some time now.

Mar 28 2019, 10:36 PM · MITK
kislinsk closed T23302: Build errors in MITK Utilities, a subtask of T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch"), as Resolved.
Mar 28 2019, 10:36 PM · MITK
nolden closed T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch") as Resolved.
Mar 28 2019, 5:16 PM · MITK
kalali added a revision to T25688: Render window manager with custom multi widget: beta version: Restricted Differential Revision.
Mar 28 2019, 4:59 PM · Noteworthy, Restricted Project, MITK
hentsch claimed T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator.
Mar 28 2019, 4:17 PM · MITK
hentsch updated subscribers of T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator.
Mar 28 2019, 4:17 PM · MITK
hentsch renamed T26188: Don't use itk smart pointer for input in ImageStatisticsCalculator from Don't use itk smart pointer for input to Don't use itk smart pointer for input in ImageStatisticsCalculator.
Mar 28 2019, 4:17 PM · MITK
hentsch closed Restricted Maniphest Task, a subtask of T25512: Restructure image statistics calculator, as Wontfix.
Mar 28 2019, 4:14 PM · MITK
hentsch added a comment to T26098: [ImageStatistics] Histogram Statistics need to be tested.

makes only sense after T24323 is done

Mar 28 2019, 4:10 PM · MITK (v2024.06), Restricted Project
hentsch closed T26010: Avoid loading all data before each test as Resolved.
Mar 28 2019, 4:09 PM · Restricted Project, MITK
hentsch closed T26010: Avoid loading all data before each test, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Mar 28 2019, 4:09 PM · Restricted Project, MITK
hentsch closed T25716: ImageStatisticsCalculatorTests run through, but are failed as Resolved.

done in f29b6e694d1a

Mar 28 2019, 4:00 PM · MITK
hentsch closed T25716: ImageStatisticsCalculatorTests run through, but are failed, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Mar 28 2019, 4:00 PM · Restricted Project, MITK
hentsch closed T26012: Define test cases, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Mar 28 2019, 3:59 PM · Restricted Project, MITK
hentsch closed T26012: Define test cases as Resolved.
Mar 28 2019, 3:59 PM · Restricted Project, MITK
hentsch closed T26011: Update TestingMacros as Resolved.

done in f29b6e694d1a

Mar 28 2019, 3:59 PM · Restricted Project, MITK
hentsch closed T26011: Update TestingMacros, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Mar 28 2019, 3:59 PM · Restricted Project, MITK
hentsch closed T25715: VerifyStatistics should use epsilon instead of boiler plate code to handle small differences as Resolved.

done in f29b6e694d1a

Mar 28 2019, 3:59 PM · MITK
hentsch closed T25715: VerifyStatistics should use epsilon instead of boiler plate code to handle small differences, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Mar 28 2019, 3:59 PM · Restricted Project, MITK
hentsch added a comment to T25697: Optimization of MitkImageStatisticsCalculatorTest.

Pushed new branch T25697-fixes.

Mar 28 2019, 3:55 PM · Restricted Project, MITK
hentsch closed T26013: Define ground truth as Resolved.
Mar 28 2019, 3:22 PM · Restricted Project, MITK
hentsch closed T26013: Define ground truth, a subtask of T25697: Optimization of MitkImageStatisticsCalculatorTest, as Resolved.
Mar 28 2019, 3:22 PM · Restricted Project, MITK
hentsch added a comment to T26169: Minimize Module dependencies.

Pushed new branch T26169-fixes.

Mar 28 2019, 3:13 PM · MITK
neher added a comment to T25779: [MITK Diffusion] Streamline tractography parameter files.

Pushed new branch T25779-StpFiles.

Mar 28 2019, 3:00 PM · MITK
kislinsk closed T26170: Integration of REST Module as Resolved.
Mar 28 2019, 2:17 PM · MITK
kislinsk added a comment to T26170: Integration of REST Module.
Mar 28 2019, 2:17 PM · MITK
kislinsk added a comment to T26170: Integration of REST Module.
  • Removed unused variables and parameters
Mar 28 2019, 11:49 AM · MITK
kislinsk added a comment to T26170: Integration of REST Module.
  • web::json::value is not comparable to NULL, use is_null() member function instead
Mar 28 2019, 11:28 AM · MITK
hentsch closed T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel as Resolved by committing rMITKa1c6fb698339: resolved T26205.
Mar 28 2019, 11:02 AM · MITK
hentsch added a comment to T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel.

Pushed new branch T26205-emptyStatisticsContainerImageStatisticsModel.

Mar 28 2019, 10:57 AM · MITK
hentsch claimed T26205: VIsualizing empty statistics container leads to crash in QmitkImageStatisticsTableModel.
Mar 28 2019, 10:47 AM · MITK
kislinsk added a comment to T26170: Integration of REST Module.
  • Replaced L"..." with _XPLATSTR("...") as string_t doesn't resolve to std::wstring on Linux.
Mar 28 2019, 10:46 AM · MITK
hentsch closed T26169: Minimize Module dependencies as Resolved.
Mar 28 2019, 10:23 AM · MITK
neher closed T26207: [MITK Diffusion] Set seed value for randm phantoms explicitely as Resolved.
Mar 28 2019, 10:21 AM · MITK
neher added a comment to T26207: [MITK Diffusion] Set seed value for randm phantoms explicitely.

Pushed new branch T26207-RandomPhantomSeed.

Mar 28 2019, 9:41 AM · MITK
neher triaged T26207: [MITK Diffusion] Set seed value for randm phantoms explicitely as Normal priority.
Mar 28 2019, 9:40 AM · MITK
hentsch added a comment to T26169: Minimize Module dependencies.

Pushed new branch T26169-minimizeModuleDependencies.

Mar 28 2019, 8:06 AM · MITK