Pushed new branch T26219-Crash_by_selection_widget_after_close_project.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 5 2019
Found it.
OK, I have narrowed it further down.
Pushed new branch T25779-StpFiles2.
Apr 4 2019
I experienced a similar problem, and I opened an issue in CMake: https://gitlab.kitware.com/cmake/cmake/issues/19132 .
Pushed new branch T25826-RadiomicsGUIUpdate-V2.
Pushed new branch T26234-TSE.
Another place where inverse matrix calculation has been introduced:
As I see, the inverse matrix calculation came in with this commit of mine:
The problem occured in context of selection widgets and may be could be patched for selection widgets in context of T26218.
This assumption was incorrect :(. Even if the widget properly release the node if it is deleted the problem still occures?!?
The callstack as additional information:
Pushed an implementation for option 2. Widgets are now synced and remove selections that are not part of their datastorage any more.
Pushed new branch T26218-Sync_node_selection_widget_with_datastorage_node_delete.
I just realized that it is actually checked in SetIndexToWorldTransform :-D
While I changed the matrix check, I left it at the current position in in the PlaneGeometry.
We should discuss if it is sensible to move this ckec and also it's applications to a different location, e.g. to SetIndexToWorldTransform of BaseGeometry.
Pushed new branch T25682-DominantAxesError.
Pushed new branch T26217-FfRefBval.
Does anyone know why the inverse is always calculated and not simply set to the transpose? After all, we are talking about rotation matrices.
In this context, the EnsurePerpendicularNormal method (https://phabricator.mitk.org/source/mitk/browse/master/Modules/Core/src/DataManagement/mitkPlaneGeometry.cpp$37) seems rather complex and also does not catch all cases since it only checks if axis 3 is perpendicular to 1&2 but not if 1&2 are perpendicular to each other. I would prefer to simply check if the matrix R is a rotation matrix by checking
- det(R) == 1?
- R*R^T = ID?
Apr 3 2019
The meaning of the dominant axes is also documented here:
Pushed new branch T26188-fixes.
It's apparently an issue of the "dominantAxis" calculation. In some cases this does not make sense and yields the same index twice. Not sure what this "dominantAxis" is supposed to be anyway. Supposedly related to T22254.
Pushed new branch T26224-RestructureCppRestSdkModule.
Pushed new branch T25832-migrateModelFitToMitkCHart.
after deleting the old plugin and renaming the new plugin, the documentation has to be fixed again.
Apr 2 2019
If you have already an interim branch, could you push it, just to be sure that it doesn't get lost.
Apr 1 2019
The migration of the code to OpenIGTLink v3 is done. The branch T24778-MigrationToOpenIGTLinkV3 compiles successfully on Ubuntu 18.04 now.
Mar 29 2019
Pushed new branch T24778-MigrationToOpenIGTLinkV3.
Pushed new branch T26188-rawPointerInputImageStatistics.
Closing as Wontfix because it is probably obsolete with Amir's project.
Yes, there was quite some work on Reinit in the meantime.
Ah, I understand. 💡
Mar 28 2019
I think this is fixed for quite some time now.
makes only sense after T24323 is done
done in f29b6e694d1a
done in f29b6e694d1a
done in f29b6e694d1a
Pushed new branch T25697-fixes.
Pushed new branch T26169-fixes.
Pushed new branch T25779-StpFiles.
- Removed unused variables and parameters
- web::json::value is not comparable to NULL, use is_null() member function instead
Pushed new branch T26205-emptyStatisticsContainerImageStatisticsModel.
- Replaced L"..." with _XPLATSTR("...") as string_t doesn't resolve to std::wstring on Linux.
Pushed new branch T26207-RandomPhantomSeed.
Pushed new branch T26169-minimizeModuleDependencies.