Page MenuHomePhabricator
Feed Advanced Search

Feb 1 2023

floca added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.

I think you found already pretty many issues. That is far enough to trigger a conversation with the Monai label team, don't you think?

Feb 1 2023, 9:57 AM · MITK

Jan 31 2023

a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. Monai label response JSON vs segmentation image mask labels:

After a segmentation is processed, the response JSON, e.g.

Jan 31 2023, 6:56 PM · MITK

Jan 28 2023

floca moved T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed. from Backlog to MITK Meeting on the Request for Discussion board.
Jan 28 2023, 4:50 PM · MITK
floca created T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed..
Jan 28 2023, 4:49 PM · MITK

Jan 25 2023

floca added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

@gaoh / @kislinsk would that integration/workflow something for the MIC meeting pitch?

Jan 25 2023, 9:18 AM · MITK
floca added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

🎉

Jan 25 2023, 9:15 AM · MITK
gaoh added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

thanks again, for solving this issue! So in the current kaapana develop the tasklist feature is now integrated!

Jan 25 2023, 9:13 AM · MITK

Jan 23 2023

kislinsk added a comment to T29412: List of MITK publications on web page is not up to date.

Status: Added quite a few papers up until 2020 thanks to a currated list of papers from @floca. For the past two years we now need to look out for papers first.

Jan 23 2023, 1:19 PM · MITK

Jan 19 2023

kislinsk added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

@gaoh I triggered the build of a new Flowbench installer in our CI. Will be ready later today and automatically uploaded. Commit hash: 122321bb.

Jan 19 2023, 3:36 PM · MITK
kislinsk closed T29431: [worklist] mitk-flow: save changed dicom segmentation not possible as Resolved by committing rMITK122321bb10af: Add DICOM SEG workaround as specified in T29431.
Jan 19 2023, 3:32 PM · MITK
floca added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

@gaoh could you verify if the fix work?

Jan 19 2023, 3:04 PM · MITK
kislinsk added a revision to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible: Restricted Differential Revision.
Jan 19 2023, 10:28 AM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Pushed new branch to rMITK MITK: feature/T29432-PreloadFirstTask2.

Jan 19 2023, 9:32 AM · MITK
kislinsk raised the priority of T29432: [worklist] mitk-flow preload first task from Wishlist to High.

Original issue resolved, raising priority and leaving open to discuss consequences in the next MITK meeting.

Jan 19 2023, 9:13 AM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Deleted branch from rMITK MITK: feature/T29432-PreloadFirstTask.

Jan 19 2023, 9:11 AM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Pushed new branch to rMITK MITK: feature/T29432-PreloadFirstTask.

Jan 19 2023, 9:11 AM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

While the original issue is rather easy to resolve by exchanging the class to data->Modified() with a RequestRenderWindowAll() (which is the actual intent anyway according to the comments), more hurdles start to appear that are not as easy to resolve.

Jan 19 2023, 9:05 AM · MITK
kislinsk removed a project from T29412: List of MITK publications on web page is not up to date: Request for Discussion.
Jan 19 2023, 7:20 AM · MITK
kislinsk added a comment to T29412: List of MITK publications on web page is not up to date.

Status: Currently I add 10 MITK-related papers per day to our publications page. Ongoing...

Jan 19 2023, 7:19 AM · MITK

Jan 17 2023

kislinsk removed a member for MITK: petersej.
Jan 17 2023, 7:26 AM
kislinsk removed a member for MITK: groehl.
Jan 17 2023, 7:26 AM
kislinsk removed a member for MITK: rosst.
Jan 17 2023, 7:26 AM
kislinsk removed a member for MITK: thomass.
Jan 17 2023, 7:26 AM
kislinsk removed a member for MITK: kleina.
Jan 17 2023, 7:25 AM
kislinsk removed a member for MITK: onogur.
Jan 17 2023, 7:25 AM
kislinsk removed a member for MITK: mindrocf.
Jan 17 2023, 7:25 AM
kislinsk removed a member for MITK: e249r.
Jan 17 2023, 7:25 AM
kislinsk removed a member for MITK: s349i.
Jan 17 2023, 7:25 AM

Jan 13 2023

floca triaged T29442: [Perfusion] Support of OSIPI Caplex as Normal priority.
Jan 13 2023, 3:42 PM · Request for Discussion, MITK
kislinsk claimed T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Thanks Ralf!

Jan 13 2023, 12:42 AM · MITK

Jan 12 2023

floca added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Describe problem has the same root then T26953. But I think for this task here we can have a work around, so that Hanno does not need to wait until the DICOM Seg thing is fixed.

Jan 12 2023, 7:09 PM · MITK

Jan 11 2023

kislinsk closed T29292: Unsupported pixel types as Wontfix.

We see and feel you. Considering the circumstances that Ralf mentioned (it's basically an ITK issue/contribution) I would anyway go for a Won't Fix here on our MITK side for now, until ITK provides the functionalities for such data types. Okay? :)

Jan 11 2023, 1:01 PM · Request for Discussion, MITK
kislinsk claimed T29412: List of MITK publications on web page is not up to date.
Jan 11 2023, 12:12 PM · MITK
franza added a comment to T29435: MITK example for usage of the ICP algorithm.

Created an example in this pull request: https://github.com/MITK/MITK/pull/271

Jan 11 2023, 10:40 AM · MITK (v2024.06), Pull Request

Jan 6 2023

kalali closed T29438: org.mitk.gui.common plugin is not initializing the CppMicroService as Resolved.
Jan 6 2023, 9:15 AM · MITK

Jan 5 2023

kalali added a revision to T29438: org.mitk.gui.common plugin is not initializing the CppMicroService: Restricted Differential Revision.
Jan 5 2023, 1:34 PM · MITK
kalali renamed T29438: org.mitk.gui.common plugin is not initializing the CppMicroService from org.mitk.gui.common plugin is not initializing the the CppMicroService to org.mitk.gui.common plugin is not initializing the CppMicroService.
Jan 5 2023, 12:47 PM · MITK
kalali created T29438: org.mitk.gui.common plugin is not initializing the CppMicroService.
Jan 5 2023, 12:45 PM · MITK
kalali removed a subtask for T23758: Introduction of custom multi widget editor: T24216: Synchronization of individual render windows: camera position.
Jan 5 2023, 9:37 AM · Restricted Project, MITK
kalali added a subtask for T29393: [mxn multi widget] Concept for individual render window synchronization: T24216: Synchronization of individual render windows: camera position.
Jan 5 2023, 9:37 AM · MITK
kalali added a comment to T29393: [mxn multi widget] Concept for individual render window synchronization.

Somehow related:

Jan 5 2023, 9:37 AM · MITK
kalali reopened T24216: Synchronization of individual render windows: camera position, a subtask of T23758: Introduction of custom multi widget editor, as Open.
Jan 5 2023, 9:37 AM · Restricted Project, MITK
kalali added a comment to T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

Related: T13465: Two 3D RenderWindows at the same time interfere with each other.

Jan 5 2023, 9:26 AM · MITK, Pull Request

Dec 22 2022

kislinsk added a comment to T24398: Dicom plugin: Retrieve does not work.

Have you pushed your clean ups? Not that your efforts get lost. 😉

Dec 22 2022, 12:17 PM · MITK (v2024.06)

Dec 19 2022

floca added a comment to T24398: Dicom plugin: Retrieve does not work.

Our side or also the CTK part.

Hm, lets put it as known issue and discuss its priority when we plan the spring release.

Only looked into our side so far. I'll create a separate task and push my clean-up that I already did so far.

Dec 19 2022, 10:43 AM · MITK (v2024.06)

Dec 16 2022

kislinsk added a comment to T29433: MITK Workbench Persistent Crash.

Without a data sample we are not able to reproduce this issue. Can you upload one of these nrrd files? Please make sure that the data does not contain any personal information. You can also restrict access to uploaded files to certain users like me.

Dec 16 2022, 11:05 AM · Auto-closed, Missing Info, MITK

Dec 14 2022

sonoaswartz added a comment to T29433: MITK Workbench Persistent Crash.

Unfortunately, it is all nrrd files. I updated my nvidia drivers and it seems to have improved slightly in that it doesn't crash within moments of loading a base nrrd file, but after I create, save and remove a segmentation nrrd, MITK Workbench crashes when I try to reload (open) the segmentation nrrd.

Dec 14 2022, 12:38 PM · Auto-closed, Missing Info, MITK
a178n edited projects for T29379: MONAI Label REST Response JSON issues, allegedly, added: MITK; removed MITK (v2023.04).
Dec 14 2022, 11:37 AM · MITK

Dec 13 2022

kislinsk moved T29432: [worklist] mitk-flow preload first task from Backlog to MITK Meeting on the Request for Discussion board.
Dec 13 2022, 8:55 PM · MITK
kislinsk added a project to T29432: [worklist] mitk-flow preload first task: Request for Discussion.
Dec 13 2022, 8:54 PM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Without any extra preferences, it's as easy as adding the line this->LoadNextUnfinishedTask(); at the end of the OnTaskListChanged() method.

Dec 13 2022, 8:54 PM · MITK
kislinsk closed T29434: Clean up preference pointer anti pattern as Resolved.
Dec 13 2022, 2:46 PM · MITK
kislinsk added a comment to T29434: Clean up preference pointer anti pattern.

Deleted branch from rMITK MITK: bugfix/T29434-CleanUpPrefPtrAntiPattern.

Dec 13 2022, 2:46 PM · MITK
kislinsk triaged T29433: MITK Workbench Persistent Crash as Normal priority.

Thanks for reporting. We are not aware of any crash like this with valid nrrd files. Since ITK snap crashes as well it could be a strong indicator that the crash is happening in the ITK reader that we use as well. It could be probably related to a corrupt nrrd file, or, in case it is a huge file, it could be simply related to running out of memory. Anyway, without the data we are not able to reproduce this issue.

Dec 13 2022, 1:19 PM · Auto-closed, Missing Info, MITK
kislinsk added a revision to T29434: Clean up preference pointer anti pattern: Restricted Differential Revision.
Dec 13 2022, 12:30 PM · MITK
kislinsk added a comment to T29434: Clean up preference pointer anti pattern.

Pushed new branch to rMITK MITK: bugfix/T29434-CleanUpPrefPtrAntiPattern.

Dec 13 2022, 12:23 PM · MITK
franza triaged T29435: MITK example for usage of the ICP algorithm as Wishlist priority.
Dec 13 2022, 10:42 AM · MITK (v2024.06), Pull Request
kislinsk triaged T29434: Clean up preference pointer anti pattern as Normal priority.
Dec 13 2022, 10:31 AM · MITK
sonoaswartz renamed T29433: MITK Workbench Persistent Crash from Please enter a meaningful title to MITK Workbench Persistent Crash.
Dec 13 2022, 12:11 AM · Auto-closed, Missing Info, MITK
sonoaswartz created T29433: MITK Workbench Persistent Crash.
Dec 13 2022, 12:10 AM · Auto-closed, Missing Info, MITK

Dec 12 2022

kislinsk triaged T29381: Move Multilabel classes to Core module as Low priority.

The hash above doesn't seem to be auto-linked. So here it is: rMITKa73e482c0387: moved labelset-related classes out from core

Dec 12 2022, 11:27 AM · MITK, Request for Discussion
kislinsk triaged T29389: Python utility module as Normal priority.

A big leap into the Python direction would be to finally resolve T27923: Integrate possibility to execute Python Code in MITK , which is complete for a while now but we weren't able to figure out why it fails on Ubuntu build clients. Since the ITK v5 upgrade, we also need to adjust a little more I guess.

Dec 12 2022, 11:25 AM · MITK (v2024.06)
kislinsk updated subscribers of T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Task lists don't do anything special regarding saving/loading data. So in theory, this bug should be reproducible by regular loading and saving via the menu in the Workbench?
However, task lists are prone to expose existing bugs related to repeated saving/loading of data. We indeed noticed another bug in this direction with .nrrd files, which were erroneous when loaded a second time in certain situations. The reason was faulty handling of properties: T29274: Label Loss on repeatedly loaded and saved segmentations.

Dec 12 2022, 11:21 AM · MITK
gaoh triaged T29432: [worklist] mitk-flow preload first task as Wishlist priority.
Dec 12 2022, 10:52 AM · MITK
gaoh triaged T29431: [worklist] mitk-flow: save changed dicom segmentation not possible as Normal priority.
Dec 12 2022, 10:46 AM · MITK

Dec 7 2022

franza updated the task description for T29429: org.mitk.gui.qt.igt.app.ultrasoundtrackingnavigation: Crash during initialization of combined modality.
Dec 7 2022, 2:54 PM · IGT, MITK
franza triaged T29429: org.mitk.gui.qt.igt.app.ultrasoundtrackingnavigation: Crash during initialization of combined modality as High priority.
Dec 7 2022, 2:53 PM · IGT, MITK
kislinsk added a comment to T29428: Creating scene file with image properties can result in missing LevelWindowbar.

Reading your other task regarding mitkscene files I wonder if it has something to to with attaching the level window property to the BaseData property list instead of the DataNode property list. In principle, the level window should be attached to the latter one as it is an "appearance" property and not something instrinsic to the data. A few years ago we changed the way properties are queried and when a property is not present in a DataNode property list, the Base Data property list is queried as fallback. Maybe it is not fully functional for level windows as it could be that the code somehow relies on / assumes that the properties are located in the DataNode property list.

Dec 7 2022, 10:00 AM · MITK
kislinsk added a comment to T29427: FlowBench mitkscene structure has changed..

Not sure if I fully understand what is going on here but the difference is that in your first example you have DataNode properties and in your second example you have BaseData properties, right? Let's talk about it in our group 5 meeting today. :)

Dec 7 2022, 9:56 AM · MITK

Dec 6 2022

gaoh triaged T29428: Creating scene file with image properties can result in missing LevelWindowbar as Normal priority.
Dec 6 2022, 4:42 PM · MITK
gaoh created T29428: Creating scene file with image properties can result in missing LevelWindowbar.
Dec 6 2022, 4:42 PM · MITK
gaoh triaged T29427: FlowBench mitkscene structure has changed. as Normal priority.
Dec 6 2022, 2:58 PM · MITK

Dec 1 2022

kislinsk updated subscribers of T29421: Finding CppRestSDK library alternative.

@a178n I added cpp-httplib as dependency to MITK in the branch mentioned above so you can easily experiment with it. For details, see rMITKf88e3d05aeb0: Add cpp-httplib as optional dependency.

Dec 1 2022, 1:51 PM · MITK
kislinsk added a comment to T29421: Finding CppRestSDK library alternative.

Pushed new branch to rMITK MITK: feature/T29421-httplib.

Dec 1 2022, 1:49 PM · MITK

Nov 30 2022

a178n updated subscribers of T29421: Finding CppRestSDK library alternative.
Nov 30 2022, 8:49 PM · MITK
a178n added a comment to T29421: Finding CppRestSDK library alternative.

After a meeting with Ralf and Stefan (30.11.2022), the header-only library cpp-httplib (GitHub: https://github.com/yhirose/cpp-httplib), was chosen as a promising alternative. The library seems the most popular in the GitHub community compared to Pistache, the second favourite library from the list.
Hands-on efforts to build server and client calls will be undertaken to test further suitability.

Nov 30 2022, 8:49 PM · MITK
a178n added a comment to T29421: Finding CppRestSDK library alternative.

The literature survey searching for alternatives is summarized here: https://hub.dkfz.de/s/qsEgaWybwiWcfYN

Nov 30 2022, 8:29 PM · MITK
a178n triaged T29421: Finding CppRestSDK library alternative as Normal priority.
Nov 30 2022, 5:39 PM · MITK
kalali removed a parent task for T29094: Deleting a data node causes global reset: T27613: Improve reinit behavior.
Nov 30 2022, 2:08 PM · MITK, Checklist
kalali closed T26394: [Render window manager] Provide tree view / model, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Wontfix.
Nov 30 2022, 2:02 PM · MITK
kislinsk edited projects for T29095: [Image Cropper] Moving of the bounding box can not be undone, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T29211: Remove "Scaling" from QmitkRegistrationManipulationWidget.ui, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK
kislinsk edited projects for T28778: "Use constraint zooming and panning" is only applied after reinit/restart, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T28803: [Properties] Fine-tune selection widget, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T29101: [3D Segmentation] Region Growing Tool - Generated Segmentation darkens the ambient image, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T29336: Changing theme in Preferences has no effect., added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T29309: [GrowCut] Further remarks regarding GrowCut, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK
kislinsk edited projects for T27142: Unit test for average baseline signal, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Restricted Project
kislinsk edited projects for T28557: Cannot load segmentations from KITS challenge due to unknown pixel type, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Request for Discussion
kislinsk edited projects for T28782: Scanning directories in DICOM Browser -> Import only works once, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Checklist
kislinsk edited projects for T28781: Selected series and studies cannot be deleted from DICOM browser without deleting the whole patient, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Checklist
kislinsk edited projects for T28207: MITK DicomBrowser q/r Retrieve part crash, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Checklist
kislinsk edited projects for T29381: Move Multilabel classes to Core module, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Request for Discussion
kislinsk added a comment to T28585: The MITK-Tutorial Step 9 missing inheritence.

The plugin generator has been removed for now. Step 9 should be redesigned if the plugin generator was the blocker.

Nov 30 2022, 10:06 AM · MITK (v2024.06)
kalali removed a project from T28108: [Release Checklists] Prepare release checklists: Next Milestone.
Nov 30 2022, 9:38 AM · MITK
kalali closed T28108: [Release Checklists] Prepare release checklists as Resolved.
Nov 30 2022, 9:37 AM · MITK
kalali removed a subtask for T28108: [Release Checklists] Prepare release checklists: Restricted Maniphest Task.
Nov 30 2022, 9:37 AM · MITK
kalali removed a subtask for T28108: [Release Checklists] Prepare release checklists: Restricted Maniphest Task.
Nov 30 2022, 9:37 AM · MITK
kalali removed a subtask for T28108: [Release Checklists] Prepare release checklists: T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification .
Nov 30 2022, 9:36 AM · MITK
floca moved T29412: List of MITK publications on web page is not up to date from Backlog to MITK Meeting on the Request for Discussion board.
Nov 30 2022, 9:13 AM · MITK