Page MenuHomePhabricator
Feed Advanced Search

Sep 10 2020

kislinsk added a comment to T24716: mitk::ImageDataItem::ComputeItemSize() has 4GB limit.

Deleted branch T24716-imageDataItem-limit-expanded.

Sep 10 2020, 10:23 AM · MITK (2018-04)
kislinsk added a comment to T24332: Limit MITK to python 3.

Deleted branch T24332-update-SimpleITK-and-use-system-python3.

Sep 10 2020, 9:46 AM · MITK (2018-04)
kislinsk added a comment to T23343: Dicom editor can not load dicom segmentation objects.

Deleted branch T23343-enable-microservice-based-reading-for-dicom-editor.

Sep 10 2020, 9:46 AM · MICO (Demo MICCAI 2018), MITK (2018-04)

Jun 30 2020

Oshio added a comment to T27389: Running tutorial's Step8 gives Segmentation Fault!.

A couple of days after writing that, I found the code that is setting the initial state to visible.

Jun 30 2020, 8:31 PM · MITK (2018-04)
kalali added a comment to T27389: Running tutorial's Step8 gives Segmentation Fault!.

@kalali Your solution solved the problem. I'd like to point out that SetWidgetPlanesVisibility(true) is already called somewhere inside InitializeMultiWidget(), so just AddPlanesToDataStorage()is enough for rendering the planes.

Jun 30 2020, 9:41 AM · MITK (2018-04)

Jun 20 2020

kalali added a comment to T27389: Running tutorial's Step8 gives Segmentation Fault!.

Thank you for your response and for pointing out the redundancy, I will fix this next week.

Jun 20 2020, 9:53 AM · MITK (2018-04)
Oshio added a comment to T27389: Running tutorial's Step8 gives Segmentation Fault!.

@kalali Your solution solved the problem. I'd like to point out that SetWidgetPlanesVisibility(true) is already called somewhere inside InitializeMultiWidget(), so just AddPlanesToDataStorage()is enough for rendering the planes.

Jun 20 2020, 6:12 AM · MITK (2018-04)

Jun 19 2020

kalali closed T27389: Running tutorial's Step8 gives Segmentation Fault! as Resolved.

I fixed the tutorial accordingly and close this task as resolved. If you still have problems, don't hesitate to reopen this task.

Jun 19 2020, 2:58 PM · MITK (2018-04)

Jun 16 2020

kalali claimed T27389: Running tutorial's Step8 gives Segmentation Fault!.

I can reproduce the error. There was a change in the StdMultiWidget so we have to adapt the tutorial. A specific initialization-method was added, so we need to call InitializeMultiWidget before accessing the render windows (which does some things for us so we can remove some lines from the tutorial).
The level window slider was removed from the StdMultiWidget and needs to be added additionally.

Jun 16 2020, 1:23 PM · MITK (2018-04)

May 11 2020

Oshio edited projects for T27389: Running tutorial's Step8 gives Segmentation Fault!, added: MITK (2018-04); removed MITK.
May 11 2020, 7:53 PM · MITK (2018-04)

Jan 9 2020

gaoh placed T24398: Dicom plugin: Retrieve does not work up for grabs.

This issue is not wDB related, but MITK related:
Query with CGET activated and then Retrieve:
Retrieve does not work, MTIK directly shows:

Jan 9 2020, 10:05 AM · MITK (v2024.06)

Jan 8 2020

gaoh reopened T24398: Dicom plugin: Retrieve does not work as "Open".

This does still not work (Retrieve from wdB fails, when going throw the "Checkliste DICOM Browser".
I have to look into this.

Jan 8 2020, 11:45 AM · MITK (v2024.06)

Jun 11 2019

full created T26397: Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK.
Jun 11 2019, 8:13 PM · MITK

Apr 15 2019

hettich added a comment to T24948: MITK doesn't build with gcc 8.

You mean like

-Wno-error=catch-value=
Apr 15 2019, 8:29 PM · MITK (2018-04)

Apr 9 2019

eisenman closed T24778: OpenIGTlink does not build in superbuild [Ubuntu 18.04], a subtask of T24786: Test MITK v2018.04 with Ubuntu 18.04, as Resolved.
Apr 9 2019, 5:06 PM · MITK (2018-04)

Mar 11 2019

kislinsk archived MITK (2018-04).
Mar 11 2019, 9:34 AM
kislinsk closed T24498: Update MITK Wikipedia page as Resolved.
Mar 11 2019, 9:34 AM · MITK (2018-04)
kislinsk closed T25619: Remaining Todos for MITK v2018.04 as Resolved.
Mar 11 2019, 9:33 AM · MITK (2018-04)

Feb 5 2019

floca created T25988: LabelSetImageIO should support time geometries and property serialization.
Feb 5 2019, 11:02 AM · MITK (v2021.02)
full added a comment to T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.

Alright, thanks for your support!

Feb 5 2019, 10:50 AM · MITK
floca added a comment to T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.

Thanks for that. The problem arises from a insufficient implementation of the LabelSetImagIO. It currently ignores the time geometry and additional properties :(.

Feb 5 2019, 10:48 AM · MITK

Jan 29 2019

full added a comment to T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.

Sorry I did not mention this, but I use the multi label segmentation.

Jan 29 2019, 4:05 PM · MITK
floca added a comment to T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.
In T25939#173903, @full wrote:

For the sake of completeness: I did as you suggested and created a segmentation from scratch and exporting it as nrrd. This did not solve the problem.

Then there might be another bug involved. Could you make such a segmentaton (must not be a meaningfull) store it as nrrd and provide the stored NRRD?

Jan 29 2019, 4:02 PM · MITK
full added a comment to T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.

Thank you for your extensive response.

Jan 29 2019, 3:59 PM · MITK
floca added a comment to T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.

The reason is (most certainly, but not verified!), that the nifti segmentations do not store correct timepoints for each frame. If loaded, they will get the default time geometry. (starting with 0 ms and a duration of 1 ms per frame). This is one of the problems I addressed last december with my camic info mail, to make people aware of current problems with using nifti (cf nrrd format) when storing data.

Jan 29 2019, 3:12 PM · MITK
full created T25939: DICOM data and Nifti Segmentation don't like each other, 3d+t data.
Jan 29 2019, 11:58 AM · MITK

Jan 8 2019

kislinsk reassigned T25619: Remaining Todos for MITK v2018.04 from kislinsk to nolden.
Jan 8 2019, 11:25 AM · MITK (2018-04)

Dec 18 2018

neher closed T24705: [MITK Diffusion] MITK Diffusion crashes on close as Invalid.
Dec 18 2018, 7:49 AM · MITK (2018-04)

Dec 17 2018

hentsch placed T24498: Update MITK Wikipedia page up for grabs.
Dec 17 2018, 4:17 PM · MITK (2018-04)

Dec 3 2018

kislinsk closed T24333: Noteworthy new features since MITK 2016.11 as Resolved.
Dec 3 2018, 3:41 PM · MITK (2018-04)
kislinsk closed T24552: Write migration guide as Resolved.
Dec 3 2018, 3:41 PM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Dec 3 2018, 3:40 PM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Dec 3 2018, 2:36 PM · MITK (2018-04)

Nov 23 2018

hentsch added a comment to T25619: Remaining Todos for MITK v2018.04.

The tutorial ("Welcome screen") has light theme and the old icons. This might be quite confusing for new users.

Nov 23 2018, 10:52 AM · MITK (2018-04)
hentsch claimed T24498: Update MITK Wikipedia page.
Nov 23 2018, 10:50 AM · MITK (2018-04)

Nov 21 2018

kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 21 2018, 10:42 AM · MITK (2018-04)

Nov 20 2018

hentsch added a comment to T24333: Noteworthy new features since MITK 2016.11.

warnings as errors on by default: New CMake option WARNINGS_NO_ERRORS

Nov 20 2018, 1:50 PM · MITK (2018-04)

Nov 15 2018

kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 15 2018, 10:27 AM · MITK (2018-04)

Nov 13 2018

kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 13 2018, 1:49 PM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 13 2018, 12:46 PM · MITK (2018-04)
floca added a comment to T24553: Write and communicate release strategy (alpha, beta, ...).

Is this really already resolved?

Nov 13 2018, 11:52 AM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 13 2018, 11:20 AM · MITK (2018-04)
kislinsk closed T24553: Write and communicate release strategy (alpha, beta, ...) as Resolved.
Nov 13 2018, 11:19 AM · MITK (2018-04)
kislinsk closed T25191: v2018.04-beta as Resolved.
Nov 13 2018, 11:19 AM · MITK (2018-04)
kislinsk closed T25186: Set version information as Resolved.
Nov 13 2018, 11:18 AM · MITK (2018-04)
kislinsk added a comment to T25186: Set version information.

Pushed new branch T25186-version-number-update.

Nov 13 2018, 11:15 AM · MITK (2018-04)
tsvetkov added a comment to T25191: v2018.04-beta.

Pushed new branch T25191-v2018.04-beta-DICOMBrowser-ListRequests.

Nov 13 2018, 10:24 AM · MITK (2018-04)

Nov 9 2018

kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 9 2018, 2:22 PM · MITK (2018-04)
kislinsk closed T24755: 2D Fast Marching Segmentation Tool doesn't work as Resolved.
Nov 9 2018, 12:59 PM · MITK (2018-04)
tsvetkov added a comment to T25619: Remaining Todos for MITK v2018.04.

Known Issues:
Under Linux after compiling i have to start the program twice, the first time with --BlueBerry.clean. I use this script to compile and start it faster:
#!/bin/bash

Nov 9 2018, 11:52 AM · MITK (2018-04)
tsvetkov added a comment to T25191: v2018.04-beta.

Pushed new branch T25191-v2018.04-beta-FastMargin.

Nov 9 2018, 11:02 AM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 9 2018, 10:54 AM · MITK (2018-04)
kislinsk closed T24951: mitkGIFVolumetricDensityStatisticsTest fails randomly as Resolved.

rMITKbd5795bba880: Fix out of range index

Nov 9 2018, 10:33 AM · MITK (2018-04)
kislinsk closed T23590: Level Window Multilabel Segmentation as Resolved.
Nov 9 2018, 10:26 AM · MITK (2018-04), Restricted Project
kislinsk claimed T23590: Level Window Multilabel Segmentation.

Cherry-picking into beta...

Nov 9 2018, 10:19 AM · MITK (2018-04), Restricted Project

Nov 7 2018

kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 7 2018, 2:57 PM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 7 2018, 12:22 PM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 7 2018, 12:12 PM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 7 2018, 12:01 PM · MITK (2018-04)
kislinsk added a comment to T25619: Remaining Todos for MITK v2018.04.

The "Write ...." todos are perfect candidates for off-side parallel tasks for "everyone" to grab.

Nov 7 2018, 11:58 AM · MITK (2018-04)
kislinsk renamed T25619: Remaining Todos for MITK v2018.04 from Remaining Todos to Remaining Todos for MITK v2018.04.
Nov 7 2018, 11:56 AM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 7 2018, 11:55 AM · MITK (2018-04)
kislinsk updated the task description for T25619: Remaining Todos for MITK v2018.04.
Nov 7 2018, 11:40 AM · MITK (2018-04)
kislinsk triaged T25619: Remaining Todos for MITK v2018.04 as Wishlist priority.
Nov 7 2018, 11:25 AM · MITK (2018-04)
kislinsk moved T23590: Level Window Multilabel Segmentation from Backlog to Waiting for feedback on the MITK (2018-04) board.
Nov 7 2018, 10:44 AM · MITK (2018-04), Restricted Project
kislinsk closed T20061: MITK crashes when loading 2D segmentation as Resolved.

I just checked again and I was able to open a 2d image and even create a segmentation for it, which is then a 3d image with a single slice.

Nov 7 2018, 10:21 AM · MITK (2018-04), Restricted Project
kislinsk closed T24640: Dicom reader crashes as Resolved.

The branch above is already merged. Closing this one.

Nov 7 2018, 9:28 AM · MITK (2018-04)
kislinsk moved T24951: mitkGIFVolumetricDensityStatisticsTest fails randomly from Backlog to Waiting for feedback on the MITK (2018-04) board.
Nov 7 2018, 9:22 AM · MITK (2018-04)
kislinsk moved T25186: Set version information from Blocking v2018.04 to Release management on the MITK (2018-04) board.
Nov 7 2018, 9:22 AM · MITK (2018-04)
kislinsk closed T25193: Enable DCMQI in ReleaseConfiguration as Resolved.
Nov 7 2018, 9:17 AM · MITK (2018-04)
kalali edited projects for T23590: Level Window Multilabel Segmentation, added: MITK (2018-04); removed MITK.
Nov 7 2018, 9:16 AM · MITK (2018-04), Restricted Project
kislinsk added a comment to T25193: Enable DCMQI in ReleaseConfiguration.

Pushed new branch T25193-DCMQI-ON.

Nov 7 2018, 9:16 AM · MITK (2018-04)
kislinsk closed T24398: Dicom plugin: Retrieve does not work as Invalid.

Okay, so this sounds to me as if it is nothing MITK specific here. I close this task, please re-open if you disagree.

Nov 7 2018, 8:40 AM · MITK (v2024.06)
kislinsk closed T23343: Dicom editor can not load dicom segmentation objects as Resolved.
Nov 7 2018, 8:38 AM · MICO (Demo MICCAI 2018), MITK (2018-04)
kislinsk closed T23343: Dicom editor can not load dicom segmentation objects, a subtask of T25193: Enable DCMQI in ReleaseConfiguration, as Resolved.
Nov 7 2018, 8:38 AM · MITK (2018-04)
kislinsk added a comment to T24951: mitkGIFVolumetricDensityStatisticsTest fails randomly.

Wrote an email to @goetzm.

Nov 7 2018, 8:36 AM · MITK (2018-04)
kislinsk added a comment to T24951: mitkGIFVolumetricDensityStatisticsTest fails randomly.

Among other tests, this one is fixed this in the master branch. I cherry-picked most commits from @goetzm into the beta branch and most tests also work in the beta branch now but this single one is still failing randomly.
@goetzm Please help identify the commit in the master that fixes this particular test.

Nov 7 2018, 8:33 AM · MITK (2018-04)
kislinsk closed T25435: time function for segmentation tasks of 2d/3d+t data as Resolved.

I closed the remaining TODOs because of ordering priorities in MITK tasks. The most important feature here is implemented and in beta branch.

Nov 7 2018, 8:23 AM · MITK (2018-04)
kislinsk closed T25525: Make keys for timestep increase/decrease configurable through preferences, a subtask of T25435: time function for segmentation tasks of 2d/3d+t data, as Wontfix.
Nov 7 2018, 8:22 AM · MITK (2018-04)
kislinsk closed T25527: Auto-cycle feature for stepping through 3d+t data, a subtask of T25435: time function for segmentation tasks of 2d/3d+t data, as Wontfix.
Nov 7 2018, 8:21 AM · MITK (2018-04)

Oct 26 2018

floca added a comment to T25105: UpdateStatusBar duplicates business logic.

We do not need to move the whole functionality to the data storage, just the geometry processing part.

What do you exactly mean with geometry processing part? Does "to the storage" mean, into the class or into the file?

Oct 26 2018, 11:06 PM · MITK (v2022.10)
kislinsk closed T24615: Make Boost build robust as Resolved.
Oct 26 2018, 3:20 PM · MITK (2018-04)
kislinsk closed T25580: Fix various minor documentation issues as Resolved.
Oct 26 2018, 2:35 PM · MITK (2018-04)
nolden raised the priority of T20061: MITK crashes when loading 2D segmentation from Low to Normal.

Discussed at MITK meeting: workbench should not crash, no matter how we handle 2D segmentations

Oct 26 2018, 11:58 AM · MITK (2018-04), Restricted Project
kislinsk updated the task description for T25186: Set version information.
Oct 26 2018, 10:55 AM · MITK (2018-04)
kislinsk updated the task description for T25580: Fix various minor documentation issues.
Oct 26 2018, 10:53 AM · MITK (2018-04)
kislinsk added a comment to T25580: Fix various minor documentation issues.

Pushed new branch T25580-DocumentationFixes-MasterOnly.

Oct 26 2018, 10:51 AM · MITK (2018-04)
kislinsk added a comment to T25580: Fix various minor documentation issues.

Pushed new branch T25580-FixVariousMinorDocumentationIssues.

Oct 26 2018, 10:07 AM · MITK (2018-04)
kislinsk triaged T25580: Fix various minor documentation issues as Normal priority.
Oct 26 2018, 10:02 AM · MITK (2018-04)

Oct 25 2018

kislinsk closed T22656: Boost binaries provoke a compile error in superbuild when built for multiple configurations, a subtask of T24615: Make Boost build robust, as Resolved.
Oct 25 2018, 12:20 PM · MITK (2018-04)
kislinsk closed T25540: Boost error: Function seekpos in class fpos of file iosfwd is deprecated and empty, a subtask of T24615: Make Boost build robust, as Resolved.
Oct 25 2018, 10:24 AM · MITK (2018-04)

Oct 24 2018

kalali added a subtask for T24615: Make Boost build robust: T25540: Boost error: Function seekpos in class fpos of file iosfwd is deprecated and empty.
Oct 24 2018, 3:08 PM · MITK (2018-04)

Oct 23 2018

kalali added a comment to T25105: UpdateStatusBar duplicates business logic.

We do not need to move the whole functionality to the data storage, just the geometry processing part. The rest can be put somewhere else, but https://phabricator.mitk.org/D14 said, It was decided that the status bar should not be responsible for extracting information from an image.

Oct 23 2018, 6:15 PM · MITK (v2022.10)
floca added a comment to T25105: UpdateStatusBar duplicates business logic.

Would it be reasonable to move the UpdateStatusBar functionality to the data storage as well

No, I don't think so. It is not job of the DataStorage to update the status bar.

Oct 23 2018, 4:26 PM · MITK (v2022.10)
floca added a subtask for T25042: How to handle update informations in heterogeneous time geometries and out of bound situations : T25098: Mapper (partially?) do not handle images correctly if they are out of time bound.
Oct 23 2018, 12:41 PM · MITK
floca added a parent task for T25098: Mapper (partially?) do not handle images correctly if they are out of time bound: T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .
Oct 23 2018, 12:40 PM · MITK (v2024.06)
floca added a comment to T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .

Yes, partially. We have no crashes, but

Oct 23 2018, 12:40 PM · MITK
floca updated the task description for T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .
Oct 23 2018, 12:30 PM · MITK
floca updated the task description for T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .
Oct 23 2018, 12:28 PM · MITK
kalali added a comment to T25105: UpdateStatusBar duplicates business logic.

The GetTopLayerNode has been moved to the data storage as FindTopmostVisibleNode.
Would it be reasonable to move the UpdateStatusBar functionality to the data storage as well, as it needs to extract image information from the topmost visible node?
Or is there some other place for this kind of image geometry processing?

Oct 23 2018, 10:55 AM · MITK (v2022.10)