Page MenuHomePhabricator
Feed Advanced Search

Jan 25 2020

kislinsk added a comment to T27033: Clean up stale remote branches.

Unmerged branches in origin/tags/

Jan 25 2020, 9:46 PM · Auto-closed, MITK
kislinsk updated subscribers of T27033: Clean up stale remote branches.
Jan 25 2020, 9:43 PM · Auto-closed, MITK
kislinsk added a comment to T27033: Clean up stale remote branches.

Unmerged branches that do not match releases/, tags/, personal/, Txxx-, or bug-xxx-

Jan 25 2020, 9:41 PM · Auto-closed, MITK
kislinsk updated subscribers of T27033: Clean up stale remote branches.

Extracted from the huge list above.

Jan 25 2020, 9:30 PM · Auto-closed, MITK
kislinsk triaged T27033: Clean up stale remote branches as Wishlist priority.
Jan 25 2020, 9:01 PM · Auto-closed, MITK

Jan 23 2020

kislinsk committed rMITK1f3b840d2e92: Merge branch 'T27025-FixDocumentationWarnings' (authored by kislinsk).
Merge branch 'T27025-FixDocumentationWarnings'
Jan 23 2020, 3:17 PM
kislinsk committed rMITKd7c7ca2bf853: Fix unambiguous declarations/definitions (authored by kislinsk).
Fix unambiguous declarations/definitions
Jan 23 2020, 3:15 PM
kislinsk committed rMITKe31f800f78c7: Help Doxygen parser by using anonymous namespace (authored by kislinsk).
Help Doxygen parser by using anonymous namespace
Jan 23 2020, 2:06 PM
kislinsk committed rMITK889701cea10b: Encapsulate friend (authored by kislinsk).
Encapsulate friend
Jan 23 2020, 2:06 PM
kislinsk committed rMITK6f94b1eea8e8: Remove undeclared symbols in snippet (authored by kislinsk).
Remove undeclared symbols in snippet
Jan 23 2020, 2:06 PM
kislinsk committed rMITK08dfbaf6134b: Fix macro documentation format (authored by kislinsk).
Fix macro documentation format
Jan 23 2020, 1:22 PM
kislinsk committed rMITKdd5e568687ad: Fix internal consistency warning (authored by kislinsk).
Fix internal consistency warning
Jan 23 2020, 1:22 PM
kislinsk committed rMITK8867404d58de: Remove wrong example reference (authored by kislinsk).
Remove wrong example reference
Jan 23 2020, 1:22 PM
kislinsk committed rMITK9643e7bc5387: Fix erroneous class documentation format (authored by kislinsk).
Fix erroneous class documentation format
Jan 23 2020, 1:22 PM
kislinsk committed rMITKcd515d5014de: Fix unbalanced nested comment (authored by kislinsk).
Fix unbalanced nested comment
Jan 23 2020, 1:22 PM
kislinsk committed rMITK3bd08eb907c6: Fix f$ blocks (authored by kislinsk).
Fix f$ blocks
Jan 23 2020, 12:29 PM
kislinsk committed rMITKf8b458193b03: Merge branch 'T27025-FixDocumentationWarnings' (authored by kislinsk).
Merge branch 'T27025-FixDocumentationWarnings'
Jan 23 2020, 12:18 PM
kislinsk committed rMITKfc8dd6fd8d82: Fix includes that could not be found by Doxygen (authored by kislinsk).
Fix includes that could not be found by Doxygen
Jan 23 2020, 12:18 PM
kislinsk committed rMITK96ed8f4a9c8c: Merge branch 'T27025-FixDocumentationWarnings' (authored by kislinsk).
Merge branch 'T27025-FixDocumentationWarnings'
Jan 23 2020, 8:55 AM

Jan 22 2020

kislinsk committed rMITK5fef4b445b74: Fix macro formatting and add semicolons to macros that confuse Doxygen (authored by kislinsk).
Fix macro formatting and add semicolons to macros that confuse Doxygen
Jan 22 2020, 4:44 PM
kislinsk committed rMITKf1fd5682d82d: Fix multiple uses of labels (authored by kislinsk).
Fix multiple uses of labels
Jan 22 2020, 4:44 PM
kislinsk committed rMITK2fa6854b3558: Create directory for Doxygen to parse (authored by kislinsk).
Create directory for Doxygen to parse
Jan 22 2020, 1:41 PM
kislinsk committed rMITK2c554de6729c: Quote more paths (authored by kislinsk).
Quote more paths
Jan 22 2020, 1:41 PM
kislinsk committed rMITKadbda9da00dc: Quote dot path (authored by kislinsk).
Quote dot path
Jan 22 2020, 1:18 PM
kislinsk committed rMITK412a05f776a2: Remove deprecated config variables (authored by kislinsk).
Remove deprecated config variables
Jan 22 2020, 1:18 PM
kislinsk committed rMITK799989e5a216: Make developer warnings less intrusive (authored by kislinsk).
Make developer warnings less intrusive
Jan 22 2020, 1:18 PM
kislinsk added a comment to T27025: Fix documentation warnings.

Pushed new branch T27025-FixDocumentationWarnings.

Jan 22 2020, 1:17 PM · MITK
kislinsk triaged T27025: Fix documentation warnings as Normal priority.
Jan 22 2020, 11:45 AM · MITK
kislinsk closed T26977: Fix Nightly warnings as Resolved.
Jan 22 2020, 11:34 AM · MITK
kislinsk added a comment to T26977: Fix Nightly warnings.

Too meta, fixed a few warnings, though.

Jan 22 2020, 11:34 AM · MITK
kislinsk committed rMITK9c096725e520: Merge branch 'T26977-FixWarnings' (authored by kislinsk).
Merge branch 'T26977-FixWarnings'
Jan 22 2020, 11:33 AM
kislinsk closed T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients as Resolved.
Jan 22 2020, 11:32 AM · MITK
kislinsk closed T26976: PythonQt is not installed on macOS when creating an MITK installer, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Jan 22 2020, 11:31 AM · MITK
kislinsk closed T26976: PythonQt is not installed on macOS when creating an MITK installer as Resolved.
Jan 22 2020, 11:31 AM · MITK
kislinsk committed rMITK5f183c6b9c54: Merge branch 'T27024-FixSpectralUnmixingTest' (authored by kislinsk).
Merge branch 'T27024-FixSpectralUnmixingTest'
Jan 22 2020, 10:23 AM
kislinsk committed rMITKe315ea04a30a: Disable randomly failing test (authored by kislinsk).
Disable randomly failing test
Jan 22 2020, 10:22 AM
kislinsk added a comment to T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest.

Pushed new branch T27024-FixSpectralUnmixingTest.

Jan 22 2020, 10:22 AM · MITK
kislinsk triaged T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest as Normal priority.
Jan 22 2020, 10:18 AM · MITK
kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Here's my CMake merge request: https://gitlab.kitware.com/cmake/cmake/merge_requests/4258

Jan 22 2020, 9:17 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

In CMake, Source/CTest/cmCTestTestHandler.cxx, cmCTestTestHandler::ProcessHandler(), there is a check if the sum of passed and failed tests equal zero. After another pre-check (see below), "No tests were found!!!" is logged as ERROR_MESSAGE. In Source/cmCTest.cxx, cmCTest::Log(), cmSystemTools::SetErrorOccured() is called if the log type is ERROR_MESSAGE.

Jan 22 2020, 6:11 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk renamed T27022: CTest returns error code if subproject does not have tests from Remove Subprojects without tests to CTest returns error code if subproject does not have tests.
Jan 22 2020, 5:50 AM · Restricted Project, Restricted Project, CI, MITK

Jan 21 2020

kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Reverted the removal as CTest still fails, probably because of no tests in superbuild projects. I think the best way to solve this is to contribute to CMake.

Jan 21 2020, 4:53 PM · Restricted Project, Restricted Project, CI, MITK
kislinsk committed rMITK12ad79a30e7a: Merge branch 'T27022-RemoveUnusedSubprojects' (authored by kislinsk).
Merge branch 'T27022-RemoveUnusedSubprojects'
Jan 21 2020, 4:52 PM
kislinsk added a reverting change for rMITK2666aaa01fbe: Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject: rMITKc7ccaf77b3e4: Revert "Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject".
Jan 21 2020, 4:52 PM
kislinsk committed rMITKc7ccaf77b3e4: Revert "Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject" (authored by kislinsk).
Revert "Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject"
Jan 21 2020, 4:52 PM
kislinsk committed rMITKc9744b3934d8: Merge branch 'T27022-RemoveUnusedSubprojects' (authored by kislinsk).
Merge branch 'T27022-RemoveUnusedSubprojects'
Jan 21 2020, 4:23 PM
kislinsk committed rMITK2666aaa01fbe: Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject (authored by kislinsk).
Remove MITK-Diffusion, MITK-CoreUI, and MITK-Plugins subproject
Jan 21 2020, 4:20 PM
kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Pushed new branch T27022-RemoveUnusedSubprojects.

Jan 21 2020, 4:20 PM · Restricted Project, Restricted Project, CI, MITK
kislinsk triaged T27022: CTest returns error code if subproject does not have tests as Normal priority.
Jan 21 2020, 4:18 PM · Restricted Project, Restricted Project, CI, MITK
kislinsk updated subscribers of T27019: Do not disable rendering tests on Linux by default.
Jan 21 2020, 3:42 PM · CI, Noteworthy, MITK
kislinsk closed T27019: Do not disable rendering tests on Linux by default as Resolved.
Jan 21 2020, 3:42 PM · CI, Noteworthy, MITK
kislinsk added a project to T27019: Do not disable rendering tests on Linux by default: Noteworthy.

I have introduced a new superbuild and MITK-build advanced cache variable called MITK_XVFB_TESTING. If switched on, it will prepend testdriver calls with xvfb-run --auto-servernum resulting in having a virtual frame buffer available for rendering tests. This is useful in headless systems like continuous integration clients. Works for Linux. To install xvfb call sudo apt install xvfb.

Jan 21 2020, 3:42 PM · CI, Noteworthy, MITK
kislinsk committed rMITK3e7b326f3900: Merge branch 'T27019-RenderingTestsOnLinux' (authored by kislinsk).
Merge branch 'T27019-RenderingTestsOnLinux'
Jan 21 2020, 3:00 PM
kislinsk committed rMITK837dbe368af2: Fix if-condition (authored by kislinsk).
Fix if-condition
Jan 21 2020, 2:28 PM
kislinsk committed rMITK0797e9c5fe24: Fix test declarations (authored by kislinsk).
Fix test declarations
Jan 21 2020, 2:00 PM
kislinsk committed rMITKd09bb9dd863a: Add MITK_XVFB_TESTING option (authored by kislinsk).
Add MITK_XVFB_TESTING option
Jan 21 2020, 1:59 PM
kislinsk committed rMITKda2f2e9b318e: Merge branch 'T27019-RenderingTestsOnLinux' (authored by kislinsk).
Merge branch 'T27019-RenderingTestsOnLinux'
Jan 21 2020, 9:48 AM
kislinsk committed rMITK9e655013a885: Remove MITK_ENABLE_RENDERING_TESTING completely (authored by kislinsk).
Remove MITK_ENABLE_RENDERING_TESTING completely
Jan 21 2020, 9:47 AM

Jan 20 2020

kislinsk committed rMITK250366539f2f: Merge branch 'T27019-RenderingTestsOnLinux' (authored by kislinsk).
Merge branch 'T27019-RenderingTestsOnLinux'
Jan 20 2020, 2:46 PM
kislinsk committed rMITK2e3e8f907d47: Enable rendering tests on Linux by default (authored by kislinsk).
Enable rendering tests on Linux by default
Jan 20 2020, 2:28 PM
kislinsk added a comment to T27019: Do not disable rendering tests on Linux by default.

Pushed new branch T27019-RenderingTestsOnLinux.

Jan 20 2020, 2:28 PM · CI, Noteworthy, MITK
kislinsk triaged T27019: Do not disable rendering tests on Linux by default as Normal priority.
Jan 20 2020, 2:22 PM · CI, Noteworthy, MITK
kislinsk committed rMITKea299c95c72b: Merge branch 'T26976-InstallPythonQtOnMacOs' (authored by kislinsk).
Merge branch 'T26976-InstallPythonQtOnMacOs'
Jan 20 2020, 11:07 AM
kislinsk committed rMITK339c050c07de: Fix IGNORE_ITEM parameter name (authored by kislinsk).
Fix IGNORE_ITEM parameter name
Jan 20 2020, 11:06 AM
kislinsk triaged T27010: `make package` takes forever (in particular on macOS) as Normal priority.
Jan 20 2020, 10:30 AM · MITK
kislinsk closed T24271: Port tests from old mitk test macros to CPPUNIT as Resolved.
Jan 20 2020, 10:23 AM · MITK

Jan 17 2020

kislinsk committed rMITK4c24e3cba37d: Merge branch 'T26976-InstallPythonQtOnMacOs' (authored by kislinsk).
Merge branch 'T26976-InstallPythonQtOnMacOs'
Jan 17 2020, 9:53 AM
kislinsk committed rMITKf02562b637bc: Ignore Python executable in macOS Python.framework (authored by kislinsk).
Ignore Python executable in macOS Python.framework
Jan 17 2020, 9:52 AM

Jan 16 2020

kislinsk added a reverting change for rMITK343d9f435f57: Discover and fixup all executables before verifying the bundle on macOS: rMITKc6e9a6caff41: Revert "Discover and fixup all executables before verifying the bundle on macOS".
Jan 16 2020, 2:21 PM
kislinsk committed rMITKc6e9a6caff41: Revert "Discover and fixup all executables before verifying the bundle on macOS" (authored by kislinsk).
Revert "Discover and fixup all executables before verifying the bundle on macOS"
Jan 16 2020, 2:21 PM
kislinsk placed T26992: Rendering tests do not run on Windows and macOS up for grabs.
Jan 16 2020, 12:51 PM · Auto-closed, MITK
kislinsk placed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) up for grabs.
Jan 16 2020, 12:51 PM · MITK, Pull Request
kislinsk placed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry up for grabs.
Jan 16 2020, 12:51 PM · MITK, Restricted Project
kislinsk committed rMITK343d9f435f57: Discover and fixup all executables before verifying the bundle on macOS (authored by kislinsk).
Discover and fixup all executables before verifying the bundle on macOS
Jan 16 2020, 12:50 PM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

https://gitlab.kitware.com/cmake/cmake/issues/20165

Jan 16 2020, 10:53 AM · MITK

Jan 14 2020

kislinsk committed rMITK258838df6a80: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Jan 14 2020, 4:24 PM
kislinsk committed rMITKf2e9c3aeb49a: Add missing header (macOS) (authored by kislinsk).
Add missing header (macOS)
Jan 14 2020, 4:23 PM
kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

For now, re-introduce a check for OpenGL support until we found a solution.

Jan 14 2020, 4:03 PM · Auto-closed, MITK
kislinsk committed rMITKe5aeb4ab1fe5: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Jan 14 2020, 4:01 PM
kislinsk committed rMITKdd8d6da2f746: Reintroduce enhanced OpenGL support test (authored by kislinsk).
Reintroduce enhanced OpenGL support test
Jan 14 2020, 4:01 PM
kislinsk committed rMITK2c98c94e9afb: Remove dangling declarations (authored by kislinsk).
Remove dangling declarations
Jan 14 2020, 4:01 PM

Jan 13 2020

kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

Test now do run on Windows but they fail because of OpenGL context creation issues. I guess it has something to do with using the Windows client in "headless" mode.

Jan 13 2020, 3:44 PM · Auto-closed, MITK
kislinsk committed rMITK31796e4f314d: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Jan 13 2020, 3:09 PM
kislinsk committed rMITKce4bd875017f: Remove flawed OpenGL detection code (authored by kislinsk).
Remove flawed OpenGL detection code
Jan 13 2020, 3:08 PM
kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

Pushed new branch T26992-FixRenderingTestHelper.

Jan 13 2020, 3:07 PM · Auto-closed, MITK
kislinsk triaged T26992: Rendering tests do not run on Windows and macOS as Normal priority.
Jan 13 2020, 3:04 PM · Auto-closed, MITK
kislinsk placed T26835: Crash on change of Surface interpolation from Phong to Flat up for grabs.
Jan 13 2020, 1:47 PM · Pull Request, MITK

Jan 9 2020

kislinsk edited projects for T18761: Verify view navigator works after BlueBerry merge, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK, Bugzilla
kislinsk edited projects for T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK (v2021.10), Cleared
kislinsk edited projects for T18866: Highlighting in View Navigator is not updated, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK (v2021.10), Restricted Project, Bugzilla
kislinsk edited projects for T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK
kislinsk edited projects for T26963: Dicom Browser progressbar not showing, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Auto-closed, MITK, Restricted Project
kislinsk edited projects for T22391: Correction tool doesn't work in empty slice, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK, Restricted Project
kislinsk edited projects for T22395: Live wire tool deactivate leads to confirm segmentation, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK, Restricted Project
kislinsk edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK (2018-04-4); removed MITK (2018-04).
Jan 9 2020, 2:52 PM · MITK (v2024.06)
kislinsk edited projects for T26957: LevelWindow context menu entries change default level-window, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · Auto-closed, MITK, Restricted Project
kislinsk edited projects for T26956: LevelWindow slider does not expand the level/window scale, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK
kislinsk edited projects for T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK (v2024.06), Checklist, Request for Discussion
kislinsk edited projects for T26964: Version number not correctly displayed in Debug mode, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK
kislinsk edited projects for T26958: LevelWindow Preset Dialog does not work correctly, added: MITK (2018-04-4); removed MITK.
Jan 9 2020, 2:52 PM · MITK