Page MenuHomePhabricator
Feed Advanced Search

Nov 30 2022

kalali moved T29240: [mxn multi widget] Allow different time navigation controller for each individual render window from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:33 AM · MITK (v2024.06)
kalali edited projects for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:33 AM · MITK (v2024.06)
kalali moved T29335: [Segmentation] Show interactive warning for uninitialized render window geometry from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:33 AM · MITK (v2023.04)
kalali edited projects for T29335: [Segmentation] Show interactive warning for uninitialized render window geometry, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:33 AM · MITK (v2023.04)
kalali moved T29402: [mxn multi widget] Concept for blocking individual render windows from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:33 AM · MITK (v2023.04)
kalali edited projects for T29402: [mxn multi widget] Concept for blocking individual render windows, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:33 AM · MITK (v2023.04)
kalali moved T29333: [mxn multi widget] Measurements / planar figure not working from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:32 AM · MITK (v2024.06)
kalali edited projects for T29333: [mxn multi widget] Measurements / planar figure not working, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:32 AM · MITK (v2024.06)
kalali moved T29364: [mxn multi widget] Image navigator cannot be used from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:32 AM · MITK (v2024.06)
kalali edited projects for T29364: [mxn multi widget] Image navigator cannot be used, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:32 AM · MITK (v2024.06)
kalali moved T29365: [mxn multi widget] Pointset interaction not working from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:31 AM · MITK (v2024.06)
kalali edited projects for T29365: [mxn multi widget] Pointset interaction not working, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:31 AM · MITK (v2024.06)
kalali moved T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:31 AM · Request for Discussion, MITK (v2023.04)
kalali edited projects for T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly, added: MITK (v2023.04), Request for Discussion; removed Next Milestone, MITK.
Nov 30 2022, 9:31 AM · Request for Discussion, MITK (v2023.04)
kalali moved T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:30 AM · MITK (v2023.12), Request for Discussion
kalali edited projects for T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty, added: MITK (v2023.04); removed MITK, Next Milestone.
Nov 30 2022, 9:30 AM · MITK (v2023.12), Request for Discussion
kalali moved T29369: [Segmentation Utilities] Handle / select different labels independently from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:30 AM · MITK (v2024.06)
kalali edited projects for T29369: [Segmentation Utilities] Handle / select different labels independently, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:30 AM · MITK (v2024.06)
kalali moved T29381: Move Multilabel classes to Core module from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:29 AM · MITK, Request for Discussion
kalali edited projects for T29381: Move Multilabel classes to Core module, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:29 AM · MITK, Request for Discussion
kalali moved T18414: Context menu item search behaves differently for single selection vs multiple selection from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Nov 30 2022, 9:28 AM · MITK (v2024.06)
kalali added a comment to T25056: Refactor data manager context menu.

We can tackle this as soon as T29025: Preference service (access) based on cpp microservices is closed.

Nov 30 2022, 9:27 AM · MITK (v2024.06), Noteworthy
kalali moved T25056: Refactor data manager context menu from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Nov 30 2022, 9:27 AM · MITK (v2024.06), Noteworthy
kalali moved T25595: [Multi widget] Make classes work with the new render window access from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Nov 30 2022, 9:25 AM · MITK (v2024.06)
kalali moved T29090: [3D Segmentation] Threshold tool preview draws contours in green and not in the active label color. from Backlog to Segmentation on the MITK (v2023.04) board.
Nov 30 2022, 9:24 AM · MITK (v2024.06), Request for Discussion, Checklist
kalali moved T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary" from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:24 AM · MITK (v2024.06), Checklist, Request for Discussion
kalali edited projects for T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:24 AM · MITK (v2024.06), Checklist, Request for Discussion
kalali moved T29313: Add a Test to check if the GrowCut algorithm produces a different output from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:22 AM · MITK (v2024.06)
kalali edited projects for T29313: Add a Test to check if the GrowCut algorithm produces a different output, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:21 AM · MITK (v2024.06)
kalali closed T28989: [Segmentation] CanHandle functions seem to be inconsistent, a subtask of T28479: [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms, as Resolved.
Nov 30 2022, 9:08 AM · MITK (v2024.06)
kalali closed T28989: [Segmentation] CanHandle functions seem to be inconsistent as Resolved.
Nov 30 2022, 9:08 AM · MITK, Request for Discussion
kalali committed rMITKefe2ad43c5eb: Make CanHandle functions more consistent (authored by kalali).
Make CanHandle functions more consistent
Nov 30 2022, 9:07 AM
kalali committed rMITK7c5aaf030a3b: Move conditions to the common base classes (authored by kalali).
Move conditions to the common base classes
Nov 30 2022, 9:07 AM

Nov 24 2022

kalali removed a subtask for T29210: Clarify / remove axis-labeling for anatomical planes: T29211: Remove "Scaling" from QmitkRegistrationManipulationWidget.ui.
Nov 24 2022, 10:44 AM · MITK (v2024.06), Request for Discussion
kalali removed a parent task for T29211: Remove "Scaling" from QmitkRegistrationManipulationWidget.ui: T29210: Clarify / remove axis-labeling for anatomical planes.
Nov 24 2022, 10:44 AM · MITK
kalali removed a subtask for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: T29210: Clarify / remove axis-labeling for anatomical planes.
Nov 24 2022, 10:44 AM · Breaking Change, Noteworthy, MITK
kalali removed a parent task for T29210: Clarify / remove axis-labeling for anatomical planes: T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.
Nov 24 2022, 10:44 AM · MITK (v2024.06), Request for Discussion
kalali closed T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations as Resolved.
Nov 24 2022, 10:43 AM · Breaking Change, Noteworthy, MITK
kalali committed rMITK748b94b4186d: Merge enums for view direction (authored by kalali).
Merge enums for view direction
Nov 24 2022, 10:38 AM
kalali committed rMITK513e872beb07: Replace ViewDirection with AnatomicalPlane (authored by kalali).
Replace ViewDirection with AnatomicalPlane
Nov 24 2022, 10:38 AM
kalali committed rMITKc0f6326f8503: Use anatomical plane in depending classes (authored by kalali).
Use anatomical plane in depending classes
Nov 24 2022, 10:38 AM
kalali committed rMITK4d4c91e4f9b5: Replace ViewDirection and PlaneOrientation with AnatomicalPlane (authored by kalali).
Replace ViewDirection and PlaneOrientation with AnatomicalPlane
Nov 24 2022, 10:38 AM

Nov 23 2022

kalali updated the task description for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.
Nov 23 2022, 5:45 PM · Breaking Change, Noteworthy, MITK
kalali committed rMITK6cd2ce96452e: Show pixel value for mxnmultiwidget (authored by kalali).
Show pixel value for mxnmultiwidget
Nov 23 2022, 5:40 PM
kalali committed rMITK674aee77ff2a: React on render window part changed (authored by kalali).
React on render window part changed
Nov 23 2022, 5:40 PM
kalali committed rMITK0d6a33f237fd: Clean up some classes (authored by kalali).
Clean up some classes
Nov 23 2022, 5:40 PM
kalali committed rMITK0a152488cdfb: React on the GeometryUpdateEvent of the SliceNavigationController (authored by kalali).
React on the GeometryUpdateEvent of the SliceNavigationController
Nov 23 2022, 5:40 PM
kalali committed rMITKddec35e41d7d: Update the crosshair with a new slice (authored by kalali).
Update the crosshair with a new slice
Nov 23 2022, 5:40 PM
kalali claimed T29385: [mxn multi widget] Pixel value view does not change on crosshair selection.
Nov 23 2022, 5:03 PM · MITK (v2023.04)
kalali closed T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash as Resolved.
Nov 23 2022, 4:55 PM · MITK
kalali removed a parent task for T29392: [SEG] Add dedicated writer to store multi-label images in nifti: T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.
Nov 23 2022, 4:54 PM · MITK (v2024.06)
kalali removed a subtask for T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: T29392: [SEG] Add dedicated writer to store multi-label images in nifti.
Nov 23 2022, 4:54 PM · MITK
kalali committed rMITK108795e0fc1f: Disable selecting legacy binary segmentations (authored by kalali).
Disable selecting legacy binary segmentations
Nov 23 2022, 4:52 PM
kalali committed rMITK00c6c35f7a3d: Remove binary segmentations as valid selection input (authored by kalali).
Remove binary segmentations as valid selection input
Nov 23 2022, 4:52 PM
kalali committed rMITK0601cbfc6a6a: Fix crash when loading multilabel nifty segmentations (authored by kalali).
Fix crash when loading multilabel nifty segmentations
Nov 23 2022, 4:51 PM
kalali committed rMITK48d2214579c5: Add nullptr checks for legacy, binary segmentations (authored by kalali).
Add nullptr checks for legacy, binary segmentations
Nov 23 2022, 4:51 PM
kalali committed rMITKcd3ac05e7ce1: Refactor QmitkStepperAdapter (authored by kalali).
Refactor QmitkStepperAdapter
Nov 23 2022, 1:52 PM
kalali committed rMITK783a734e5ca9: Clean class and replace the custom event listener (authored by kalali).
Clean class and replace the custom event listener
Nov 23 2022, 1:52 PM
kalali committed rMITK49c60f9c660a: Remove unused parameter (authored by kalali).
Remove unused parameter
Nov 23 2022, 1:52 PM

Nov 22 2022

kalali closed T29316: Rename QmitkSliderNavigatorWidget and clean variable names, a subtask of T29289: Compare responsibilities of QmitkSliceNavigationController related classes, as Resolved.
Nov 22 2022, 3:41 PM · MITK
kalali closed T29316: Rename QmitkSliderNavigatorWidget and clean variable names as Resolved.
Nov 22 2022, 3:41 PM · MITK (v2022.10)
kalali committed rMITK250afb4786bc: Rename QmitkSliderNavigatorWidget (authored by kalali).
Rename QmitkSliderNavigatorWidget
Nov 22 2022, 3:41 PM
kalali committed rMITK393bd580b653: Adapt modules to use the new class name (authored by kalali).
Adapt modules to use the new class name
Nov 22 2022, 3:41 PM
kalali committed rMITKd211c65cc657: Adapt plugins to use the new class name (authored by kalali).
Adapt plugins to use the new class name
Nov 22 2022, 3:41 PM
kalali committed rMITK06488ff694dc: Adapt Examples to use the new class name (authored by kalali).
Adapt Examples to use the new class name
Nov 22 2022, 3:41 PM
kalali committed rMITK3b1728efdffe: Clean QmitkSliceNavigationWidget (authored by kalali).
Clean QmitkSliceNavigationWidget
Nov 22 2022, 3:41 PM
kalali committed rMITK62425e9dab4e: Rename QmitkSliderNavigatorWidget to better reflect the widget type (authored by kalali).
Rename QmitkSliderNavigatorWidget to better reflect the widget type
Nov 22 2022, 3:40 PM

Nov 21 2022

kalali added a comment to T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.

@kalali please indicate that it has breaking changes in your commit message and how to handle them/migrate. thanks.

Nov 21 2022, 4:49 PM · Breaking Change, Noteworthy, MITK
kalali edited projects for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations, added: Breaking Change; removed Request for Discussion.
Nov 21 2022, 4:48 PM · Breaking Change, Noteworthy, MITK
kalali closed T29394: [mxn multi widget] Image cropper shows weird behavior as Resolved.
Nov 21 2022, 4:33 PM · MITK
kalali committed rMITK84009201569b: Reset mapper for crosshair plane nodes (authored by kalali).
Reset mapper for crosshair plane nodes
Nov 21 2022, 4:31 PM
kalali committed rMITK92a5bee04caa: Remove unnecessary layer information (authored by kalali).
Remove unnecessary layer information
Nov 21 2022, 4:31 PM
kalali committed rMITK96b30f5acacf: Reset mapper everytime the data is changed (authored by kalali).
Reset mapper everytime the data is changed
Nov 21 2022, 4:31 PM

Nov 18 2022

kalali raised the priority of T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations from Low to Normal.
Nov 18 2022, 12:32 PM · Breaking Change, Noteworthy, MITK
kalali added a parent task for T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager: T29403: [mxn multi widget] Concept for crosshair data type.
Nov 18 2022, 12:26 PM · MITK (v2024.06)
kalali added a subtask for T29403: [mxn multi widget] Concept for crosshair data type: T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager.
Nov 18 2022, 12:26 PM · MITK (v2023.04)
kalali triaged T29403: [mxn multi widget] Concept for crosshair data type as Normal priority.
Nov 18 2022, 12:26 PM · MITK (v2023.04)
kalali added a parent task for T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: T29402: [mxn multi widget] Concept for blocking individual render windows.
Nov 18 2022, 11:32 AM · MITK (v2023.04)
kalali added a subtask for T29402: [mxn multi widget] Concept for blocking individual render windows: T29335: [Segmentation] Show interactive warning for uninitialized render window geometry.
Nov 18 2022, 11:32 AM · MITK (v2023.04)
kalali triaged T29402: [mxn multi widget] Concept for blocking individual render windows as Normal priority.
Nov 18 2022, 11:32 AM · MITK (v2023.04)
kalali added a comment to T29396: [Segmentation] Newly created labelset image has wrong image type.

Yes that's what I found out too. I wanted to test something by changing the threshold tool to accept a vector image and work with AccessVectorPixelTypeByItk_n and itk::VectorImage<TPixel, VImageDimension> VectorImageType; but let's discuss how we want to prioritize this.

Nov 18 2022, 8:10 AM · MITK (v2024.06)

Nov 17 2022

kalali updated subscribers of T29396: [Segmentation] Newly created labelset image has wrong image type.

@floca The error seems to be inside AccessFixedTypeByItk_n, which produces a _accessByItkPixelTypeException (from inside Modules/Core/include/mitkImageAccessByItk.h

Nov 17 2022, 6:07 PM · MITK (v2024.06)
kalali added a comment to T29396: [Segmentation] Newly created labelset image has wrong image type.

I looked into this and can verify the behavior.
I debugged and the crash happens inside ``
I tested other 3D tools, e.g. "Threshold" or "UL Threshold" (and even Otsu) and the following error message is shown:

Pixel type vector is not in (int)( unsigned int)( short)( unsigned short)( char)( unsigned char)(double)( float)
Nov 17 2022, 6:01 PM · MITK (v2024.06)
kalali added a revision to T29394: [mxn multi widget] Image cropper shows weird behavior: Unknown Object (Differential Revision).
Nov 17 2022, 5:08 PM · MITK
kalali added a comment to T29394: [mxn multi widget] Image cropper shows weird behavior.

When initializing the plane nodes inside CrosshairManager DataNode::SetMapper is called which results in the node's m_Mapper variable to hold a PlaneGeometryDataMapper2D at position 1 (mapper slot id is Standard2D = 1).
But if DataNode::GetMapper is called later with MapperSlotId = 1 the list m_Mappers is completely empty and a new mapper is created via the BoundingShapeObjectFactory.

Nov 17 2022, 2:39 PM · MITK
kalali added a comment to T29394: [mxn multi widget] Image cropper shows weird behavior.

Somehow it seems as if the BoundingShapeObjectFactory is the last factory to be checked for extra factories to create valid mappers and this one is then used (it overwrites previously existing mappers). I wonder why this does not happen for the StdMultiWidget.

Nov 17 2022, 12:23 PM · MITK
kalali closed T29383: [mxn multi widget] Crosshair does not show a gap as Resolved.
Nov 17 2022, 9:55 AM · MITK
kalali committed rMITK11d249cdf16a: Show crosshair gap (authored by kalali).
Show crosshair gap
Nov 17 2022, 9:53 AM
kalali committed rMITKae1adc478989: Reuse the existing plane geometry data (authored by kalali).
Reuse the existing plane geometry data
Nov 17 2022, 9:53 AM
kalali claimed T29394: [mxn multi widget] Image cropper shows weird behavior.
Nov 17 2022, 9:37 AM · MITK
kalali added a comment to T29394: [mxn multi widget] Image cropper shows weird behavior.

It seems as if there is something wrong with mitk::CoreObjectFactory::CreateMapper but I have to go a little bit deeper. Maybe this is also related to {D755} because the crosshair planes do not get a specific mapper set.

Nov 17 2022, 9:37 AM · MITK

Nov 16 2022

kalali triaged T29394: [mxn multi widget] Image cropper shows weird behavior as Normal priority.
Nov 16 2022, 4:26 PM · MITK
kalali updated the task description for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window.
Nov 16 2022, 3:51 PM · MITK (v2024.06)
kalali edited parent tasks for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window, added: T29393: [mxn multi widget] Concept for individual render window synchronization; removed: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Nov 16 2022, 3:49 PM · MITK (v2024.06)
kalali added a subtask for T29393: [mxn multi widget] Concept for individual render window synchronization: T29240: [mxn multi widget] Allow different time navigation controller for each individual render window.
Nov 16 2022, 3:49 PM · MITK
kalali removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29240: [mxn multi widget] Allow different time navigation controller for each individual render window.
Nov 16 2022, 3:49 PM · MITK
kalali added a comment to T29393: [mxn multi widget] Concept for individual render window synchronization.

I added T24704: [Multi widget] Rules for updating the render windows as a somewhat related task.

Nov 16 2022, 3:47 PM · MITK
kalali removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T24704: [Multi widget] Rules for updating the render windows.
Nov 16 2022, 3:46 PM · MITK
kalali added a subtask for T29393: [mxn multi widget] Concept for individual render window synchronization: T24704: [Multi widget] Rules for updating the render windows.
Nov 16 2022, 3:46 PM · MITK
kalali edited parent tasks for T24704: [Multi widget] Rules for updating the render windows, added: T29393: [mxn multi widget] Concept for individual render window synchronization; removed: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Nov 16 2022, 3:46 PM · Request for Discussion, MITK