Page MenuHomePhabricator
Feed Advanced Search

Thu, Sep 7

s434n moved T29302: Movie maker plugin does not work correctly with the new mxn multi widget from Cycle to Backlog on the MITK (v2023.10) board.
Thu, Sep 7, 10:33 AM · MITK (v2023.10)
s434n removed a project from T29369: [Segmentation Utilities] Handle / select different labels independently: Request for Discussion.
Thu, Sep 7, 10:31 AM · MITK (v2023.10)
s434n added a comment to T29369: [Segmentation Utilities] Handle / select different labels independently.
  • Boolean Operations
    • chosen: high effort
    • Can be used so that the other functions can do everything
    • Work only on one image, select two labels
  • Contour to Image & Surface to Image
    • chosen: low effort seems more senseful. The functionality can be achieved via other tools (e.g. boolean)
  • Image Masking
    • chosen: low effort
  • Morphological Operations
    • as proposed
    • Pick an image & pick a label
    • Include options like in picking tool, i.e. generate a new layer when doing an operation, lock labels (to make sure other labels are not overwritten e.g. for a dilution)
  • Add a new tool: Transfer Label could be used to transfer a label from one image to another (if the same image is selected twice, it's just a rename)
Thu, Sep 7, 10:30 AM · MITK (v2023.10)
s434n removed a project from T30192: [MxN] UI elements not visible on Mac: Request for Discussion.
Thu, Sep 7, 9:57 AM · MITK (v2023.10)
s434n moved T30192: [MxN] UI elements not visible on Mac from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Sep 7, 9:14 AM · MITK (v2023.10)
s434n added a project to T30192: [MxN] UI elements not visible on Mac: Request for Discussion.
Thu, Sep 7, 9:14 AM · MITK (v2023.10)

Thu, Aug 31

s434n triaged T30192: [MxN] UI elements not visible on Mac as High priority.
Thu, Aug 31, 2:31 PM · MITK (v2023.10)

Aug 29 2023

s434n added a comment to T28491: [Segmentation] Slice interpolation 'confirm for all slices' sometimes crahes.

I tested this again with the current version of MITK (develop branch) and can see no problems. Interpolation works without problems on my laptop (Windows 10, 32GB RAM)

Aug 29 2023, 4:07 PM · MITK (v2023.10)

Aug 24 2023

s434n committed rMITK013da8c575c1: remove unused/outdated QmitkFFmpegWriter import (authored by s434n).
remove unused/outdated QmitkFFmpegWriter import
Aug 24 2023, 4:30 PM
s434n committed rMITK77eaee663ab1: Decouple TimeNavigation from SliceNavigationController (authored by s434n).
Decouple TimeNavigation from SliceNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKf9cb09180c85: Use concrete variable type and const (authored by kalali).
Use concrete variable type and const
Aug 24 2023, 4:30 PM
s434n committed rMITKc8c7a75725c3: Update the time nc before the slice nc (authored by kalali).
Update the time nc before the slice nc
Aug 24 2023, 4:30 PM
s434n committed rMITK40b57ea76624: adapt new SNC occurences introduced since merging and fix remaining bugs (authored by s434n).
adapt new SNC occurences introduced since merging and fix remaining bugs
Aug 24 2023, 4:30 PM
s434n committed rMITK0dab5fe5f1ac: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITK80bda9107823: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKf314ae99a2f5: Remove TimeNavigationController parameter / member (authored by kalali).
Remove TimeNavigationController parameter / member
Aug 24 2023, 4:30 PM
s434n committed rMITKfcd58f5173b5: Remove unnecessary controller / controller-connections (authored by kalali).
Remove unnecessary controller / controller-connections
Aug 24 2023, 4:30 PM
s434n committed rMITK5c3b7c799bf3: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKd58b817f6178: Replace SliceNavigationController with TimeNavigationController (authored by kalali).
Replace SliceNavigationController with TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKfe90eadd9150: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKcc1dda7884d6: Replace the SliceNavigationController inside the RenderingManager (authored by kalali).
Replace the SliceNavigationController inside the RenderingManager
Aug 24 2023, 4:30 PM
s434n committed rMITK0fd0318820f2: Modify BaseController to only hold a single stepper (authored by kalali).
Modify BaseController to only hold a single stepper
Aug 24 2023, 4:30 PM
s434n committed rMITK79829b658496: Modify the SliceNavigationController to remove time-related data (authored by kalali).
Modify the SliceNavigationController to remove time-related data
Aug 24 2023, 4:30 PM
s434n committed rMITKed8c3c8ee4a8: Remove unnecessary / unused functions / variable (authored by kalali).
Remove unnecessary / unused functions / variable
Aug 24 2023, 4:30 PM
s434n committed rMITK742c0a0f3e7e: Add TimeNavigationController (authored by kalali).
Add TimeNavigationController
Aug 24 2023, 4:29 PM

Aug 9 2023

s434n triaged T30184: [MxN] Turning on data synchronizing hides segmentation of non-visible nodes as Normal priority.
Aug 9 2023, 5:10 PM · MITK (v2023.10)
s434n removed a project from T30181: Add option for a "mean" line profile in statistics view: Request for Discussion.
Aug 9 2023, 12:14 PM · Restricted Project, MITK
s434n merged task T29630: Command-line app for voxelizing contour sets / RTSTRUCTs in MITK into T30177: Add command-line app for converting contours like RTSTRUCT to masks.
Aug 9 2023, 11:52 AM · Request for Discussion, MITK
s434n merged T29630: Command-line app for voxelizing contour sets / RTSTRUCTs in MITK into T30177: Add command-line app for converting contours like RTSTRUCT to masks.
Aug 9 2023, 11:52 AM · MITK
s434n removed a project from T29454: Clarify the versions/editions we publish as installer: Request for Discussion.

We want to have:

  • a slick minimum Workbench version
  • a fuller / bigger version. Exact contents and name still need to be compiled (e.g. Perfusion, Fitting, ...)
Aug 9 2023, 11:46 AM · MITK

Aug 1 2023

s434n closed T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds as Resolved.
Aug 1 2023, 12:31 PM · MITK (v2023.10), Checklist
s434n committed rMITK2b0ed86731c2: Fix livewire crashing out of bounds (authored by s434n).
Fix livewire crashing out of bounds
Aug 1 2023, 12:31 PM
s434n committed rMITKfab339f94c12: make livewire drawing conditional on being in the correct plane (authored by s434n).
make livewire drawing conditional on being in the correct plane
Aug 1 2023, 12:31 PM

Jul 26 2023

s434n committed rRTTB882fec8538c7: Fix the fix of namespaces for ITK v5.3.0 (authored by s434n).
Fix the fix of namespaces for ITK v5.3.0
Jul 26 2023, 4:34 PM
s434n closed T28548: Allow Zooming during creation of Segmentation. as Resolved.

With the addition of the polygon tool, this is now possible.

Jul 26 2023, 12:05 PM · MITK (v2023.10), Request for Discussion
s434n triaged T30166: [Logging] Introduce filtering by level as Low priority.
Jul 26 2023, 12:03 PM · MITK (v2023.10)
s434n moved T29369: [Segmentation Utilities] Handle / select different labels independently from Backlog to MITK Meeting on the Request for Discussion board.
Jul 26 2023, 10:32 AM · MITK (v2023.10)

Jul 25 2023

s434n claimed T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus.
Jul 25 2023, 9:14 AM · MITK (v2023.10)
s434n closed T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support as Resolved.
Jul 25 2023, 9:14 AM · MITK (v2023.10)
s434n committed rMITKe7a6ceb95e8d: Update interpolation documentation & fix some typos (authored by s434n).
Update interpolation documentation & fix some typos
Jul 25 2023, 9:14 AM
s434n committed rMITK059a81c9379b: remove outdated warning about multiple labels from interpolation docu & some… (authored by s434n).
remove outdated warning about multiple labels from interpolation docu & some…
Jul 25 2023, 9:14 AM

Jul 17 2023

s434n claimed T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds.
Jul 17 2023, 11:51 AM · MITK (v2023.10), Checklist

Jul 14 2023

s434n added a project to T29369: [Segmentation Utilities] Handle / select different labels independently: Request for Discussion.

I think the handling of multiple labels depends on each action and needs to be handled separately.

  • Boolean Operations: I see a few options here
    • low effort: only allow for segmentations with one label. If there is more than one label, show a message that this is not possible
    • higher effort: completely rework the selection. Let the user select two specific labels (from the same or different segmentations) and work on these, either replacing the first label or adding a new label (or instance) to that segmentation
  • Contour to Image & Surface to Image:
    • low effort: leave it as is, still works at the moment
    • higher effort: introduce the option to add the newly created segmentation as a new label / instance to an existing segmentation
  • Image Masking:
    • low effort: leave it as is, still works at the moment (using all labels of a segmentation)
    • higher effort: introduce the option to select which labels/instances should be considered for masking
  • Morphological Operations: Currently don't crash, but always use label 1
    • I think the most senseful solution would be to let the user select a specific label for the operation to work on. Multiple at the same time probably only get in each other's way and make it unnecessarily complicated.
Jul 14 2023, 4:44 PM · MITK (v2023.10)
s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2022.10), Breaking Change
s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2023.10), Request for Discussion
s434n added a revision to T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support: Unknown Object (Differential Revision).
Jul 14 2023, 3:25 PM · MITK (v2023.10)
s434n triaged T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support as Low priority.
Jul 14 2023, 2:40 PM · MITK (v2023.10)

Jul 12 2023

s434n committed rRTTB8907f1c6d32f: Fix namespaces for ITK v5.3.0 (authored by s434n).
Fix namespaces for ITK v5.3.0
Jul 12 2023, 3:03 PM

Jul 6 2023

s434n committed rRTTB9f4f5fd77d0e: Add gamma index to RTTB (authored by s434n).
Add gamma index to RTTB
Jul 6 2023, 11:27 AM

Jul 4 2023

s434n moved T27284: [Image Statistic] Histogram is only supported with one image and <=1 ROI from Backlog to Cycle on the MITK (v2023.10) board.
Jul 4 2023, 5:37 PM · MITK (v2023.10)
s434n moved T29302: Movie maker plugin does not work correctly with the new mxn multi widget from Backlog to Cycle on the MITK (v2023.10) board.
Jul 4 2023, 5:27 PM · MITK (v2023.10)
s434n moved T29579: [Documentation] Help page of Pointset Interaction has no table of contents from Backlog to Cycle on the MITK (v2023.10) board.
Jul 4 2023, 5:26 PM · MITK (v2023.10), Checklist
s434n moved T29580: [Measurement] Unclear how to end drawing with some tools from Backlog to Cycle on the MITK (v2023.10) board.
Jul 4 2023, 5:26 PM · MITK (v2023.10), Checklist
s434n moved T29641: [Movie Maker] Allow rotation around different axes from Backlog to Cycle on the MITK (v2023.10) board.
Jul 4 2023, 4:59 PM · MITK (v2023.10)

Jun 20 2023

s434n triaged T29641: [Movie Maker] Allow rotation around different axes as Normal priority.
Jun 20 2023, 10:46 AM · MITK (v2023.10)
s434n triaged T29639: [Registration] Mapping crashes when super-sampling is activated as Normal priority.
Jun 20 2023, 10:44 AM · MITK (v2023.10)

Jun 2 2023

s434n committed rRTTB2b478446abcb: align test result matrices for better overview (authored by s434n).
align test result matrices for better overview
Jun 2 2023, 10:57 AM

May 25 2023

s434n closed T26555: [mxn multi widget] Provide different default layouts, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
May 25 2023, 4:33 PM · MITK
s434n closed T26555: [mxn multi widget] Provide different default layouts as Resolved.

During our testing event there were no suggestions for new layouts people would like, so this task will be closed and any layouts that are requested in the future can be added on demand.

May 25 2023, 4:33 PM · MITK

May 24 2023

s434n added a comment to T29620: Check if GenericFitMiniApp supports the needed model.

What exactly was the model again? Just an exponential decay?

May 24 2023, 5:54 PM · Missing Info, MITK, Restricted Project, Restricted Project
s434n created T29616: [DICOM] Add option to save images as DICOM.
May 24 2023, 4:45 PM · MITK (v2023.10)
s434n added a comment to T29608: [Segmentation Utils] Workbench crashes for Morphological operations.

This is more of the stack trace:

MitkCore.dll!mitk::ImageDataItem::GetData() Zeile 131
MitkCore.dll!mitk::Image::Image(const mitk::Image & other) Zeile 83
MitkMultilabel.dll!mitk::LabelSetImage::LabelSetImage(const mitk::LabelSetImage & other) Zeile 75
MitkMultilabel.dll!mitk::LabelSetImage::InternalClone() Zeile 494
MitkMultilabel.dll!mitk::LabelSetImage::Clone() Zeile 33
MitkSegmentationUI.dll!ModifyLabelProcessing<3>(mitk::LabelSetImage * labelSetImage, itk::SmartPointer<mitk::SurfaceInterpolationController> surfaceInterpolator, unsigned int timePoint) Zeile 203
MitkSegmentationUI.dll!QmitkSlicesInterpolator::OnModifyLabelChanged(const itk::Object * caller, const itk::EventObject & __formal) Zeile 1915
May 24 2023, 10:35 AM · MITK

May 22 2023

s434n added a comment to T29608: [Segmentation Utils] Workbench crashes for Morphological operations.

Can reproduce. When debugging, the error is caused while trying to clone a LabelSetImage. While creating a new mitk::Image from a reference, it tries to get:

ImageDataItemPointer volume = other.GetVolumeData(0);
this->SetVolume(volume->GetData(), 0);

but volume is nullptr.
I'm not sure if this just needs a nullptr safeguard (and eventually an additional default initialization?) or if this should not be able to happen in the first place.

May 22 2023, 10:26 AM · MITK

May 12 2023

s434n committed rMITKd9f6ca2f596d: Automatically set .json file ending for MxN layout files (authored by s434n).
Automatically set .json file ending for MxN layout files
May 12 2023, 11:08 AM
s434n committed rMITKd544cde8c955: automatically set MxN layout file ending when missing (authored by s434n).
automatically set MxN layout file ending when missing
May 12 2023, 11:08 AM

May 11 2023

s434n closed T29492: [mxn multi widget] Update and extend checklist as Resolved.
May 11 2023, 3:17 PM · MITK (v2023.04)
s434n added a revision to T29585: [MxN] Loading layout needs .json file ending: Unknown Object (Differential Revision).
May 11 2023, 11:03 AM · Checklist, MITK (v2023.04)

May 9 2023

s434n triaged T29585: [MxN] Loading layout needs .json file ending as Normal priority.
May 9 2023, 4:27 PM · Checklist, MITK (v2023.04)
s434n moved T29585: [MxN] Loading layout needs .json file ending from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 4:27 PM · Checklist, MITK (v2023.04)
s434n claimed T29585: [MxN] Loading layout needs .json file ending.
May 9 2023, 3:46 PM · Checklist, MITK (v2023.04)
s434n closed T29587: [MxN] Resetting render window to specific image always fills visible area with highest image in Data Manager as Invalid.

This is behavior as intended. The "reset" is basically a reinit to the specified image. When there is an image higher in the list, it is rendered on top, just as in the standard display and the data manager.
I have added a hint in the checklist to make it clear this is how it is supposed to work.

May 9 2023, 3:46 PM · Checklist, MITK (v2023.04)

May 8 2023

s434n triaged T29584: [Interpolation] Confirming 3D interpolation does not set mode to "disabled" as Low priority.
May 8 2023, 2:27 PM · MITK (v2023.10), Checklist
s434n triaged T29583: [Interpolation] Interpolation is not triggered correctly as Low priority.
May 8 2023, 1:48 PM · MITK (v2023.10), Checklist
s434n triaged T29582: [Segmentation] Error when pressing "Undo" after undoing all fill changes as Normal priority.
May 8 2023, 1:22 PM · MITK (v2023.10), Checklist
s434n triaged T29581: [Segmentation] Switch tool icon next to cursor when inverting via Ctrl as Wishlist priority.
May 8 2023, 12:47 PM · MITK (v2023.10), Checklist
s434n triaged T29580: [Measurement] Unclear how to end drawing with some tools as Wishlist priority.
May 8 2023, 12:13 PM · MITK (v2023.10), Checklist
s434n triaged T29579: [Documentation] Help page of Pointset Interaction has no table of contents as Low priority.
May 8 2023, 11:43 AM · MITK (v2023.10), Checklist
s434n triaged T29578: [Segmentation] Removing last selected region in picking tool does not update preview as Low priority.
May 8 2023, 11:31 AM · MITK (v2023.10), Checklist
s434n triaged T29577: [Segmentation] Otsu tool does not create and transfer label names correctly in added groups as Normal priority.
May 8 2023, 11:24 AM · Checklist, MITK (v2023.04)
s434n triaged T29575: [Segmentation] Threshold tool crashes when new label is created during preview as High priority.
May 8 2023, 9:58 AM · Request for Discussion, Checklist, MITK (v2023.04)
s434n closed T29568: [MxN] Add MxN MultiWidget to workbench release configuration as Resolved.
May 8 2023, 9:35 AM · MITK (v2023.04)
s434n committed rMITK161d55102438: add MxN to Default build configuration (authored by s434n).
add MxN to Default build configuration
May 8 2023, 9:28 AM
s434n committed rMITK0e2d28a3f276: Add MxN to Default build configuration (authored by s434n).
Add MxN to Default build configuration
May 8 2023, 9:28 AM

May 5 2023

s434n added a revision to T29568: [MxN] Add MxN MultiWidget to workbench release configuration: Unknown Object (Differential Revision).
May 5 2023, 3:49 PM · MITK (v2023.04)
s434n triaged T29570: [Preferences] Render window decoration color not immediately updated in Image Navigator as Low priority.
May 5 2023, 2:58 PM · MITK (v2023.10), Checklist
s434n triaged T29568: [MxN] Add MxN MultiWidget to workbench release configuration as Unbreak Now! priority.
May 5 2023, 11:43 AM · MITK (v2023.04)

May 4 2023

s434n added a subtask for T29309: [GrowCut] Further remarks regarding GrowCut: T29562: [GrowCut] "Undo" only changes slices with seed images.
May 4 2023, 1:46 PM · MITK
s434n added a parent task for T29562: [GrowCut] "Undo" only changes slices with seed images: T29309: [GrowCut] Further remarks regarding GrowCut.
May 4 2023, 1:46 PM · Request for Discussion, MITK
s434n triaged T29562: [GrowCut] "Undo" only changes slices with seed images as Normal priority.
May 4 2023, 1:46 PM · Request for Discussion, MITK

May 3 2023

s434n closed T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash as Resolved.
May 3 2023, 6:02 PM · MITK (v2023.04)
s434n committed rMITKd951ff141fda: Correctly handle segmentation observers in interpolation (authored by s434n).
Correctly handle segmentation observers in interpolation
May 3 2023, 5:57 PM
s434n committed rMITK51d604bd8dfc: remove observers when working data is changed or deleted (authored by s434n).
remove observers when working data is changed or deleted
May 3 2023, 5:57 PM
s434n added a revision to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash: Unknown Object (Differential Revision).
May 3 2023, 5:40 PM · MITK (v2023.04)
s434n committed rMITK0a303fed6cd3: Fix segmentation serialization by changing serializer name back (authored by s434n).
Fix segmentation serialization by changing serializer name back
May 3 2023, 5:34 PM
s434n committed rMITK074e26fd7843: rename MultiLabelSegmentationSerializer back to LabelSetImageSerializer (authored by s434n).
rename MultiLabelSegmentationSerializer back to LabelSetImageSerializer
May 3 2023, 5:34 PM
s434n added a revision to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash: Unknown Object (Differential Revision).
May 3 2023, 5:26 PM · MITK (v2023.04)
s434n closed T29554: [Segmentation] Creating a new group while interpolating causes crash as Resolved.
May 3 2023, 3:01 PM · MITK (v2023.04)
s434n added a revision to T29554: [Segmentation] Creating a new group while interpolating causes crash: Unknown Object (Differential Revision).
May 3 2023, 3:01 PM · MITK (v2023.04)
s434n committed rMITK9b949db68c3b: Fix crashes when adding group while interpolating (authored by s434n).
Fix crashes when adding group while interpolating
May 3 2023, 3:00 PM
s434n committed rMITK107fe1951b25: remove unnecessary nullptr initialization (authored by s434n).
remove unnecessary nullptr initialization
May 3 2023, 3:00 PM