Page MenuHomePhabricator
Feed Advanced Search

Sep 7 2023

fedorov added a comment to T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number.

offer the feature to take an instance UID that is an int as the pixel value.

Sep 7 2023, 5:19 PM · MITK (v2024.06), Missing Info, Request for Discussion

Jul 11 2023

fedorov added a comment to T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number.

Sounds good Ralf - happy to help!

Jul 11 2023, 8:18 PM · MITK (v2024.06), Missing Info, Request for Discussion
fedorov added a comment to T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number.

" increase monotonically by 1" could be interpreted as "no holes allowed". We should clarify if this is the case.

Jul 11 2023, 5:37 PM · MITK (v2024.06), Missing Info, Request for Discussion

Apr 11 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

@floca I think the issue is that it will probably be better to separately communicate server endpoint and refer to the Study/Series items in the DICOM model hierarchy via UIDs. I think adding support for DICOM should be done as part of the initial design, rather than and afterthought and replacement of file paths by URIs. But that only makes sense if DICOM is important and primary for the use case driving the development. That is why I suggest you guys proceed with your original plan, and we will try to experiment with the DICOM-centric design. But of course I may be wrong. I just think it is more expedient to experiment rather than coordinate the design at the same time as the use cases and requirements are evolving.

Apr 11 2023, 4:58 PM · MITK (v2022.10)

Apr 10 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

@kislinsk @floca thank you for the feedback!

Apr 10 2023, 11:53 PM · MITK (v2022.10)

Apr 3 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Thanks. Here are some more comments to start the discussion:

  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?
  • In addition to segmentations, it would be helpful to include an option to perform the review of existing segmentations (e.g., those generated by AI that need to be QA'd by an expert, and where some kind of segmentation may or may not be generated as part of the QA process)
  • I think there is potentially common needs between this task and the "MetaDashboard" initiative in kaapana (see https://projectweek.na-mic.org/PW38_2023_GranCanaria/Projects/MetaDashboard/) - should these two efforts be coordinated? In that regard, the definition of the worklist does not need to be limited to support of the segmentation task (e.g., there are other tasks already considered in the context of the MetaDashboard, such as series type classification, presence of the artifacts.
Apr 3 2023, 6:23 PM · MITK (v2022.10)

Mar 30 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Did you consider using JSON Schema to formalize the definition? It is a bit hard to grasp it right now, but admittedly I probably didn't spend enough time looking over the various resources provided.

Mar 30 2023, 4:29 AM · MITK (v2022.10)

Jan 27 2022

fedorov added a comment to T28946: MITK Flow - Save Segmentation - Error/Exception Handling.

Since in the input image a required tag is missing, MITK cannot provide a fix, allowing a success in dcmqi

Jan 27 2022, 5:46 PM · Kaapana (internal), MITK

Feb 3 2021

fedorov added a comment to T28127: Reopen segmentation in MITK.

Here's the PR with CI testing results https://github.com/QIICR/dcmqi/pull/415. You can look at the CI results for earlier commits, if you would like to investigate.

Feb 3 2021, 12:15 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Jan 19 2021

fedorov added a comment to T28127: Reopen segmentation in MITK.

@floca thanks for the report! I added a comment to the dcmqi issue you created.

Jan 19 2021, 4:27 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Feb 18 2019

fedorov added a comment to T26033: Update ModelFit manual.

Also note that the link to the manual from the ModelFit page (which I am assuming is http://mitk.org/wiki/MITK-ModelFit) is currently broken: http://mitk.org/index.php?title=MITK_ModelFit_Manual_2018-07-17.pdf&action=edit&redlink=1

Feb 18 2019, 10:32 PM · Restricted Project, MITK

Jan 9 2019

fedorov created T25834: macOS compile error: moving a local object in a return statement prevents copy elision.
Jan 9 2019, 9:56 PM · MITK