Page MenuHomePhabricator
Feed All Stories

Jun 5 2019

jungsi committed rMITK2ed269fa24c3: Add return value to CreateAnnotationsFromConfiguration (authored by jungsi).
Add return value to CreateAnnotationsFromConfiguration
Jun 5 2019, 1:59 PM
jungsi committed rMITK2df27eec4d22: Major refactoring distributing the set of responsibilities of AnnotationFactory… (authored by jungsi).
Major refactoring distributing the set of responsibilities of AnnotationFactory…
Jun 5 2019, 1:59 PM
jungsi committed rMITK9015833b7f9f: Refactored annotation plugin and extended tests (authored by jungsi).
Refactored annotation plugin and extended tests
Jun 5 2019, 1:59 PM
jungsi committed rMITKb2e293fc9d47: Refactoring and renaming. Cleanup of includes and include guards (authored by jungsi).
Refactoring and renaming. Cleanup of includes and include guards
Jun 5 2019, 1:58 PM
jungsi committed rMITK03a5b94fcf1e: Added function to save the actual configuration to json (authored by jungsi).
Added function to save the actual configuration to json
Jun 5 2019, 1:58 PM
jungsi committed rMITKa6a6a73c064f: Refactored the annotation factory, fixed SliceChanged method not being called. (authored by jungsi).
Refactored the annotation factory, fixed SliceChanged method not being called.
Jun 5 2019, 1:58 PM
jungsi committed rMITKb9f1ea760079: Added logo annotation (as of now with absolute path only) (authored by jungsi).
Added logo annotation (as of now with absolute path only)
Jun 5 2019, 1:58 PM
jungsi committed rMITK046cad94c611: Ideas regarding custom interdependent DataSources (authored by jungsi).
Ideas regarding custom interdependent DataSources
Jun 5 2019, 1:58 PM
jungsi committed rMITK7f21a1867077: Added first simple tests (authored by jungsi).
Added first simple tests
Jun 5 2019, 1:58 PM
jungsi committed rMITK03e00a9a026f: First draft of the annotations plugin responsible for creating the standard… (authored by jungsi).
First draft of the annotations plugin responsible for creating the standard…
Jun 5 2019, 1:58 PM
jungsi committed rMITK89d71e094673: First draft of the Annotation Module extension for dynamic data (authored by jungsi).
First draft of the Annotation Module extension for dynamic data
Jun 5 2019, 1:58 PM
rosst added a member for IMSY: scholzpa.
Jun 5 2019, 1:40 PM

Jun 4 2019

kalali committed rMITKc6069d1f64ca: Merge branch 'T26376-Remove-specific-render-windows-from-segmentation-plugin'… (authored by kalali).
Merge branch 'T26376-Remove-specific-render-windows-from-segmentation-plugin'…
Jun 4 2019, 6:33 PM
kalali committed rMITK4f47d770e31f: Check if currently active render window part has a 3d render window (authored by kalali).
Check if currently active render window part has a 3d render window
Jun 4 2019, 6:32 PM
kalali committed rMITKddec6738bbb0: Remove specific render windows (authored by kalali).
Remove specific render windows
Jun 4 2019, 6:32 PM
kalali committed rMITK1959adec442a: Merge branch 'T26376-Set-active-render-window' into T25767-BlackSwan-release (authored by kalali).
Merge branch 'T26376-Set-active-render-window' into T25767-BlackSwan-release
Jun 4 2019, 6:32 PM
kalali committed rMITK76ecef0ef166: Control all render windows of the active render window part (authored by kalali).
Control all render windows of the active render window part
Jun 4 2019, 6:32 PM
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

Pushed new branch T26376-Remove-specific-render-windows-from-segmentation-plugin.

Jun 4 2019, 6:32 PM · MITK (v2022.10)
kalali committed rMITKd86d88367d31: Allow setting the currently active render window of a render window part (authored by kalali).
Allow setting the currently active render window of a render window part
Jun 4 2019, 6:31 PM
kalali committed rMITK9d24a346df04: Install regiongrowing plugin (authored by kalali).
Install regiongrowing plugin
Jun 4 2019, 6:31 PM
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

Pushed new branch T26376-Set-active-render-window.

Jun 4 2019, 6:30 PM · MITK (v2022.10)
kalali triaged T26381: QmitkDataStorageComboBox does not react on DICOM node changes as Normal priority.
Jun 4 2019, 6:04 PM · Restricted Project, MITK
steint committed rMITK606e20fde09c: Add comments for low random part lengh, and use a higher lower bound for tests (authored by steint).
Add comments for low random part lengh, and use a higher lower bound for tests
Jun 4 2019, 11:53 AM
steint committed rMITKccca78f88769: Remove c code for time. Make seed and generator unique for the application (authored by steint).
Remove c code for time. Make seed and generator unique for the application
Jun 4 2019, 11:42 AM
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

The plugin always shows the message "Please perform a reinit on the segmentation image!", when the active render window is not an axial or 3D render window, though. In that case, both world geometries (working node and current geometry of active render window) are not equal.

Jun 4 2019, 11:35 AM · MITK (v2022.10)
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

Reinit did not work correctly, as the RenderingManagerViewsInitializedEvent was not send for a single view initialization.
In case of a specified base render (using the RenderWindowManager context menu), reinit will only initialize the specified render window. This will now also send the mentioned event so that the segmentation plugin can react to this event as it would if all render windows would have been initialized.

Jun 4 2019, 11:34 AM · MITK (v2022.10)
kalali claimed T26376: Segmentation plugin does not work correctly with the new mxn multi widget.
Jun 4 2019, 11:32 AM · MITK (v2022.10)
steint committed rMITK92daebea0b2b: Replace itk with std functions for RNG (authored by steint).
Replace itk with std functions for RNG
Jun 4 2019, 9:51 AM
kislinsk added a comment to T25535: DCMTK won't build if Anaconda is installed.

I think it is not the best idea to get rid of ICU as it has its purpose regarding Unicode handling. If building or finding ICU interferes with an installation of Anaconda, there are probably other ways of telling DCMTK through CMake to behave as expected.

Jun 4 2019, 9:23 AM · Auto-closed, MITK
steint committed rMITK0cc6e30d5b06: Merge branch 'personal/steint/jens-student' of https://phabricator.mitk. (authored by steint).
Merge branch 'personal/steint/jens-student' of https://phabricator.mitk.
Jun 4 2019, 8:51 AM
steint committed rMITK05b4bd223206: Add planar figure to binary segmentation conversion option triggered by simple… (authored by steint).
Add planar figure to binary segmentation conversion option triggered by simple…
Jun 4 2019, 8:51 AM
steint committed rMITK3eb82494b674: add fixed radius for planar figure circle (authored by steint).
add fixed radius for planar figure circle
Jun 4 2019, 8:51 AM

Jun 3 2019

kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

An active render window will now be set by using the RenderWindowManager.

Jun 3 2019, 6:38 PM · MITK (v2022.10)
kalali lowered the priority of T26376: Segmentation plugin does not work correctly with the new mxn multi widget from High to Normal.

This was fixed for T25767. Need to look closer and test if everything works as expected.
The idea is not to ask for specific render windows but to retrieve all available render windows of a multi widget and use them.

Jun 3 2019, 5:06 PM · MITK (v2022.10)
kalali committed rMITKb0c92cb212b6: Add crosshair moving to change plane orientation (authored by kalali).
Add crosshair moving to change plane orientation
Jun 3 2019, 3:26 PM
steint committed rMITKb398232034fb: Add loop of mesh data which is updated in the renderwindow and also sent from… (authored by steint).
Add loop of mesh data which is updated in the renderwindow and also sent from…
Jun 3 2019, 2:51 PM
kausch closed T19683: "Show only selected node" changes the visibility of crosshair as Resolved.
Jun 3 2019, 2:06 PM · Bugzilla, Pull Request, MITK
kausch committed rMITK99c7cb94f0c2: deleted duplicated file for show selected node (authored by kausch).
deleted duplicated file for show selected node
Jun 3 2019, 2:02 PM
kalali triaged T26376: Segmentation plugin does not work correctly with the new mxn multi widget as High priority.
Jun 3 2019, 1:55 PM · MITK (v2022.10)
kausch committed rMITKb61aa5dd99fd: updated show only selected nodes (authored by kausch).
updated show only selected nodes
Jun 3 2019, 1:55 PM
kalali committed rMITK97f4bc5189b6: Check for invalid last segmentation (authored by kalali).
Check for invalid last segmentation
Jun 3 2019, 12:15 PM
steint committed rMITKcf7621227b0e: Change uid generator to avoid expensive string operations and overflow while… (authored by steint).
Change uid generator to avoid expensive string operations and overflow while…
Jun 3 2019, 11:56 AM
kausch added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Through merge conflicts.. The baserenderer argument was added in the master.

Jun 3 2019, 11:20 AM · Bugzilla, Pull Request, MITK
kausch added a comment to T19683: "Show only selected node" changes the visibility of crosshair.
Jun 3 2019, 11:18 AM · Bugzilla, Pull Request, MITK
kalali updated subscribers of T25535: DCMTK won't build if Anaconda is installed.

I can't think of any reason. I just stumbled upon this and suggested the fix. Since I have no experience with Anaconda or DCMTK I wasn't sure if this is the correct way to fix it or if there are any side effects. Maybe a review would have been a good idea. Maybe @nolden can help?

Jun 3 2019, 11:12 AM · Auto-closed, MITK
kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

QmitkDataNodeShowSelectedNodesAction.cpp and QmitkDataNodeShowSelectedNodesAction2.cpp in Plugins/org.mitk.gui.qt.application/src/

Jun 3 2019, 11:04 AM · Bugzilla, Pull Request, MITK
kausch added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Which 2 actions?

Jun 3 2019, 11:02 AM · Bugzilla, Pull Request, MITK
groehl added a member for Photoacoustics: schellem.
Jun 3 2019, 10:43 AM
groehl added a member for IMSY: schellem.
Jun 3 2019, 10:43 AM
franza committed rMITK4c3fb0a8553b: implemented tool axis RSME computation (authored by franza).
implemented tool axis RSME computation
Jun 3 2019, 10:25 AM
franza committed rMITK6a832254fdab: Added new method to compute tool axis RMSE (not fully implemented yet) (authored by franza).
Added new method to compute tool axis RMSE (not fully implemented yet)
Jun 3 2019, 10:25 AM
franza added a comment to T26372: Evaluation view for needle calibration test.

Pushed new branch T26372-AddAxisRSME.

Jun 3 2019, 10:25 AM · Auto-closed, IGT, MITK
kislinsk closed T10304: NavigationDataPlayer should support tool storages, a subtask of T19743: IGT documentation Step 5 - Tracking Lab, as Wontfix.
Jun 3 2019, 9:41 AM · Bugzilla, MITK
kislinsk closed T10304: NavigationDataPlayer should support tool storages, a subtask of T19747: IGT documentation Navigation data player, as Wontfix.
Jun 3 2019, 9:41 AM · Bugzilla, MITK
kislinsk closed T10304: NavigationDataPlayer should support tool storages as Wontfix.

Thank you for the feedback! 👍

Jun 3 2019, 9:41 AM · Bugzilla, MITK
kislinsk placed T24555: HDF5 library: superbuild fails in Install phase of RelWithDebInfo up for grabs.

HDF5 1.10.5 does not work at least with ITK 4.13, so upgrading HDF5 would probably result in an upgrade cascade that is not appropriate for a minor release. Hence I removed the 2018-04-4 milestone tag.

Jun 3 2019, 9:39 AM · Auto-closed, MITK
kausch closed T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work as Resolved.

@floca This is the branch T26029-4DImageAnd4DSegmentation

Jun 3 2019, 9:18 AM · Restricted Project, MITK
franza triaged T26372: Evaluation view for needle calibration test as Wishlist priority.
Jun 3 2019, 9:04 AM · Auto-closed, IGT, MITK

May 31 2019

franza triaged T26371: MITK crash when starting tracking during editing tool information as Normal priority.
May 31 2019, 11:20 AM · Auto-closed, IGT, MITK

May 30 2019

franza placed T10304: NavigationDataPlayer should support tool storages up for grabs.
May 30 2019, 1:11 PM · Bugzilla, MITK
franza added a comment to T10304: NavigationDataPlayer should support tool storages.

I had a look on it. The idea that time was to change the navigation data player in a way that in can be handled as any other tracking device. @rosst and @wildes invested a lot of work, but unfortunately we found out that there are some problems when doing this and it never fully worked. As far as I can remember we decided to keep the navigation data player as a separate view in the end. Anyway, thanks to @rosst and @wildes for their efforts. It would have been a nice feature, but is not that important in the end. I would agree to close the bug and not merge the changes.

May 30 2019, 1:10 PM · Bugzilla, MITK
franza committed rMITK8268297509dd: Renamed build configuration for navigation modules (authored by franza).
Renamed build configuration for navigation modules
May 30 2019, 12:55 PM
franza added a comment to T26370: Buildconfigration mitkNavigationModules is not working.

Pushed new branch T26370-BuildConfigurationNavigationModulesNotWorking.

May 30 2019, 12:54 PM · IGT, MITK
franza claimed T26370: Buildconfigration mitkNavigationModules is not working.
May 30 2019, 12:54 PM · IGT, MITK
franza committed rMITK2cdb47fb34aa: forced ICU Conversion to be disabled, because it leads to linker errors when… (authored by franza).
forced ICU Conversion to be disabled, because it leads to linker errors when…
May 30 2019, 12:46 PM
franza added a comment to T25535: DCMTK won't build if Anaconda is installed.

Pushed new branch T25535-FixLinkerErrorWhenAnacondaIsInstalled.

May 30 2019, 12:45 PM · Auto-closed, MITK
franza claimed T25535: DCMTK won't build if Anaconda is installed.
May 30 2019, 12:40 PM · Auto-closed, MITK
franza raised the priority of T25535: DCMTK won't build if Anaconda is installed from Normal to Unbreak Now!.
May 30 2019, 12:38 PM · Auto-closed, MITK
franza added a comment to T25535: DCMTK won't build if Anaconda is installed.

Thanks a lot, solution works for me. Is there any reason to not add the fix to the master?

May 30 2019, 12:37 PM · Auto-closed, MITK
franza added a comment to T26370: Buildconfigration mitkNavigationModules is not working.

Seems as if the name is the problem. When renaming the file to "NavigationModules.cmake" it works again.

May 30 2019, 12:24 PM · IGT, MITK
franza moved T26370: Buildconfigration mitkNavigationModules is not working from Backlog to In Progress on the IGT board.
May 30 2019, 12:23 PM · IGT, MITK

May 29 2019

floca added a comment to T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work.

I merged it, we only pushed the branch

May 29 2019, 9:31 PM · Restricted Project, MITK
franza added a comment to T26370: Buildconfigration mitkNavigationModules is not working.

... also not working with cmake 3.13.1

May 29 2019, 8:18 PM · IGT, MITK
franza created T26370: Buildconfigration mitkNavigationModules is not working.
May 29 2019, 7:19 PM · IGT, MITK
franza added a comment to T10304: NavigationDataPlayer should support tool storages.

Seems as if implementation was never finished.

May 29 2019, 6:50 PM · Bugzilla, MITK
kausch added a comment to T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work.

I merged it, we only pushed the branch

May 29 2019, 5:33 PM · Restricted Project, MITK
kausch committed rMITK15d0439f6092: 4D image statistics are calculated for those timesteps were mask is provided (authored by kausch).
4D image statistics are calculated for those timesteps were mask is provided
May 29 2019, 5:30 PM
kalali committed rMITK77f93ce4db27: Check for invalid last segmentation (authored by kalali).
Check for invalid last segmentation
May 29 2019, 4:42 PM
kalali committed rMITK023be0d87f70: Merge branch 'T22946-Integration-beta' into T25767-BlackSwan-release (authored by kalali).
Merge branch 'T22946-Integration-beta' into T25767-BlackSwan-release
May 29 2019, 4:42 PM
kalali committed rMITK341c72e4a585: Merge remote-tracking branch 'origin/T25772-integrate-bone-seg-in-mitk' into… (authored by kalali).
Merge remote-tracking branch 'origin/T25772-integrate-bone-seg-in-mitk' into…
May 29 2019, 4:42 PM
kalali committed rMITK9d7fa17b2e3f: Clean and refactor bone segmentation classes (authored by kalali).
Clean and refactor bone segmentation classes
May 29 2019, 4:42 PM
kalali committed rMITK79d4ceb65399: Add combo box for data node selection and clean classes (authored by kalali).
Add combo box for data node selection and clean classes
May 29 2019, 4:42 PM
kalali committed rMITK7cd31261b50c: Use the semantic relations inside the region growing plugin (authored by kalali).
Use the semantic relations inside the region growing plugin
May 29 2019, 4:42 PM
kalali committed rMITK71fe61c6aeb0: Move add-action and make it available inside the region growing plugin (authored by kalali).
Move add-action and make it available inside the region growing plugin
May 29 2019, 4:42 PM
kalali committed rMITKf96607d3fd05: Clean and refactor region growing classes (authored by kalali).
Clean and refactor region growing classes
May 29 2019, 4:42 PM
kalali committed rMITK4dabae6bd007: Merge remote-tracking branch 'origin/T22346-point-set-tool-and-region-growing'… (authored by kalali).
Merge remote-tracking branch 'origin/T22346-point-set-tool-and-region-growing'…
May 29 2019, 4:42 PM
kislinsk claimed T24555: HDF5 library: superbuild fails in Install phase of RelWithDebInfo.
May 29 2019, 2:20 PM · Auto-closed, MITK
kislinsk closed T19989: MITK Youtube channel, a subtask of T19985: MITK Videos, as Wontfix.
May 29 2019, 1:04 PM · Restricted Project, MITK
kislinsk closed T19989: MITK Youtube channel as Wontfix.

Closing these tasks because of inactivity and completely changed way of building MITK.

May 29 2019, 1:04 PM · Restricted Project, MITK
kislinsk closed T19988: Cut Tutorial Videos, a subtask of T19985: MITK Videos, as Wontfix.
May 29 2019, 1:04 PM · Restricted Project, MITK
kislinsk closed T19988: Cut Tutorial Videos as Wontfix.

Closing these tasks because of inactivity and completely changed way of building MITK.

May 29 2019, 1:04 PM · Restricted Project, MITK
kislinsk closed T19985: MITK Videos as Wontfix.

Closing these tasks because of inactivity and completely changed way of building MITK.

May 29 2019, 1:04 PM · Restricted Project, MITK
kislinsk added a comment to T10304: NavigationDataPlayer should support tool storages.

Was never merged into master, what shall we do, @franza ?

May 29 2019, 1:02 PM · Bugzilla, MITK
kislinsk closed T18520: Geometry CleanUp Reloaded as Resolved.

Close as resolved because of last activity was three years ago.

May 29 2019, 1:00 PM · Bugzilla, MITK
kislinsk closed T26187: Create polygon model works only once as Invalid.
May 29 2019, 12:47 PM
kislinsk moved T10304: NavigationDataPlayer should support tool storages from Bugsquashing - In Progress to Backlog on the MITK board.
May 29 2019, 12:46 PM · Bugzilla, MITK
kislinsk moved T18520: Geometry CleanUp Reloaded from Bugsquashing - In Progress to Backlog on the MITK board.
May 29 2019, 12:46 PM · Bugzilla, MITK
kislinsk moved T19985: MITK Videos from Bugsquashing - In Progress to Backlog on the MITK board.
May 29 2019, 12:46 PM · Restricted Project, MITK
kislinsk closed T26356: Colored render window frames misaligned as Resolved.

Capture.JPG (106×135 px, 9 KB)

May 29 2019, 12:34 PM · MITK
kislinsk committed rMITK6d9dbcf2721f: Merge branch 'T26356-MisalignedRenderWindowFrames' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26356-MisalignedRenderWindowFrames' into releases/2018-04
May 29 2019, 12:31 PM