Page MenuHomePhabricator
Feed All Stories

Jul 27 2020

kislinsk committed rMITK51b7a790230a: Migrate .arcconfig to mid 2020 changes of "arc land" (authored by kislinsk).
Migrate .arcconfig to mid 2020 changes of "arc land"
Jul 27 2020, 5:35 PM
kislinsk closed T27611: Migrate .arcconfig as Resolved by committing rMITK51b7a790230a: Migrate .arcconfig to mid 2020 changes of "arc land".
Jul 27 2020, 5:35 PM · MITK
thomass claimed T27103: [MITKDoc] Revise Point Set Interaction Plugin Documentation.
Jul 27 2020, 5:29 PM · Cleared, MITK (v2021.02)
nolden triaged T27612: Fix build errors with clang 10.x as High priority.
Jul 27 2020, 4:27 PM · Breaking Change, MITK (v2021.02)
kislinsk added a revision to T27611: Migrate .arcconfig: Unknown Object (Differential Revision).
Jul 27 2020, 4:22 PM · MITK
kislinsk triaged T27611: Migrate .arcconfig as Unbreak Now! priority.
Jul 27 2020, 4:19 PM · MITK
thomass committed rMITK1511e63fc5ba: Rename documentation manual page names with leading the (authored by thomass).
Rename documentation manual page names with leading the
Jul 27 2020, 3:48 PM
thomass closed T27610: [MITKDoc] Rename Plugin and Module names with leading "The" article as Resolved by committing rMITK1511e63fc5ba: Rename documentation manual page names with leading the.
Jul 27 2020, 3:48 PM · MITK (v2021.02)
thomass committed rMITKdb8bf5c52f67: Rename documentation manual page names with leading the (authored by thomass).
Rename documentation manual page names with leading the
Jul 27 2020, 3:48 PM
kislinsk merged task T27609: Segmentation image not selectable for segmentation into Restricted Maniphest Task.
Jul 27 2020, 3:36 PM · MITK
thomass added a revision to T27610: [MITKDoc] Rename Plugin and Module names with leading "The" article: Unknown Object (Differential Revision).
Jul 27 2020, 3:29 PM · MITK (v2021.02)
thomass created T27610: [MITKDoc] Rename Plugin and Module names with leading "The" article.
Jul 27 2020, 2:40 PM · MITK (v2021.02)
schwadav added a member for IMSY: a294n.
Jul 27 2020, 2:39 PM
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

Deleted branch bugfix/T27607-chartExample-UserManual.

Jul 27 2020, 1:20 PM · MITK (v2021.02)
kislinsk renamed T27607: [Documentation] Remove dummy chartExample documentation from [Documentation] Fix chartExample user manual to [Documentation] Remove dummy chartExample documentation.
Jul 27 2020, 1:20 PM · MITK (v2021.02)
kislinsk closed T27607: [Documentation] Remove dummy chartExample documentation as Resolved.

I surrendered and deleted the chartExample documentation as it simply was a copy of the dummy documentation anyway (in other words: no documentation). The Ubuntu and macOS dartclients now complain because of the geometrytools plugin. Hence, the Windows dartclient probably reports a complete list as it continues to generate the documentation.

Jul 27 2020, 1:19 PM · MITK (v2021.02)
neher triaged T27609: Segmentation image not selectable for segmentation as Normal priority.
Jul 27 2020, 1:15 PM · MITK
neher closed T27603: Fit fiber compression to image spacing as Resolved.
Jul 27 2020, 1:10 PM · MITK Diffusion
kislinsk committed rMITKcb4b1a8e3f65: Merge branch 'bugfix/T27607-chartExample-UserManual' into develop (authored by kislinsk).
Merge branch 'bugfix/T27607-chartExample-UserManual' into develop
Jul 27 2020, 1:03 PM
kompan added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

Pushed new branch bugfix/T27608-DocumentationRefurbish-DeveloperManual.

Jul 27 2020, 12:58 PM · MITK (v2024.06), Cleared
kislinsk committed rMITK0e7a0a80bd97: Merge branch 'bugfix/T27607-chartExample-UserManual' into develop (authored by kislinsk).
Merge branch 'bugfix/T27607-chartExample-UserManual' into develop
Jul 27 2020, 12:49 PM
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

Pushed new branch bugfix/T27607-chartExample-UserManual.

Jul 27 2020, 12:49 PM · MITK (v2021.02)
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

Deleted branch bugfix/T27607-chartExample-UserManual.

Jul 27 2020, 12:48 PM · MITK (v2021.02)
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

Okay, two red herrings here:

Jul 27 2020, 12:41 PM · MITK (v2021.02)
kislinsk added a comment to T27563: Help link (pressing F1) is partially broken.

These are views that have non-standard view IDs (not beginning with "org.mitk.views"):

  • QmitkCESTNormalizeView.cpp
  • CommandLineModulesViewConstants.cpp
  • QmitkDicomInspectorView.cpp
  • FitGeneratorDemoView.cpp
  • GenericDataFittingView.cpp
  • ModelFitInspectorView.cpp
  • PerfusionCurveDescriptionParameterView.cpp
  • ConcentrationCurveConverterView.cpp
  • MRPerfusionView.cpp
  • PETDynamicView.cpp
  • PerfusionDataSimulationView.cpp
  • MatchPointBrowserConstants.cpp

When fixing these IDs make sure to also change them in the corresponding plugin.xml file and in any \page links in the documentation.

Jul 27 2020, 12:18 PM · MITK (v2021.02)
neher committed rMITKDIFF6928050dcb80: Merge branch 'T27603-FibCompression' (authored by neher).
Merge branch 'T27603-FibCompression'
Jul 27 2020, 12:11 PM
neher committed rMITKDIFF397fd34bd7ff: Adjust cmdapp (authored by neher).
Adjust cmdapp
Jul 27 2020, 12:11 PM
kislinsk committed rMITK5c239b6d51fb: Merge branch 'bugfix/T27607-chartExample-UserManual' into develop (authored by kislinsk).
Merge branch 'bugfix/T27607-chartExample-UserManual' into develop
Jul 27 2020, 12:08 PM
kompan triaged T27608: [MITKDoc] Documentation Refurbish - Developer Manual as Normal priority.
Jul 27 2020, 12:04 PM · MITK (v2024.06), Cleared
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

"imageMacro{3}=\image html \1 \2 \n \image latex \1 \2 width=\3cm"

Jul 27 2020, 12:01 PM · MITK (v2021.02)
kislinsk committed rMITK67f46b71eabf: Merge branch 'bugfix/T27607-chartExample-UserManual' into develop (authored by kislinsk).
Merge branch 'bugfix/T27607-chartExample-UserManual' into develop
Jul 27 2020, 11:56 AM
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

Moving the table of contents above any imageMacros did not work. Next try is to (temporarily) remove the imageMacros and if it works, look into the imageMacro.

Jul 27 2020, 11:54 AM · MITK (v2021.02)
kislinsk committed rMITK31d634d52d40: Merge branch 'bugfix/T27607-chartExample-UserManual' into develop (authored by kislinsk).
Merge branch 'bugfix/T27607-chartExample-UserManual' into develop
Jul 27 2020, 11:43 AM
kislinsk added a comment to T27607: [Documentation] Remove dummy chartExample documentation.

Pushed new branch bugfix/T27607-chartExample-UserManual.

Jul 27 2020, 11:42 AM · MITK (v2021.02)
kislinsk moved T27607: [Documentation] Remove dummy chartExample documentation from Backlog to Documentation on the MITK (v2021.02) board.
Jul 27 2020, 11:40 AM · MITK (v2021.02)
kislinsk triaged T27607: [Documentation] Remove dummy chartExample documentation as High priority.
Jul 27 2020, 11:39 AM · MITK (v2021.02)
kislinsk added a revision to T26840: Mission Homepage Reorganization : Unknown Object (Differential Revision).
Jul 27 2020, 10:46 AM · MITK
kislinsk committed rMITKc2b11310095f: Task T26840-MitkHomepageReorganization-TopLevel-integrationBranch (authored by thomass).
Task T26840-MitkHomepageReorganization-TopLevel-integrationBranch
Jul 27 2020, 10:42 AM
kislinsk committed rMITKa7752cd49b46: Task T26840-MitkHomepageReorganization-TopLevel-integrationBranch (authored by thomass).
Task T26840-MitkHomepageReorganization-TopLevel-integrationBranch
Jul 27 2020, 10:42 AM
neher committed rMITKDIFF91ebbc696a17: Merge branch 'T27603-FibCompression' (authored by neher).
Merge branch 'T27603-FibCompression'
Jul 27 2020, 10:34 AM
neher committed rMITKDIFF41bb26f8f05a: Auto-adjusting parameters (authored by neher).
Auto-adjusting parameters
Jul 27 2020, 10:29 AM
neher added a comment to T27603: Fit fiber compression to image spacing.

Pushed new branch T27603-FibCompression.

Jul 27 2020, 10:28 AM · MITK Diffusion
floca triaged T27605: Stitching functionality as Normal priority.
Jul 27 2020, 10:28 AM · Noteworthy, MITK
thomass added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

So I am not quite sure that about the re-init problem but to further clarify my list:

Jul 27 2020, 8:35 AM · MITK (v2021.10), Missing Info, Restricted Project
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

Deleted branch bugfix/T27085-2DRegionGrowing.

Jul 27 2020, 7:39 AM · Cleared, MITK (v2021.02)

Jul 26 2020

floca added a comment to T27085: 2D region growing tool fails for low intensity regions.

This bug was introduced in T26167: ExtractSliceFilter handles 3D+t images inefficiently and inconsequently in the ExtractSliceFilter, so more or less every sliced image by this filter is affected. One of the overloads of Image::Initialize() that uses a PlaneGeometry as input is called with the parameter sDim set to 2. I guess the meaning of this parameter was simply misinterpreted as image dimension instead of number of slices.

Jul 26 2020, 8:57 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

The ToolManager reference and working slices are 2d according to their details, but the number of slices is set to 2. An additional empty slice is drawn if these images are added to the data storage for inspection.

Jul 26 2020, 8:46 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

Another issue I noticed while working on region growing:

Jul 26 2020, 1:55 PM · Cleared, MITK (v2021.02)

Jul 25 2020

floca claimed T25805: Standardize/Rework DICOM module naming.
Jul 25 2020, 5:26 PM · Noteworthy, Breaking Change, MITK (v2021.02), DICOM
floca added a project to T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser: Breaking Change.
Jul 25 2020, 5:25 PM · Breaking Change, MITK (v2021.02), Cleared
floca added a revision to T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser: Restricted Differential Revision.
Jul 25 2020, 5:23 PM · Breaking Change, MITK (v2021.02), Cleared
floca added a revision to T25805: Standardize/Rework DICOM module naming: Restricted Differential Revision.
Jul 25 2020, 5:23 PM · Noteworthy, Breaking Change, MITK (v2021.02), DICOM
floca added projects to T25805: Standardize/Rework DICOM module naming: Breaking Change, Noteworthy.

Cleaned up naming of DICOM related modules

Jul 25 2020, 5:22 PM · Noteworthy, Breaking Change, MITK (v2021.02), DICOM

Jul 24 2020

floca claimed T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser.
Jul 24 2020, 7:15 PM · Breaking Change, MITK (v2021.02), Cleared
floca triaged T27604: DicomUI depends on resources (images) of plugin dicombrowser as Low priority.
Jul 24 2020, 6:04 PM · Auto-closed, Cleared, Restricted Project, MITK
floca added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

@kleina do you still have the problem?

Jul 24 2020, 5:43 PM · Auto-closed, Missing Info, MITK (v2021.02)
floca added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

+1

Jul 24 2020, 5:21 PM · Request for Discussion, Missing Info, MITK (v2021.02)
neher triaged T27603: Fit fiber compression to image spacing as High priority.
Jul 24 2020, 4:22 PM · MITK Diffusion
kislinsk closed T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images as Resolved.

Yes.

Jul 24 2020, 4:22 PM · Request for Discussion, Missing Info, MITK (v2021.02)
floca added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

But either our reinit-algorithm is misleading or the static mask should really only cover this individual timestep, instead of the whole time span. Or am I missing something?

I think you are missing, that one should never reinit on the segmentation itself, but always on the reference image. Then there is always a time slider apropriate to the reference image where you can select the current time point and the reference image content associated with this time point should be used to generate the (static) segmentation.
Could you please recheck your evaluation? I think we have a fundamental difference in the assumption how the segmentation tools should behave an therefore what the correct outcomes of the tools should be. Thank you.

Jul 24 2020, 4:01 PM · MITK (v2021.10), Missing Info, Restricted Project
floca added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

@kislinsk/@kalali Is this bug also solved due to your fix of T27386?

Jul 24 2020, 3:52 PM · Request for Discussion, Missing Info, MITK (v2021.02)
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

Pushed new branch bugfix/T27085-2DRegionGrowing.

Jul 24 2020, 3:08 PM · Cleared, MITK (v2021.02)
neher committed rMITKDIFF4b9493566e83: Merge branch 'T27601-FiberSliceThickness' (authored by neher).
Merge branch 'T27601-FiberSliceThickness'
Jul 24 2020, 2:52 PM
neher committed rMITKDIFFfc8a6a116d4a: adjusting thickness (authored by neher).
adjusting thickness
Jul 24 2020, 2:51 PM
neher added a comment to T27601: Fiber2DSliceThickness in fiber processing.

Pushed new branch T27601-FiberSliceThickness.

Jul 24 2020, 2:51 PM · MITK Diffusion
neher triaged T27601: Fiber2DSliceThickness in fiber processing as Normal priority.
Jul 24 2020, 2:32 PM · MITK Diffusion
kahl triaged T27600: [SWIG] building pyMITK leads to access violation as Normal priority.
Jul 24 2020, 2:11 PM · Auto-closed, MITK
thomass added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

I would suggest that you land it for now since it solves the bug and I will create another task in which I also take a look into the stepper problem. But both is fine for me :)

Jul 24 2020, 12:42 PM · MITK (v2021.02)
neher placed T27250: Color scale overlay does not work up for grabs.
Jul 24 2020, 12:14 PM · Auto-closed, MITK
neher closed T27597: streamline tracking view slot connections as Resolved.
Jul 24 2020, 12:06 PM · MITK Diffusion
neher committed rMITKDIFF2efe4e6ff15a: Merge branch 'T27597-TrackingSignalSlot' (authored by neher).
Merge branch 'T27597-TrackingSignalSlot'
Jul 24 2020, 12:02 PM
neher committed rMITKDIFFa14904410dfc: Fixed connections (authored by neher).
Fixed connections
Jul 24 2020, 12:02 PM
neher added a comment to T27597: streamline tracking view slot connections.

Pushed new branch T27597-TrackingSignalSlot.

Jul 24 2020, 12:02 PM · MITK Diffusion
floca added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

@thomass Shold we land my solution now, or did you take care in a better way (which would be totaly fine)? In the later case it would make sense that you claim the task and we scrap my D346.

Jul 24 2020, 11:43 AM · MITK (v2021.02)
floca added a comment to T27559: Crash when changing parent data nodes in Data Manager.

Start at 16 seconds, end at 30 seconds (sorry @floca):

Jul 24 2020, 11:41 AM · Cleared, MITK (v2021.02)
neher triaged T27597: streamline tracking view slot connections as Normal priority.
Jul 24 2020, 11:36 AM · MITK Diffusion
neher placed T27324: Investigate MITK <--> python image transfer up for grabs.
Jul 24 2020, 11:35 AM · Auto-closed, MITK
kislinsk claimed T27085: 2D region growing tool fails for low intensity regions.
Jul 24 2020, 10:34 AM · Cleared, MITK (v2021.02)
kislinsk updated the task description for T27596: Update supported platforms in documentation.
Jul 24 2020, 10:19 AM · MITK (v2021.02)
kislinsk closed T27596: Update supported platforms in documentation as Resolved.
Jul 24 2020, 10:19 AM · MITK (v2021.02)
kislinsk added a comment to T27596: Update supported platforms in documentation.

Deleted branch feature/T27596-UpdateSupportedPlatforms.

Jul 24 2020, 10:18 AM · MITK (v2021.02)
kislinsk committed rMITK4b4b0552dedb: Merge branch 'feature/T27596-UpdateSupportedPlatforms' into develop (authored by kislinsk).
Merge branch 'feature/T27596-UpdateSupportedPlatforms' into develop
Jul 24 2020, 10:17 AM
kislinsk added a comment to T27596: Update supported platforms in documentation.

Pushed new branch feature/T27596-UpdateSupportedPlatforms.

Jul 24 2020, 10:17 AM · MITK (v2021.02)
kislinsk raised the priority of T27596: Update supported platforms in documentation from Normal to High.
Jul 24 2020, 10:11 AM · MITK (v2021.02)
kislinsk triaged T27596: Update supported platforms in documentation as Normal priority.
Jul 24 2020, 10:11 AM · MITK (v2021.02)
kislinsk updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Jul 24 2020, 9:53 AM · MITK, Restricted Project, Cleared
kislinsk closed T27594: Refactor Remeshing plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Jul 24 2020, 9:52 AM · MITK, Restricted Project, Cleared
kislinsk closed T27594: Refactor Remeshing plugin to use the new node selection widgets as Resolved.
Jul 24 2020, 9:52 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk committed rMITK5b78854aceae: Adapt Remeshing view to new selection widgets (authored by kislinsk).
Adapt Remeshing view to new selection widgets
Jul 24 2020, 9:47 AM
kislinsk committed rMITK1d62fcddd88d: Adapt Remeshing view to new selection widgets (authored by kislinsk).
Adapt Remeshing view to new selection widgets
Jul 24 2020, 9:47 AM
kislinsk committed rMITKb547a8f6352b: Fix newly introduced memory leak (authored by kislinsk).
Fix newly introduced memory leak
Jul 24 2020, 1:26 AM
kislinsk committed rMITK502bcaa86770: Fix newly introduced memory leak (authored by kislinsk).
Fix newly introduced memory leak
Jul 24 2020, 1:26 AM

Jul 23 2020

floca added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Ok. @kalali Thank you very much for the clarification.

Jul 23 2020, 6:04 PM · Request for Discussion, MITK (v2021.02)
k656s committed rNNCCfeab5ae9cac8: cleaning up (authored by k656s).
cleaning up
Jul 23 2020, 5:26 PM
floca added a revision to T27582: ImageStatistic check for same geometry is to pedantic: Unknown Object (Differential Revision).
Jul 23 2020, 5:14 PM · MITK (v2021.02)
floca added a revision to T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects: Unknown Object (Differential Revision).
Jul 23 2020, 5:14 PM · MITK (v2021.02)
j562r committed rNNCC0273678b9d92: Add paper code (authored by j562r).
Add paper code
Jul 23 2020, 4:49 PM
kislinsk added a revision to T27594: Refactor Remeshing plugin to use the new node selection widgets: Restricted Differential Revision.
Jul 23 2020, 3:59 PM · Restricted Project, Cleared, MITK (v2021.02)
j562r committed rNNCC1fa44e50969b: Add basic git setup (authored by j562r).
Add basic git setup
Jul 23 2020, 3:58 PM
neher closed T27593: Make gradient container const as Resolved.
Jul 23 2020, 3:54 PM · MITK Diffusion