Page MenuHomePhabricator
Feed All Stories

Wed, Jul 29

kompan triaged T27619: MR Perfusion: Use model fit result relation rules for predicate definition as Normal priority.
Wed, Jul 29, 11:02 AM · Cleared, MITK (2020)
thomass added a comment to T27097: [MITKDoc] Revise Statistics Plugin Documentation.

that was misleading since the statistics view is in the measurement toolkit view (actually I find this confusing, maybe we can change that in general)

Wed, Jul 29, 10:58 AM · Cleared, MITK (2020)
neher committed rMITKDIFF05a9a10bca71: Merge branch 'T27618-UpdateReadme' (authored by neher).
Merge branch 'T27618-UpdateReadme'
Wed, Jul 29, 10:47 AM
neher committed rMITKDIFFc80f89d4a5e1: added ubuntu 20.04 (authored by neher).
added ubuntu 20.04
Wed, Jul 29, 10:46 AM
neher added a comment to T27618: Update Readme.

Pushed new branch T27618-UpdateReadme.

Wed, Jul 29, 10:46 AM · MITK Diffusion
neher created T27618: Update Readme.
Wed, Jul 29, 10:46 AM · MITK Diffusion
koehlerg added a member for trixi: f818k.
Wed, Jul 29, 10:43 AM
koehlerg added a member for MIA: f818k.
Wed, Jul 29, 10:43 AM
koehlerg added a member for Deep Learning: f818k.
Wed, Jul 29, 10:43 AM
kompan committed rMITK24158ffb55c1: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox. (authored by kompan).
Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox.
Wed, Jul 29, 10:37 AM
kompan committed rMITKe8c6a0a2ad5a: Case sensitive spelling of QmitkSingelNodeSelectionWidget. (authored by kompan).
Case sensitive spelling of QmitkSingelNodeSelectionWidget.
Wed, Jul 29, 10:37 AM
kompan committed rMITK4c2473dc50f8: Remove unrequired include file. (authored by kompan).
Remove unrequired include file.
Wed, Jul 29, 10:37 AM
kompan closed T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept as Resolved by committing rMITK24158ffb55c1: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox..
Wed, Jul 29, 10:37 AM · Cleared, MITK (2020)
kompan closed T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Wed, Jul 29, 10:37 AM · MITK, Restricted Project, Cleared
kompan committed rMITK8d63af91b336: Update GUI controls, when AIF mask and image selection has changed. (authored by kompan).
Update GUI controls, when AIF mask and image selection has changed.
Wed, Jul 29, 10:37 AM
kompan committed rMITK1b93ec66c172: Enable auto select for AIF mask. (authored by kompan).
Enable auto select for AIF mask.
Wed, Jul 29, 10:37 AM
kompan committed rMITK28cfe9a3e4fd: Replace AIF mask and image combo boxes with single node selection widgets. (authored by kompan).
Replace AIF mask and image combo boxes with single node selection widgets.
Wed, Jul 29, 10:37 AM
kompan committed rMITK1b6ec1748f4f: Rename OnSelectionChanged to OnNodeSelectionChanged. (authored by kompan).
Rename OnSelectionChanged to OnNodeSelectionChanged.
Wed, Jul 29, 10:37 AM
kompan committed rMITK850fbac79fb5: Change size policies. (authored by kompan).
Change size policies.
Wed, Jul 29, 10:37 AM
kompan committed rMITKafa09efbeea1: Refactor AIF mask and AIF image selection using new selection concept. (authored by kompan).
Refactor AIF mask and AIF image selection using new selection concept.
Wed, Jul 29, 10:37 AM
kompan committed rMITKf8f8c8e47519: Change mask selection to be optional. (authored by kompan).
Change mask selection to be optional.
Wed, Jul 29, 10:37 AM
kompan committed rMITK1e641f1b87ae: Activate auto select for time series selection. (authored by kompan).
Activate auto select for time series selection.
Wed, Jul 29, 10:37 AM
kompan committed rMITK73f49980871d: Merge branch 'feature/T27043-RefactorModelFitAndPharmacokineticsPluginToUseNewS… (authored by kompan).
Merge branch 'feature/T27043-RefactorModelFitAndPharmacokineticsPluginToUseNewS…
Wed, Jul 29, 10:37 AM
kompan committed rMITKeab41537a7bf: Narrow predicates for time series, mask and PDW image selection. (authored by kompan).
Narrow predicates for time series, mask and PDW image selection.
Wed, Jul 29, 10:37 AM
kompan committed rMITKcaf612b04010: Replace DataStorageComboBoxes with SingleNodeSelectionWidgets for timeseries… (authored by kompan).
Replace DataStorageComboBoxes with SingleNodeSelectionWidgets for timeseries…
Wed, Jul 29, 10:37 AM
thomass added a revision to T27103: [MITKDoc] Revise Point Set Interaction Plugin Documentation: Restricted Differential Revision.
Wed, Jul 29, 10:37 AM · Cleared, MITK (2020)
kompan committed rMITK234bec8db139: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox. (authored by kompan).
Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox.
Wed, Jul 29, 10:36 AM
floca committed rMITK978e3fbf6328: Introduced ModelFitResultRelationRule (authored by floca).
Introduced ModelFitResultRelationRule
Wed, Jul 29, 10:26 AM
floca committed rMITKb9af16068179: Fixed review remarks (authored by floca).
Fixed review remarks
Wed, Jul 29, 10:26 AM
floca committed rMITK1b57565cf609: Fixed gcc compile errors (authored by floca).
Fixed gcc compile errors
Wed, Jul 29, 10:26 AM
floca committed rMITK154cd9ee0f1c: Improved test coverage of SourceImageRelationRule and ModelFitResultRelationRule (authored by floca).
Improved test coverage of SourceImageRelationRule and ModelFitResultRelationRule
Wed, Jul 29, 10:26 AM
floca committed rMITKa1f71ea0ee6f: Fixed business logic in the ModelFitInspectorView (authored by floca).
Fixed business logic in the ModelFitInspectorView
Wed, Jul 29, 10:26 AM
floca committed rMITK58e8ee2b8bd9: Fixed T26142 by adding persistency for needed PropertyRule properties. (authored by floca).
Fixed T26142 by adding persistency for needed PropertyRule properties.
Wed, Jul 29, 10:26 AM
floca committed rMITK98394bbae559: Deprecated old modelfit UID scheme (now uses property rule) (authored by floca).
Deprecated old modelfit UID scheme (now uses property rule)
Wed, Jul 29, 10:26 AM
floca closed T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps as Resolved by committing rMITKa1f71ea0ee6f: Fixed business logic in the ModelFitInspectorView.
Wed, Jul 29, 10:26 AM · Breaking Change, MITK (2020)
floca committed rMITK826398b541aa: Added ModelFitResultRelationRule (authored by floca).
Added ModelFitResultRelationRule
Wed, Jul 29, 10:26 AM
floca closed T26142: Property persistence for property relation instance identifing (RII) properties as Resolved by committing rMITK58e8ee2b8bd9: Fixed T26142 by adding persistency for needed PropertyRule properties..
Wed, Jul 29, 10:26 AM · Cleared, MITK (2020)
floca closed T26142: Property persistence for property relation instance identifing (RII) properties, a subtask of T23754: DataStorage/Relationship clean up/refactoring, as Resolved.
Wed, Jul 29, 10:26 AM · MITK
floca committed rMITKbf292f6e9d09: Corrected ModelFit property description (authored by floca).
Corrected ModelFit property description
Wed, Jul 29, 10:26 AM
floca committed rMITK7648cacdc58c: Corrected include guard (authored by floca).
Corrected include guard
Wed, Jul 29, 10:26 AM
thomass added a comment to T27617: [ImageCropper] Workbench crashes when the plugin is opened.

Eventually related to changes in D360

Wed, Jul 29, 10:02 AM · MITK (2020)
thomass triaged T27617: [ImageCropper] Workbench crashes when the plugin is opened as High priority.
Wed, Jul 29, 9:00 AM · MITK (2020)
thomass moved T27608: [MITKDoc] Documentation Refurbish - Developer Manual from Backlog to Documentation on the MITK (2020) board.
Wed, Jul 29, 8:09 AM · Cleared, MITK (2020)
thomass moved T27616: [Segmentation] Otsu creates static 3D segmentation regardless of segmentation choice from Backlog to Segmentation on the MITK (2020) board.
Wed, Jul 29, 8:09 AM · MITK (2020)
thomass moved T27615: [Segmentation] Threshold and UL threshold show unwanted behavior on static and dynamic segmentations from Backlog to Segmentation on the MITK (2020) board.
Wed, Jul 29, 8:09 AM · MITK (2020)

Tue, Jul 28

kahl added a comment to T27600: [SWIG] building pyMITK leads to access violation.

If you use Python 3.7/3.8, you need to install SWIG version 4.0.2. This solves the problem. Currently, SWIG version 3.0.2. is installed in the Superbuild.

Tue, Jul 28, 5:17 PM · MITK
kislinsk committed rMITKc6c5256a8dd7: Fix QWebEngine warning about unregistered qthelp scheme (authored by kislinsk).
Fix QWebEngine warning about unregistered qthelp scheme
Tue, Jul 28, 5:14 PM
kislinsk committed rMITK1b30808db9e5: Revise Movie Maker documentation (authored by kislinsk).
Revise Movie Maker documentation
Tue, Jul 28, 5:14 PM
kislinsk closed T27102: [MITKDoc] Revise Movie Maker Plugin Documentation as Resolved by committing rMITK1b30808db9e5: Revise Movie Maker documentation.
Tue, Jul 28, 5:14 PM · Cleared, MITK (2020)
kislinsk committed rMITK4d0d5b8358b6: Remove references to libav from code and documentation (authored by kislinsk).
Remove references to libav from code and documentation
Tue, Jul 28, 5:14 PM
kislinsk committed rMITK6d34627b39d0: Add documentation to Properties View (authored by kislinsk).
Add documentation to Properties View
Tue, Jul 28, 5:13 PM
kislinsk committed rMITK01fc3468ed94: Add documentation to Properties View (authored by kislinsk).
Add documentation to Properties View
Tue, Jul 28, 5:13 PM
kislinsk closed T27109: [MITKDoc] Revise Properties Plugin Documentation as Resolved by committing rMITK6d34627b39d0: Add documentation to Properties View.
Tue, Jul 28, 5:13 PM · Cleared, MITK (2020)
floca added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

@kalali / @thomass Can you spawn the identified open tool problems as sub tasks till tomorrow noon or at least indicated here the final results after our todays discussion/clarification how to proceed? That would be very helpfull as they have also to be tackeled. thanks. Ralf

Tue, Jul 28, 5:04 PM · Restricted Project, Cleared, MITK (2020)
nolden committed rMITK3d31d74f9e36: Patch VTK to properly detect gcc 10 (authored by nolden).
Patch VTK to properly detect gcc 10
Tue, Jul 28, 4:54 PM
nolden committed rMITKbc8bf3835b5e: Patch VTK to properly detect gcc 10 (authored by nolden).
Patch VTK to properly detect gcc 10
Tue, Jul 28, 4:54 PM
floca claimed T27114: [MITKDoc] Revise Matchpoint Mapper Plugin Documentation.
Tue, Jul 28, 3:05 PM · Cleared, MITK (2020)
floca added a revision to T27117: [MITKDoc] Revise Matchpoint Algorithm Control Plugin Documentation: Restricted Differential Revision.
Tue, Jul 28, 3:00 PM · Cleared, MITK (2020)
kalali added a revision to T27595: Refactor DeformableClippingPlane plugin to use the new node selection widgets: Restricted Differential Revision.
Tue, Jul 28, 1:59 PM · Cleared, MITK (2020)
floca closed T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects, a subtask of T27582: ImageStatistic check for same geometry is to pedantic, as Resolved.
Tue, Jul 28, 1:58 PM · MITK (2020)
floca closed T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects as Resolved.
Tue, Jul 28, 1:58 PM · MITK (2020)
floca committed rMITK3340d7805c11: Fixed broken tests for T27583 (authored by floca).
Fixed broken tests for T27583
Tue, Jul 28, 1:56 PM
floca committed rMITK1153771459b8: Fixed broken tests for T27583 (authored by floca).
Fixed broken tests for T27583
Tue, Jul 28, 1:56 PM
zimmerer committed rMOODe788c89e52e0: Add boostrap list method (authored by zimmerer).
Add boostrap list method
Tue, Jul 28, 11:56 AM
zimmerer committed rMOODd09f8c6eb614: Make docker also only read-only for local testing (authored by zimmerer).
Make docker also only read-only for local testing
Tue, Jul 28, 11:56 AM
nolden committed rMITK467d01b492e2: Fix some clang triggered issues (authored by nolden).
Fix some clang triggered issues
Tue, Jul 28, 11:25 AM
nolden committed rMITKb73371b41722: Silence clang on float int conversion in uServices (authored by nolden).
Silence clang on float int conversion in uServices
Tue, Jul 28, 11:24 AM
nolden committed rMITKefc061e82760: Use std::string instead of const char* in file extension handling (authored by nolden).
Use std::string instead of const char* in file extension handling
Tue, Jul 28, 11:24 AM
nolden committed rMITK87e3bb7e499b: Git ignore .clangd (authored by nolden).
Git ignore .clangd
Tue, Jul 28, 11:24 AM
nolden committed rMITKf2d1b2910f34: Fixed some range-based loops (authored by nolden).
Fixed some range-based loops
Tue, Jul 28, 11:24 AM
kislinsk added a revision to T27109: [MITKDoc] Revise Properties Plugin Documentation: Unknown Object (Differential Revision).
Tue, Jul 28, 10:59 AM · Cleared, MITK (2020)
kompan added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

In the developer manual section, the table of contents is repeated in each section and subsection. This is not a show-stopper, but doesn't look very nice and should be cleaned up at some point.

Tue, Jul 28, 10:33 AM · Cleared, MITK (2020)
kleina added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

I do. I can build the current develop and let you know, if something changed for me.

Tue, Jul 28, 10:23 AM · Missing Info, MITK (2020)
thomass triaged T27616: [Segmentation] Otsu creates static 3D segmentation regardless of segmentation choice as Normal priority.
Tue, Jul 28, 10:21 AM · MITK (2020)
thomass triaged T27615: [Segmentation] Threshold and UL threshold show unwanted behavior on static and dynamic segmentations as Normal priority.
Tue, Jul 28, 10:10 AM · MITK (2020)
kislinsk triaged T27614: Equalize reinit behavior of Segmentation View and Multilabel Segmentation View as Wishlist priority.
Tue, Jul 28, 9:59 AM · MITK
kislinsk merged task T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit into T27613: Improve reinit behavior.
Tue, Jul 28, 9:57 AM · Request for Discussion, MITK (2020)
kislinsk merged T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit into T27613: Improve reinit behavior.
Tue, Jul 28, 9:57 AM · MITK
kislinsk triaged T27613: Improve reinit behavior as Wishlist priority.
Tue, Jul 28, 9:57 AM · MITK
thomass claimed T27105: [MITKDoc] Revise Measurement Plugin Documentation.
Tue, Jul 28, 8:37 AM · Cleared, MITK (2020)
kislinsk claimed T27109: [MITKDoc] Revise Properties Plugin Documentation.
Tue, Jul 28, 6:57 AM · Cleared, MITK (2020)
kislinsk added a revision to T27102: [MITKDoc] Revise Movie Maker Plugin Documentation: Unknown Object (Differential Revision).
Tue, Jul 28, 6:45 AM · Cleared, MITK (2020)
kislinsk claimed T27102: [MITKDoc] Revise Movie Maker Plugin Documentation.
Tue, Jul 28, 6:08 AM · Cleared, MITK (2020)
kislinsk reopened T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects, a subtask of T27582: ImageStatistic check for same geometry is to pedantic, as Open.
Tue, Jul 28, 5:18 AM · MITK (2020)
kislinsk reopened T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects as "Open".

The following tests fail on the continuous dart clients:

  • mitkNodePredicateGeometryTest
  • mitkNodePredicateSubGeometryTest
Tue, Jul 28, 5:18 AM · MITK (2020)
kislinsk added a revision to T27085: 2D region growing tool fails for low intensity regions: Unknown Object (Differential Revision).
Tue, Jul 28, 5:11 AM · Cleared, MITK (2020)
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

Pushed new branch bugfix/T27085-2DRegionGrowing.

Tue, Jul 28, 5:07 AM · Cleared, MITK (2020)
floca committed rMITK3117a4d3c970: T27582 BaseGeometry equality checks (in ImageStatistics) should be less… (authored by floca).
T27582 BaseGeometry equality checks (in ImageStatistics) should be less…
Tue, Jul 28, 12:07 AM
floca committed rMITKa4d01b0baeaa: Remove deprecated equal() function (authored by floca).
Remove deprecated equal() function
Tue, Jul 28, 12:07 AM
floca committed rMITK3575c71b077a: Fixed review remarks. (authored by floca).
Fixed review remarks.
Tue, Jul 28, 12:07 AM
floca committed rMITK3c0fbe73e8e7: Set NodePredicateGeometry and NodePredicateSubGeometry precision default (authored by floca).
Set NodePredicateGeometry and NodePredicateSubGeometry precision default
Tue, Jul 28, 12:07 AM
floca committed rMITK6471d8650a7c: Reworked MaskUtilities to use explicit constants for tolerance and no magic… (authored by floca).
Reworked MaskUtilities to use explicit constants for tolerance and no magic…
Tue, Jul 28, 12:07 AM
floca closed T27582: ImageStatistic check for same geometry is to pedantic as Resolved by committing rMITK3c0fbe73e8e7: Set NodePredicateGeometry and NodePredicateSubGeometry precision default.
Tue, Jul 28, 12:07 AM · MITK (2020)
floca committed rMITK88eaf0e5bd75: Extend BaseGeometry equality check with coordinate and direction tolerance. (authored by floca).
Extend BaseGeometry equality check with coordinate and direction tolerance.
Tue, Jul 28, 12:07 AM
floca closed T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects, a subtask of T27582: ImageStatistic check for same geometry is to pedantic, as Resolved.
Tue, Jul 28, 12:07 AM · MITK (2020)
floca closed T27583: Extend mitk:Equal (for geometries) and mitk::IsSubGeometry to allow an eps for direction and spatial aspects as Resolved by committing rMITK88eaf0e5bd75: Extend BaseGeometry equality check with coordinate and direction tolerance..
Tue, Jul 28, 12:07 AM · MITK (2020)

Mon, Jul 27

floca claimed T27117: [MITKDoc] Revise Matchpoint Algorithm Control Plugin Documentation.
Mon, Jul 27, 5:54 PM · Cleared, MITK (2020)
floca added a comment to T27085: 2D region growing tool fails for low intensity regions.

*OMG*

Mon, Jul 27, 5:53 PM · Cleared, MITK (2020)
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

Oof, that took a while. I narrowed it down to the itk::ConnectedThresholdImageFilter, which takes a seed point, a lower, and an upper threshold. I verified that the seed lies within the thresholds and still the output image was empty for low intensity regions.

Mon, Jul 27, 5:49 PM · Cleared, MITK (2020)
kislinsk committed rMITK71718abcc2b2: Migrate .arcconfig to mid 2020 changes of "arc land" (authored by kislinsk).
Migrate .arcconfig to mid 2020 changes of "arc land"
Mon, Jul 27, 5:35 PM