Page MenuHomePhabricator
Feed All Stories

Oct 15 2020

kislinsk added a revision to T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto: Restricted Differential Revision.
Oct 15 2020, 9:49 AM · MITK
kislinsk added a comment to T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.

Thanks for reporting. The whole method seems to be dubious. The lines of code you mentioned are plain wrong, the loop should start with k=1 and the data type of numPixelsInDataset should be more appropriate.

Oct 15 2020, 9:30 AM · MITK
kislinsk claimed T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.
Oct 15 2020, 9:27 AM · MITK
CptMo updated CptMo.
Oct 15 2020, 8:47 AM
CptMo updated the task description for T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.
Oct 15 2020, 8:45 AM · MITK
CptMo triaged T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto as Normal priority.
Oct 15 2020, 7:24 AM · MITK

Oct 14 2020

floca added a comment to T27506: Extend checklists for segmentation view.

OK. But I tend/think more and more that we should strive for a unit test testbed that tests all that on the tool class level (either the respective base classes or the tools itself where it is easily possible (e.g. because the have no interaction (but even thous shouldn't be a show stopper).

Oct 14 2020, 8:21 PM · MITK (v2022.04), Cleared
kalali added a comment to T27506: Extend checklists for segmentation view.

The checklist don't say anything about multilabel segmentation. This should be addressed with a special focus on creating and combining multiple labels / layers.
I couldn't find any other checklist with a focus on the multilabel functionality.

Oct 14 2020, 3:42 PM · MITK (v2022.04), Cleared
kalali added a comment to T27873: Extend "Checkliste Segmentierung – Interpolation".

I updated the document and added content to explicitly tests

Oct 14 2020, 3:38 PM · MITK (v2022.04), Cleared
kalali triaged T27883: [Segmentation] Crash and interpolation issues in static segmentation on reference image with strange arbitrary time geometry (3d+t heart) as Normal priority.
Oct 14 2020, 2:55 PM · MITK (v2021.02)
kalali renamed T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden from Segmentation: interpolation nodes are not removed from data manager to [Segmentation] Interpolation nodes / position nodes are not correctly hidden.
Oct 14 2020, 2:27 PM · MITK (v2024.12)
kalali added a comment to T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden.

I can verify this behavior. Also, if you close the segmentation view while the position nodes are shown, they stay visible.
If you open the segmentation view again and select the 3-Dimensional interpolation, the position nods are still shown, although the checkbox is not checked.
Checking it and unchecking it will hide the position nodes again.

Oct 14 2020, 2:26 PM · MITK (v2024.12)
kalali renamed T20110: [Multilabel Segmentation] Contour broken for 3D and 2D interpolation from Contour broken for 3D and 2D interpolation in multilabel segmentation plugin to [Multilabel Segmentation] Contour broken for 3D and 2D interpolation.
Oct 14 2020, 2:21 PM · Next Milestone, MITK
schererj edited projects for T27706: Refactor kaapana radiomics workflow to output xml files, added: Kaapana (internal); removed Request for Discussion, Kaapana (internal) (Open Source Rocketplant).

Alright -> removed the task from release-workboard

Oct 14 2020, 2:20 PM · Kaapana (internal)
floca added a comment to T27706: Refactor kaapana radiomics workflow to output xml files.

@floca do you know something about the status of the "new" radiomics container?

No.

Oct 14 2020, 1:52 PM · Kaapana (internal)
kislinsk edited projects for T27817: [Multilabel] Live Wire tool always assigns first label when being used with multiple labels, added: Cleared; removed Request for Discussion.
Oct 14 2020, 10:29 AM · Cleared, MITK (v2021.02)
kislinsk raised the priority of T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation from Normal to High.
Oct 14 2020, 10:24 AM · MITK (v2021.02)
kalali claimed T27873: Extend "Checkliste Segmentierung – Interpolation".
Oct 14 2020, 10:23 AM · MITK (v2022.04), Cleared
schererj updated subscribers of T27706: Refactor kaapana radiomics workflow to output xml files.

@floca do you know something about the status of the "new" radiomics container?
Since we don't have the new container yet, we will keep the old radiomics pipepline for this release if that's ok.

Oct 14 2020, 9:53 AM · Kaapana (internal)
kislinsk closed T27879: [CDash] CTEST_BUILD_NAME suffix feature as Resolved.
Oct 14 2020, 9:36 AM · MITK
kislinsk added a comment to T27879: [CDash] CTEST_BUILD_NAME suffix feature.

Deleted branch feature/T27879-MITK_BUILD_NAME_SUFFIX.

Oct 14 2020, 9:36 AM · MITK
kislinsk committed rMITK0a52c695f724: Merge branch 'feature/T27879-MITK_BUILD_NAME_SUFFIX' into develop (authored by kislinsk).
Merge branch 'feature/T27879-MITK_BUILD_NAME_SUFFIX' into develop
Oct 14 2020, 9:36 AM
kislinsk added a comment to T27879: [CDash] CTEST_BUILD_NAME suffix feature.

Pushed new branch feature/T27879-MITK_BUILD_NAME_SUFFIX.

Oct 14 2020, 9:35 AM · MITK
kislinsk triaged T27879: [CDash] CTEST_BUILD_NAME suffix feature as Wishlist priority.
Oct 14 2020, 9:34 AM · MITK
kompan added a comment to T27340: [ModelFit] Request for Mac Workbench installer.

No, not yet. I've sent an email and asked for a more detailed description of the problems and will post it in this task when I hear back from Jerome.

Oct 14 2020, 9:01 AM · Auto-closed, Restricted Project, MITK

Oct 13 2020

schererj added a project to T27706: Refactor kaapana radiomics workflow to output xml files: Request for Discussion.

@k656s have you heard from @gaoh about the status of this container?
Is there a new one, which is based on the MITK develop branch?

Oct 13 2020, 7:45 PM · Kaapana (internal)
schererj moved T27706: Refactor kaapana radiomics workflow to output xml files from Backlog to Blocked on the Kaapana (internal) (Open Source Rocketplant) board.
Oct 13 2020, 7:43 PM · Kaapana (internal)
kalali moved T27873: Extend "Checkliste Segmentierung – Interpolation" from Backlog to Segmentation on the MITK (v2021.02) board.
Oct 13 2020, 3:38 PM · MITK (v2022.04), Cleared
kalali triaged T27873: Extend "Checkliste Segmentierung – Interpolation" as High priority.
Oct 13 2020, 3:36 PM · MITK (v2022.04), Cleared
kalali added a comment to T27850: Extend "Checkliste Segmentierung – 3D Segmentierung".

Similar to T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung" I updated the document and added content to explicitly tests different image types / segmentation types.
Additionally I tried to make both checklists more consistent.

Oct 13 2020, 3:34 PM · MITK (v2022.04), Cleared
kalali added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

So Region Growing 3D seems to work and could probably be used for reference for other algorithms.

Oct 13 2020, 2:42 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali triaged T27872: [Segmentation] Region Growing 3D GUI does not provide a "Overwrite" checkbox as Normal priority.
Oct 13 2020, 2:41 PM · MITK (v2022.10), Cleared
kalali created T27872: [Segmentation] Region Growing 3D GUI does not provide a "Overwrite" checkbox.
Oct 13 2020, 2:41 PM · MITK (v2022.10), Cleared
kalali removed a subtask for T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation: T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks.
Oct 13 2020, 2:36 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali removed a parent task for T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks: T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.
Oct 13 2020, 2:36 PM · MITK (v2021.02)
floca triaged T27871: [Registration] Mapper should only autoselect Reference if it is an image as Normal priority.
Oct 13 2020, 2:08 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali renamed T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks from {Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks to [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks.
Oct 13 2020, 1:01 PM · MITK (v2021.02)
kalali moved T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks from Backlog to Segmentation on the MITK (v2021.02) board.
Oct 13 2020, 12:22 PM · MITK (v2021.02)
kalali triaged T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks as Normal priority.
Oct 13 2020, 12:22 PM · MITK (v2021.02)
kislinsk added a project to T26897: Build error: Could not find git for clone of qRestAPI: Noteworthy.
Oct 13 2020, 12:22 PM · Noteworthy, MITK
kislinsk added a comment to T27340: [ModelFit] Request for Mac Workbench installer.

Any details?

Oct 13 2020, 12:21 PM · Auto-closed, Restricted Project, MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Deleted branch bugfix/T26897-RemoveCustomFindGitModule.

Oct 13 2020, 12:18 PM · Noteworthy, MITK
kislinsk closed T26897: Build error: Could not find git for clone of qRestAPI as Resolved.

Should be fixed now.

Oct 13 2020, 12:15 PM · Noteworthy, MITK
kislinsk committed rMITKe02262024ec3: Merge branch 'bugfix/T26897-RemoveCustomFindGitModule' into develop (authored by kislinsk).
Merge branch 'bugfix/T26897-RemoveCustomFindGitModule' into develop
Oct 13 2020, 12:12 PM
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

I wonder how this is related to our findings from December last year.

Oct 13 2020, 11:53 AM · Noteworthy, MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Pushed new branch bugfix/T26897-RemoveCustomFindGitModule.

Oct 13 2020, 11:38 AM · Noteworthy, MITK
kalali added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

I wonder how this is related to our findings from December last year.

Oct 13 2020, 10:51 AM · Noteworthy, MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

I noticed a few things that may be related or not but we should clean them anyway:

Oct 13 2020, 10:45 AM · Noteworthy, MITK
kislinsk closed T27852: [CDash] Add option to clean build directory as Resolved.
Oct 13 2020, 10:27 AM · MITK
kislinsk added a comment to T27852: [CDash] Add option to clean build directory.

Deleted branch feature/T27852-CDashAddOptionToCleanDirs.

Oct 13 2020, 10:27 AM · MITK
kislinsk committed rMITKaabd0623f1d6: Merge branch 'feature/T27852-CDashAddOptionToCleanDirs' into develop (authored by kislinsk).
Merge branch 'feature/T27852-CDashAddOptionToCleanDirs' into develop
Oct 13 2020, 10:26 AM
kislinsk added a comment to T27852: [CDash] Add option to clean build directory.

You can add the following options to your configuration script:

Oct 13 2020, 10:25 AM · MITK
kislinsk added a comment to T27852: [CDash] Add option to clean build directory.

Pushed new branch feature/T27852-CDashAddOptionToCleanDirs.

Oct 13 2020, 10:22 AM · MITK
neher added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Seems to be resolved by setting

"GIT_EXECUTABLE:FILEPATH=/usr/bin/git"

in MITKDashboardScript.cmake

Oct 13 2020, 10:04 AM · Noteworthy, MITK
kislinsk moved T27844: CDash links to commits in phabricator seems not to work correctly from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 13 2020, 9:41 AM · Restricted Project, Restricted Project, MITK
kompan reopened T27340: [ModelFit] Request for Mac Workbench installer as "Open".

Jerome Devy reported problems with the installation on 12th October 2020.

Oct 13 2020, 8:37 AM · Auto-closed, Restricted Project, MITK
neher added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

yes, openstack

Oct 13 2020, 8:34 AM · Noteworthy, MITK

Oct 12 2020

kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

May be completely unrelated but who knows: https://cmake.org/pipermail/cmake-developers/2015-November/027082.html

Oct 12 2020, 11:44 PM · Noteworthy, MITK
aguilera moved T27829: [shiny] Disabling button "Next" when a text field is empty from Backlog to Done on the webChallengeR board.
Oct 12 2020, 10:54 PM · webChallengeR
aguilera moved T27842: [shiny] Error while generating single-task report from Backlog to Done on the webChallengeR board.
Oct 12 2020, 5:09 PM · webChallengeR
wiesenfa added a comment to T27708: ggplot2 dendrogram .

disadvantage would be dependency on another package facilitating ggplot2 dendrograms

Oct 12 2020, 2:30 PM · challengeR
wiesenfa added a comment to T27708: ggplot2 dendrogram .

current implementation is fine. However, we said it would be nice if all plots (if directly called by users and not within the report) would have the same syntax and could be layouted with ggplot2 syntax. current implementation is using basic R graphics.

Oct 12 2020, 2:30 PM · challengeR
wiesenfa added a comment to T27326: autolayout networks in multi task report ugly.

turned off in v1.0, everything else postponed

Oct 12 2020, 2:27 PM · challengeR
reinkea added a comment to T27326: autolayout networks in multi task report ugly.

I also agree!

Oct 12 2020, 1:47 PM · challengeR
reinkea added a comment to T27794: Stacked frequency plots should switch to single page layout.

People that are not from the statistics community might find them easier to read and interpret. I would be in favour of keeping them in the reports. We used the plots in one of our papers.

Oct 12 2020, 1:44 PM · challengeR (v1.0)
eisenman added a comment to T27708: ggplot2 dendrogram .

What is the issue with the current implementation?

Oct 12 2020, 1:28 PM · challengeR
e148c moved T27867: report corrections from In Progress to Done on the challengeR board.
Oct 12 2020, 1:19 PM · challengeR (v1.0)
e148c committed rCHALLENGER1150961eecaa: Merge branch 'feature/T27867-reportCorrections' into develop (authored by e148c).
Merge branch 'feature/T27867-reportCorrections' into develop
Oct 12 2020, 1:18 PM
e148c committed rCHALLENGER6460c5c9d27c: language corrections in the report (authored by e148c).
language corrections in the report
Oct 12 2020, 1:18 PM
e148c moved T27867: report corrections from Backlog to In Progress on the challengeR board.
Oct 12 2020, 12:53 PM · challengeR (v1.0)
e148c created T27867: report corrections.
Oct 12 2020, 12:53 PM · challengeR (v1.0)
neher added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

This just occurred on my ubuntu dartclients. Any idea how to fix this in MITKDashboardScript.cmake?
https://cdash.mitk.org/index.php?project=MITK-Diffusion

Oct 12 2020, 11:40 AM · Noteworthy, MITK
kislinsk triaged T27852: [CDash] Add option to clean build directory as Low priority.
Oct 12 2020, 11:15 AM · MITK
kompan edited projects for T27745: [MITKDoc] Revise Model Fit Generic View Documentation, added: Next Milestone, MITK; removed MITK (v2021.02).
Oct 12 2020, 10:53 AM · MITK (v2022.04)
kislinsk updated the task description for T27851: Unhide label presets.
Oct 12 2020, 10:52 AM · MITK (v2021.02)
kislinsk triaged T27851: Unhide label presets as High priority.
Oct 12 2020, 10:51 AM · MITK (v2021.02)
kalali moved T27850: Extend "Checkliste Segmentierung – 3D Segmentierung" from Backlog to Segmentation on the MITK (v2021.02) board.
Oct 12 2020, 10:51 AM · MITK (v2022.04), Cleared
kompan edited projects for T27847: [MITKDoc] Chart Example view documentation, added: Next Milestone, MITK; removed MITK (v2021.02).
Oct 12 2020, 10:50 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan added a comment to T27847: [MITKDoc] Chart Example view documentation.

Sounds good to me (the view just came up in T27563, so I thought I should open a task that it doesn't get forgotten about). It has low priority though at the moment and it makes sense to tag it with "next milestone".

Oct 12 2020, 10:50 AM · Moved to git.dkfz.de, MITK (v2024.12)
kalali triaged T27850: Extend "Checkliste Segmentierung – 3D Segmentierung" as High priority.
Oct 12 2020, 10:47 AM · MITK (v2022.04), Cleared
kalali added a comment to T27847: [MITKDoc] Chart Example view documentation.

Should we put this on "Next Milestone" since the chart example will probably not be included in any installer?

Oct 12 2020, 10:43 AM · Moved to git.dkfz.de, MITK (v2024.12)
kalali moved T27847: [MITKDoc] Chart Example view documentation from Backlog to Documentation on the MITK (v2021.02) board.
Oct 12 2020, 10:41 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk closed T27849: MITK extensions do not work in CDash script on Linux and macOS as Resolved.
Oct 12 2020, 10:35 AM · MITK
kislinsk added a comment to T27849: MITK extensions do not work in CDash script on Linux and macOS.

Deleted branch hotfix/T27849-MITKExtensionsInCDashScriptOnUnix.

Oct 12 2020, 10:34 AM · MITK
kislinsk committed rMITK105f7104f504: Merge branch 'hotfix/T27849-MITKExtensionsInCDashScriptOnUnix' (authored by kislinsk).
Merge branch 'hotfix/T27849-MITKExtensionsInCDashScriptOnUnix'
Oct 12 2020, 10:34 AM
kislinsk committed rMITKd3ce78442e93: Merge branch 'hotfix/T27849-MITKExtensionsInCDashScriptOnUnix' into develop (authored by kislinsk).
Merge branch 'hotfix/T27849-MITKExtensionsInCDashScriptOnUnix' into develop
Oct 12 2020, 10:34 AM
kislinsk added a comment to T27849: MITK extensions do not work in CDash script on Linux and macOS.

Pushed new branch hotfix/T27849-MITKExtensionsInCDashScriptOnUnix.

Oct 12 2020, 10:33 AM · MITK
kislinsk updated the task description for T27849: MITK extensions do not work in CDash script on Linux and macOS.
Oct 12 2020, 10:23 AM · MITK
kislinsk triaged T27849: MITK extensions do not work in CDash script on Linux and macOS as Unbreak Now! priority.
Oct 12 2020, 10:23 AM · MITK
eisenman moved T27278: Writing documentation for main functions from Backlog to In Progress on the challengeR (v1.0) board.
Oct 12 2020, 9:47 AM · challengeR (v1.0)
kislinsk added a comment to T27844: CDash links to commits in phabricator seems not to work correctly.

https://github.com/Kitware/CDash/issues/514

Oct 12 2020, 9:35 AM · Restricted Project, Restricted Project, MITK
kislinsk reopened T27844: CDash links to commits in phabricator seems not to work correctly as "Open".

Oh, I just noticed an "Add repository" button in CDash. There may be the possibility to actually report revisions of more than one repository. Let me check that... :-)

Oct 12 2020, 9:31 AM · Restricted Project, Restricted Project, MITK
kislinsk committed rMITK3fda52eea343: Fix view IDs (authored by kislinsk).
Fix view IDs
Oct 12 2020, 9:23 AM
kislinsk committed rMITKbfcb35e9c997: Remove reference to non-existent documentation page (authored by kislinsk).
Remove reference to non-existent documentation page
Oct 12 2020, 9:22 AM
kislinsk closed T27563: Help link (pressing F1) is partially broken as Resolved by committing rMITK3fda52eea343: Fix view IDs.
Oct 12 2020, 9:22 AM · MITK (v2021.02)
kislinsk committed rMITK82224f11595f: Fix view IDs in MITKPluginGeneralManualsList (authored by kislinsk).
Fix view IDs in MITKPluginGeneralManualsList
Oct 12 2020, 9:22 AM
kislinsk committed rMITKff7d74aa8123: Fix view IDs (authored by kislinsk).
Fix view IDs
Oct 12 2020, 9:22 AM
kislinsk closed T27844: CDash links to commits in phabricator seems not to work correctly as Resolved.

Done. @floca, if you do not agree, please reopen.

Oct 12 2020, 9:22 AM · Restricted Project, Restricted Project, MITK
kislinsk added a comment to T27844: CDash links to commits in phabricator seems not to work correctly.

I looked into the CDash script and to basically "swap" the primary repository would induce many many new lines of code. Hence, I vote for "let's always keep MITK as primary repository that reports its revision but change the CDash settings to the MITK repository instead of the MITK extension's repository". Tl;dr: Make the revision links work in the web UI but they will always link to MITK, not an MITK extension.

Oct 12 2020, 9:19 AM · Restricted Project, Restricted Project, MITK
kompan triaged T27847: [MITKDoc] Chart Example view documentation as Low priority.
Oct 12 2020, 9:02 AM · Moved to git.dkfz.de, MITK (v2024.12)