I think the only reason that they are not part of the release installers is simply that they are not enabled in the WorkbenchRelease build configuration. The actual todo is to specify what CLI apps we want to include I guess.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 24 2020
Nov 23 2020
🤞
Changes in header files: git diff -U0 ff0027ee 8e328dab *.h > output.txt
Let's see if the Nightly installers tomorrow morning are able to load Sarah's DICOM files. 🤞
Deleted branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.
Pushed new branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.
Everything you need to know about the DICOM dictionaries and how DCMTK is handling them is described here: https://github.com/InsightSoftwareConsortium/DCMTK/blob/master/dcmdata/docs/datadict.txt
Verified on macOS. I downloaded the dictionary and exported DCMDICTPATH. The MITK Workbench was able to load the DICOM files correctly afterwards. 🎉
I made the variable thread-safe by making it an atomic.
Deleted branch bugfix/T28001-FixRESTClientTest.
Pushed new branch bugfix/T28001-FixRESTClientTest.
Deleted branch bugfix/T27999-RemovePhotoacoustics.
Pushed new branch bugfix/T27999-RemovePhotoacoustics.
Removed modules:
- mitkBiophotonics
- MitkBiophotonicsHardware
- MitkSpectroCam
- MitkPhotoacousticsAlgorithms
- MitkPhotoacousticsHardware
- MitkPhotoacousticsLib
- MitkUSHardwareDiPhAS
Deleted branch feature/T27985-TinyXML-2.
It was released a few days before we put our new server in production mode and I already tested it back then but unfortunately already the installation went everything but smooth. So we should give it at least a few more months to mature before we try to upgrade. :-)
Feature branch. :)
I can confirm this patches fixes the problem. @kislinsk : hotfix oder feature branch?
diff --git a/Rendering/FreeType/vtkFreeTypeTools.cxx b/Rendering/FreeType/vtkFreeTypeTools.cxx index c54289dc60..03b899c4da 100644 --- a/Rendering/FreeType/vtkFreeTypeTools.cxx +++ b/Rendering/FreeType/vtkFreeTypeTools.cxx @@ -378,8 +378,7 @@ FTC_CMapCache* vtkFreeTypeTools::GetCMapCache() }
The missing DCMTK dictionary in Linux and macOS installers seems to be the actual issue for some other tickets as well. We recently experienced this again with DICOM files from @s429r. Loading works on Windows in both build and installer versions, but only in build versions on Linux and macOS.
Possibly related to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Maybe this is related to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Possibly as duplicate of T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers. There's a workaround in the task that you could use to verify if it is the same issue.
Added T26164 as subtask for now, as it is probably the same issue (missing DCMTK dictionary).
I do not activly work on that issue.
Nov 22 2020
Pushed new branch feature/T27985-TinyXML-2.
Deleted branch feature/T27985-TinyXML-2.
I created experimental CI jobs for the branch above: https://cdash.mitk.org/index.php?project=MITK&date=2020-11-22
Pushed new branch feature/T27985-TinyXML-2.