Page MenuHomePhabricator
Feed All Stories

Nov 24 2020

holzwart raised the priority of T28005: General Code Review from Wishlist to Normal.
Nov 24 2020, 8:23 AM
holzwart triaged T28005: General Code Review as Wishlist priority.
Nov 24 2020, 8:23 AM

Nov 23 2020

kislinsk added a comment to T27992: Release of MITK CLIs.

I think the only reason that they are not part of the release installers is simply that they are not enabled in the WorkbenchRelease build configuration. The actual todo is to specify what CLI apps we want to include I guess.

Nov 23 2020, 11:42 PM · MITK (v2021.02), Request for Discussion
kislinsk triaged T28002: MITK cannot handle CMake target namespaces in module and plugin package dependencies as Unbreak Now! priority.
Nov 23 2020, 11:35 PM · Noteworthy, MITK (v2021.02)
floca added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

🤞

Nov 23 2020, 11:24 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

Changes in header files: git diff -U0 ff0027ee 8e328dab *.h > output.txt

Nov 23 2020, 11:15 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Let's see if the Nightly installers tomorrow morning are able to load Sarah's DICOM files. 🤞

Nov 23 2020, 11:03 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Deleted branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.

Nov 23 2020, 11:01 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITK5e254ee7298e: Always use built-in DICOM dictionaries (authored by kislinsk).
Always use built-in DICOM dictionaries
Nov 23 2020, 11:00 PM
kislinsk committed rMITKfa2b431b38e4: Merge branch 'bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries' into develop (authored by kislinsk).
Merge branch 'bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries' into develop
Nov 23 2020, 11:00 PM
kislinsk added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Pushed new branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.

Nov 23 2020, 10:59 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Everything you need to know about the DICOM dictionaries and how DCMTK is handling them is described here: https://github.com/InsightSoftwareConsortium/DCMTK/blob/master/dcmdata/docs/datadict.txt

Nov 23 2020, 10:55 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Verified on macOS. I downloaded the dictionary and exported DCMDICTPATH. The MITK Workbench was able to load the DICOM files correctly afterwards. 🎉

Nov 23 2020, 10:40 PM · Cleared, MITK (v2021.02)
kislinsk closed T28001: Fix mitkRESTClientTest as Resolved.

I made the variable thread-safe by making it an atomic.

Nov 23 2020, 10:31 PM · MITK
kislinsk added a comment to T28001: Fix mitkRESTClientTest.

Deleted branch bugfix/T28001-FixRESTClientTest.

Nov 23 2020, 10:30 PM · MITK
kislinsk committed rMITK236c4a1ee0a4: Make counter variable thread-safe (authored by kislinsk).
Make counter variable thread-safe
Nov 23 2020, 10:30 PM
kislinsk committed rMITK13c4a5937ef9: Merge branch 'bugfix/T28001-FixRESTClientTest' into develop (authored by kislinsk).
Merge branch 'bugfix/T28001-FixRESTClientTest' into develop
Nov 23 2020, 10:30 PM
kislinsk added a comment to T28001: Fix mitkRESTClientTest.

Pushed new branch bugfix/T28001-FixRESTClientTest.

Nov 23 2020, 10:30 PM · MITK
kislinsk triaged T28001: Fix mitkRESTClientTest as Normal priority.
Nov 23 2020, 10:28 PM · MITK
kislinsk added a project to T27999: Remove Biophotonics and Photo Acoustics from MITK: Noteworthy.
Nov 23 2020, 9:36 PM · Noteworthy, MITK
kislinsk closed T27999: Remove Biophotonics and Photo Acoustics from MITK as Resolved.
Nov 23 2020, 9:32 PM · Noteworthy, MITK
kislinsk added a comment to T27999: Remove Biophotonics and Photo Acoustics from MITK.

Deleted branch bugfix/T27999-RemovePhotoacoustics.

Nov 23 2020, 9:32 PM · Noteworthy, MITK
kislinsk committed rMITKcb17cca5ef28: Remove Biophotonics and Photoacoustics (authored by kislinsk).
Remove Biophotonics and Photoacoustics
Nov 23 2020, 9:31 PM
kislinsk committed rMITKfc048ef737a2: Merge branch 'bugfix/T27999-RemovePhotoacoustics' into develop (authored by kislinsk).
Merge branch 'bugfix/T27999-RemovePhotoacoustics' into develop
Nov 23 2020, 9:31 PM
kislinsk added a comment to T27999: Remove Biophotonics and Photo Acoustics from MITK.

Pushed new branch bugfix/T27999-RemovePhotoacoustics.

Nov 23 2020, 9:30 PM · Noteworthy, MITK
kislinsk renamed T27999: Remove Biophotonics and Photo Acoustics from MITK from Remove Photo Acoustics from MITK to Remove Biophotonics and Photo Acoustics from MITK.
Nov 23 2020, 9:26 PM · Noteworthy, MITK
kislinsk added a comment to T27999: Remove Biophotonics and Photo Acoustics from MITK.

Removed modules:

  • mitkBiophotonics
  • MitkBiophotonicsHardware
    • MitkSpectroCam
  • MitkPhotoacousticsAlgorithms
  • MitkPhotoacousticsHardware
  • MitkPhotoacousticsLib
  • MitkUSHardwareDiPhAS
Nov 23 2020, 9:25 PM · Noteworthy, MITK
kislinsk added a project to T27985: Migrate from TinyXML to TinyXML-2: Noteworthy.
Nov 23 2020, 8:42 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27985: Migrate from TinyXML to TinyXML-2, a subtask of T27383: Update external toolkits, as Resolved.
Nov 23 2020, 8:41 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27985: Migrate from TinyXML to TinyXML-2 as Resolved.
Nov 23 2020, 8:41 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

Deleted branch feature/T27985-TinyXML-2.

Nov 23 2020, 8:41 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK2777a68ac317: Fix ambiguous overloads (authored by kislinsk).
Fix ambiguous overloads
Nov 23 2020, 8:39 PM
kislinsk committed rMITKac364ef387c2: Migrate from TinyXML v2.6.2 to TinyXML-2 v8.0.0 (authored by kislinsk).
Migrate from TinyXML v2.6.2 to TinyXML-2 v8.0.0
Nov 23 2020, 8:39 PM
kislinsk committed rMITKbdd8cd4c8a73: Fix unused variable (authored by kislinsk).
Fix unused variable
Nov 23 2020, 8:39 PM
kislinsk committed rMITK97f944d5726a: Fix unused variables (authored by kislinsk).
Fix unused variables
Nov 23 2020, 8:39 PM
kislinsk committed rMITK87fa18f83d65: Fix ambiguous overload (authored by kislinsk).
Fix ambiguous overload
Nov 23 2020, 8:39 PM
kislinsk committed rMITK5937c1877f5b: Fix ambiguous overloads (authored by kislinsk).
Fix ambiguous overloads
Nov 23 2020, 8:39 PM
kislinsk committed rMITKc7eb53960544: Fix unambiguous overloads (authored by kislinsk).
Fix unambiguous overloads
Nov 23 2020, 8:39 PM
kislinsk committed rMITK930102f33812: Fix comparison of serialized calibrations (authored by kislinsk).
Fix comparison of serialized calibrations
Nov 23 2020, 8:39 PM
kislinsk committed rMITK19171bc36c65: Fix missing cast (authored by kislinsk).
Fix missing cast
Nov 23 2020, 8:39 PM
kislinsk committed rMITKab268348e582: Fix ContourModelSetWriter and repair flawed XML files before parsing in… (authored by kislinsk).
Fix ContourModelSetWriter and repair flawed XML files before parsing in…
Nov 23 2020, 8:39 PM
kislinsk committed rMITKc22b17fe7f7b: Fix and optimize writing of boolean attributes (authored by kislinsk).
Fix and optimize writing of boolean attributes
Nov 23 2020, 8:39 PM
kislinsk committed rMITKf58fbd0569d6: Fix logic error (authored by kislinsk).
Fix logic error
Nov 23 2020, 8:39 PM
kislinsk committed rMITK761a39df5cdf: Ignore navigation data XML tag name (authored by kislinsk).
Ignore navigation data XML tag name
Nov 23 2020, 8:39 PM
kislinsk committed rMITKb3df67fa0c69: Remove last TinyXML remnants (authored by kislinsk).
Remove last TinyXML remnants
Nov 23 2020, 8:39 PM
kislinsk committed rMITK125db9d4aa17: Fix uninitialized array (authored by kislinsk).
Fix uninitialized array
Nov 23 2020, 8:39 PM
kislinsk committed rMITK8e328dab075b: Merge branch 'feature/T27985-TinyXML-2' into develop (authored by kislinsk).
Merge branch 'feature/T27985-TinyXML-2' into develop
Nov 23 2020, 8:39 PM
j562r committed rNNCC812702389814: Update graph score notebooks (authored by j562r).
Update graph score notebooks
Nov 23 2020, 7:52 PM
j562r committed rNNCC3f6303eceb54: Add score differences box plot (authored by j562r).
Add score differences box plot
Nov 23 2020, 7:52 PM
j562r committed rNNCCe379c5a6f8d5: Use .env file for environment variables (authored by j562r).
Use .env file for environment variables
Nov 23 2020, 7:52 PM
j562r committed rNNCC88c5ce89f0ae: Improve graph score analysis (authored by j562r).
Improve graph score analysis
Nov 23 2020, 7:52 PM
j562r committed rNNCC787db8a74096: Add times new roman font to Docker container (authored by j562r).
Add times new roman font to Docker container
Nov 23 2020, 7:52 PM
kislinsk closed T27959: MITK with VTK 9 fails on Fedora CI clients as Resolved.
Nov 23 2020, 7:49 PM · MITK
nolden committed rMITKff0027eee2cb: Patch VTK to fix Freetype build error on GCC 10 (authored by nolden).
Patch VTK to fix Freetype build error on GCC 10
Nov 23 2020, 5:39 PM
nolden committed rMITK3ee32df042fb: Patch VTK to fix Freetype build error on GCC 10 (authored by nolden).
Patch VTK to fix Freetype build error on GCC 10
Nov 23 2020, 5:38 PM
kislinsk added a revision to T27959: MITK with VTK 9 fails on Fedora CI clients: Unknown Object (Differential Revision).
Nov 23 2020, 5:38 PM · MITK
kislinsk triaged T28000: MITK v2021.02 as Normal priority.
Nov 23 2020, 5:13 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk triaged T27999: Remove Biophotonics and Photo Acoustics from MITK as Normal priority.
Nov 23 2020, 5:12 PM · Noteworthy, MITK
kislinsk added a comment to T27995: Upgrade CDash to 3.0.

It was released a few days before we put our new server in production mode and I already tested it back then but unfortunately already the installation went everything but smooth. So we should give it at least a few more months to mature before we try to upgrade. :-)

Nov 23 2020, 5:05 PM · CI, MITK
kislinsk added a comment to T27959: MITK with VTK 9 fails on Fedora CI clients.

Feature branch. :)

Nov 23 2020, 5:02 PM · MITK
eisenman created T27998: Interpretation of consensus ranking values needs further explanation.
Nov 23 2020, 3:19 PM · challengeR (v1.0)
eisenman moved T27996: Restructure troubleshooting section from In Progress to Done on the challengeR (v1.0) board.
Nov 23 2020, 3:00 PM · challengeR (v1.0)
eisenman committed rCHALLENGER0b2f008acf09: Merge branch 'feature/T27996-RestructureTroubleshootingSection' into develop (authored by eisenman).
Merge branch 'feature/T27996-RestructureTroubleshootingSection' into develop
Nov 23 2020, 2:56 PM
eisenman committed rCHALLENGERa4fe647120df: Restructure troubleshooting section (authored by eisenman).
Restructure troubleshooting section
Nov 23 2020, 2:55 PM
eisenman moved T27996: Restructure troubleshooting section from Backlog to In Progress on the challengeR (v1.0) board.
Nov 23 2020, 2:53 PM · challengeR (v1.0)
eisenman created T27996: Restructure troubleshooting section.
Nov 23 2020, 2:53 PM · challengeR (v1.0)
nolden triaged T27995: Upgrade CDash to 3.0 as Wishlist priority.
Nov 23 2020, 2:04 PM · CI, MITK
nolden added a comment to T27959: MITK with VTK 9 fails on Fedora CI clients.

I can confirm this patches fixes the problem. @kislinsk : hotfix oder feature branch?

Nov 23 2020, 1:49 PM · MITK
nolden added a comment to T27959: MITK with VTK 9 fails on Fedora CI clients.
diff --git a/Rendering/FreeType/vtkFreeTypeTools.cxx b/Rendering/FreeType/vtkFreeTypeTools.cxx
index c54289dc60..03b899c4da 100644
--- a/Rendering/FreeType/vtkFreeTypeTools.cxx
+++ b/Rendering/FreeType/vtkFreeTypeTools.cxx
@@ -378,8 +378,7 @@ FTC_CMapCache* vtkFreeTypeTools::GetCMapCache()
 }
Nov 23 2020, 1:34 PM · MITK
wiesenfa claimed T27971: Provide code for podium plot in vignette "Visualizations".
Nov 23 2020, 12:08 PM · challengeR (v1.0)
wiesenfa claimed T27963: Task names printed as R output in Sec. 3.1 of multi-task report.
Nov 23 2020, 12:07 PM · challengeR (v1.0)
kislinsk raised the priority of T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers from High to Unbreak Now!.
Nov 23 2020, 11:57 AM · Cleared, MITK (v2021.02)
kislinsk updated subscribers of T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

The missing DCMTK dictionary in Linux and macOS installers seems to be the actual issue for some other tickets as well. We recently experienced this again with DICOM files from @s429r. Loading works on Windows in both build and installer versions, but only in build versions on Linux and macOS.

Nov 23 2020, 11:52 AM · Cleared, MITK (v2021.02)
kislinsk added a subtask for T24398: Dicom plugin: Retrieve does not work: T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Nov 23 2020, 11:50 AM · MITK (v2024.06)
kislinsk added a parent task for T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers: T24398: Dicom plugin: Retrieve does not work.
Nov 23 2020, 11:50 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T24398: Dicom plugin: Retrieve does not work.

Possibly related to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Nov 23 2020, 11:50 AM · MITK (v2024.06)
kislinsk added a subtask for T27696: Dicom loading does not work for some 4D data with the latest installer: T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Nov 23 2020, 11:48 AM · DICOM, Missing Info, MITK
kislinsk added a parent task for T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers: T27696: Dicom loading does not work for some 4D data with the latest installer.
Nov 23 2020, 11:48 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27696: Dicom loading does not work for some 4D data with the latest installer.

Maybe this is related to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Nov 23 2020, 11:48 AM · DICOM, Missing Info, MITK
kislinsk added a parent task for T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers: T27669: Dicom import issue with MITK binaries (package) and Ubuntu.
Nov 23 2020, 11:48 AM · Cleared, MITK (v2021.02)
kislinsk added a subtask for T27669: Dicom import issue with MITK binaries (package) and Ubuntu: T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Nov 23 2020, 11:48 AM · Missing Info, DICOM, MITK
kislinsk added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

Possibly as duplicate of T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers. There's a workaround in the task that you could use to verify if it is the same issue.

Nov 23 2020, 11:47 AM · Missing Info, DICOM, MITK
kislinsk added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Added T26164 as subtask for now, as it is probably the same issue (missing DCMTK dictionary).

Nov 23 2020, 11:45 AM · MITK
kislinsk added a parent task for T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers: T26451: DICOM plugin cannot parse DICOM directories in macOS installer.
Nov 23 2020, 11:44 AM · Cleared, MITK (v2021.02)
kislinsk added a subtask for T26451: DICOM plugin cannot parse DICOM directories in macOS installer: T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Nov 23 2020, 11:44 AM · MITK
eisenman moved T27930: Revise examples given in the vignettes from In Progress to Done on the challengeR (v1.0) board.
Nov 23 2020, 10:53 AM · challengeR (v1.0)
eisenman committed rCHALLENGERc8c08e6545b8: Merge branch 'feature/T27930-ReviseDocumentation' into develop (authored by eisenman).
Merge branch 'feature/T27930-ReviseDocumentation' into develop
Nov 23 2020, 10:53 AM
eisenman committed rCHALLENGER89654d3c7eb6: Revise quickstart guide (authored by eisenman).
Revise quickstart guide
Nov 23 2020, 10:51 AM
eisenman committed rCHALLENGERb7f777620193: Remove overview as it is redundant to the README and the Roxygen documentation… (authored by eisenman).
Remove overview as it is redundant to the README and the Roxygen documentation…
Nov 23 2020, 10:51 AM
floca triaged T27992: Release of MITK CLIs as High priority.
Nov 23 2020, 9:53 AM · MITK (v2021.02), Request for Discussion
floca placed T27974: Sarah requires an MITK installer containing the mitk file converter up for grabs.

I do not activly work on that issue.

Nov 23 2020, 9:00 AM · Missing Info, MITK

Nov 22 2020

m113r closed T27986: Check case metrics as Resolved.
Nov 22 2020, 8:23 PM · m113r
floca updated the task description for T27568: US 2D image cannot be read: invalid tilt information.
Nov 22 2020, 5:54 PM · Restricted Project, MITK
m113r created T27986: Check case metrics.
Nov 22 2020, 2:02 PM · m113r
kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

Pushed new branch feature/T27985-TinyXML-2.

Nov 22 2020, 7:29 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

Deleted branch feature/T27985-TinyXML-2.

Nov 22 2020, 7:29 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

I created experimental CI jobs for the branch above: https://cdash.mitk.org/index.php?project=MITK&date=2020-11-22

Nov 22 2020, 2:25 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27985: Migrate from TinyXML to TinyXML-2.

Pushed new branch feature/T27985-TinyXML-2.

Nov 22 2020, 2:07 AM · Noteworthy, MITK (v2021.02)
kislinsk triaged T27985: Migrate from TinyXML to TinyXML-2 as Normal priority.
Nov 22 2020, 1:55 AM · Noteworthy, MITK (v2021.02)

Nov 20 2020

kislinsk edited the content of 2020 Week 47 (Mid November).
Nov 20 2020, 4:51 PM