Will be done together with T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep.

@floca I could only find two tasks mentioned here that are not closed, T27872 and T27684, but they are unrelated to the task description. Can this task be closed?

Maybe something to keep an eye on: T28478 and https://github.com/InsightSoftwareConsortium/ITK/tree/master/Modules/ThirdParty/DCMTK

Thanks for the clarification. I agree 100%.

Don't get me wrong - I'm not saying that you or someone "verschlimmbesserte" anything :D I understand and appreciate all the effort that has been made by you.
I am more thinking of a different approach architecture wise - you already mentioned "abstraction levels". For me it seems as if different classes and functions are on the same "level" of doing something but they do it differently - which makes it even harder to grasp the logic behind it. That's why I mentioned "class diagrams". Also, often classes and functions are way too overloaded (e.g. SegTool2D) with way too many responsibilities.

In T28131#223675, @kalali wrote:

Ok I have to admit: The whole code base that is related to this topic is totally unclear to me and I find it very hard to understand what is going on.[...]

Told you so. ;) As proposed we can have a session together.

Ok I have to admit: The whole code base that is related to this topic is totally unclear to me and I find it very hard to understand what is going on. I don't know why the code is like that but I would highly suggest to simplify and clean the relevant classes and functions as much as possible before it becomes problematic (e.g. more complex cases with 4D-dynamic segmentations with multi-layer multi-label segmentation masks or similar). Also, I highly doubt that this is future proof when it comes to changes in the following years so as already mentioned in my last comment: I think we really need to discuss this topic - maybe it helps to have a clearer picture by creating (class) diagrams with relations etc.

Thanks for the clarification. I will look into the FeedbackCntourTool and ContourModelUtils and see if I can make sense of all this :D
Depending on what I find out I think we should really talk about the future of the (multilabel) segmentation modules / plugins and how we can simplify the code base (generalize it) and remove redundancy as well as decouple classes etc.

In T28206#223651, @kalali wrote:

With the changes in T28211 @floca mentioned,

You meen T28221, don't you?

Great you are looking into that matter.
The problem is caused by mitk::AutoSegmentationWithPreviewTool::TransferImageAtTimeStep() more precisely in the private helper template function ITKSetVolume (same cpp).

I am not sure what is exactly done here to reproduce. To get any help page I have to click on a plugin anyway. How would I provoke a blank page?
When I use F1 while the Standard Display is activated I get a blank page for the Standard Display. If that's what is meant than we need to reconsider how to display this specific help page: There is a description of the "four window view" inside src\Plugins\org.mitk.gui.qt.ext\documentation\UserManual\MITKUserManual.dox but we can not move it to the stdmultiwidgeteditor-plugin as it contains more information about the workbench, not only about the standard display.

I tried to reproduce this issue and found the following:
With the changes in T28211 @floca mentioned, there is no legend anymore m_Controls.chartWidget->SetShowLegend(false);
Showing this legend again displays "histogram" as the label name - not even the original segmentation node name. Now when I add another segmentation and add it to the statistics, the histogram is completely removed (it's calculated but the widget does not provide any space for the histogram anymore).

@floca I sarted looking into this and found out the following:
The threshold tool used is QmitkBinaryThresholdToolGUIBase, which is a subclass of QmitkAutoSegmentationToolGUIBase. This class uses the AutoSegmentationTool, a subclass of the mitkTool. As far as I can see the target node that will be connected with this tool upon activating the tool is done inside mitk::AutoSegmentationTool::GetTargetSegmentationNode().
However, there is no information about any layer or even the information that this can be used with multilabel segmentation nodes.

Let me know if you got hold of it.

Deleted branch from rMITK MITK: release/T28473-2021-Week-17.

Pushed new branch to rMITK MITK: release/T28473-2021-Week-17.

Deleted branch from rMITK MITK: feature/T28118-Refactor_SegTool2D_and_derived_classes.

@floca Please delete the feature branch mentioned above if this task is resolved.

Deleted branch from rMITK MITK: bugfix/T28437-RegionGrowing3DSeedPoint0.

The task as such is resolved. Another task with open questions from D279 is created with T28466

Fixed the task policy :D Did you get acces to it ?

@eisenman the change in develop branch has not been uploaded to GitHub, is this not automatically synchronized?. So the user who reported the bug still has the same problem. It would be good to merge into master as well

In T27437#223356, @al-sabr wrote:

Can this also be matched with this other task I created?

https://phabricator.mitk.org/T28454

I only need help in one place if that part is cleared then I already refactored the Core to reflect the changes suitable for version 3.6.0 of CppMicroServices.

I will put this up for grabs as it does not make sense to start a new project now. Personally I will investigate further after the Conan evaluation report has been written.