Page MenuHomePhabricator
Feed All Stories

Jun 3 2022

kalali added a parent task for T29200: Completely remove QmitkFunctionality: T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Jun 3 2022, 9:04 AM · MITK (v2022.10), Breaking Change
kalali added a subtask for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor): T29200: Completely remove QmitkFunctionality.
Jun 3 2022, 9:04 AM · MITK (v2022.10)
a178n triaged T29202: Update doku for pretrained model download as Normal priority.
Jun 3 2022, 8:56 AM · MITK (v2022.10)
a178n triaged T29201: Update checklist for pretrained model download as Normal priority.
Jun 3 2022, 8:55 AM · MITK (v2022.10)
kalali triaged T29200: Completely remove QmitkFunctionality as Normal priority.
Jun 3 2022, 8:54 AM · MITK (v2022.10), Breaking Change
a178n triaged T29199: Move model download to a different thread. as Normal priority.
Jun 3 2022, 8:53 AM · MITK (v2022.10)
a178n added a comment to T29187: Add GUI elements to parse and show available models.

However, the implementation showed that it could take quite a long to download, depending on the model size. Hence, this should happen in a different thread.

Jun 3 2022, 8:51 AM · MITK (v2022.10)
a178n added a comment to T29187: Add GUI elements to parse and show available models.

A new combo box and button were added in the "Advanced" section. This combo box listed all available models for download, reading the JSON file.
The download button goes ahead & downloads the model and keeps it in the results folder location, in a valid way. No extra effort is required from the user.

Jun 3 2022, 8:49 AM · MITK (v2022.10)

Jun 2 2022

amiiney updated the task description for T29166: GSP: EndoCV detection challenge.
Jun 2 2022, 9:30 PM · Restricted Project
kislinsk closed T29189: Software crashes when launching python console as Wontfix.

Thank you for the report. The Python plugin is labeled as experimental and is not used by us anymore since quite some time now. We don't recommend to use it anymore.

Jun 2 2022, 8:59 PM · MITK
kalali updated the task description for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Jun 2 2022, 6:06 PM · MITK (v2022.10)
kalali added a revision to T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView: Unknown Object (Differential Revision).
Jun 2 2022, 6:06 PM · MITK (v2022.10)
kalali added a comment to T29197: [Segmentation] Is the classificationsegmentation-plugin used / required?.

I tried clicking different buttons and crashes happen regularly.

Jun 2 2022, 5:58 PM · MITK (v2024.06), Request for Discussion
kalali moved T29197: [Segmentation] Is the classificationsegmentation-plugin used / required? from Backlog to Segmentation on the MITK (v2022.10) board.
Jun 2 2022, 5:52 PM · MITK (v2024.06), Request for Discussion
kalali triaged T29197: [Segmentation] Is the classificationsegmentation-plugin used / required? as Normal priority.
Jun 2 2022, 5:52 PM · MITK (v2024.06), Request for Discussion
kislinsk added a comment to T29195: Fix FlowBench argument parsing and icon resource access.

Deleted branch from rMITK MITK: bugfix/T29195-FixFlowBenchArgParsingAndIconLoading.

Jun 2 2022, 4:00 PM · MITK
kislinsk committed rMITK5936329a056b: Replace manual argument parsing with app config access (authored by kislinsk).
Replace manual argument parsing with app config access
Jun 2 2022, 3:59 PM
kislinsk committed rMITK97d21e25491f: Fix dependencies to have access to necessary resources and icons (authored by kislinsk).
Fix dependencies to have access to necessary resources and icons
Jun 2 2022, 3:59 PM
kislinsk committed rMITKa3f5676ce09e: Remove unused code path (authored by kislinsk).
Remove unused code path
Jun 2 2022, 3:59 PM
kislinsk committed rMITKc6183651ff3c: Fix FlowBench argument parsing and icon resource access (authored by kislinsk).
Fix FlowBench argument parsing and icon resource access
Jun 2 2022, 3:59 PM
kislinsk closed T29195: Fix FlowBench argument parsing and icon resource access as Resolved by committing rMITKc6183651ff3c: Fix FlowBench argument parsing and icon resource access.
Jun 2 2022, 3:59 PM · MITK
kalali claimed T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView.
Jun 2 2022, 3:20 PM · MITK (v2022.10)
kalali updated the task description for T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView.
Jun 2 2022, 3:19 PM · MITK (v2022.10)
floca added a comment to T25725: "Show in" action is currently not implemented.

@floca Did you test the differential in the Workbench? Actually I was just implementing this feature witch was there for many years but never functioning. It was never of any use since we only had a single rendering display. What I realized, though: the use is barely existing, since you can only "send" a node to a render display / multi widget. But the StdMultiWidget displays the nodes anyway and the mxnMultiWidget should be controllered differently, right (since you only send the node to the whole multi widget, not to a single render window)?
So I can land the changes but I'm also fine with removing the feature entirely, eventually.

Jun 2 2022, 3:13 PM · MITK (v2022.10)
kislinsk added a revision to T29195: Fix FlowBench argument parsing and icon resource access: Unknown Object (Differential Revision).
Jun 2 2022, 2:19 PM · MITK
kislinsk added a comment to T29195: Fix FlowBench argument parsing and icon resource access.

Pushed new branch to rMITK MITK: bugfix/T29195-FixFlowBenchArgParsingAndIconLoading.

Jun 2 2022, 2:17 PM · MITK
kislinsk triaged T29195: Fix FlowBench argument parsing and icon resource access as Normal priority.
Jun 2 2022, 2:14 PM · MITK
a178n added a comment to T29187: Add GUI elements to parse and show available models.

Pushed new branch to rMITK MITK: feature/T29187-nnunet-show-download-models.

Jun 2 2022, 2:14 PM · MITK (v2022.10)
kalali reopened T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView, a subtask of T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), as Open.
Jun 2 2022, 1:04 PM · MITK (v2022.10)
kalali reopened T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView as "Open".
Jun 2 2022, 1:04 PM · MITK (v2022.10)
kalali updated the task description for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Jun 2 2022, 1:04 PM · MITK (v2022.10)
kalali added a parent task for T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView: T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Jun 2 2022, 1:04 PM · MITK (v2022.10)
kalali added a subtask for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor): T26547: Clarify difference between QmitkPointListViewWidget and QmitkPointListView.
Jun 2 2022, 1:04 PM · MITK (v2022.10)
j806e triaged T29194: Adapt annotation based simulations for current SIMPA as Normal priority.
Jun 2 2022, 12:49 PM · Photoacoustics
kalali moved T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor) from Backlog to mxn MultiWidget on the MITK (v2022.10) board.
Jun 2 2022, 12:37 PM · MITK (v2022.10)
kalali edited projects for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), added: MITK (v2022.10); removed Restricted Project, MITK.
Jun 2 2022, 12:37 PM · MITK (v2022.10)
kalali added a subtask for T25595: [Multi widget] Make classes work with the new render window access: T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.
Jun 2 2022, 12:34 PM · MITK (v2024.06)
kalali added a parent task for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: T25595: [Multi widget] Make classes work with the new render window access.
Jun 2 2022, 12:34 PM · Breaking Change, Noteworthy, MITK
kalali moved T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations from Backlog to MITK Meeting on the Request for Discussion board.
Jun 2 2022, 12:26 PM · Breaking Change, Noteworthy, MITK
kalali reopened T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations as "Open".
Jun 2 2022, 12:26 PM · Breaking Change, Noteworthy, MITK
kalali updated subscribers of T25725: "Show in" action is currently not implemented.

@floca Did you test the differential in the Workbench? Actually I was just implementing this feature witch was there for many years but never functioning. It was never of any use since we only had a single rendering display. What I realized, though: the use is barely existing, since you can only "send" a node to a render display / multi widget. But the StdMultiWidget displays the nodes anyway and the mxnMultiWidget should be controllered differently, right (since you only send the node to the whole multi widget, not to a single render window)?
So I can land the changes but I'm also fine with removing the feature entirely, eventually.

Jun 2 2022, 11:48 AM · MITK (v2022.10)
kalali closed T27197: [Selection concept] Data storage inspector icons shift in node selection dialog as Wontfix.

I realized that this only happens for the second, third ... tab icon. Even if you change the order / number of tabs (and e.g. have the "Rendering tree" icon as the first icon tab) the first tab icon does not move. So I guess this is a Qt-issue and I would not deem this important enough, since this is barely visible and nondisruptive.

Jun 2 2022, 11:32 AM · MITK
kislinsk added a comment to T29158: [Segmentation] Custom list for optional label names.

Deleted branch from rMITK MITK: feature/T29158-CustomLabelSuggestions.

Jun 2 2022, 11:27 AM · MITK (v2022.10)
kislinsk added a comment to T29158: [Segmentation] Custom list for optional label names.

Deleted branch from rMITK MITK: feature/T29158-OptionallyAskForLabelNamesAndColors.

Jun 2 2022, 11:27 AM · MITK (v2022.10)
kislinsk committed rMITKd3a08fcf3715: Follow one definition rule (authored by kislinsk).
Follow one definition rule
Jun 2 2022, 11:26 AM
kislinsk committed rMITK574b951f12cf: Add preference for default label naming (authored by kislinsk).
Add preference for default label naming
Jun 2 2022, 11:26 AM
kislinsk committed rMITKb9e617d137ba: Optionally intervene default label naming with prompt (authored by kislinsk).
Optionally intervene default label naming with prompt
Jun 2 2022, 11:26 AM
kislinsk committed rMITK76ee5489fa88: Add command-line argument for label suggestions (authored by kislinsk).
Add command-line argument for label suggestions
Jun 2 2022, 11:26 AM
kislinsk committed rMITK9e86b53e0ac7: Set standard label suggestions internally (authored by kislinsk).
Set standard label suggestions internally
Jun 2 2022, 11:26 AM
kislinsk committed rMITKad284e0386a5: Add preferences for custom label name and color suggestions (authored by kislinsk).
Add preferences for custom label name and color suggestions
Jun 2 2022, 11:26 AM
kislinsk committed rMITK45205c38c0e8: Modernize QmitkNewSegmentationDialog (authored by kislinsk).
Modernize QmitkNewSegmentationDialog
Jun 2 2022, 11:26 AM
kislinsk committed rMITK97516d76ae36: Also adapt label text in RenameLabel mode (authored by kislinsk).
Also adapt label text in RenameLabel mode
Jun 2 2022, 11:26 AM
kislinsk committed rMITK45ebb5c40086: Disable default label naming when label suggestions are enforced (authored by kislinsk).
Disable default label naming when label suggestions are enforced
Jun 2 2022, 11:26 AM
kislinsk committed rMITK5d1b8fa64660: Allow custom label name and color suggestions (authored by kislinsk).
Allow custom label name and color suggestions
Jun 2 2022, 11:26 AM
kislinsk committed rMITKd020f050d7bd: Fix newly introduced copy & paste error (authored by kislinsk).
Fix newly introduced copy & paste error
Jun 2 2022, 11:26 AM
kislinsk committed rMITK193befc69858: Optionally remove existing label names from label suggestions (authored by kislinsk).
Optionally remove existing label names from label suggestions
Jun 2 2022, 11:26 AM
kislinsk committed rMITK81e6846444e0: Add information about custom label suggestions to the user manual (authored by kislinsk).
Add information about custom label suggestions to the user manual
Jun 2 2022, 11:26 AM
kislinsk committed rMITK7366a123981d: Fix erroneous color value parsing (authored by kislinsk).
Fix erroneous color value parsing
Jun 2 2022, 11:26 AM
kislinsk committed rMITK1e329ab2dfb2: Rename variables (authored by kislinsk).
Rename variables
Jun 2 2022, 11:26 AM
kislinsk committed rMITK324954680f1c: Fix unused variable warning due to structured binding (authored by kislinsk).
Fix unused variable warning due to structured binding
Jun 2 2022, 11:26 AM
kislinsk committed rMITK5dd4ba85b7bc: Generalize description of label suggestions (authored by kislinsk).
Generalize description of label suggestions
Jun 2 2022, 11:26 AM
kislinsk closed T29158: [Segmentation] Custom list for optional label names as Resolved by committing rMITKa9242aa9966a: Allow custom label name and color suggestions.
Jun 2 2022, 11:26 AM · MITK (v2022.10)
kislinsk closed T29158: [Segmentation] Custom list for optional label names, a subtask of T29157: NCT ISSO Annotation Support with MITK Segmentation Flow, as Resolved.
Jun 2 2022, 11:26 AM · MITK (v2024.06)
kislinsk committed rMITKa9242aa9966a: Allow custom label name and color suggestions (authored by kislinsk).
Allow custom label name and color suggestions
Jun 2 2022, 11:26 AM
schellem added a comment to T29176: IMSY-Poster for "Arbeitsgruppeninspirationsmesse".

resolved :)

Jun 2 2022, 8:01 AM · Restricted Project

Jun 1 2022

floca updated the task description for T29160: [Segmentation] Worklist specification, data structure and io functions.
Jun 1 2022, 5:36 PM · MITK (v2022.10)
floca updated the task description for T29160: [Segmentation] Worklist specification, data structure and io functions.
Jun 1 2022, 5:34 PM · MITK (v2022.10)
floca updated subscribers of T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:23 PM · MITK (v2024.06)
floca added a parent task for T29193: [SEG] Add a superpixel tool: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:20 PM · MITK (v2024.06)
floca added a subtask for T29191: [SEG] New segmentation tool candidates: T29193: [SEG] Add a superpixel tool.
Jun 1 2022, 5:20 PM · MITK (v2024.06)
floca triaged T29193: [SEG] Add a superpixel tool as Normal priority.
Jun 1 2022, 5:19 PM · MITK (v2024.06)
floca added a parent task for T29192: [SEG] MONAI Label support in MITK Workbench: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:12 PM · MITK (v2024.06)
floca added a subtask for T29191: [SEG] New segmentation tool candidates: T29192: [SEG] MONAI Label support in MITK Workbench.
Jun 1 2022, 5:12 PM · MITK (v2024.06)
floca triaged T29192: [SEG] MONAI Label support in MITK Workbench as Normal priority.
Jun 1 2022, 5:12 PM · MITK (v2024.06)
floca added a parent task for T28406: [Segmentation] Examine Live-wire tool for different costfunctions/behavior: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:06 PM · MITK
floca added a parent task for T28464: [Segmentation] New Add/Remove tool: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:06 PM · MITK (v2022.10)
floca added subtasks for T29191: [SEG] New segmentation tool candidates: T28464: [Segmentation] New Add/Remove tool, T28406: [Segmentation] Examine Live-wire tool for different costfunctions/behavior, T28851: [SEG] Add ITK GrowCut as segmentation tool.
Jun 1 2022, 5:06 PM · MITK (v2024.06)
floca added a parent task for T28851: [SEG] Add ITK GrowCut as segmentation tool: T29191: [SEG] New segmentation tool candidates.
Jun 1 2022, 5:06 PM · MITK (v2022.10)
floca renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [Segmentation] Evaluate if we should add itkGrowCut as a tool to [SEG] Evaluate if we should add itkGrowCut as a tool.
Jun 1 2022, 5:06 PM · MITK (v2022.10)
floca triaged T29191: [SEG] New segmentation tool candidates as Normal priority.
Jun 1 2022, 5:03 PM · MITK (v2024.06)
kalali closed T29110: [Segmentation] Optimize new segmentation view as Resolved.
Jun 1 2022, 2:38 PM · MITK (v2022.10)
kislinsk added a revision to T29158: [Segmentation] Custom list for optional label names: Unknown Object (Differential Revision).
Jun 1 2022, 2:20 PM · MITK (v2022.10)
floca removed a project from T29077: [Segmentation] Showing / hiding labels using the labelsetwidget selects them: Request for Discussion.
Jun 1 2022, 1:51 PM · MITK (v2023.04), Checklist
kalali claimed T25725: "Show in" action is currently not implemented.
Jun 1 2022, 1:25 PM · MITK (v2022.10)
floca moved T25725: "Show in" action is currently not implemented from mxn MultiWidget to Cycle on the MITK (v2022.10) board.
Jun 1 2022, 1:20 PM · MITK (v2022.10)
kislinsk moved T29158: [Segmentation] Custom list for optional label names from Segmentation to Cycle on the MITK (v2022.10) board.
Jun 1 2022, 1:11 PM · MITK (v2022.10)
kalali moved T29163: [XNAT] Opening XNAT session fails from Backlog to Cycle on the MITK (v2022.10) board.
Jun 1 2022, 1:08 PM · MITK (v2024.06)
kalali edited projects for T29163: [XNAT] Opening XNAT session fails, added: MITK (v2022.10); removed MITK.
Jun 1 2022, 1:07 PM · MITK (v2024.06)
gaoh added a member for MIC: l597s.
Jun 1 2022, 12:52 PM
gaoh added a member for Kaapana (internal): l597s.
Jun 1 2022, 12:52 PM
holzwart closed T29176: IMSY-Poster for "Arbeitsgruppeninspirationsmesse" as Resolved.

Resolved?

Jun 1 2022, 12:42 PM · Restricted Project
kalali closed T25643: Context menu adds its default actions multiple times as Resolved.

However, this leads to the question why the global descriptors (singleton instance) are necessary in the first place. It was probably used to add local actions to the globally accessible node descriptors, e.g. from a custom plugin. So this task is closely related to T19752 and T25583.

Jun 1 2022, 10:14 AM · MITK (v2022.10)
kalali closed T25643: Context menu adds its default actions multiple times, a subtask of T25056: Refactor data manager context menu, as Resolved.
Jun 1 2022, 10:14 AM · MITK (v2024.06), Noteworthy

May 31 2022

kalali added a revision to T25725: "Show in" action is currently not implemented: Unknown Object (Differential Revision).
May 31 2022, 8:13 PM · MITK (v2022.10)
HOUJF triaged T29189: Software crashes when launching python console as High priority.
May 31 2022, 5:31 PM · MITK
kislinsk added a comment to T29158: [Segmentation] Custom list for optional label names.

I finished this task in feature/T29158-CustomLabelSuggestions. After a mental break I will go through the code and double-check for any business logic bugs or edge cases but I am confident. Will create a Diff later or tomorrow morning.

May 31 2022, 3:21 PM · MITK (v2022.10)
kalali added a comment to T26399: Workbench crash on simple tree model update.

I'm not sure if this is the reason (T24348: Invalid pointer exception due to invalid QModelIndex in QmitkDataStorageTreeModel) for the decision. I would go the route to deprecate the QmitkDataStorageModel and replace it with the QmitkDataStorageSimpleTreeModel.
However, the QmitkDataStorageSimpleTreeModel probably needs to be extended (e.g. dropping, changing hierarchy). Do we already have a task for this / should we tackle this in this release-phase?

This should be carefully discussed. I think some of the features QmitkDataStorageModel does not belong in a model.

May 31 2022, 12:19 PM · MITK, Request for Discussion
s349i added a comment to T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.

D657 should give surface interpolation multilablel functionality. Contour interpolation also partially.

May 31 2022, 11:15 AM · MITK (v2023.04), Restricted Project
kompan committed rMITK3dccb1356a35: Unit test for Descriptive Pharmacokinetic Brix Model. (authored by kompan).
Unit test for Descriptive Pharmacokinetic Brix Model.
May 31 2022, 10:32 AM
kompan committed rMITKf5ac852f1e9e: Unit test for Descriptive Pharmacokinetic Brix Model. (authored by kompan).
Unit test for Descriptive Pharmacokinetic Brix Model.
May 31 2022, 10:32 AM