Page MenuHomePhabricator
Feed All Stories

Sep 20 2022

kalali added a revision to T28851: [SEG] Add ITK GrowCut as segmentation tool: Restricted Differential Revision.
Sep 20 2022, 2:14 PM · MITK (v2022.10)
kislinsk closed T29305: Fix GDCM Globals issue with many MITK binaries as Resolved.
Sep 20 2022, 2:23 AM · MITK (v2022.10)
kislinsk added a comment to T29305: Fix GDCM Globals issue with many MITK binaries.

Deleted branch from rMITK MITK: bugfix/T29305-FixGDCMIssues.

Sep 20 2022, 2:22 AM · MITK (v2022.10)
kislinsk added a reverting change for rMITK7b40015a2c73: Use ITK's GDCM instead of separate GDCM: rMITK41939fd2a5d4: Revert "Use ITK's GDCM instead of separate GDCM".
Sep 20 2022, 2:22 AM
kislinsk committed rMITK41939fd2a5d4: Revert "Use ITK's GDCM instead of separate GDCM" (authored by kislinsk).
Revert "Use ITK's GDCM instead of separate GDCM"
Sep 20 2022, 2:22 AM
kislinsk committed rMITK7ea583973b1e: Upgrade GDCM from version 3.0.10 to 3.0.18 (authored by kislinsk).
Upgrade GDCM from version 3.0.10 to 3.0.18
Sep 20 2022, 2:22 AM
kislinsk committed rMITK54fc88f462dd: Downgrade GDCM from version 3.0.18 to 3.0.17 (authored by kislinsk).
Downgrade GDCM from version 3.0.18 to 3.0.17
Sep 20 2022, 2:22 AM
kislinsk committed rMITK0fa3a9b7684c: Downgrade GDCM to version 3.0.14 (authored by kislinsk).
Downgrade GDCM to version 3.0.14
Sep 20 2022, 2:22 AM
kislinsk committed rMITKea18963576a0: Merge branch 'bugfix/T29305-FixGDCMIssues' into develop (authored by kislinsk).
Merge branch 'bugfix/T29305-FixGDCMIssues' into develop
Sep 20 2022, 2:22 AM

Sep 19 2022

kislinsk added a revision to T29305: Fix GDCM Globals issue with many MITK binaries: Unknown Object (Differential Revision).
Sep 19 2022, 10:46 PM · MITK (v2022.10)
kislinsk added a reverting change for rMITK7b40015a2c73: Use ITK's GDCM instead of separate GDCM: Unknown Object (Differential Revision).
Sep 19 2022, 10:46 PM
kislinsk added a comment to T29305: Fix GDCM Globals issue with many MITK binaries.

Pushed new branch to rMITK MITK: bugfix/T29305-FixGDCMIssues.

Sep 19 2022, 10:43 PM · MITK (v2022.10)
kislinsk triaged T29305: Fix GDCM Globals issue with many MITK binaries as Unbreak Now! priority.
Sep 19 2022, 9:30 PM · MITK (v2022.10)
kalali claimed T29219: StatusBar / mouse scrolling is broken.
Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a comment to T29219: StatusBar / mouse scrolling is broken.

I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.

Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a revision to T29219: StatusBar / mouse scrolling is broken: Unknown Object (Differential Revision).
Sep 19 2022, 4:41 PM · MITK (v2022.10)
s434n committed rMITK26df569787e2: Fix typos (authored by s434n).
Fix typos
Sep 19 2022, 11:05 AM
s434n committed rMITKb4c69945ef44: fix typos and remove misspelled unused code (authored by s434n).
fix typos and remove misspelled unused code
Sep 19 2022, 11:05 AM

Sep 18 2022

floca added a comment to T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns.

Pushed new branch to rMITK MITK: feature/T29206-MVC_pattern_for_labelsets.

Sep 18 2022, 5:38 PM · MITK (v2023.04), Checklist

Sep 16 2022

kalali closed T28762: [Interaction] Remove deprecated / unused interaction files as Resolved.
Sep 16 2022, 11:00 PM · MITK
kalali committed rMITKcc1edae351e2: Remove unused interaction files (authored by kalali).
Remove unused interaction files
Sep 16 2022, 10:59 PM
kalali committed rMITKdd6756610999: Remove unused segmentation interaction files (authored by kalali).
Remove unused segmentation interaction files
Sep 16 2022, 10:59 PM
kalali committed rMITKb18f5343112e: Remove legacy state machine / display configuration (authored by kalali).
Remove legacy state machine / display configuration
Sep 16 2022, 10:59 PM
kalali committed rMITKd80fdb784ffe: Remove unused DisplayConfig.xml-file (authored by kalali).
Remove unused DisplayConfig.xml-file
Sep 16 2022, 10:59 PM
s434n closed T29287: Rework segmentation checklist for new modes of the picking tool as Resolved.
Sep 16 2022, 1:55 PM · MITK (v2022.10)
s434n claimed T29287: Rework segmentation checklist for new modes of the picking tool.
Sep 16 2022, 12:41 PM · MITK (v2022.10)

Sep 15 2022

kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 4:52 PM · MITK (v2022.10)
kalali triaged T29303: IGT classes do not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 4:43 PM · MITK (v2024.06)
j870n added a member for Kaapana (internal): kausch.
Sep 15 2022, 3:23 PM
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 3:00 PM · MITK (v2022.10)
kalali updated the task description for T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
Sep 15 2022, 3:00 PM · MITK (v2024.06)
kalali triaged T29302: Movie maker plugin does not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 2:59 PM · MITK (v2024.06)
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 9:33 AM · MITK (v2022.10)

Sep 14 2022

kalali added a comment to T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

I quickly looked into this using the experimental state of the mxnMultiWidget but I get a Workbench crash. This might be unrelated so I tested something else:
I used the StdMultiWidget, loaded Pic3D but then I used the Render Window Manager to change the Mapper of the axial render window from 2D Mapper to 3D Mapper.
I get the following crash:

Sep 14 2022, 6:20 PM · MITK, Pull Request
floca claimed T28524: Refactor LabelSetImage and associated classes..
Sep 14 2022, 11:27 AM · Next Milestone
floca closed T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Wontfix.
Sep 14 2022, 11:27 AM · MITK (v2022.10), Breaking Change
floca closed T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel as Wontfix.

I will close it. For the reasons noted above.

Sep 14 2022, 11:27 AM · MITK (v2022.10), Checklist
floca added a comment to T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel.

Should not be address directly now. Reason: With the new Segementation class, there will be a hard upper limit for the number of labels anyways. In this corner case we also would have to show a error message then, just telling that we cannot cover more then 2^16 labels. So that the provided image cannot be converted into a label image.

Sep 14 2022, 11:25 AM · MITK (v2022.10), Checklist
floca added a comment to T26972: Dialog and plugin layout seems to be not shown correctly on laptops.

Could be the same issue like in T28816: [Segmentation] "New Segmentation" dialog to small

Sep 14 2022, 11:13 AM · MITK (v2024.06), Missing Info
kislinsk triaged T29300: Improve feedback for progress of long running tasks/operations as Wishlist priority.
Sep 14 2022, 11:10 AM · MITK (v2024.06)
floca added a project to T29090: [3D Segmentation] Threshold tool preview draws contours in green and not in the active label color. : Next Milestone.
Sep 14 2022, 11:10 AM · MITK (v2024.06), Request for Discussion, Checklist
floca added a project to T28793: [Segmentation][Multilabel][Options] Changing only decimation rate has no visible effect in "Create smoothed polygon model": Missing Info.

We have to check if the property is applied or the reason for no difference is that the rate is to small.

Sep 14 2022, 10:53 AM · Cleared, MITK (v2022.10), Checklist
s349i added a subtask for T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: T29060: [Segmentation] Glitch in label color after 3d-interpolation.
Sep 14 2022, 10:46 AM · MITK (v2023.04), Restricted Project
s349i added a parent task for T29060: [Segmentation] Glitch in label color after 3d-interpolation: T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.
Sep 14 2022, 10:46 AM · MITK (v2023.04), Checklist
s349i claimed T29060: [Segmentation] Glitch in label color after 3d-interpolation.
Sep 14 2022, 10:46 AM · MITK (v2023.04), Checklist
s349i added a subtask for T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: T29105: [3D Surface Interpolation] 3D+t Interpolation Preview Crashes When Going Through Different Time Steps.
Sep 14 2022, 10:42 AM · MITK (v2023.04), Restricted Project
s349i added a parent task for T29105: [3D Surface Interpolation] 3D+t Interpolation Preview Crashes When Going Through Different Time Steps: T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.
Sep 14 2022, 10:42 AM · Breaking Change, MITK (v2024.06), Checklist
s349i claimed T29105: [3D Surface Interpolation] 3D+t Interpolation Preview Crashes When Going Through Different Time Steps.
Sep 14 2022, 10:41 AM · Breaking Change, MITK (v2024.06), Checklist
isensee added a comment to T29292: Unsupported pixel types.

Stefan is right that, from the medical perspective, there is no need for these pixel types. And urgently needed not they are. We can easily convert all the files with strange pixel types to files with 'normal' ones. The issue here is simply from a usability/user experience perspective. It is uncommon to me (and probably other as well) to load an image and then get told the pixel type is not supported

Sep 14 2022, 10:26 AM · Request for Discussion, MITK
kalali closed T26496: [mxn multi widget] Re-initializations reset all render windows, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Sep 14 2022, 9:05 AM · MITK
kalali closed T26496: [mxn multi widget] Re-initializations reset all render windows as Resolved.
Sep 14 2022, 9:05 AM · MITK (v2022.10), Restricted Project
kalali committed rMITK46bc8f473d61: Initialize render windows individually (authored by kalali).
Initialize render windows individually
Sep 14 2022, 9:03 AM
kalali committed rMITK6f11b3331cfb: Initialize the render window part correctly to null (authored by kalali).
Initialize the render window part correctly to null
Sep 14 2022, 9:03 AM
kalali committed rMITK6d128ebb0011: Allow initializing a render window with bounding objects (authored by kalali).
Allow initializing a render window with bounding objects
Sep 14 2022, 9:03 AM
kalali committed rMITKc44600cabb0f: Only initialize the newly created render window (authored by kalali).
Only initialize the newly created render window
Sep 14 2022, 9:03 AM
kislinsk committed rMITK802ed4cd6b79: Made tool manager sensitive to the visibility of the reference image (authored by siddharth.tourani <tourani.siddharth@gmail.com>).
Made tool manager sensitive to the visibility of the reference image
Sep 14 2022, 6:07 AM
kislinsk closed T28180: [Segmentation] Showing a previously hidden reference image requires a reinit as Resolved by committing rMITK720ebe4ad468: Made tool manager sensitive to the visibility of the reference image.
Sep 14 2022, 6:07 AM · MITK (v2022.10)
kislinsk committed rMITK720ebe4ad468: Made tool manager sensitive to the visibility of the reference image (authored by siddharth.tourani <tourani.siddharth@gmail.com>).
Made tool manager sensitive to the visibility of the reference image
Sep 14 2022, 6:07 AM
kislinsk closed T27578: 2021.1 Linux installer does not work on Fedora as Resolved.

I tested the fixed installer in a Fedora VM and it worked as expected.

Sep 14 2022, 5:59 AM · MITK (v2022.10)
kislinsk added a comment to T27578: 2021.1 Linux installer does not work on Fedora.

Deleted branch from rMITK MITK: bugfix/T27578-RemoveTCPWrappersDependency.

Sep 14 2022, 5:58 AM · MITK (v2022.10)
kislinsk committed rMITK20ed344cb5d6: Remove TCP Wrappers (libwrap) dependency (authored by kislinsk).
Remove TCP Wrappers (libwrap) dependency
Sep 14 2022, 5:57 AM
kislinsk committed rMITKd4ce642978a6: Merge branch 'bugfix/T27578-RemoveTCPWrappersDependency' into develop (authored by kislinsk).
Merge branch 'bugfix/T27578-RemoveTCPWrappersDependency' into develop
Sep 14 2022, 5:57 AM
kislinsk updated subscribers of T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

@kalali Do you have a use case with the mxn widget where you could check this pull request with multiple 3d render windows?

Sep 14 2022, 5:52 AM · MITK, Pull Request
kislinsk triaged T29220: StatusBar info is dependent on the pointer position, not on the crosshair / mouse click as Normal priority.
Sep 14 2022, 5:42 AM · Request for Discussion, MITK
kislinsk triaged T29219: StatusBar / mouse scrolling is broken as Normal priority.
Sep 14 2022, 5:41 AM · MITK (v2022.10)
kislinsk triaged T29229: SetDataNode on SinglePointDataInteractor clears data in node as Low priority.
NOTE: The SinglePointDataInteractor is not used anymore in our code base. It was once used for the AdaptiveRegionGrowingTool.
Sep 14 2022, 5:40 AM · MITK

Sep 13 2022

floca added a comment to T29292: Unsupported pixel types.

I wouldn't care for the extra size (if it stays reasonable), if users need the pixel type.

Sep 13 2022, 9:16 PM · Request for Discussion, MITK
j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Deleted branch from rMITK MITK: feature/T28851-AddITKGrowCutTool.

Sep 13 2022, 2:59 PM · MITK (v2022.10)
s434n added a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n added a parent task for T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n triaged T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized as Normal priority.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n added a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29298: [mxn multi widget] Add context menu to render window specific data inspector.
Sep 13 2022, 1:03 PM · MITK (v2023.04)
s434n added a parent task for T29298: [mxn multi widget] Add context menu to render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 1:03 PM · MITK
s434n triaged T29298: [mxn multi widget] Add context menu to render window specific data inspector as Normal priority.
Sep 13 2022, 1:02 PM · MITK
kislinsk closed T29296: Crash when clearing the segmentation task list selection as Resolved.
Sep 13 2022, 12:48 PM · MITK (v2022.10)
kislinsk added a comment to T29296: Crash when clearing the segmentation task list selection.

Deleted branch from rMITK MITK: bugfix/T29296-FixCrashWhenClearingTaskListSelection.

Sep 13 2022, 12:48 PM · MITK (v2022.10)
kislinsk committed rMITK99fad818c03f: Remove debug output (authored by kislinsk).
Remove debug output
Sep 13 2022, 12:48 PM
kislinsk committed rMITKc7562ac0dca1: Check validity of task list before updating navigation buttons (authored by kislinsk).
Check validity of task list before updating navigation buttons
Sep 13 2022, 12:48 PM
kislinsk committed rMITKe91794e34de4: Merge branch 'bugfix/T29296-FixCrashWhenClearingTaskListSelection' into develop (authored by kislinsk).
Merge branch 'bugfix/T29296-FixCrashWhenClearingTaskListSelection' into develop
Sep 13 2022, 12:48 PM
kislinsk added a comment to T29296: Crash when clearing the segmentation task list selection.

Pushed new branch to rMITK MITK: bugfix/T29296-FixCrashWhenClearingTaskListSelection.

Sep 13 2022, 12:47 PM · MITK (v2022.10)
s434n added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 12:46 PM · MITK
s434n added a parent task for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Sep 13 2022, 12:46 PM · MITK (v2023.04)
s434n triaged T29297: [mxn multi widget] Optimize data accessibility inside render windows as Normal priority.
Sep 13 2022, 12:46 PM · MITK (v2023.04)
kislinsk triaged T29296: Crash when clearing the segmentation task list selection as High priority.
Sep 13 2022, 12:44 PM · MITK (v2022.10)
a178n added a comment to T29295: MONAI Label App as auto-segmentation tool in MITK.

Pushed new branch to rMITK MITK: feature/T29295-monai-segmentation-tool.

Sep 13 2022, 11:14 AM · MITK (v2024.06)
a178n added a project to T29295: MONAI Label App as auto-segmentation tool in MITK: MITK.
Sep 13 2022, 11:14 AM · MITK (v2024.06)
a178n triaged T29295: MONAI Label App as auto-segmentation tool in MITK as Normal priority.
Sep 13 2022, 10:53 AM · MITK (v2024.06)
a178n placed T29275: Test new nnUNet(v2) python codebase with MITK up for grabs.
Sep 13 2022, 10:01 AM · MITK (v2024.06)
a178n placed T29294: Extend &/or Test nnUnet(v2) on Windows up for grabs.
Sep 13 2022, 10:01 AM · MITK (v2023.12), Request for Discussion
a178n triaged T29294: Extend &/or Test nnUnet(v2) on Windows as Normal priority.
Sep 13 2022, 10:00 AM · MITK (v2023.12), Request for Discussion
kislinsk removed a project from T27578: 2021.1 Linux installer does not work on Fedora: Next Milestone.
Sep 13 2022, 9:35 AM · MITK (v2022.10)

Sep 12 2022

isensee added a comment to T29292: Unsupported pixel types.

I sent the file to you via slack.
Not supporting some pixel types can be very frustrating for users, so it might make sense to extend this list (I would certainly appreciate it and a 200MB standalone is really not large by 2022 standards so there is some headroom imo ;-) ). This is not the first time I ran into this issue :-/

Sep 12 2022, 12:19 PM · Request for Discussion, MITK
kislinsk created ARGOS UI.
Sep 12 2022, 12:15 PM
kislinsk added a revision to T27578: 2021.1 Linux installer does not work on Fedora: Unknown Object (Differential Revision).
Sep 12 2022, 12:12 PM · MITK (v2022.10)
kislinsk added a comment to T27578: 2021.1 Linux installer does not work on Fedora.

Pushed new branch to rMITK MITK: bugfix/T27578-RemoveTCPWrappersDependency.

Sep 12 2022, 12:10 PM · MITK (v2022.10)
kislinsk added a comment to T27578: 2021.1 Linux installer does not work on Fedora.

Looking closer into the issue I wonder why it should not work without TCP Wrappers. It is an optional dependency of DCMTK which, regarding to storescp, adds two access control cmd-line arguments that we are not using anyway as far as I can see. So maybe it is just an issue since we so an explicit requirement check and then of course DO link against it. If we would explicitly disable it in DCMTK and remove the check in our CMake script, it should probably work already,

Sep 12 2022, 11:55 AM · MITK (v2022.10)
kislinsk lowered the priority of T27578: 2021.1 Linux installer does not work on Fedora from High to Normal.
Sep 12 2022, 8:30 AM · MITK (v2022.10)
kislinsk added a comment to T27578: 2021.1 Linux installer does not work on Fedora.

I would recommend to file a ticket in the DCMTK bug tracker since it is a dependency of dcmnet.

Sep 12 2022, 8:30 AM · MITK (v2022.10)
kislinsk moved T29285: [Checklist] Revise Remeshing checklist from Backlog to Tests/Checklists on the MITK (v2022.10) board.
Sep 12 2022, 8:17 AM · MITK (v2023.04), Checklist
kislinsk closed T29293: Fix typos in Core module documentation as Resolved.
Sep 12 2022, 8:01 AM · Pull Request, MITK (v2022.10)