Page MenuHomePhabricator
Feed All Stories

Nov 27 2023

kislinsk committed rMITK09a394c66855: Add missing include (authored by kislinsk).
Add missing include
Nov 27 2023, 10:32 AM
kislinsk committed rMITK8f9396c71352: Remove unused parameter (authored by kislinsk).
Remove unused parameter
Nov 27 2023, 10:32 AM
kislinsk committed rMITK93acff4e90c8: Add missing include (authored by kislinsk).
Add missing include
Nov 27 2023, 10:31 AM
kislinsk committed rMITKb303d7ca9f90: Remove unused variable (authored by kislinsk).
Remove unused variable
Nov 27 2023, 10:31 AM
kislinsk committed rMITK82381087fa7b: Remove unused function (authored by kislinsk).
Remove unused function
Nov 27 2023, 10:31 AM
kislinsk committed rMITK43a91fba572b: Add missing include (authored by kislinsk).
Add missing include
Nov 27 2023, 10:31 AM
kislinsk committed rMITK4aeabc52b019: Replace deprecated method call (authored by kislinsk).
Replace deprecated method call
Nov 27 2023, 10:31 AM
kislinsk committed rMITK4f28789a8c0e: Implement JSON serialization for TubeGraphProperty (authored by kislinsk).
Implement JSON serialization for TubeGraphProperty
Nov 27 2023, 10:31 AM
kislinsk committed rMITK16d103b465b2: Add missing include (authored by kislinsk).
Add missing include
Nov 27 2023, 10:31 AM
kislinsk committed rMITK392eea25e27a: Add missing include (authored by kislinsk).
Add missing include
Nov 27 2023, 10:31 AM
kislinsk committed rMITK5fa57aac105e: Implement JSON serialization for CameraIntrinsicsProperty (authored by kislinsk).
Implement JSON serialization for CameraIntrinsicsProperty
Nov 27 2023, 10:31 AM
kislinsk committed rMITK745ec315b697: Reorder includes (authored by kislinsk).
Reorder includes
Nov 27 2023, 10:31 AM
kislinsk committed rMITK42b3b7f82a8d: Improve detection for time-resolved ROIs (authored by kislinsk).
Improve detection for time-resolved ROIs
Nov 27 2023, 10:31 AM
kislinsk committed rMITK9b3a81340e45: Add ROI documentation (authored by kislinsk).
Add ROI documentation
Nov 27 2023, 10:31 AM
kislinsk committed rMITK5b52d58976d9: Remove outdated sentence (authored by kislinsk).
Remove outdated sentence
Nov 27 2023, 10:31 AM
kislinsk committed rMITK3342cc69bb7a: Reorder includes (authored by kislinsk).
Reorder includes
Nov 27 2023, 10:31 AM
kislinsk committed rMITK52c74468c53d: Reorder includes (authored by kislinsk).
Reorder includes
Nov 27 2023, 10:31 AM
kislinsk committed rMITKbb2783265f11: Fix bounding shape handle size (authored by kislinsk).
Fix bounding shape handle size
Nov 27 2023, 10:31 AM
kislinsk committed rMITK0ce20cf8f9f9: Make inclusion of ctkAbstractPythonManager.h compatible to nlohmann_json (authored by kislinsk).
Make inclusion of ctkAbstractPythonManager.h compatible to nlohmann_json
Nov 27 2023, 10:31 AM
kislinsk committed rMITKeb354f334d4c: Change bounding shape handles from spheres to cubes (authored by kislinsk).
Change bounding shape handles from spheres to cubes
Nov 27 2023, 10:31 AM
kislinsk committed rMITK7a807cbe2f44: Add icon for GeometryData (authored by kislinsk).
Add icon for GeometryData
Nov 27 2023, 10:31 AM
kislinsk committed rMITK2018a9c821c9: Consistently use "bounding box" instead of "bounding shape" (authored by kislinsk).
Consistently use "bounding box" instead of "bounding shape"
Nov 27 2023, 10:31 AM
kislinsk committed rMITK0c7ca73b00b3: Fix bounding shape mapper property connection (authored by kislinsk).
Fix bounding shape mapper property connection
Nov 27 2023, 10:31 AM
kislinsk committed rMITK405c6b86c575: Add "Convert to ROI" action to GeometryData nodes (authored by kislinsk).
Add "Convert to ROI" action to GeometryData nodes
Nov 27 2023, 10:31 AM
kislinsk committed rMITKf1cec65c81b1: Add const overload of GetVtkMatrix() (authored by kislinsk).
Add const overload of GetVtkMatrix()
Nov 27 2023, 10:31 AM
kislinsk committed rMITK3bbbbec20282: Only save name if set (authored by kislinsk).
Only save name if set
Nov 27 2023, 10:31 AM
kislinsk committed rMITK526f0f0bca85: Add conversion from GeometryData to ROI (authored by kislinsk).
Add conversion from GeometryData to ROI
Nov 27 2023, 10:31 AM
kislinsk committed rMITK01f785485a6b: Warn against use of experimental ROI class. (authored by kislinsk).
Warn against use of experimental ROI class.
Nov 27 2023, 10:31 AM
kislinsk committed rMITKe60d3c62a4e0: Fix missing returns (authored by kislinsk).
Fix missing returns
Nov 27 2023, 10:31 AM
kislinsk committed rMITK6ab482816510: Add MITK ROI file format documentation (authored by kislinsk).
Add MITK ROI file format documentation
Nov 27 2023, 10:31 AM
kislinsk committed rMITKb54bcd101ae7: Add TimeStepType overloads to property methods (authored by kislinsk).
Add TimeStepType overloads to property methods
Nov 27 2023, 10:31 AM
kislinsk committed rMITKdcce84a018c1: Merge branch 'develop' into feature/T30155-ROI (authored by kislinsk).
Merge branch 'develop' into feature/T30155-ROI
Nov 27 2023, 10:31 AM
kislinsk committed rMITK226bcc35c217: Merge branch 'feature/T30155-ROI' into develop (authored by kislinsk).
Merge branch 'feature/T30155-ROI' into develop
Nov 27 2023, 10:31 AM

Nov 24 2023

floca triaged T29640: Verboseness in MatchPoint Algorithm Control as Low priority.
Nov 24 2023, 2:46 PM · MITK (v2024.12), Missing Info

Nov 23 2023

a178n committed rMITK1e02a70d45fb: Add dimension check for 2d images (authored by a178n).
Add dimension check for 2d images
Nov 23 2023, 11:11 AM
a178n committed rMITKfc8b96111fc6: Convert IsImageAtTimeStepValid as free function (authored by a178n).
Convert IsImageAtTimeStepValid as free function
Nov 23 2023, 11:11 AM
a178n committed rMITK6feb99dd9e27: SAM: Bugfix for 2D images (authored by a178n).
SAM: Bugfix for 2D images
Nov 23 2023, 11:10 AM
kislinsk closed T30233: lz4.h is not found on our Ubuntu 22.04 client as Resolved.

AFAIK this was a temporary quirk and doesn't happen anymore.

Nov 23 2023, 10:37 AM · MITK

Nov 22 2023

s434n added a comment to T29454: Clarify the versions/editions we publish as installer.

MITK Workbench XL
MITK Workbench - extra

Nov 22 2023, 12:07 PM · MITK (v2024.06), Request for Discussion
kompan added a comment to T29454: Clarify the versions/editions we publish as installer.

Some more name ideas:
MITK Workbench Plus
MITK Workbench - Advanced Edition
MITK Workbench - Extended Edition
MITK Deluxe (ok, too far, I'll better stop now...)

Nov 22 2023, 11:04 AM · MITK (v2024.06), Request for Discussion
kislinsk added a comment to T29454: Clarify the versions/editions we publish as installer.

Name suggestion: MITK Workbench - Science Edition

Nov 22 2023, 10:50 AM · MITK (v2024.06), Request for Discussion
a178n added a project to T30268: [Checklist] Segmentation 3D Interpolation: Checklist.
Nov 22 2023, 10:43 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n added a project to T30275: [Segmentation] 3D Interpolation Show-Position-Nodes not updating sometimes: Checklist.
Nov 22 2023, 10:43 AM · Checklist, MITK
a178n added a project to T30270: [Segmentation] Show Position Nodes in Interpolation not working for loaded mitk projects: Checklist.
Nov 22 2023, 10:43 AM · Checklist, MITK
a178n added a project to T30263: [Segmentation] SAM tool issue with single slice (2D): Checklist.
Nov 22 2023, 10:36 AM · Checklist, MITK (v2023.12)
kislinsk triaged T29588: [MxN] Lock icon is unintuitive as Wishlist priority.
Nov 22 2023, 10:30 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added a revision to T30263: [Segmentation] SAM tool issue with single slice (2D): Unknown Object (Differential Revision).
Nov 22 2023, 12:05 AM · Checklist, MITK (v2023.12)

Nov 21 2023

a178n added a comment to T30263: [Segmentation] SAM tool issue with single slice (2D).

Pushed new branch to rMITK MITK: feature/T30263-sam-2d-bugfix.

Nov 21 2023, 8:07 PM · Checklist, MITK (v2023.12)
a178n renamed T30263: [Segmentation] SAM tool issue with single slice (2D) from [Segmentation] SAM tool issue with single slice dicom to [Segmentation] SAM tool issue with single slice (2D).
Nov 21 2023, 8:05 PM · Checklist, MITK (v2023.12)
s434n added a comment to T30275: [Segmentation] 3D Interpolation Show-Position-Nodes not updating sometimes.

I don't see a good way to handle this differently. Discerning if a slice has become obsolete would be very hard, especially since it's in 3D and the slice could be intersected by a segmented slice of a different orientation. The position node remaining does not seem like a problem to me, so I would vote to close as Invalid or Wontfix.

Nov 21 2023, 12:52 PM · Checklist, MITK
kompan closed T27738: Curve Color selection not possible in ModelFit Inspector view settings as Resolved.

This task is closed due to task duplication and will be further taken care of in https://phabricator.mitk.org/T30238.

Nov 21 2023, 11:40 AM · MITK (v2023.12), Cleared
a178n renamed T30275: [Segmentation] 3D Interpolation Show-Position-Nodes not updating sometimes from [Segmentation] 3D Interpolation position nodes also includes unlabeled slices to [Segmentation] 3D Interpolation Show-Position-Nodes not updating sometimes.
Nov 21 2023, 11:39 AM · Checklist, MITK
s434n merged task T28800: [Segmentation] Threshold tool updates after each digit if typed in manually into Restricted Maniphest Task.
Nov 21 2023, 9:48 AM · MITK (v2023.12), Checklist, Request for Discussion
a178n added a comment to T30256: TotalSeg: Add check for Python version.

Pushed new branch to rMITK MITK: feature/T30256-add-python-version-check.

Nov 21 2023, 6:03 AM · MITK (v2024.06)

Nov 20 2023

s434n added a revision to T30258: [Statistics] Lines across different geometries can cause crash when analyzed with image: Unknown Object (Differential Revision).
Nov 20 2023, 5:19 PM · Checklist, MITK (v2023.12)
s434n claimed T30258: [Statistics] Lines across different geometries can cause crash when analyzed with image.
Nov 20 2023, 4:00 PM · Checklist, MITK (v2023.12)
a178n created T30275: [Segmentation] 3D Interpolation Show-Position-Nodes not updating sometimes.
Nov 20 2023, 3:31 PM · Checklist, MITK
kislinsk added a comment to T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points.

Deleted branch from rMITK MITK: bugfix/T30262-SelectClosestPointInsteadOfAnyClosePoint.

Nov 20 2023, 2:39 PM · Checklist, MITK (v2023.12)
kislinsk committed rMITK36d33e1cab35: Correctly determine the closest point to a certain position (authored by kislinsk).
Correctly determine the closest point to a certain position
Nov 20 2023, 2:39 PM
kislinsk closed T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points as Resolved by committing rMITKe121425d0e90: [PointSet interaction] Correctly determine the closest point to a certain….
Nov 20 2023, 2:39 PM · Checklist, MITK (v2023.12)
kislinsk committed rMITKe121425d0e90: [PointSet interaction] Correctly determine the closest point to a certain… (authored by kislinsk).
[PointSet interaction] Correctly determine the closest point to a certain…
Nov 20 2023, 2:39 PM
a178n renamed T30270: [Segmentation] Show Position Nodes in Interpolation not working for loaded mitk projects from [Segmentation] Show Position Nodes in not working for loaded mitk projects to [Segmentation] Show Position Nodes in Interpolation not working for loaded mitk projects.
Nov 20 2023, 1:23 PM · Checklist, MITK
kislinsk claimed T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points.
Nov 20 2023, 1:21 PM · Checklist, MITK (v2023.12)
a178n created T30270: [Segmentation] Show Position Nodes in Interpolation not working for loaded mitk projects.
Nov 20 2023, 1:16 PM · Checklist, MITK
a178n added a comment to T30268: [Checklist] Segmentation 3D Interpolation.

Whoever corrects these, please update the contour colours across the checklist for consistency.

Nov 20 2023, 12:58 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n updated the task description for T30268: [Checklist] Segmentation 3D Interpolation.
Nov 20 2023, 12:53 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n updated the task description for T30268: [Checklist] Segmentation 3D Interpolation.
Nov 20 2023, 12:53 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added a revision to T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points: Unknown Object (Differential Revision).
Nov 20 2023, 12:07 PM · Checklist, MITK (v2023.12)
kislinsk added a comment to T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points.

Pushed new branch to rMITK MITK: bugfix/T30262-SelectClosestPointInsteadOfAnyClosePoint.

Nov 20 2023, 11:58 AM · Checklist, MITK (v2023.12)
kislinsk added a comment to T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points.

My suspicion is that the reaction on hovering is a two-step process. As soon as the mouse pointer hovers over a sphere, I guess a search is started to check which point is closest to the mouse pointer but prematurely discontinued as soon as any point is "close enough" to the mouse pointer, leaving out other candidates that are actually closer.

Nov 20 2023, 11:32 AM · Checklist, MITK (v2023.12)
a178n updated the task description for T30268: [Checklist] Segmentation 3D Interpolation.
Nov 20 2023, 11:29 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n updated the task description for T30268: [Checklist] Segmentation 3D Interpolation.
Nov 20 2023, 11:26 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n updated the task description for T30268: [Checklist] Segmentation 3D Interpolation.
Nov 20 2023, 11:26 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n triaged T30268: [Checklist] Segmentation 3D Interpolation as Normal priority.
Nov 20 2023, 11:26 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
floca updated subscribers of T29562: [GrowCut] "Undo" only changes slices with seed images.

Thats because 3D Tools in total do not support undo redo currently.
Sofar we havent dared due to the memory footprint (as it would mean storing copies of the volume); but also never tested it.
May be we should ceck if it is OK in conjunction with compression (introduced by @kislinsk some time ago) and if needed limitations (a max step limit, or clearing the history if the segmentation is finished), to avoid extrem memory consumption due to long undo/redo history.

Nov 20 2023, 11:23 AM · Moved to git.dkfz.de, Request for Discussion, MITK
kislinsk triaged T30263: [Segmentation] SAM tool issue with single slice (2D) as Normal priority.
Nov 20 2023, 11:16 AM · Checklist, MITK (v2023.12)
kislinsk changed the visibility for F2765256: Capture.JPG.
Nov 20 2023, 11:13 AM
kislinsk added a comment to T30267: [Segmentation] Undo/Redo does not work for many aspects of segmentation.

In particular working with different groups seems to have impact on the amount of undo/redo shenanigans.

Nov 20 2023, 10:58 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added subtasks for T30267: [Segmentation] Undo/Redo does not work for many aspects of segmentation: T29582: [Segmentation] Error when pressing "Undo" after undoing all fill changes, T29562: [GrowCut] "Undo" only changes slices with seed images.
Nov 20 2023, 10:50 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added a parent task for T29562: [GrowCut] "Undo" only changes slices with seed images: T30267: [Segmentation] Undo/Redo does not work for many aspects of segmentation.
Nov 20 2023, 10:50 AM · Moved to git.dkfz.de, Request for Discussion, MITK
kislinsk added a parent task for T29582: [Segmentation] Error when pressing "Undo" after undoing all fill changes: T30267: [Segmentation] Undo/Redo does not work for many aspects of segmentation.
Nov 20 2023, 10:50 AM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Checklist
kislinsk triaged T30267: [Segmentation] Undo/Redo does not work for many aspects of segmentation as Normal priority.
Nov 20 2023, 10:49 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n added a parent task for T30263: [Segmentation] SAM tool issue with single slice (2D): T29524: SAM in MITK.
Nov 20 2023, 10:13 AM · Checklist, MITK (v2023.12)
a178n added a subtask for T29524: SAM in MITK: T30263: [Segmentation] SAM tool issue with single slice (2D).
Nov 20 2023, 10:13 AM · Moved to git.dkfz.de, MITK
a178n created T30263: [Segmentation] SAM tool issue with single slice (2D).
Nov 20 2023, 10:12 AM · Checklist, MITK (v2023.12)
kislinsk triaged T30262: [PointSet interaction] Picking/hovering in 3-d render window highlights wrong points when in close proximity to other points as Low priority.
Nov 20 2023, 10:07 AM · Checklist, MITK (v2023.12)
a178n triaged T30259: [Segmentation] Available models dropdown is empty in nnUNet tool as Normal priority.
Nov 20 2023, 9:05 AM · Moved to git.dkfz.de, MITK
a178n renamed T30253: SAM tool: Installation could show error message for wrong python path from SAM tool: Installation can show error for wrong python path to SAM tool: Installation could show error message for wrong python path.
Nov 20 2023, 8:58 AM · MITK (v2024.06)
a178n closed T29644: Doxygen documentation for SAM, a subtask of T29524: SAM in MITK, as Resolved.
Nov 20 2023, 8:58 AM · Moved to git.dkfz.de, MITK
a178n closed T29644: Doxygen documentation for SAM as Resolved.
Nov 20 2023, 8:58 AM · MITK (v2023.12)

Nov 18 2023

floca committed rMPd9be8415db3d: Add feature for ITKImageRegistrationAlgorithms to allow (authored by floca).
Add feature for ITKImageRegistrationAlgorithms to allow
Nov 18 2023, 2:56 PM
floca committed rMPbcd7dcb79b37: Added algorithm Rigid2DMSAlgorithm (authored by floca).
Added algorithm Rigid2DMSAlgorithm
Nov 18 2023, 2:56 PM

Nov 17 2023

s434n triaged T30258: [Statistics] Lines across different geometries can cause crash when analyzed with image as High priority.
Nov 17 2023, 4:32 PM · Checklist, MITK (v2023.12)
s434n triaged T30257: Changing opacity messes up rendering order as Normal priority.
Nov 17 2023, 2:33 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n updated the task description for T30256: TotalSeg: Add check for Python version.
Nov 17 2023, 12:03 PM · MITK (v2024.06)
a178n triaged T30256: TotalSeg: Add check for Python version as High priority.
Nov 17 2023, 11:49 AM · MITK (v2024.06)
kislinsk added a comment to T30255: Allow render window utility widgets on all sides .

Pushed new branch to rMITK MITK: feature/T30255-RenderWindowUtilityWidgets.

Nov 17 2023, 10:54 AM · MITK (v2024.12), Pull Request
kislinsk triaged T30255: Allow render window utility widgets on all sides as Wishlist priority.
Nov 17 2023, 10:52 AM · MITK (v2024.12), Pull Request

Nov 16 2023

s434n published a new version of 2023 Week 46 (Mid November).
Nov 16 2023, 5:42 PM
kislinsk committed rMITKaea0d7c59906: Change search algorithm to include all nodes per level (authored by kislinsk).
Change search algorithm to include all nodes per level
Nov 16 2023, 4:59 PM