Page MenuHomePhabricator
Feed All Stories

May 24 2020

floca added a revision to T27441: PlanarFigure clone is in invalid state due to copy of unmanged/uncontrolled pointer for PlaneGeometry: Restricted Differential Revision.
May 24 2020, 12:23 AM · Missing Info, Request for Discussion, MITK (v2021.02)
floca added a revision to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Restricted Differential Revision.
May 24 2020, 12:23 AM · Cleared, MITK (v2021.02)

May 23 2020

floca triaged T27441: PlanarFigure clone is in invalid state due to copy of unmanged/uncontrolled pointer for PlaneGeometry as Unbreak Now! priority.
May 23 2020, 11:45 PM · Missing Info, Request for Discussion, MITK (v2021.02)
floca committed rMITK1e46d7cea901: Fixed T27372 (authored by floca).
Fixed T27372
May 23 2020, 11:43 AM
floca committed rMITKe3c69e5155fb: Fixed T27372 (authored by floca).
Fixed T27372
May 23 2020, 11:43 AM
floca closed T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method as Resolved by committing rMITKe3c69e5155fb: Fixed T27372.
May 23 2020, 11:43 AM · Cleared, Noteworthy, MITK (v2021.02)
floca added a project to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Cleared.
May 23 2020, 11:33 AM · Cleared, MITK (v2021.02)

May 22 2020

floca added a project to T27440: [ModelFit] More efficient pixel based fitting when masks are used: Restricted Project.
May 22 2020, 10:13 PM · Auto-closed, Restricted Project, MITK
floca triaged T27440: [ModelFit] More efficient pixel based fitting when masks are used as Normal priority.
May 22 2020, 10:13 PM · Auto-closed, Restricted Project, MITK
floca added a comment to T27437: Migrate MITK to use ITK 5.x .

I had a swift look into ITK and our code base and I would guess the following:

May 22 2020, 10:06 PM · MITK-ProjectTemplate, MITK (v2022.04)
floca edited projects for T25445: MultiLabel segmentation mapper is very slow, added: MITK (v2021.02); removed MITK.
May 22 2020, 9:36 PM · MITK (v2024.06), Request for Discussion
floca added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

I guess that will be something that has to be fixed in the mapper. When looking into it, may be you also see the reason for T25445: MultiLabel segmentation mapper is very slow would be great.

May 22 2020, 9:34 PM · Cleared, MITK (v2021.02)
floca added a parent task for T27414: Adapt CMake version macro to generate version description with "no official release": Unknown Object (Maniphest Task).
May 22 2020, 9:00 PM · MITK (v2024.06), Restricted Project, CI
zimmerer committed rMOODe7f1b90a82ad: Again... (authored by zimmerer).
Again...
May 22 2020, 4:37 PM
zimmerer committed rMOODcad6f14d9f23: Again... (authored by zimmerer).
Again...
May 22 2020, 4:37 PM
zimmerer committed rMOODd99d8a98d275: Again... (authored by zimmerer).
Again...
May 22 2020, 4:18 PM
floca updated subscribers of T27432: Error loading DCE-MRI DICOM image.

@kompan FYI I think the loading error is a known/fixed issue (see above).

May 22 2020, 2:53 PM · MITK, DICOM, Cleared
floca edited projects for T27416: DICOM Seg IO skips empty slices when storing DICOM seg, added: Cleared; removed Request for Discussion.

Discussion result: For now (MITK 2020) we well deactivate the skipping of empty slices. But such a support would make sense longterm, but it is also a bigger issue. I have opened a dedicated Task T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid for that.

May 22 2020, 2:51 PM · Cleared, HiGHmed, DICOM, MITK (v2021.02)
nolden added a comment to T27438: Fix compile errors on Fedora 32 using gcc 10.1.

Pushed new branch feature/T27438-fix-gcc10-errors.

May 22 2020, 2:29 PM · MITK (v2021.02)
nolden updated subscribers of T27437: Migrate MITK to use ITK 5.x .

I changed the superbuild to use ITK 5 with compatibilty and fixed some straightforward issues. This branch can be used for further investigations @floca : some ideas about the geometry issues would be very helpful. The migration guide has an overview on the topic but my experience in that area is limited

May 22 2020, 2:22 PM · MITK-ProjectTemplate, MITK (v2022.04)
nolden added a comment to T27437: Migrate MITK to use ITK 5.x .

Pushed new branch feature/T27437-migrate-to-ITK-5.

May 22 2020, 2:17 PM · MITK-ProjectTemplate, MITK (v2022.04)
floca renamed T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid from [Segmentation] Support of Mask/Segmentations that are cropped / do not coverthe whole image grid to [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.
May 22 2020, 2:00 PM · Auto-closed, MITK
floca moved T25825: [Segmentation] Crash using Watershed on different time steps from Backlog to Segmentation on the MITK (v2021.02) board.
May 22 2020, 1:59 PM · MITK (v2021.02)
floca edited projects for T25825: [Segmentation] Crash using Watershed on different time steps, added: MITK (v2021.02); removed MITK.
May 22 2020, 1:59 PM · MITK (v2021.02)
floca closed T25941: Saving Registered Data in new Coordinate frame as Resolved.

The fix of the manual is in the master. As there was no more updates/questions, I will closed this task as resolved. @TE_Cork : If there is still an issue, please feel free to open the task again and to provide new information. Thanks.

May 22 2020, 1:58 PM · MITK
floca created T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.
May 22 2020, 1:55 PM · Auto-closed, MITK
floca edited projects for T25098: Mapper (partially?) do not handle images correctly if they are out of time bound, added: MITK (v2021.02); removed MITK.
May 22 2020, 1:54 PM · MITK (v2024.06)
nolden triaged T27438: Fix compile errors on Fedora 32 using gcc 10.1 as Normal priority.
May 22 2020, 1:31 PM · MITK (v2021.02)
nolden triaged T27437: Migrate MITK to use ITK 5.x as Normal priority.
May 22 2020, 1:27 PM · MITK-ProjectTemplate, MITK (v2022.04)
floca reopened T27409: Specifiy and implement cleaning policies for MITK tasks as "Open".

Sorry for that ;)

May 22 2020, 1:27 PM · Cleared, Restricted Project, MITK (v2021.02)
floca edited projects for T25305: Property enums of DICOM module are not supported by scene serialization, added: MITK (v2021.02); removed MITK.
May 22 2020, 1:21 PM · MITK (v2024.06), Restricted Project
floca added a subtask for T27270: Planar figures are inconsistently bound by reference image: T27269: PlanarCircle shrinks in size when moved towards image boundaries.
May 22 2020, 1:12 PM · MITK (v2024.06)
floca added a parent task for T27269: PlanarCircle shrinks in size when moved towards image boundaries: T27270: Planar figures are inconsistently bound by reference image.
May 22 2020, 1:12 PM · MITK (v2024.06)
floca lowered the priority of T27270: Planar figures are inconsistently bound by reference image from Normal to Low.

I would also lower the prio here. As we now workarrounds and for fixed sized planarfigures the problem does not exist.

May 22 2020, 1:11 PM · MITK (v2024.06)
floca removed a project from T27269: PlanarCircle shrinks in size when moved towards image boundaries: Request for Discussion.
May 22 2020, 1:10 PM · MITK (v2024.06)
floca removed a project from T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method: Request for Discussion.

I have now removed the dysfunctional Clone for now. See D303

May 22 2020, 1:06 PM · Cleared, Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser.

We need to adjust the path in O1: MITK Reviewer Group I afterwards.

May 22 2020, 12:39 PM · Breaking Change, MITK (v2021.02), Cleared
zimmerer committed rMOOD8a8f94af4e7e: Fix typo (authored by zimmerer).
Fix typo
May 22 2020, 12:29 PM
zimmerer committed rMOODc94b9d36723a: Add readme for example algos (authored by zimmerer).
Add readme for example algos
May 22 2020, 12:28 PM
zimmerer committed rMOODa68ca188ba6b: Add fAnoGAN algorithm (authored by zimmerer).
Add fAnoGAN algorithm
May 22 2020, 12:28 PM
zimmerer committed rMOOD0093631c1e6c: Add ceVAE algorithm (authored by zimmerer).
Add ceVAE algorithm
May 22 2020, 12:28 PM
zimmerer committed rMOOD592982413023: Little Code Cleanup (authored by zimmerer).
Little Code Cleanup
May 22 2020, 12:28 PM
kislinsk closed T27409: Specifiy and implement cleaning policies for MITK tasks as Resolved.

Created global Maniphest filters for both examples above with 3 and 18 months.

May 22 2020, 12:21 PM · Cleared, Restricted Project, MITK (v2021.02)
floca edited projects for T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser, added: Cleared, MITK (v2021.02); removed Request for Discussion, MITK.

dicombrowser it is.

May 22 2020, 11:55 AM · Breaking Change, MITK (v2021.02), Cleared
floca removed a project from T27435: [Registration] Mapper does not properly support LabelSetImages: Request for Discussion.
May 22 2020, 11:53 AM · MITK (v2022.04)
kislinsk claimed T27409: Specifiy and implement cleaning policies for MITK tasks.

We can save the filters in Phabricator and then manually do batch edits at specific times like before an official release or every once in a while.

May 22 2020, 11:51 AM · Cleared, Restricted Project, MITK (v2021.02)
kislinsk removed a project from T27270: Planar figures are inconsistently bound by reference image: Request for Discussion.

There's a check in PlanarCircle that prevents control points to leave the image extents. We would need to change that check to fix this task.

May 22 2020, 11:38 AM · MITK (v2024.06)
nolden edited projects for T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms, added: Cleared; removed Missing Info, Request for Discussion.

Seems the reason this passes on all official clients is Debug vs Release. We currently only test release which ignores asserts. Thus, this should be investigated properly by tracing the problem, Windows and Linux are both affected

May 22 2020, 11:26 AM · Cleared, MITK (v2021.02), Restricted Project, CI
floca removed projects from T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Request for Discussion, Missing Info.
May 22 2020, 11:16 AM · Cleared, MITK (v2021.02)
floca moved T27416: DICOM Seg IO skips empty slices when storing DICOM seg from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:04 AM · Cleared, HiGHmed, DICOM, MITK (v2021.02)
floca moved T27269: PlanarCircle shrinks in size when moved towards image boundaries from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:04 AM · MITK (v2024.06)
floca moved T27270: Planar figures are inconsistently bound by reference image from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:03 AM · MITK (v2024.06)
floca moved T27409: Specifiy and implement cleaning policies for MITK tasks from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:03 AM · Cleared, Restricted Project, MITK (v2021.02)
floca moved T27435: [Registration] Mapper does not properly support LabelSetImages from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:03 AM · MITK (v2022.04)
floca moved T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:03 AM · Cleared, MITK (v2021.02), Restricted Project, CI
floca moved T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open from Backlog to MITK Meeting on the Request for Discussion board.
May 22 2020, 11:03 AM · Cleared, MITK (v2021.02)
floca added a project to T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method: Request for Discussion.
May 22 2020, 11:00 AM · Cleared, Noteworthy, MITK (v2021.02)
floca claimed T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method.
May 22 2020, 10:40 AM · Cleared, Noteworthy, MITK (v2021.02)
floca moved T15551: Tutorial Step 6: region growing does not display results from Backlog to Segmentation on the MITK (v2021.02) board.
May 22 2020, 9:28 AM · Auto-closed, MITK (v2021.02), Missing Info, Bugzilla
floca reopened T15551: Tutorial Step 6: region growing does not display results as "Open".

Plesae, could you add some more information (which version?, which OS?, is it reproducible with different images? Preferably an image that can be shared. E.G. something from the MITK-Data repository)
Thanks.

May 22 2020, 9:27 AM · Auto-closed, MITK (v2021.02), Missing Info, Bugzilla
Kevin added a comment to T15551: Tutorial Step 6: region growing does not display results.

Hello, I ran into the same problem as you when running tutorial Step6. How did you solve it?

May 22 2020, 7:32 AM · Auto-closed, MITK (v2021.02), Missing Info, Bugzilla
Kevin added a comment to T15551: Tutorial Step 6: region growing does not display results.
May 22 2020, 7:31 AM · Auto-closed, MITK (v2021.02), Missing Info, Bugzilla

May 21 2020

floca added a project to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Request for Discussion.
May 21 2020, 9:51 PM · Cleared, MITK (v2021.02)
floca added projects to T27247: MITK_SHOW_CONSOLE_WINDOW is not honored in mitk_create_executable function: Cleared, Pull Request.
May 21 2020, 9:48 PM · Pull Request, Cleared, MITK (v2021.02)
floca moved T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image from Backlog to Segmentation on the MITK (v2021.02) board.
May 21 2020, 9:47 PM · Cleared, MITK (v2021.02)
floca moved T27435: [Registration] Mapper does not properly support LabelSetImages from Backlog to Registration on the MITK (v2021.02) board.
May 21 2020, 9:45 PM · MITK (v2022.04)
floca added a project to T27432: Error loading DCE-MRI DICOM image: Missing Info.

Hi, thanks for reporting the problem. I think it is caused by a known problem fixed by T27321: [DICOM reader] DICOM 3D+t image reader should condense only images of the same series.. To verify the assumption you could either:

  1. test the loading with a current master build of mitk
  2. or ensure that only the DCE dicom files are in the directory (e.g. no scout images or other sequences) while loading. This option would also be your workarround if you want to use an older version.
May 21 2020, 9:42 PM · MITK, DICOM, Cleared
sharonYu triaged T27432: Error loading DCE-MRI DICOM image as High priority.
May 21 2020, 9:24 AM · MITK, DICOM, Cleared

May 20 2020

floca added a comment to T27031: [Image statistics] Define identifier for statistics and histogram.

It's not about identification under the hood but the name of the data in the histogram, i.e. the label of the legend. But it's probably low priority for now.

May 20 2020, 11:26 PM · MITK (v2024.06)
floca claimed T27200: [Registration] Crash in frame corrector .
May 20 2020, 9:19 PM · Cleared, MITK (v2021.02)
floca claimed T27308: [statistics] Statistics with segmentations are not automatically updated if segmentation is changed..
May 20 2020, 9:18 PM · Cleared, MITK (v2021.02)
floca added a project to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Missing Info.
May 20 2020, 7:02 PM · Cleared, MITK (v2021.02)
floca edited projects for T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View, added: MITK, Restricted Project; removed MITK (v2021.02).

I keept the priority (as it is important im ML segmentation should be realy be able to replace everything) and moved it back into "MITK" as it is not realistic to make it in this cycle. We can reevaluate it later .

May 20 2020, 7:01 PM · MITK (v2023.04), Restricted Project
floca moved T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported from Backlog to Segmentation on the MITK (v2021.02) board.
May 20 2020, 6:57 PM · Restricted Project, Cleared, MITK (v2021.02)
floca renamed T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View from Either remove interpolation widgets from Multilabel Segmentation View or implement them to [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.
May 20 2020, 6:56 PM · MITK (v2023.04), Restricted Project
floca triaged T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported as High priority.
May 20 2020, 6:54 PM · Restricted Project, Cleared, MITK (v2021.02)
floca removed a project from T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Cleared.

So we have to make an auto load module for the planar figure IO. Right?

No, I think it is probably the last module that was never migrated to have an extra IO auto-load module.

@kislinsk I am somewhot confused, as your answer seems contradicting itself. Should we now have a IO auto load (sub) module for planar figure or not. If not, what do you propose?

May 20 2020, 6:39 PM · Cleared, MITK (v2021.02)
floca added a comment to T27209: [Registration] Mapper does not allow to select ML segmentation as input.

Fixing this branch I will focus on enabling mask selection at all again. The support of ML is covered in T27435: [Registration] Mapper does not properly support LabelSetImages.

May 20 2020, 5:06 PM · Cleared, MITK (v2021.02)
floca added a revision to T27209: [Registration] Mapper does not allow to select ML segmentation as input: Unknown Object (Differential Revision).
May 20 2020, 5:05 PM · Cleared, MITK (v2021.02)
floca triaged T27435: [Registration] Mapper does not properly support LabelSetImages as Normal priority.
May 20 2020, 4:48 PM · MITK (v2022.04)
floca claimed T27209: [Registration] Mapper does not allow to select ML segmentation as input.
May 20 2020, 3:56 PM · Cleared, MITK (v2021.02)
floca claimed T27346: [Registration] Mapper does not work with no registration selected.
May 20 2020, 3:34 PM · Cleared, MITK (v2021.02)
kislinsk moved T27416: DICOM Seg IO skips empty slices when storing DICOM seg from Backlog to DICOM SEG on the MITK (v2021.02) board.
May 20 2020, 10:35 AM · Cleared, HiGHmed, DICOM, MITK (v2021.02)
kislinsk moved T26949: DICOM SEG - 3D segmentations with only one slice cannot be reloaded as DICOM SEG from Backlog to DICOM SEG on the MITK (v2021.02) board.
May 20 2020, 10:35 AM · Auto-closed, MITK, DICOM, Missing Info
floca added a project to T26950: Add rule class for DICOM Seg relations to source image: Cleared.
May 20 2020, 10:34 AM · MITK (v2024.06), Cleared
floca moved T27373: ModelFit: Generate absolute curve data from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 20 2020, 10:14 AM · Restricted Project, MITK
floca moved T27413: MITK Workflow Q&A from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 20 2020, 10:14 AM · MITK, Request for Discussion
sharonYu added a project to T27432: Error loading DCE-MRI DICOM image: MITK.
May 20 2020, 8:30 AM · MITK, DICOM, Cleared
sharonYu created T27432: Error loading DCE-MRI DICOM image.
May 20 2020, 8:29 AM · MITK, DICOM, Cleared
sharonYu created T27431: Error loading DCE-MRI DICOM image.
May 20 2020, 8:28 AM

May 19 2020

eisenman merged task T27430: Ranking heatmaps in mult task report don't have titles into T27325: Plot titles in rankingHeatmap missing in multi task report.
May 19 2020, 11:00 AM · challengeR (v1.0)
eisenman merged T27430: Ranking heatmaps in mult task report don't have titles into T27325: Plot titles in rankingHeatmap missing in multi task report.
May 19 2020, 11:00 AM · challengeR (v1.0)
reinkea closed T27430: Ranking heatmaps in mult task report don't have titles as Resolved.

Ah perfect :) I was looking into a decathlon report which was apparently created with the master branch.

May 19 2020, 10:55 AM · challengeR (v1.0)
eisenman added a comment to T27430: Ranking heatmaps in mult task report don't have titles.

This seems to be a duplicate of T27325 and should already be solved on develop branch. Which version did you use?

May 19 2020, 10:53 AM · challengeR (v1.0)
kislinsk created MITK Elevated Branching Privileges.
May 19 2020, 8:43 AM
reinkea created T27430: Ranking heatmaps in mult task report don't have titles.
May 19 2020, 8:33 AM · challengeR (v1.0)

May 16 2020

griffith removed a watcher for MITK-ProjectTemplate: griffith.
May 16 2020, 6:10 AM
griffith added a watcher for MITK-ProjectTemplate: griffith.
May 16 2020, 6:07 AM

May 15 2020

floca updated the task description for T25801: DICOM Seg writer doesn't support 4d DICOM images.
May 15 2020, 6:08 PM · Auto-closed, MITK
floca added inline comments to rOBSHYPPOPYc5ef45302a73: loss_function_batch works for now, but only receives one candidate. Have to….
May 15 2020, 2:36 PM