Page MenuHomePhabricator
Feed All Stories

Jun 30 2020

norajitr added a comment to T27085: 2D region growing tool fails for low intensity regions.

@floca @nolden At this point I would say the task is still a blocker from a clinical point of view. The tool is somewhat usable, but still not always working as expected thus making it inconvenient and non-intuitive. Sometimes for example, the region growing cannot be further expanded in contrast to the similarity of nearby image intensities, sometimes it takes several trials at different seed points. Altogether, this makes the tool work differently than one would expect. Also sometimes, the tool displays some kind of 'lag' when waiting for region updates (i.e. mouse position updates that had just worked suddenly have no more effect).

Jun 30 2020, 4:16 PM · Cleared, MITK (v2021.02)
menjivar added a watcher for Photoacoustics: menjivar.
Jun 30 2020, 2:47 PM
k656s added a member for Kaapana (internal): r010a.
Jun 30 2020, 1:56 PM
floca closed T27201: [Registration] Executor layout in mask box is broken as Resolved.

Seems to be fixed already in the current develop branch

Jun 30 2020, 12:05 PM · Restricted Project, Cleared, MITK (v2021.02)
aguilera moved T27301: Add on boarding tutorial from In Progress to Done on the challengeR (v1.0) board.
Jun 30 2020, 12:01 PM · challengeR (v1.0)
aguilera committed rCHALLENGERb9aa4e2e6a52: Merge branch 'feature/T27301-AddOnBoardingTutorial' into develop (authored by aguilera).
Merge branch 'feature/T27301-AddOnBoardingTutorial' into develop
Jun 30 2020, 12:01 PM
aguilera committed rCHALLENGER24fca252fc4d: correct explanation (authored by aguilera).
correct explanation
Jun 30 2020, 11:55 AM
floca claimed T27493: Rework QmitkContourModelToImageWidget to be time point aware.

Covered by T27492 by accident ;)

Jun 30 2020, 11:54 AM · MITK (v2021.02)
aguilera committed rCHALLENGEReb20ffa0cf90: adapt documentation to v0.3.3 (authored by aguilera).
adapt documentation to v0.3.3
Jun 30 2020, 11:54 AM
floca added a revision to T27492: Rework QmitkBooleanOperationsWidget to be time point aware: Restricted Differential Revision.
Jun 30 2020, 11:50 AM · MITK (v2021.02)
neher closed T27512: Fix registration file renaming as Resolved.
Jun 30 2020, 11:49 AM · MITK Diffusion
neher committed rMITKDIFF108f4325ec45: Merge branch 'T27512-FixRenamingIssue' (authored by neher).
Merge branch 'T27512-FixRenamingIssue'
Jun 30 2020, 11:44 AM
neher committed rMITKDIFF402417bfc4da: Fix naming issue in cmdapp (authored by neher).
Fix naming issue in cmdapp
Jun 30 2020, 11:43 AM
neher committed rMITKDIFF5b3c0b588122: Merge branch 'T27512-FixRenamingIssue' (authored by neher).
Merge branch 'T27512-FixRenamingIssue'
Jun 30 2020, 11:38 AM
neher committed rMITKDIFFfdab76cac1da: Fix naming issue in cmdapp (authored by neher).
Fix naming issue in cmdapp
Jun 30 2020, 11:38 AM
thomass added a revision to T26974: [Segmentation] Region Growing 3D with 4D dataset not working: Restricted Differential Revision.
Jun 30 2020, 11:26 AM · MITK (v2021.02)
neher committed rMITKDIFF1625582d6eab: Merge branch 'T27512-FixRenamingIssue' (authored by neher).
Merge branch 'T27512-FixRenamingIssue'
Jun 30 2020, 10:58 AM
neher committed rMITKDIFFebc7079eaa01: Renamed include (authored by neher).
Renamed include
Jun 30 2020, 10:57 AM
neher added a comment to T27512: Fix registration file renaming.

Pushed new branch T27512-FixRenamingIssue.

Jun 30 2020, 10:57 AM · MITK Diffusion
neher triaged T27512: Fix registration file renaming as Normal priority.
Jun 30 2020, 10:56 AM · MITK Diffusion
floca committed rMITKf7333b92e781: T27497-Statistics_view_intensity_profile_slider_does_not_work (authored by floca).
T27497-Statistics_view_intensity_profile_slider_does_not_work
Jun 30 2020, 10:09 AM
floca committed rMITKf61fcb23bc3c: Fixed T27497 (authored by floca).
Fixed T27497
Jun 30 2020, 10:09 AM
floca closed T27497: Intensity profile of dynamic image only works for first timestep as Resolved by committing rMITKf61fcb23bc3c: Fixed T27497.
Jun 30 2020, 10:09 AM · MITK (v2021.02)
floca committed rMITKd68e055ff3bd: T27491 Corrected time point awareness of MatchPoint views (authored by floca).
T27491 Corrected time point awareness of MatchPoint views
Jun 30 2020, 10:08 AM
floca committed rMITKa4796ab1632c: Corrected time point awareness of MatchPoint views (authored by floca).
Corrected time point awareness of MatchPoint views
Jun 30 2020, 10:08 AM
floca closed T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware as Resolved by committing rMITKa4796ab1632c: Corrected time point awareness of MatchPoint views.
Jun 30 2020, 10:08 AM · MITK (v2021.02)
kalali added a comment to T27389: Running tutorial's Step8 gives Segmentation Fault!.

@kalali Your solution solved the problem. I'd like to point out that SetWidgetPlanesVisibility(true) is already called somewhere inside InitializeMultiWidget(), so just AddPlanesToDataStorage()is enough for rendering the planes.

Jun 30 2020, 9:41 AM · MITK (2018-04)
Qaler added a comment to 2020 Week 25 (Late June).

MITK is a great image processing tool that is very popular in our research group. Thank you guys for making/maintaining such an amazing open source project!
Any time schedule to upgrade ITK and VTK to latest version (ITK5.1 & VTK9)?

Jun 30 2020, 6:16 AM

Jun 29 2020

kislinsk closed T27486: Prepare changelog and migration guide for upcoming master merge as Resolved.
Jun 29 2020, 11:01 PM · MITK (v2021.02)
kislinsk committed rMITK4cc93539239d: 2020 Week 25 (Late June) (authored by kislinsk).
2020 Week 25 (Late June)
Jun 29 2020, 11:00 PM
kislinsk published a new version of 2020 Week 25 (Late June).
Jun 29 2020, 10:52 PM
aguilera moved T27302: Add sections to the readme from In Progress to Done on the challengeR (v1.0) board.
Jun 29 2020, 7:42 PM · challengeR (v1.0)
aguilera committed rCHALLENGERd0ffa6f0c308: Merge branch 'feature/T27302-AddSectionsToTheReadme' into develop (authored by aguilera).
Merge branch 'feature/T27302-AddSectionsToTheReadme' into develop
Jun 29 2020, 7:40 PM
aguilera committed rCHALLENGER7f10ea4057a7: add backports related issue (authored by aguilera).
add backports related issue
Jun 29 2020, 7:19 PM
floca claimed T27492: Rework QmitkBooleanOperationsWidget to be time point aware.
Jun 29 2020, 7:03 PM · MITK (v2021.02)
floca added a revision to T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware: Unknown Object (Differential Revision).
Jun 29 2020, 7:02 PM · MITK (v2021.02)
floca claimed T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware.
Jun 29 2020, 6:55 PM · MITK (v2021.02)
floca added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

New Image Statistics (preview)

The image statistics (modules ImageStatistics and ImageStatisticsUI as well as the QmitkImageStatisticsView provided by the plugin org.mitk.gui.qt.measurementtoolbox) have been heavily refactored on the backend and the frontend side. The rework is not yet finished as the current state just ensures that we have no regression but does only to a little extend tap into the potential of the new infrastructure.
The following paragraphs briefly summarize what’s new.

Jun 29 2020, 5:28 PM · MITK (v2021.02)
floca triaged T27510: [MITKDoc] Add/revise developers documentation for new statistics back-/frontend as Normal priority.
Jun 29 2020, 4:50 PM · MITK
floca edited projects for T24771: [MITKDoc] Add a concept documentation for the data storage inspectors and the overhaul of the selection concept, added: MITK (v2021.02); removed MITK.
Jun 29 2020, 4:47 PM · MITK (v2021.02)
kahl added a comment to T27500: Use Python/C-API for execution of Python Code with MITK-Python-Service.

Pushed new branch feature/T27500-use-PythonCApi-in-python-service.

Jun 29 2020, 3:44 PM · MITK
floca committed rMITKdb7545f1ff98: Fixed broking unit test (authored by floca).
Fixed broking unit test
Jun 29 2020, 3:28 PM
floca committed rMITKaa6caa16db68: Fixed broking unit test (authored by floca).
Fixed broking unit test
Jun 29 2020, 3:28 PM
kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

Just add it here.

Jun 29 2020, 3:12 PM · MITK (v2021.02)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0, as Resolved.
Jun 29 2020, 2:08 PM · MITK (v2021.02)
floca closed T27490: Correct handling of time points selected by SliceNavigator as Resolved.
Jun 29 2020, 2:08 PM · Noteworthy, MITK (v2021.02)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T27492: Rework QmitkBooleanOperationsWidget to be time point aware, as Resolved.
Jun 29 2020, 2:08 PM · MITK (v2021.02)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware, as Resolved.
Jun 29 2020, 2:08 PM · MITK (v2021.02)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T26974: [Segmentation] Region Growing 3D with 4D dataset not working, as Resolved.
Jun 29 2020, 2:08 PM · MITK (v2021.02)
floca committed rMITK9827e87b0805: T27490 - Correct handling of timepoints selected by SliceNavigator (authored by floca).
T27490 - Correct handling of timepoints selected by SliceNavigator
Jun 29 2020, 2:04 PM
floca committed rMITK795547ab54bc: Fixed review remarks (authored by floca).
Fixed review remarks
Jun 29 2020, 2:04 PM
floca committed rMITKaa706123b8cd: (ML)Segmentation views no reinit views according to the reference image (authored by floca).
(ML)Segmentation views no reinit views according to the reference image
Jun 29 2020, 2:04 PM
floca committed rMITKd8b575f7d1e9: Refactored QmitkImageCropperView to be time point aware. (authored by floca).
Refactored QmitkImageCropperView to be time point aware.
Jun 29 2020, 2:04 PM
floca committed rMITK70d71578a30c: Fixed review remarks. (authored by floca).
Fixed review remarks.
Jun 29 2020, 2:04 PM
floca committed rMITKae14494f50df: Reworked QmitkDicomInspectorView for time point awareness (authored by floca).
Reworked QmitkDicomInspectorView for time point awareness
Jun 29 2020, 2:04 PM
floca committed rMITK0e300ecea187: Refactored CESTStatisticView to be time point aware. (authored by floca).
Refactored CESTStatisticView to be time point aware.
Jun 29 2020, 2:04 PM
floca committed rMITK09e4ea88b587: Refactored AutoSegmentationTools to be time point aware (authored by floca).
Refactored AutoSegmentationTools to be time point aware
Jun 29 2020, 2:04 PM
floca committed rMITKa5f414eb66e6: Refactored QmitkSlicesInterpolater to be time point aware. (authored by floca).
Refactored QmitkSlicesInterpolater to be time point aware.
Jun 29 2020, 2:04 PM
floca committed rMITKe7dd2b342ea1: Add time point awareness to QmitkSliceBasedInterpolatorWidget (authored by floca).
Add time point awareness to QmitkSliceBasedInterpolatorWidget
Jun 29 2020, 2:04 PM
floca committed rMITK735b36be69b3: Removed unused/incorrect ui file. (authored by floca).
Removed unused/incorrect ui file.
Jun 29 2020, 2:04 PM
floca committed rMITK6b246a24bc55: Removed dead code (authored by floca).
Removed dead code
Jun 29 2020, 2:03 PM
floca committed rMITK8f6380912e9d: Added convinience method GetSelectedTimePoint to IRenderWindowPart (authored by floca).
Added convinience method GetSelectedTimePoint to IRenderWindowPart
Jun 29 2020, 2:03 PM
floca committed rMITK75e424bf5121: Added convienience methods to SliceNavigationController (authored by floca).
Added convienience methods to SliceNavigationController
Jun 29 2020, 2:03 PM
floca added a comment to T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

I would propose the following policy:

  1. All tools per default work only on the respective time step of the reference data and the segmentation, that are indicated by the currently selected time point (SliceNavigator). So this is general and independent from the fact if it is a 3D or a 4D segmentation. This is the same behavior like the interactive tools and does not break user expectations.
  2. It is up to the specific tool (must be discussed there) if for 4D reference images others then the current time step of the reference data step should be used. Per se, I would say no.
  3. It is up to the specific (3D) tool to allow the altering of more then the current segmentation time step (if the segmentation is 4D). If one wants such a feature I would add e.g. a check box to the tool like "confirm for all time steps".
Jun 29 2020, 1:48 PM · MITK (v2021.02), Request for Discussion
kalali triaged T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images as Normal priority.
Jun 29 2020, 1:36 PM · MITK (v2021.02), Request for Discussion
floca added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

I think I moved and aligned everything into a draft of the official changelog (click on View Draft Version): 2020 Week 25 (Late June).

@floca The only thing missing is statistics as it seems that the text above is not yet complete.

Jun 29 2020, 12:47 PM · MITK (v2021.02)
kalali added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

Image statistics are now correctly cached to prevent recalculation for the same image (-mask pair).
The UI of the histogram has been improved and is now theme-aware.

Jun 29 2020, 12:29 PM · MITK (v2021.02)
kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

I think I moved and aligned everything into a draft of the official changelog (click on View Draft Version): 2020 Week 25 (Late June).

Jun 29 2020, 12:12 PM · MITK (v2021.02)
kompan placed T27097: [MITKDoc] Revise Statistics Plugin Documentation up for grabs.
Jun 29 2020, 10:27 AM · Cleared, MITK (v2021.02)

Jun 27 2020

floca added a comment to T27497: Intensity profile of dynamic image only works for first timestep.

Histogram has a simelar problem, but to fix that the Histogramwidget also needs a rework). Such a rework should be done in conjunction with the rework of T27284

Jun 27 2020, 2:49 PM · MITK (v2021.02)
floca updated the task description for T27284: [Image Statistic] Histogram is only supported with one image and <=1 ROI.
Jun 27 2020, 2:45 PM · MITK (v2024.06)
floca claimed T27497: Intensity profile of dynamic image only works for first timestep.
Jun 27 2020, 2:41 PM · MITK (v2021.02)
floca added a revision to T27497: Intensity profile of dynamic image only works for first timestep: Unknown Object (Differential Revision).
Jun 27 2020, 2:41 PM · MITK (v2021.02)
floca triaged T27506: Extend checklists for segmentation view as High priority.
Jun 27 2020, 1:31 PM · MITK (v2022.04), Cleared
floca moved T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 27 2020, 1:30 PM · MITK (v2021.10), Missing Info, Restricted Project
floca triaged T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation as High priority.
Jun 27 2020, 1:30 PM · MITK (v2021.10), Missing Info, Restricted Project
floca moved T27506: Extend checklists for segmentation view from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 27 2020, 1:25 PM · MITK (v2022.04), Cleared
floca updated the task description for T27506: Extend checklists for segmentation view.
Jun 27 2020, 1:25 PM · MITK (v2022.04), Cleared
floca created T27506: Extend checklists for segmentation view.
Jun 27 2020, 1:24 PM · MITK (v2022.04), Cleared
floca closed T25030: Image navigator time slider moves twice as Wontfix.

This is due to the Autorepeat feature of the SpinBox up and down buttons (which allow to just keep the btn widget press and produce several clicks).
This feature can lead to problems, if you make to time consuming computations in your slot function, that is triggered by the value change, and therefor the button release event comes to late, the auto repeat kicks in.
So debug mode and especially break points often produce false positives. They should be ignored. It is only important if you can observe/reproduce this problem in release mode. I was not able to do so with ~10 dynamic images in one session at once.

Jun 27 2020, 1:19 PM · MITK (v2021.02)
floca added a comment to T27085: 2D region growing tool fails for low intensity regions.

@norajitr How pressing is this task with the work arround given by @nolden ?

Jun 27 2020, 12:16 PM · Cleared, MITK (v2021.02)

Jun 26 2020

kislinsk added a comment to 2020 Week 25 (Late June).
Jun 26 2020, 2:29 PM
kalali added a comment to T27097: [MITKDoc] Revise Statistics Plugin Documentation.

In the description it says:

MITK User Manual --> MITK Plugin Manuals --> Statistics Plugin

Jun 26 2020, 1:51 PM · Cleared, MITK (v2021.02)
kalali closed T25831: [MITDoc][ImageStatistics] Improve documentation as Invalid.

Will be continued in T27097: [MITKDoc] Revise Statistics Plugin Documentation.

Jun 26 2020, 1:26 PM · MITK
kislinsk edited the content of Changelog.
Jun 26 2020, 1:22 PM · MITK
kislinsk created an object: 2020 Week 25 (Late June).
Jun 26 2020, 1:16 PM
kislinsk created an object: Changelog.
Jun 26 2020, 1:14 PM · MITK
kislinsk edited the content of Phabricator Onboarding.
Jun 26 2020, 12:57 PM · Onboarding

Jun 25 2020

kalali added a comment to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.

Seems to be resolved because D329 changed

// In case the time is not valid use 0 to access the time geometry of the working node
unsigned int time_position = 0;
if (m_LastSNC->GetTime() != nullptr)
  time_position = m_LastSNC->GetTime()->GetPos();
Jun 25 2020, 2:11 PM · MITK (v2021.02)
floca added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.

But the 3d segmentation has only 1 timestep with duration = sum of durations of all 4D image timesteps, right?

Jun 25 2020, 1:53 PM · MITK (v2021.02)
kalali added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.

Yes. I think this is more related to your other discussion in T26974: "What to do with a 3D segmentation of a 4D image."

Jun 25 2020, 1:49 PM · MITK (v2021.02)
floca placed T27483: DICOM import of multi-channel data not working up for grabs.

Looked into the topics. Following comments:

Jun 25 2020, 1:47 PM · MITK (v2021.02), Restricted Project, DICOM
thomass added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.

But the 3d segmentation has only 1 timestep with duration = sum of durations of all 4D image timesteps, right?

Jun 25 2020, 1:44 PM · MITK (v2021.02)
floca claimed T27483: DICOM import of multi-channel data not working.
Jun 25 2020, 12:58 PM · MITK (v2021.02), Restricted Project, DICOM
kalali added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.
  • Works for dynamic (4D) segmentations but creates the same segmentation for all timesteps
  • Could not be reproduced for static segmentations since the workbench crashes during the creation of a static segmentation (related to T27476)
Jun 25 2020, 12:51 PM · MITK (v2021.02)
kislinsk closed T27503: Fix GCC 9 compiler errors on Ubuntu 20.04 as Resolved.
Jun 25 2020, 12:07 AM · MITK (v2021.02)
kislinsk added a comment to T27503: Fix GCC 9 compiler errors on Ubuntu 20.04.

Deleted branch bugfix/T27503-GCC-9.3-Ubuntu-20.04.

Jun 25 2020, 12:04 AM · MITK (v2021.02)
kislinsk committed rMITK479e4c4805f5: Merge branch 'bugfix/T27503-GCC-9.3-Ubuntu-20.04' into develop (authored by kislinsk).
Merge branch 'bugfix/T27503-GCC-9.3-Ubuntu-20.04' into develop
Jun 25 2020, 12:02 AM
kislinsk added a comment to T27503: Fix GCC 9 compiler errors on Ubuntu 20.04.

Pushed new branch bugfix/T27503-GCC-9.3-Ubuntu-20.04.

Jun 25 2020, 12:01 AM · MITK (v2021.02)

Jun 24 2020

kislinsk triaged T27503: Fix GCC 9 compiler errors on Ubuntu 20.04 as High priority.
Jun 24 2020, 11:16 PM · MITK (v2021.02)