In T24398#241991, @kislinsk wrote:I noticed that the whole plugin is a complete mess BTW and urgently needs at least some clean up to see all the potentials for improvements and bug fixes. :/
Our side or also the CTK part.
In T24398#241991, @kislinsk wrote:I noticed that the whole plugin is a complete mess BTW and urgently needs at least some clean up to see all the potentials for improvements and bug fixes. :/
Our side or also the CTK part.
I looked into the dicombrowser plugin and found out that the directory on Windows is something like %APPDATA%/../Local/Temp/TmpDicomFolder.************. However I didn't see pop up any files after retrieve.
Pushed new branch to rMITK MITK: feature/T28851-AddITKGrowCutTool.
In T29313#241891, @floca wrote:What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.
Tests work again. So if the DLL-Exception/failing tests was the reason for removing it, you can add it again.
This is your job @amiiney :)
Please move this Task to the IMSY Community Day Issue Board in GitLab:
I have updated the checklist according to the documented / actual function of the two tools.
However, I had to add a note regarding the "remove everything" functionality of the erase tool, which currently does not work correctly (?) when a segmented region touches the boundary of the image (see T29078 example 2).
I just tried to retrieve data from dicomserver.co.uk and I am able to query and kind of retrieve data. A repeated retrieve even tells me that existing files are overriden. At least that is what the console output tells me. But where are the retrieved images supposed to be stored? And shouldn't the retrieved images appear somewhere in the DICOM editor?
The idea was to provide an additional differential here for this task that adds the test so yes, the code is there and will be visible in the differential.
What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.
I have added a checklist for growcut into Checklist Segmentation – 3D Segmentation_EN.docx in Nextcloud.
There are no specific test cases (checklists) for other tools on 4D images as far as I know/have seen.
I think this Task should just kept in mind because the growcut tool is new.
I already wrote a test, but removed it for now so I could create the Diff (D712).
Now the Diff needs to be accepted and the T28851-AddImagesForGrowCutSegmentationTest Branch needs to be merged into the mitkdata repository:
Do we have a checklist for growcut? I guess that would be the place to add additional cases, wouldn't it?
Haven't you added a test alread? Or are you thinking about other test cases?
If this is the case, could you give a bit more input regarding your thoughts.
Discussion results:
We discussed on it.
To make our live a bit easier. I would say it is a data problem ;).
oh so I forgot to send it: But this is, what my browser had cashed: "Yes, so I recently tested it, with the current release."
But also, if I remember correctly, this was due to the Phantom dataset we have as the default dataset:
I removed a few slices at the end, and now it is working.
@gaoh Ping
@s349i Are those checked now? If not please do this ASAP and verify. Thanks.
Some further remarks as I am leaving DKFZ:
Deleted branch from rMITK MITK: bugfix/T29305-FixGDCMIssues.
Pushed new branch to rMITK MITK: bugfix/T29305-FixGDCMIssues.
I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.
Pushed new branch to rMITK MITK: feature/T29206-MVC_pattern_for_labelsets.
I quickly looked into this using the experimental state of the mxnMultiWidget but I get a Workbench crash. This might be unrelated so I tested something else:
I used the StdMultiWidget, loaded Pic3D but then I used the Render Window Manager to change the Mapper of the axial render window from 2D Mapper to 3D Mapper.
I get the following crash:
I will close it. For the reasons noted above.