Page MenuHomePhabricator
Feed All Stories

Sep 27 2022

floca edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK, Next Milestone; removed MITK (v2022.10).

I noticed that the whole plugin is a complete mess BTW and urgently needs at least some clean up to see all the potentials for improvements and bug fixes. :/

Our side or also the CTK part.

Sep 27 2022, 5:38 PM · Next Milestone, MITK, Request for Discussion, Missing Info
kalali added a parent task for T29316: Rename QmitkSliderNavigatorWidget and clean variable names: T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:43 PM · MITK (v2022.10)
kalali added a subtask for T29289: Compare responsibilities of QmitkSliceNavigationController related classes: T29316: Rename QmitkSliderNavigatorWidget and clean variable names.
Sep 27 2022, 12:43 PM · MITK
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:42 PM · MITK
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:17 PM · MITK
kislinsk added a comment to T24398: Dicom plugin: Retrieve does not work.

I looked into the dicombrowser plugin and found out that the directory on Windows is something like %APPDATA%/../Local/Temp/TmpDicomFolder.************. However I didn't see pop up any files after retrieve.

Sep 27 2022, 10:56 AM · Next Milestone, MITK, Request for Discussion, Missing Info
kalali triaged T29316: Rename QmitkSliderNavigatorWidget and clean variable names as Normal priority.
Sep 27 2022, 9:52 AM · MITK (v2022.10)

Sep 26 2022

floca claimed T29307: [Segmentation] Add a fill tool like e.g. GIMP or Photoshop has.
Sep 26 2022, 6:10 PM · Next Milestone, Request for Discussion, MITK (v2022.10)
s349i updated the task description for T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
Sep 26 2022, 9:41 AM · MITK (v2023.04), Checklist
s349i updated the task description for T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
Sep 26 2022, 9:28 AM · MITK (v2023.04), Checklist

Sep 23 2022

j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Pushed new branch to rMITK MITK: feature/T28851-AddITKGrowCutTool.

Sep 23 2022, 5:49 PM · MITK (v2022.10)
j762e added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.

Tests work again. So if the DLL-Exception/failing tests was the reason for removing it, you can add it again.

Sep 23 2022, 5:46 PM · MITK (v2023.04)
j762e attached a referenced file: F2572275: mitkGrowCutFilterTest.cpp.
Sep 23 2022, 5:37 PM · MITK (v2023.04)
j762e attached a referenced file: F2572274: files.cmake.
Sep 23 2022, 5:37 PM · MITK (v2023.04)
j762e attached a referenced file: F2572277: ExpectedResultImage.nrrd.
Sep 23 2022, 5:37 PM · MITK (v2023.04)
j762e attached a referenced file: F2572276: InputSeedImage.nrrd.
Sep 23 2022, 5:37 PM · MITK (v2023.04)
scholzpa added a comment to T29166: GSP: EndoCV detection challenge.

This is your job @amiiney :)

Sep 23 2022, 4:14 PM · Restricted Project
holzwart added a comment to T29166: GSP: EndoCV detection challenge.

Please move this Task to the IMSY Community Day Issue Board in GitLab:

Sep 23 2022, 3:15 PM · Restricted Project
s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool , a subtask of T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool, as Resolved.
Sep 23 2022, 3:01 PM · MITK (v2022.10)
s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool as Resolved.

I have updated the checklist according to the documented / actual function of the two tools.
However, I had to add a note regarding the "remove everything" functionality of the erase tool, which currently does not work correctly (?) when a segmented region touches the boundary of the image (see T29078 example 2).

Sep 23 2022, 3:01 PM · MITK (v2022.10)
d587s added a member for ARGOS UI: fsagodi.
Sep 23 2022, 2:01 PM
s434n claimed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool .
Sep 23 2022, 12:23 PM · MITK (v2022.10)
floca claimed T29078: [Segmentation] Erase tool has unclear edge cases.
Sep 23 2022, 10:59 AM · Next Milestone, Checklist
kislinsk moved T24398: Dicom plugin: Retrieve does not work from Backlog to MITK Meeting on the Request for Discussion board.
Sep 23 2022, 9:50 AM · Next Milestone, MITK, Request for Discussion, Missing Info
kislinsk added a project to T24398: Dicom plugin: Retrieve does not work: Request for Discussion.

I just tried to retrieve data from dicomserver.co.uk and I am able to query and kind of retrieve data. A repeated retrieve even tells me that existing files are overriden. At least that is what the console output tells me. But where are the retrieved images supposed to be stored? And shouldn't the retrieved images appear somewhere in the DICOM editor?

Sep 23 2022, 9:50 AM · Next Milestone, MITK, Request for Discussion, Missing Info

Sep 22 2022

kalali added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

The idea was to provide an additional differential here for this task that adds the test so yes, the code is there and will be visible in the differential.

Sep 22 2022, 8:03 PM · MITK (v2023.04)
floca added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.

Sep 22 2022, 4:44 PM · MITK (v2023.04)
j762e added a comment to T29311: Further observation of the GrowCut segmentation tool on 4D images.

I have added a checklist for growcut into Checklist Segmentation – 3D Segmentation_EN.docx in Nextcloud.
There are no specific test cases (checklists) for other tools on 4D images as far as I know/have seen.
I think this Task should just kept in mind because the growcut tool is new.

Sep 22 2022, 3:57 PM · MITK (v2023.04)
j762e added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

I already wrote a test, but removed it for now so I could create the Diff (D712).
Now the Diff needs to be accepted and the T28851-AddImagesForGrowCutSegmentationTest Branch needs to be merged into the mitkdata repository:

Sep 22 2022, 3:36 PM · MITK (v2023.04)
kalali closed T29219: StatusBar / mouse scrolling is broken as Resolved.
Sep 22 2022, 11:26 AM · MITK (v2022.10)
kalali committed rMITKe36380da1e5f: Update the status bar correctly (authored by kalali).
Update the status bar correctly
Sep 22 2022, 11:25 AM
kalali committed rMITK2eee153e5804: Merge remote-tracking branch 'maleike/fix-status-bar-updates' into develop (authored by kalali).
Merge remote-tracking branch 'maleike/fix-status-bar-updates' into develop
Sep 22 2022, 11:25 AM
maleike committed rMITK125b15152e2e: Force a rendering update before updating the status bar. (authored by maleike).
Force a rendering update before updating the status bar.
Sep 22 2022, 11:25 AM
kalali closed T29265: QmitkSelectableGLWidget is not used anymore and can be removed as Resolved.
Sep 22 2022, 11:22 AM · MITK (v2022.10)
kalali committed rMITK0c57d7ad6218: Remove unused QmitkSelectableGLWidget (authored by kalali).
Remove unused QmitkSelectableGLWidget
Sep 22 2022, 11:22 AM
kalali committed rMITK3edfcc488dc7: Remove QmitkSelectableGLWidget and unnecessary includes (authored by kalali).
Remove QmitkSelectableGLWidget and unnecessary includes
Sep 22 2022, 11:22 AM

Sep 21 2022

kalali added a revision to T29265: QmitkSelectableGLWidget is not used anymore and can be removed: Unknown Object (Differential Revision).
Sep 21 2022, 7:35 PM · MITK (v2022.10)
kalali claimed T29265: QmitkSelectableGLWidget is not used anymore and can be removed.
Sep 21 2022, 5:34 PM · MITK (v2022.10)
k688h removed a project from T28357: Running Isolated container in Kaapana ( Instead of Default Docker): Request for Discussion.
Sep 21 2022, 2:58 PM · Restricted Project, Kaapana (internal)
k688h removed a project from T28043: TFDA MVP1-Tasks:Tools and Technologies: Request for Discussion.
Sep 21 2022, 2:58 PM · Restricted Project, Kaapana (internal)
k688h triaged T28167: System set up: Multi Provider Site Version as Normal priority.
Sep 21 2022, 2:57 PM · Restricted Project
k688h removed a parent task for T29016: TFDA MVP - Airflow 2 Migration + Latest Kaapana Dev Branch Integration: Unknown Object (Maniphest Task).
Sep 21 2022, 2:41 PM · Restricted Project
floca added a comment to T29311: Further observation of the GrowCut segmentation tool on 4D images.

Do we have a checklist for growcut? I guess that would be the place to add additional cases, wouldn't it?

Sep 21 2022, 2:05 PM · MITK (v2023.04)
floca added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

Haven't you added a test alread? Or are you thinking about other test cases?
If this is the case, could you give a bit more input regarding your thoughts.

Sep 21 2022, 2:04 PM · MITK (v2023.04)
j762e triaged T29313: Add a Test to check if the GrowCut algorithm produces a different output as Normal priority.
Sep 21 2022, 1:39 PM · MITK (v2023.04)
j762e renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [SEG] Add ITK Growcut as segmentation tool to [SEG] Add ITK GrowCut as segmentation tool.
Sep 21 2022, 1:33 PM · MITK (v2022.10)
j762e renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [SEG] Evaluate if we should add itkGrowCut as a tool to [SEG] Add ITK Growcut as segmentation tool.
Sep 21 2022, 1:33 PM · MITK (v2022.10)
j762e triaged T29312: Add support for using layers other than layer 0 of the current LabelSetImage as Wishlist priority.
Sep 21 2022, 1:29 PM · MITK (v2023.04)
j762e triaged T29311: Further observation of the GrowCut segmentation tool on 4D images as Normal priority.
Sep 21 2022, 1:26 PM · MITK (v2023.04)
j762e triaged T29310: [ITK] Check if ITK 5.3 adds the GrowCut remote module by default as Normal priority.
Sep 21 2022, 1:24 PM · MITK (v2023.04)
j762e triaged T29309: [GrowCut] Further remarks regarding GrowCut as Low priority.
Sep 21 2022, 1:22 PM · MITK
floca moved T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool from Backlog to Tests/Checklists on the MITK (v2022.10) board.
Sep 21 2022, 12:52 PM · MITK (v2022.10)
floca triaged T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool as High priority.
Sep 21 2022, 12:52 PM · MITK (v2022.10)
floca triaged T29307: [Segmentation] Add a fill tool like e.g. GIMP or Photoshop has as Normal priority.
Sep 21 2022, 12:50 PM · Next Milestone, Request for Discussion, MITK (v2022.10)
floca triaged T29306: [Segmentation] Provide Close tool (behavior of old Fill tool) as Normal priority.
Sep 21 2022, 12:49 PM · Request for Discussion, MITK (v2022.10)
floca removed a project from T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool: Request for Discussion.

Discussion results:

Sep 21 2022, 12:44 PM · MITK (v2022.10)
floca added a comment to T29078: [Segmentation] Erase tool has unclear edge cases.

We discussed on it.

Sep 21 2022, 12:38 PM · Next Milestone, Checklist
floca edited projects for T29078: [Segmentation] Erase tool has unclear edge cases, added: Next Milestone; removed MITK (v2022.10), Request for Discussion.
Sep 21 2022, 11:45 AM · Next Milestone, Checklist
floca closed T28886: MITK Flowbench - Reopen created segmentation not working as Invalid.

To make our live a bit easier. I would say it is a data problem ;).

Sep 21 2022, 9:36 AM · MITK (v2022.10), Missing Info, Kaapana (internal)
gaoh added a comment to T28886: MITK Flowbench - Reopen created segmentation not working.

oh so I forgot to send it: But this is, what my browser had cashed: "Yes, so I recently tested it, with the current release."
But also, if I remember correctly, this was due to the Phantom dataset we have as the default dataset:
I removed a few slices at the end, and now it is working.

Sep 21 2022, 9:28 AM · MITK (v2022.10), Missing Info, Kaapana (internal)
floca added a comment to T28886: MITK Flowbench - Reopen created segmentation not working.

@gaoh Ping

Sep 21 2022, 9:07 AM · MITK (v2022.10), Missing Info, Kaapana (internal)
floca added a comment to T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.

@s349i Are those checked now? If not please do this ASAP and verify. Thanks.

Sep 21 2022, 8:57 AM · MITK (v2023.04), Checklist

Sep 20 2022

j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Some further remarks as I am leaving DKFZ:

Sep 20 2022, 3:33 PM · MITK (v2022.10)
kalali added a revision to T28851: [SEG] Add ITK GrowCut as segmentation tool: Restricted Differential Revision.
Sep 20 2022, 2:14 PM · MITK (v2022.10)
kislinsk closed T29305: Fix GDCM Globals issue with many MITK binaries as Resolved.
Sep 20 2022, 2:23 AM · MITK (v2022.10)
kislinsk added a comment to T29305: Fix GDCM Globals issue with many MITK binaries.

Deleted branch from rMITK MITK: bugfix/T29305-FixGDCMIssues.

Sep 20 2022, 2:22 AM · MITK (v2022.10)
kislinsk added a reverting change for rMITK7b40015a2c73: Use ITK's GDCM instead of separate GDCM: rMITK41939fd2a5d4: Revert "Use ITK's GDCM instead of separate GDCM".
Sep 20 2022, 2:22 AM
kislinsk committed rMITK41939fd2a5d4: Revert "Use ITK's GDCM instead of separate GDCM" (authored by kislinsk).
Revert "Use ITK's GDCM instead of separate GDCM"
Sep 20 2022, 2:22 AM
kislinsk committed rMITK7ea583973b1e: Upgrade GDCM from version 3.0.10 to 3.0.18 (authored by kislinsk).
Upgrade GDCM from version 3.0.10 to 3.0.18
Sep 20 2022, 2:22 AM
kislinsk committed rMITK54fc88f462dd: Downgrade GDCM from version 3.0.18 to 3.0.17 (authored by kislinsk).
Downgrade GDCM from version 3.0.18 to 3.0.17
Sep 20 2022, 2:22 AM
kislinsk committed rMITK0fa3a9b7684c: Downgrade GDCM to version 3.0.14 (authored by kislinsk).
Downgrade GDCM to version 3.0.14
Sep 20 2022, 2:22 AM
kislinsk committed rMITKea18963576a0: Merge branch 'bugfix/T29305-FixGDCMIssues' into develop (authored by kislinsk).
Merge branch 'bugfix/T29305-FixGDCMIssues' into develop
Sep 20 2022, 2:22 AM

Sep 19 2022

kislinsk added a revision to T29305: Fix GDCM Globals issue with many MITK binaries: Unknown Object (Differential Revision).
Sep 19 2022, 10:46 PM · MITK (v2022.10)
kislinsk added a reverting change for rMITK7b40015a2c73: Use ITK's GDCM instead of separate GDCM: Unknown Object (Differential Revision).
Sep 19 2022, 10:46 PM
kislinsk added a comment to T29305: Fix GDCM Globals issue with many MITK binaries.

Pushed new branch to rMITK MITK: bugfix/T29305-FixGDCMIssues.

Sep 19 2022, 10:43 PM · MITK (v2022.10)
kislinsk triaged T29305: Fix GDCM Globals issue with many MITK binaries as Unbreak Now! priority.
Sep 19 2022, 9:30 PM · MITK (v2022.10)
kalali claimed T29219: StatusBar / mouse scrolling is broken.
Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a comment to T29219: StatusBar / mouse scrolling is broken.

I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.

Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a revision to T29219: StatusBar / mouse scrolling is broken: Unknown Object (Differential Revision).
Sep 19 2022, 4:41 PM · MITK (v2022.10)
s434n committed rMITK26df569787e2: Fix typos (authored by s434n).
Fix typos
Sep 19 2022, 11:05 AM
s434n committed rMITKb4c69945ef44: fix typos and remove misspelled unused code (authored by s434n).
fix typos and remove misspelled unused code
Sep 19 2022, 11:05 AM

Sep 18 2022

floca added a comment to T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns.

Pushed new branch to rMITK MITK: feature/T29206-MVC_pattern_for_labelsets.

Sep 18 2022, 5:38 PM · MITK (v2023.04), Checklist

Sep 16 2022

kalali closed T28762: [Interaction] Remove deprecated / unused interaction files as Resolved.
Sep 16 2022, 11:00 PM · MITK
kalali committed rMITKcc1edae351e2: Remove unused interaction files (authored by kalali).
Remove unused interaction files
Sep 16 2022, 10:59 PM
kalali committed rMITKdd6756610999: Remove unused segmentation interaction files (authored by kalali).
Remove unused segmentation interaction files
Sep 16 2022, 10:59 PM
kalali committed rMITKb18f5343112e: Remove legacy state machine / display configuration (authored by kalali).
Remove legacy state machine / display configuration
Sep 16 2022, 10:59 PM
kalali committed rMITKd80fdb784ffe: Remove unused DisplayConfig.xml-file (authored by kalali).
Remove unused DisplayConfig.xml-file
Sep 16 2022, 10:59 PM
s434n closed T29287: Rework segmentation checklist for new modes of the picking tool as Resolved.
Sep 16 2022, 1:55 PM · MITK (v2022.10)
s434n claimed T29287: Rework segmentation checklist for new modes of the picking tool.
Sep 16 2022, 12:41 PM · MITK (v2022.10)

Sep 15 2022

kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 4:52 PM · MITK (v2022.10)
kalali triaged T29303: IGT classes do not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 4:43 PM · Next Milestone, MITK
j870n added a member for Kaapana (internal): kausch.
Sep 15 2022, 3:23 PM
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 3:00 PM · MITK (v2022.10)
kalali updated the task description for T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
Sep 15 2022, 3:00 PM · Next Milestone, MITK
kalali triaged T29302: Movie maker plugin does not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 2:59 PM · Next Milestone, MITK
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 9:33 AM · MITK (v2022.10)

Sep 14 2022

kalali added a comment to T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

I quickly looked into this using the experimental state of the mxnMultiWidget but I get a Workbench crash. This might be unrelated so I tested something else:
I used the StdMultiWidget, loaded Pic3D but then I used the Render Window Manager to change the Mapper of the axial render window from 2D Mapper to 3D Mapper.
I get the following crash:

Sep 14 2022, 6:20 PM · MITK, Pull Request
floca claimed T28524: Refactor LabelSetImage and associated classes..
Sep 14 2022, 11:27 AM · Next Milestone
floca closed T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Wontfix.
Sep 14 2022, 11:27 AM · MITK (v2022.10), Breaking Change
floca closed T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel as Wontfix.

I will close it. For the reasons noted above.

Sep 14 2022, 11:27 AM · MITK (v2022.10), Checklist