Page MenuHomePhabricator
Feed All Stories

Mar 19 2023

kislinsk committed rMITK65af279906d1: Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop (authored by kislinsk).
Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop
Mar 19 2023, 5:18 PM
kislinsk added a comment to T29494: Notify Views on Preference changes when the Preferences dialog is closed.

Pushed new branch to rMITK MITK: bugfix/T29494-RegressionInPreferencesChangedEvent.

Mar 19 2023, 5:17 PM · MITK (v2023.04)
kislinsk triaged T29494: Notify Views on Preference changes when the Preferences dialog is closed as Normal priority.
Mar 19 2023, 5:15 PM · MITK (v2023.04)

Mar 18 2023

a178n added a comment to T29461: TotalSegmentator output label names conundrum.

After meeting it is decided that:

  1. Label names/classes & their pixel values that are hardcoded in the python codebase will be parsed directly and shown in MITK for 2023.04 release (Ref: https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/map_to_binary.py)
  2. Certain subtasks which need multiple nifti file agglomeration (eg. "Body") will not be included in the 2023.04 release.
Mar 18 2023, 7:15 PM · MITK

Mar 17 2023

kalali closed T29402: [mxn multi widget] Concept for blocking individual render windows as Resolved.

With the child task T29335: [Segmentation] Show interactive warning for uninitialized render window geometry being closed, I will close this task as well. If more plugins should be able to enable blocked render windows, this should now be easily doable.

Mar 17 2023, 4:58 PM · MITK (v2023.04)
kalali closed T29335: [Segmentation] Show interactive warning for uninitialized render window geometry, a subtask of T29402: [mxn multi widget] Concept for blocking individual render windows, as Resolved.
Mar 17 2023, 4:57 PM · MITK (v2023.04)
kalali closed T29335: [Segmentation] Show interactive warning for uninitialized render window geometry as Resolved.
Mar 17 2023, 4:57 PM · MITK (v2023.04)
kalali committed rMITK4974a335ada8: Show warning for interaction reference geometry (authored by kalali).
Show warning for interaction reference geometry
Mar 17 2023, 4:57 PM
kalali committed rMITKc48fce2c31ca: Provide button overlay and use it to reset geometry (authored by kalali).
Provide button overlay and use it to reset geometry
Mar 17 2023, 4:57 PM
kalali committed rMITK1783751c9175: Clean base renderer (authored by kalali).
Clean base renderer
Mar 17 2023, 4:57 PM
kalali committed rMITKcf2f057add3c: Remove segmentation interactor and use new approach (authored by kalali).
Remove segmentation interactor and use new approach
Mar 17 2023, 4:57 PM
kalali committed rMITK077f4342b0e5: Provide functions to enable overlay warnings for not-aligned geometries (authored by kalali).
Provide functions to enable overlay warnings for not-aligned geometries
Mar 17 2023, 4:57 PM
kalali triaged T29493: RenderWindow management classes need to be revised / cleaned as Normal priority.
Mar 17 2023, 4:49 PM · MITK (v2024.06)
kalali added a revision to T26555: [mxn multi widget] Provide different default layouts: Unknown Object (Differential Revision).
Mar 17 2023, 3:32 PM · MITK
kalali triaged T29492: [mxn multi widget] Update and extend checklist as Normal priority.
Mar 17 2023, 3:31 PM · MITK (v2023.04)
kalali created T29492: [mxn multi widget] Update and extend checklist.
Mar 17 2023, 3:30 PM · MITK (v2023.04)
kalali moved T29491: [mxn multi widget] Provide F1-Help page from Backlog to Cycle on the MITK (v2023.04) board.
Mar 17 2023, 3:27 PM · MITK (v2023.04)
kalali triaged T29491: [mxn multi widget] Provide F1-Help page as Normal priority.
Mar 17 2023, 3:27 PM · MITK (v2023.04)
floca added a comment to T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns.

Pushed new branch to rMITK MITK: feature/T29206-MVC_for_labelset_v3.

Mar 17 2023, 9:02 AM · MITK (v2023.04), Checklist

Mar 16 2023

kalali triaged T29490: [StdMultiWidget] Block multi widget like it is done for the MxNMultiWidget as Normal priority.
Mar 16 2023, 6:54 PM · MITK (v2024.06)
kislinsk renamed T29489: Empty dialog may pop up when opening DICOM Browser on macOS from Empty dialog may pop up when opening DICOM Broswer on macOS to Empty dialog may pop up when opening DICOM Browser on macOS.
Mar 16 2023, 6:26 PM · MITK (v2023.04)
kislinsk closed T29489: Empty dialog may pop up when opening DICOM Browser on macOS as Resolved.
Mar 16 2023, 6:26 PM · MITK (v2023.04)
kislinsk added a comment to T29489: Empty dialog may pop up when opening DICOM Browser on macOS.

Deleted branch from rMITK MITK: bugfix/T29489-CreateProgressDialogOnTheFly.

Mar 16 2023, 6:26 PM · MITK (v2023.04)
kislinsk committed rMITK3cb98543eec0: Create progress dialog on the fly as it is shown immediately on creation (authored by kislinsk).
Create progress dialog on the fly as it is shown immediately on creation
Mar 16 2023, 6:26 PM
kislinsk committed rMITK751ab6fee6d8: Merge branch 'bugfix/T29489-CreateProgressDialogOnTheFly' into develop (authored by kislinsk).
Merge branch 'bugfix/T29489-CreateProgressDialogOnTheFly' into develop
Mar 16 2023, 6:25 PM
kislinsk added a comment to T29489: Empty dialog may pop up when opening DICOM Browser on macOS.

Pushed new branch to rMITK MITK: bugfix/T29489-CreateProgressDialogOnTheFly.

Mar 16 2023, 4:26 PM · MITK (v2023.04)
kislinsk triaged T29489: Empty dialog may pop up when opening DICOM Browser on macOS as High priority.
Mar 16 2023, 4:24 PM · MITK (v2023.04)
kislinsk added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

@kislinsk Thank you, I will test it.

First thing I noticed: An empty Window opens when I open the DICOM browser. I can change the focus to the main window, but I cannot close the empty one:

Screen Shot 2023-03-16 at 7.41.45 AM.png (996×1 px, 574 KB)

Mar 16 2023, 3:23 PM · MITK (v2023.04)
kalali added a revision to T29403: [mxn multi widget] Concept for crosshair data type: Restricted Differential Revision.
Mar 16 2023, 2:07 PM · MITK (v2023.04)
aklein added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

@kislinsk Thank you, I will test it.

Mar 16 2023, 12:43 PM · MITK (v2023.04)
kislinsk added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

@aklein Here's the latest snapshot installer for macOS: https://www.mitk.org/download/ci/snapshots/macOS%20Catalina/MITK-snapshots_2023-03-16-macos-x86_64.dmg

Mar 16 2023, 10:33 AM · MITK (v2023.04)
kislinsk closed T29488: 2023 Week 11 (Mid March) as Resolved.
Mar 16 2023, 8:05 AM · MITK
kislinsk edited the content of Changelog.
Mar 16 2023, 8:05 AM · MITK
kislinsk edited the content of MITK v2022.10.
Mar 16 2023, 8:04 AM
kislinsk added a comment to T29488: 2023 Week 11 (Mid March).

Deleted branch from rMITK MITK: release/T29488-2023-Week-11.

Mar 16 2023, 8:03 AM · MITK
kislinsk committed rMITK1d73e51dfab2: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Mar 16 2023, 8:03 AM
kislinsk committed rMITK562e1073a93b: 2023 Week 11 (Mid March) (authored by kislinsk).
2023 Week 11 (Mid March)
Mar 16 2023, 8:02 AM
kislinsk edited the content of 2023 Week 11 (Mid March).
Mar 16 2023, 7:48 AM
kislinsk added a comment to T29488: 2023 Week 11 (Mid March).

Pushed new branch to rMITK MITK: release/T29488-2023-Week-11.

Mar 16 2023, 6:45 AM · MITK
kislinsk triaged T29488: 2023 Week 11 (Mid March) as Normal priority.
Mar 16 2023, 6:38 AM · MITK
kislinsk created an object: 2023 Week 11 (Mid March).
Mar 16 2023, 6:37 AM

Mar 15 2023

a178n added a comment to T29463: Doxygen documentation for TotalSegmentator.

Pushed new branch to rMITK MITK: feature/T29463-totalsegmentator-doku-full.

Mar 15 2023, 8:42 PM · MITK (v2023.04)
floca added a comment to T29451: [SEG] Response labels all not displayed on Workbench.

Current interim thoughts:

Mar 15 2023, 5:55 PM · Cleared, MITK (v2023.04)
a178n created T29487: Tool Icon for TotalSegmentator.
Mar 15 2023, 5:53 PM · MITK (v2024.06)
a178n added a comment to T29451: [SEG] Response labels all not displayed on Workbench.

The issue is also applicable to TotalSegmentator tool where label id 1 (spleen) is predefined yet replaced as "Label 1" by MITK.

Mar 15 2023, 5:40 PM · Cleared, MITK (v2023.04)
a178n renamed T29451: [SEG] Response labels all not displayed on Workbench from MONAILabel response labels all not displayed on Workbench to [SEG] Response labels all not displayed on Workbench.
Mar 15 2023, 5:38 PM · Cleared, MITK (v2023.04)
r948e committed rMITKDIFFba84d252fa0b: User now creates two vtk spheres as start and end regions, which should be used… (authored by r948e).
User now creates two vtk spheres as start and end regions, which should be used…
Mar 15 2023, 5:31 PM
r948e committed rMITKDIFF6741aa4b264b: Update QmitkInteractiveFiberDissectionView.cpp (authored by r948e).
Update QmitkInteractiveFiberDissectionView.cpp
Mar 15 2023, 5:31 PM
r948e committed rMITKDIFFd09e5cc30141: Update QmitkInteractiveFiberDissectionView.cpp (authored by r948e).
Update QmitkInteractiveFiberDissectionView.cpp
Mar 15 2023, 5:31 PM
r948e committed rMITKDIFF5938557ad827: Update mitkSphereInteractor.cpp, mitkSphereInteractor.h, and 4 more files... (authored by r948e).
Update mitkSphereInteractor.cpp, mitkSphereInteractor.h, and 4 more files...
Mar 15 2023, 5:31 PM
kislinsk closed T29481: Fix and unify include guards as Resolved.
Mar 15 2023, 1:31 PM · MITK
kislinsk added a comment to T29481: Fix and unify include guards.

Deleted branch from rMITK MITK: bugfix/T29481-FixOddIncludeGuard.

Mar 15 2023, 1:31 PM · MITK
kislinsk committed rMITK1d80533a6247: Fix odd include guard situation (authored by kislinsk).
Fix odd include guard situation
Mar 15 2023, 1:31 PM
kislinsk committed rMITK11e962fc1548: Merge branch 'bugfix/T29481-FixOddIncludeGuard' into develop (authored by kislinsk).
Merge branch 'bugfix/T29481-FixOddIncludeGuard' into develop
Mar 15 2023, 1:31 PM
kislinsk added a comment to T29481: Fix and unify include guards.

Pushed new branch to rMITK MITK: bugfix/T29481-FixOddIncludeGuard.

Mar 15 2023, 1:30 PM · MITK
kislinsk reopened T29481: Fix and unify include guards as "Open".
Mar 15 2023, 1:28 PM · MITK

Mar 14 2023

a178n triaged T29485: TotalSegmentator User Testing as High priority.
Mar 14 2023, 9:07 PM · MITK
r948e renamed T29484: SphereInteractor from Create Interactor with vtk sphere to SphereInteractor.
Mar 14 2023, 4:18 PM · MITK Diffusion
r948e committed rMITKDIFFc4524c54cc36: fixed bug if not all fibers have equal number of points and the negative Bundle… (authored by r948e).
fixed bug if not all fibers have equal number of points and the negative Bundle…
Mar 14 2023, 4:18 PM
r948e claimed T29484: SphereInteractor.
Mar 14 2023, 4:16 PM · MITK Diffusion
r948e triaged T29484: SphereInteractor as Normal priority.
Mar 14 2023, 4:15 PM · MITK Diffusion
r948e created T29484: SphereInteractor.
Mar 14 2023, 4:14 PM · MITK Diffusion
r948e closed T29395: Fix Polygon Bug as Resolved.
Mar 14 2023, 4:13 PM · MITK Diffusion
r948e committed rMITKDIFF233799aa1a55: Ball init (authored by r948e).
Ball init
Mar 14 2023, 7:20 AM

Mar 13 2023

r948e committed rMITKDIFF9eea23c8ebd8: Comment on dmdf function (authored by r948e).
Comment on dmdf function
Mar 13 2023, 1:29 PM

Mar 10 2023

wiesenfa added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

Could someone please try on Windows

Mar 10 2023, 10:16 PM · challengeR
wiesenfa added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

oh I hate it so much. I know the problem, only Windows is affected. Parallelization does not work with forking there, I keep forgetting this. I'll look for a solution on windows

Mar 10 2023, 4:20 PM · challengeR
kislinsk updated subscribers of T29483: [Segmentation] Gracefully handle out of memory situations.
Mar 10 2023, 2:59 PM · MITK (v2024.06)
kislinsk triaged T29483: [Segmentation] Gracefully handle out of memory situations as High priority.
Mar 10 2023, 2:59 PM · MITK (v2024.06)
aekavur added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

I tested it with R 4.2.0 on Windows system and got the same error. I stopped the test and looked rankingBootstrapped1 and rankingBootstrapped2. Here are the screenshots:

Mar 10 2023, 2:57 PM · challengeR
kislinsk edited Description on Moved to git.dkfz.de.
Mar 10 2023, 2:53 PM
kislinsk set the color for wDB to Orange.
Mar 10 2023, 2:51 PM
kislinsk set the color for Python Ontology Populator to Orange.
Mar 10 2023, 2:50 PM
kislinsk set the color for MITK-MBI to Orange.
Mar 10 2023, 2:50 PM
kislinsk created Moved to git.dkfz.de.
Mar 10 2023, 2:49 PM
kislinsk claimed T29482: [Segmentation] Opened segmentation plugin and two binary mask in data manager lead to problems / crash.
Mar 10 2023, 1:11 PM · MITK (v2023.04)
kislinsk added a comment to T29482: [Segmentation] Opened segmentation plugin and two binary mask in data manager lead to problems / crash.

I noticed that it only happens in v2022.10 but not in the latest develop so chances are high that it is already fixed but it should be double-checked with the upcoming snapshot installer.

Mar 10 2023, 1:09 PM · MITK (v2023.04)
kahl triaged T29482: [Segmentation] Opened segmentation plugin and two binary mask in data manager lead to problems / crash as High priority.
Mar 10 2023, 12:19 PM · MITK (v2023.04)
kislinsk closed T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS as Resolved.
Mar 10 2023, 11:57 AM · MITK (v2023.04)
kislinsk added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

Deleted branch from rMITK MITK: bugfix/T29469-FixScanDirectoryFreeze.

Mar 10 2023, 11:56 AM · MITK (v2023.04)
kislinsk committed rMITKd3509e022867: Fix dialog modality for macOS (authored by kislinsk).
Fix dialog modality for macOS
Mar 10 2023, 11:56 AM
kislinsk committed rMITKc72e00997724: Merge branch 'bugfix/T29469-FixScanDirectoryFreeze' into develop (authored by kislinsk).
Merge branch 'bugfix/T29469-FixScanDirectoryFreeze' into develop
Mar 10 2023, 11:56 AM
kislinsk added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

Pushed new branch to rMITK MITK: bugfix/T29469-FixScanDirectoryFreeze.

Mar 10 2023, 11:55 AM · MITK (v2023.04)
kislinsk claimed T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

The issue is:

Mar 10 2023, 11:51 AM · MITK (v2023.04)

Mar 9 2023

kislinsk closed T29481: Fix and unify include guards as Resolved.
Mar 9 2023, 2:50 PM · MITK
kislinsk added a comment to T29481: Fix and unify include guards.

Deleted branch from rMITK MITK: bugfix/T29481-FixAndUnifyIncludeGuards.

Mar 9 2023, 2:50 PM · MITK
kislinsk committed rMITKb4b0312c5a99: Add missing include guards (authored by kislinsk).
Add missing include guards
Mar 9 2023, 2:50 PM
kislinsk committed rMITK4f40514be593: Fix missing mitk namespace (authored by kislinsk).
Fix missing mitk namespace
Mar 9 2023, 2:50 PM
kislinsk committed rMITK6539ce3c8576: Remove dangling file (authored by kislinsk).
Remove dangling file
Mar 9 2023, 2:50 PM
kislinsk committed rMITKe0a248a0eb14: Fix typo in copyright headers (authored by kislinsk).
Fix typo in copyright headers
Mar 9 2023, 2:50 PM
kislinsk committed rMITK3ac48d9e0e6f: Fix copyright headers (authored by kislinsk).
Fix copyright headers
Mar 9 2023, 2:50 PM
kislinsk committed rMITKd6c7759137eb: Adapt ctor and dtor definitions to new class name (authored by kislinsk).
Adapt ctor and dtor definitions to new class name
Mar 9 2023, 2:49 PM
kislinsk committed rMITK545645a982b1: Remove dispensable comments (authored by kislinsk).
Remove dispensable comments
Mar 9 2023, 2:49 PM
kislinsk committed rMITKb8e6bfd728c4: Prepare header files for automatic unification of include guards (authored by kislinsk).
Prepare header files for automatic unification of include guards
Mar 9 2023, 2:49 PM
kislinsk committed rMITKf2088ae79d37: Unify include guards (authored by kislinsk).
Unify include guards
Mar 9 2023, 2:49 PM
kislinsk committed rMITK8f9504d2c63f: Remove closing include guard comments (authored by kislinsk).
Remove closing include guard comments
Mar 9 2023, 2:49 PM
kislinsk committed rMITKda3f7addf2ed: Merge branch 'bugfix/T29481-FixAndUnifyIncludeGuards' into develop (authored by kislinsk).
Merge branch 'bugfix/T29481-FixAndUnifyIncludeGuards' into develop
Mar 9 2023, 2:49 PM
kislinsk added a comment to T29481: Fix and unify include guards.

Pushed new branch to rMITK MITK: bugfix/T29481-FixAndUnifyIncludeGuards.

Mar 9 2023, 1:55 PM · MITK
kislinsk triaged T29481: Fix and unify include guards as Normal priority.
Mar 9 2023, 1:13 PM · MITK
kislinsk closed T29480: [Segmentation] Remove unused classes and icons as Resolved.
Mar 9 2023, 9:47 AM · MITK