Page MenuHomePhabricator

a178n (Ashis Ravindran)
User

Projects

User Details

User Since
Nov 19 2020, 10:58 PM (149 w, 3 d)

Recent Activity

Aug 31 2023

a178n added a comment to T29652: [Preferences] Cannot open SAM preference page after tool activation.

After suspecting whether python process using std::async would be causing the issue, like below:

m_Future = std::async(std::launch::async, &mitk::SegmentAnythingPythonService::start_python_daemon, this);

I tried starting python process using basic std::thread like shown below:

std::thread([&](){mitk::SegmentAnythingPythonService::start_python_daemon();}).detach();

there is no change in behavior.
The issue root cause still eludes me.

Aug 31 2023, 2:45 PM · MITK (v2023.10)

Aug 11 2023

a178n closed T29560: TotalSegmentator Label naming scheme, a subtask of T29437: [SEG] Add TotalSegmentator, as Resolved.
Aug 11 2023, 2:55 PM · MITK
a178n closed T29560: TotalSegmentator Label naming scheme as Resolved.
Aug 11 2023, 2:55 PM · MITK (v2023.10)
a178n committed rMITKfb7dfa8e93d7: Add regex for totalsegmentator label name parsing (authored by a178n).
Add regex for totalsegmentator label name parsing
Aug 11 2023, 2:55 PM
a178n committed rMITKce2d44ed17aa: Fix totalsegmentator label name parsing (authored by a178n).
Fix totalsegmentator label name parsing
Aug 11 2023, 2:55 PM

Aug 9 2023

a178n added a revision to T29560: TotalSegmentator Label naming scheme: Unknown Object (Differential Revision).
Aug 9 2023, 6:34 PM · MITK (v2023.10)
a178n added a comment to T29560: TotalSegmentator Label naming scheme.

Pushed new branch to rMITK MITK: feature/T29560-totalseg-label-update.

Aug 9 2023, 5:23 PM · MITK (v2023.10)
a178n placed T29437: [SEG] Add TotalSegmentator up for grabs.
Aug 9 2023, 5:22 PM · MITK
a178n claimed T29560: TotalSegmentator Label naming scheme.

After meeting, it was decided to remove the quotes from label names.

Aug 9 2023, 11:32 AM · MITK (v2023.10)
a178n lowered the priority of T29560: TotalSegmentator Label naming scheme from High to Normal.
Aug 9 2023, 11:31 AM · MITK (v2023.10)
a178n removed a project from T29560: TotalSegmentator Label naming scheme: Request for Discussion.
Aug 9 2023, 11:31 AM · MITK (v2023.10)

Aug 8 2023

a178n moved T29560: TotalSegmentator Label naming scheme from Backlog to MITK Meeting on the Request for Discussion board.
Aug 8 2023, 3:38 PM · MITK (v2023.10)

Jul 26 2023

a178n added a comment to T28181: [Segmentation] Should warning messages be passed on to the UI?.

It's agreed in the meeting that the status quo is inconsistent.

Jul 26 2023, 12:17 PM · MITK (v2023.10)
a178n lowered the priority of T28181: [Segmentation] Should warning messages be passed on to the UI? from Normal to Low.
Jul 26 2023, 12:00 PM · MITK (v2023.10)
a178n added a subtask for T29649: Classification Module clean up: T29631: Integration of an updated Feature Branch.
Jul 26 2023, 11:50 AM · MITK (v2023.10), Request for Discussion
a178n added a parent task for T29631: Integration of an updated Feature Branch: T29649: Classification Module clean up.
Jul 26 2023, 11:50 AM · MITK
a178n removed a project from T29631: Integration of an updated Feature Branch: Request for Discussion.
Jul 26 2023, 11:50 AM · MITK
a178n updated the task description for T29649: Classification Module clean up.
Jul 26 2023, 11:44 AM · MITK (v2023.10), Request for Discussion
a178n updated the task description for T29649: Classification Module clean up.
Jul 26 2023, 11:42 AM · MITK (v2023.10), Request for Discussion

Jul 25 2023

a178n added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

Yes, after commenting the 4 lines in the mitkExtractSliceFilter I am getting 3 component image.
Also, found out that the following works instead of commenting the snippet out:
Comment vectorComponentExtractor->SetComponents(m_Component); and pass on exact component needed to vectorComponentExtractor->SetComponents(0,1,2);.

Jul 25 2023, 3:26 PM · Request for Discussion, MITK (v2023.10)
a178n edited projects for T29485: TotalSegmentator User Testing , added: MITK; removed MITK (v2023.10).
Jul 25 2023, 11:53 AM · MITK
a178n lowered the priority of T29485: TotalSegmentator User Testing from High to Normal.
Jul 25 2023, 11:53 AM · MITK
a178n closed T29569: [Checklist] Update TotalSegmentator & nnUNet checklist, a subtask of T29437: [SEG] Add TotalSegmentator, as Resolved.
Jul 25 2023, 11:46 AM · MITK
a178n closed T29569: [Checklist] Update TotalSegmentator & nnUNet checklist as Resolved.

Checklists updated

Jul 25 2023, 11:46 AM · MITK (v2023.10), Checklist
a178n added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

Oh ok. Yes, I can the see the pixel type "rgb". Also, when I save the mitk::Image object using IOUtils::Save, I can see (in python) that the written image is 3 channel.
But the issue still occurs, channel is information is ultimately lost here in mitk::SegWithPreviewTool::UpdatePreview:

Jul 25 2023, 10:20 AM · Request for Discussion, MITK (v2023.10)

Jul 24 2023

a178n added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

After a little debugging, I see that even DataNode::GetData() returns single channel Image.
eg. dynamic_cast<const Image *>(m_SegmentationInputNode->GetData())
SegPreviewTool class uses this image for further processing.

Jul 24 2023, 2:08 PM · Request for Discussion, MITK (v2023.10)

Jul 22 2023

a178n claimed T30153: SAM tool: Add caching support for Cross-hair rotated image views.
Jul 22 2023, 12:47 AM · MITK (v2023.10)
a178n claimed T30156: Level Window contrast effect in SAM tool.
Jul 22 2023, 12:47 AM · MITK (v2023.10)

Jul 20 2023

a178n closed T30156: Level Window contrast effect in SAM tool as Resolved.
Jul 20 2023, 1:04 PM · MITK (v2023.10)
a178n closed T30156: Level Window contrast effect in SAM tool, a subtask of T29524: SAM in MITK, as Resolved.
Jul 20 2023, 1:04 PM · MITK
a178n added a comment to T30156: Level Window contrast effect in SAM tool.

Anyway after discussing with Ralf, the problem at hand - implementing levelwindow effect of input images to SAM, is solved using itk::IntensityWindowingImageFilter.

Jul 20 2023, 1:04 PM · MITK (v2023.10)
a178n created T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.
Jul 20 2023, 10:43 AM · Request for Discussion, MITK (v2023.10)

Jul 19 2023

a178n moved T29645: Test Plan for SAM from Backlog to Cycle on the MITK (v2023.10) board.
Jul 19 2023, 11:43 AM · MITK (v2023.10)
a178n edited projects for T29645: Test Plan for SAM, added: MITK (v2023.10); removed MITK.
Jul 19 2023, 11:40 AM · MITK (v2023.10)
a178n added a comment to T29645: Test Plan for SAM.

Updated document: https://hub.dkfz.de/f/55254009

Jul 19 2023, 11:39 AM · MITK (v2023.10)
a178n added a project to T29596: Move out FAST checkbox from Advanced: Request for Discussion.
Jul 19 2023, 11:36 AM · Request for Discussion, MITK (v2023.10), Checklist
a178n moved T29540: SAM as 2D tool in MITK from Cycle to Segmentation on the MITK (v2023.10) board.
Jul 19 2023, 10:34 AM · MITK (v2023.10)
a178n moved T29604: SAM as 2D Tool in MITK- iteration 2 from Segmentation to Cycle on the MITK (v2023.10) board.
Jul 19 2023, 10:34 AM · MITK (v2023.10)
a178n moved T29644: Doxygen documentation for SAM from Backlog to Cycle on the MITK (v2023.10) board.
Jul 19 2023, 10:31 AM · MITK (v2023.10)

Jul 18 2023

a178n added a comment to T30156: Level Window contrast effect in SAM tool.
  1. I am seeing the array in python after writing it out IOUtil::Save(mitkImage, imagePath);. That's 4 channel image. ie. 32x32x4.
  2. I use vtkMitkLevelWindowFilter because you recommended(?) and also its used by MITK for its levelwindow processing and at few other occasions. So this data type change is widely affecting MITK. But whether its compensated somewhere else or not is not clear for me.

But for SAM tool- Thanks for the tip, I will try out vtkImageMapToColors and see.

Jul 18 2023, 4:26 PM · MITK (v2023.10)
a178n added a comment to T30156: Level Window contrast effect in SAM tool.

Hi,
I finally could apply levelwindow Filter on image successfully for SAM tool.
But that seems to opened up another can of worms 😅 (?)
The vtkMitkLevelWindowFilter gives me 2D 4 channel image. But the channels are duplicate. I verified using numpy/python. Presumably. I can just take out one channel slice and that should be it.
But I observe somethings not correct:

  1. I convert vtk image to mitk image using the following syntax:
Jul 18 2023, 3:10 PM · MITK (v2023.10)

Jul 13 2023

a178n added a comment to T29645: Test Plan for SAM.

First draft available here: https://hub.dkfz.de/f/55114850

Jul 13 2023, 3:20 PM · MITK (v2023.10)
a178n closed T30153: SAM tool: Add caching support for Cross-hair rotated image views, a subtask of T29524: SAM in MITK, as Resolved.
Jul 13 2023, 11:57 AM · MITK
a178n closed T30153: SAM tool: Add caching support for Cross-hair rotated image views as Resolved.
Jul 13 2023, 11:57 AM · MITK (v2023.10)
a178n added a comment to T30153: SAM tool: Add caching support for Cross-hair rotated image views.

Updated logic to use only Normal and center to generate unique hash for a plane. Updated D847

Jul 13 2023, 11:57 AM · MITK (v2023.10)
a178n edited projects for T29437: [SEG] Add TotalSegmentator, added: MITK; removed MITK (v2023.10).
Jul 13 2023, 10:35 AM · MITK
a178n closed T30150: Decommission current nnUNet(v1) tool? as Wontfix.

nnUNet(v1) won't be removed until nnUnet v2 is introduced.

Jul 13 2023, 10:35 AM · Request for Discussion, MITK (v2023.10)

Jul 12 2023

a178n added a revision to T30153: SAM tool: Add caching support for Cross-hair rotated image views: Unknown Object (Differential Revision).
Jul 12 2023, 2:56 PM · MITK (v2023.10)
a178n added a revision to T29604: SAM as 2D Tool in MITK- iteration 2: Unknown Object (Differential Revision).
Jul 12 2023, 2:55 PM · MITK (v2023.10)

Jul 10 2023

a178n renamed T30153: SAM tool: Add caching support for Cross-hair rotated image views from SAM tool support Cross-hair rotated images to SAM tool: Add caching support for Cross-hair rotated image views.
Jul 10 2023, 11:29 PM · MITK (v2023.10)
a178n added a project to T30156: Level Window contrast effect in SAM tool: Request for Discussion.
Jul 10 2023, 5:22 PM · MITK (v2023.10)
a178n added a comment to T30156: Level Window contrast effect in SAM tool.

I tried to implement this feature using the below snippet in DoUpdatePreview method.
The image get written successfully however there is no level window effect in the output image. Looks normal. What's going on?

mitk::LevelWindow levelWindow;
this->GetToolManager()->GetReferenceData(0)->GetLevelWindow(levelWindow);
MITK_INFO << "levelWindow.GetLowerWindowBound(): " << levelWindow.GetLowerWindowBound();
MITK_INFO << "levelWindow.GetUpperWindowBound(): " << levelWindow.GetUpperWindowBound();
MITK_INFO << "levelWindow.GetWindow(): " << levelWindow.GetWindow();
MITK_INFO << "levelWindow.GetLevel(): " << levelWindow.GetLevel();
Jul 10 2023, 5:22 PM · MITK (v2023.10)
a178n triaged T30156: Level Window contrast effect in SAM tool as Normal priority.
Jul 10 2023, 5:19 PM · MITK (v2023.10)

Jul 7 2023

a178n added a comment to T30154: MONAI Label server usage issues.

Multistage Vertebra Segmentation
Multistage Vertebra Segmentation is an auto segmentation workflow involving multiple models namely, localization_spine, localization_vertebra & segmentation_vertebra (unexposed).
There could be several issues in this:

  1. localization_spine: In practice, this gives me binary mask even though there is a whole of labels exposed in the API. This is in compliance with the documentation. But then the labels it claims to segment in the API don't make sense.
Jul 7 2023, 10:59 AM · MITK

Jul 6 2023

a178n added a comment to T30154: MONAI Label server usage issues.

CUDA memory not cleared when out-of-memory exception occurs
Not all models have the same VRAM requirement.
When a model cannot run inferencing due to torch.cuda.OutOfMemoryError, exception occurs at server side clogging the GPU. Even if another model which could have potentially ran on the GPU, this clogging blocks it. Ideally TORCH.CUDA.EMPTY_CACHE should have been called to make room for next inferencing calls.

Jul 6 2023, 5:28 PM · MITK
a178n triaged T30154: MONAI Label server usage issues as Normal priority.
Jul 6 2023, 5:23 PM · MITK
a178n triaged T30153: SAM tool: Add caching support for Cross-hair rotated image views as Normal priority.
Jul 6 2023, 11:50 AM · MITK (v2023.10)

Jul 5 2023

a178n added a comment to T29644: Doxygen documentation for SAM.

Pushed new branch to rMITK MITK: feature/T29644-sam-doku.

Jul 5 2023, 5:04 PM · MITK (v2023.10)

Jul 4 2023

a178n reopened T29539: SAM Python wrapper for MITK as "Open".
Jul 4 2023, 11:32 PM · MITK (v2023.10)
a178n reopened T29539: SAM Python wrapper for MITK, a subtask of T29524: SAM in MITK, as Open.
Jul 4 2023, 11:32 PM · MITK
a178n closed T29539: SAM Python wrapper for MITK, a subtask of T29524: SAM in MITK, as Resolved.
Jul 4 2023, 11:32 PM · MITK
a178n closed T29539: SAM Python wrapper for MITK as Resolved.

Update: Wrapper exists now at https://github.com/ASHISRAVINDRAN/sam-mitk

Jul 4 2023, 11:32 PM · MITK (v2023.10)
a178n triaged T30151: MONAI Label tool support other interaction patterns as Normal priority.
Jul 4 2023, 11:27 PM · MITK (v2023.10)
a178n closed T30146: SAMtool: Problem while downloading pretrained models as Resolved.

Python wrapper now automatically downloads model type. The feature lifted off from MITK c++ code base

Jul 4 2023, 11:23 PM · MITK (v2023.10)
a178n closed T30146: SAMtool: Problem while downloading pretrained models, a subtask of T29524: SAM in MITK, as Resolved.
Jul 4 2023, 11:23 PM · MITK
a178n claimed T30146: SAMtool: Problem while downloading pretrained models.
Jul 4 2023, 11:23 PM · MITK (v2023.10)
a178n updated the task description for T30150: Decommission current nnUNet(v1) tool?.
Jul 4 2023, 11:20 PM · Request for Discussion, MITK (v2023.10)
a178n triaged T30150: Decommission current nnUNet(v1) tool? as Normal priority.
Jul 4 2023, 11:07 PM · Request for Discussion, MITK (v2023.10)
a178n closed T29294: Extend &/or Test nnUnet(v2) on Windows as Resolved.

Fabian has reported than nnUNet(v2) python codebase can run to Windows.

Jul 4 2023, 11:00 PM · MITK (v2023.10), Request for Discussion
a178n closed T29294: Extend &/or Test nnUnet(v2) on Windows , a subtask of T29275: Test new nnUNet(v2) python codebase with MITK, as Resolved.
Jul 4 2023, 11:00 PM · MITK (v2023.10)
a178n triaged T30149: nnUNet(v2) in MITK as Normal priority.
Jul 4 2023, 10:57 PM · MITK (v2023.10)
a178n added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

yes, issue exists the last time I tested.

Jul 4 2023, 9:54 PM · MITK (v2023.10)

Jul 3 2023

a178n renamed T30147: MONAI Label: New approach using python wrapper?? from MONAI Label: New approach using python wrapper??q to MONAI Label: New approach using python wrapper??.
Jul 3 2023, 4:48 PM · Request for Discussion, MITK (v2023.10)
a178n renamed T30147: MONAI Label: New approach using python wrapper?? from MONAI Label: New approach using python wrapper to MONAI Label: New approach using python wrapper??q.
Jul 3 2023, 4:47 PM · Request for Discussion, MITK (v2023.10)

Jul 2 2023

a178n triaged T30147: MONAI Label: New approach using python wrapper?? as Normal priority.
Jul 2 2023, 11:34 PM · Request for Discussion, MITK (v2023.10)

Jun 30 2023

a178n added a comment to T30146: SAMtool: Problem while downloading pretrained models.

A practical solution is to shift the download feature into the python wrapper.

Jun 30 2023, 1:00 PM · MITK (v2023.10)
a178n added a comment to T30146: SAMtool: Problem while downloading pretrained models.

After discussion with @kislinsk, it's presumed that Ubuntu 22.04 comes with OpenSSL 3 which is incompatible to OpenSSL 1.1.1. Qt from the online installer was built against OpenSSL 1.1.1, though. That's why it is not working. It probably works Ubuntu setups with system Qt 5 which I guess is patched to work with system OpenSSL 3.
Therefore, so the way out, without any fixes to get this running on Ubuntu 22.04 is on the actual build machine when using system Qt5.

Jun 30 2023, 12:59 PM · MITK (v2023.10)
a178n triaged T30146: SAMtool: Problem while downloading pretrained models as Normal priority.
Jun 30 2023, 12:19 PM · MITK (v2023.10)

Jun 29 2023

a178n removed a project from T29655: SAM tool: Enable 2D RGB image support: Request for Discussion.
Jun 29 2023, 2:31 PM · MITK (v2023.10)
a178n closed T29655: SAM tool: Enable 2D RGB image support, a subtask of T29524: SAM in MITK, as Resolved.
Jun 29 2023, 2:31 PM · MITK
a178n closed T29655: SAM tool: Enable 2D RGB image support as Resolved.

Code test and patched for 2D image support.

Jun 29 2023, 2:31 PM · MITK (v2023.10)

Jun 27 2023

a178n added a comment to T29655: SAM tool: Enable 2D RGB image support.

I am not sure what happens when 2D 3 channel is loaded for segmentation. Never tested the behaviour of the SegWithPreviewTool API. From my side, I need to update the wrapper to accommodate for 3 channel images. Of course, it's a straightforward change but at the moment, 3-channel won't work.

Jun 27 2023, 6:06 PM · MITK (v2023.10)
a178n triaged T29655: SAM tool: Enable 2D RGB image support as Normal priority.
Jun 27 2023, 5:01 PM · MITK (v2023.10)
a178n closed T29635: SAM tool: Cannot Confirm segmentation properly, a subtask of T29604: SAM as 2D Tool in MITK- iteration 2, as Resolved.
Jun 27 2023, 2:41 PM · MITK (v2023.10)
a178n closed T29635: SAM tool: Cannot Confirm segmentation properly as Resolved.
Jun 27 2023, 2:41 PM · MITK (v2023.10)
a178n triaged T29654: SAM tool: Preview not fully cleared when Reset Picks button is clicked as Normal priority.
Jun 27 2023, 1:48 PM · MITK (v2023.10)
a178n triaged T29653: SAM tool: Install process can be non-blocking as Normal priority.
Jun 27 2023, 11:06 AM · MITK (v2023.10)
a178n triaged T29652: [Preferences] Cannot open SAM preference page after tool activation as Normal priority.
Jun 27 2023, 9:52 AM · MITK (v2023.10)

Jun 26 2023

a178n triaged T29651: [Preferences] SAM tool Preferences not rendered nicely on MacOS as Normal priority.
Jun 26 2023, 7:32 PM · MITK (v2023.10)
a178n renamed T29539: SAM Python wrapper for MITK from Python wrapper for MITK to SAM Python wrapper for MITK.
Jun 26 2023, 7:28 PM · MITK (v2023.10)
a178n added a subtask for T29539: SAM Python wrapper for MITK: T29648: SAM Python: Improve the wrapper to be used independently without MITK.
Jun 26 2023, 7:27 PM · MITK (v2023.10)
a178n removed a subtask for T29604: SAM as 2D Tool in MITK- iteration 2: T29648: SAM Python: Improve the wrapper to be used independently without MITK.
Jun 26 2023, 7:27 PM · MITK (v2023.10)
a178n edited parent tasks for T29648: SAM Python: Improve the wrapper to be used independently without MITK, added: T29539: SAM Python wrapper for MITK; removed: T29604: SAM as 2D Tool in MITK- iteration 2.
Jun 26 2023, 7:27 PM · MITK
a178n added a subtask for T29604: SAM as 2D Tool in MITK- iteration 2: T29648: SAM Python: Improve the wrapper to be used independently without MITK.
Jun 26 2023, 7:25 PM · MITK (v2023.10)
a178n added a parent task for T29648: SAM Python: Improve the wrapper to be used independently without MITK: T29604: SAM as 2D Tool in MITK- iteration 2.
Jun 26 2023, 7:25 PM · MITK

Jun 22 2023

a178n triaged T29648: SAM Python: Improve the wrapper to be used independently without MITK as Normal priority.
Jun 22 2023, 9:09 AM · MITK

Jun 21 2023

a178n created T29647: [Interpolation] The 3D mesh is visible after interpolation is confirmed.
Jun 21 2023, 6:27 PM · Request for Discussion, MITK
a178n triaged T29645: Test Plan for SAM as Normal priority.
Jun 21 2023, 9:40 AM · MITK (v2023.10)
a178n triaged T29644: Doxygen documentation for SAM as Normal priority.
Jun 21 2023, 9:39 AM · MITK (v2023.10)

Jun 19 2023

a178n updated subscribers of T29635: SAM tool: Cannot Confirm segmentation properly.
Jun 19 2023, 1:13 PM · MITK (v2023.10)