Page MenuHomePhabricator

aurelien (Aurélien Labrosse)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (268 w, 4 d)

Recent Activity

Aug 28 2017

aurelien added a revision to T23306: Reactivation of org.blueberry.test plugin: Unknown Object (Differential Revision).
Aug 28 2017, 2:39 PM
aurelien created T23306: Reactivation of org.blueberry.test plugin.
Aug 28 2017, 2:36 PM

Aug 25 2017

aurelien added a comment to T19348: Support OpenCV 3 via superbuild.

Integrating this one would be great there is a lot of enhancement in OpenCV 3.1.0. Our MITK-based application use it to have the Eigen Face module available in the contribs.
We fixed using a new "-D" parameter for superbuild, and #ifdef in the code to allow both 2.4.x and 3.x series of OpenCV

Aug 25 2017, 3:24 PM · MITK (2018-04), Bugzilla

Aug 10 2017

aurelien added a comment to T22591: Error compiling Mitk 2016-11 : Error on SimpleITK installation phase (patch provided).

@jernejf is suggest you to use WinMerge to apply the patch on your Mitk source tree.

Aug 10 2017, 10:52 AM · Restricted Project, Pull Request, MITK

May 4 2017

aurelien awarded rMITK84fc0cbcbf0a: Replace GetDefaultDataStorage() with GetDataStorage() a Like token.
May 4 2017, 9:47 AM

Mar 7 2017

aurelien created T22603: Cannot use external Eigen library with Mitk 2016-03 (patch provided).
Mar 7 2017, 8:54 AM · Pull Request, MITK

Mar 6 2017

aurelien renamed T22591: Error compiling Mitk 2016-11 : Error on SimpleITK installation phase (patch provided) from Error compiling Mitk 2016-11 : Error on SimpleITK installation phase to Error compiling Mitk 2016-11 : Error on SimpleITK installation phase (patch provided).
Mar 6 2017, 5:45 PM · Restricted Project, Pull Request, MITK
aurelien added a comment to T22591: Error compiling Mitk 2016-11 : Error on SimpleITK installation phase (patch provided).

Here is a simple patch wich fixes the command format. The PYTHONPATH has to be set before CMake is called.
basically, it has to be set to [compilation folder]ep/Lib/site-packages/

Mar 6 2017, 5:45 PM · Restricted Project, Pull Request, MITK

Mar 3 2017

aurelien added a comment to T22591: Error compiling Mitk 2016-11 : Error on SimpleITK installation phase (patch provided).

We fixed that in the previous version patching CMakeExternals/SimpleITK.cmake :

Mar 3 2017, 2:52 PM · Restricted Project, Pull Request, MITK

Mar 2 2017

aurelien created T22591: Error compiling Mitk 2016-11 : Error on SimpleITK installation phase (patch provided).
Mar 2 2017, 9:22 AM · Restricted Project, Pull Request, MITK

Nov 18 2016

aurelien committed rMITKc992322e0061: fix for bug 19635 (authored by aurelien).
fix for bug 19635
Nov 18 2016, 11:28 AM

Sep 20 2016

aurelien awarded rMITKa5312246035b: Context menu action can be initialized with icon attribute via the extension… a Like token.
Sep 20 2016, 8:29 AM

Aug 9 2016

aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

Thanks i better see. The implementation is good and follows the Eclipse 3 Job API. The job listeners should work, and the "job view" can be plugged using a 'ProgressProvider' concept. I think we will work on that part soon.
We also have the plugin tests quite working (the tested plugin is still not loaded, but whole code now compiles). It should be done within next month -i hope- because we really need testing :)
Existing test code for job api would be then plugged back.

Aug 9 2016, 4:40 PM · Auto-closed, MITK
aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

no problem. Thanks for the link i'm not yet aware of a lot of Phabricator features

Aug 9 2016, 3:10 PM · Auto-closed, MITK
aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

There is still problems with scheduling, but I have to go on other tasks for the moment. The API is useable even there are still problems with scheduling. I should come back on this ticket once we get the plugin test infrastructure back to work.

Aug 9 2016, 3:07 PM · Auto-closed, MITK
kislinsk awarded T19841: The BlueBerry jobs API is unuseable a Like token.
Aug 9 2016, 8:41 AM · Auto-closed, MITK
aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

After some more learning in Berry and smart pointer, I'm now quite done. No more freeze and clean Job subclassing.

Aug 9 2016, 12:05 AM · Auto-closed, MITK

Aug 8 2016

aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

In the other hand, if i create a job using a berry::SmartPointer, I no longer have the early deletion problem thanks to internal ref counter. In that case, I can launch the job only one time : the second time the job is fired, the first one has not been destroyed and i face an UI freeze (and have to kill the application)

Aug 8 2016, 9:40 PM · Auto-closed, MITK
aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

In some functions, 'this' (as instance of InternalJob) is wrapped into berry::SmartPointer.
When the function ends, then the pointer counter falls to 0 and the object is destroyed.
From my point of view we can use pointer everywhere, and the Job pointer can be deleted when finished,
if no rescheduled, when all listeners has been called.

Aug 8 2016, 5:13 PM · Auto-closed, MITK

Aug 5 2016

aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

There are some other errors in the API with the smart pointers. I often have my Job deleted before execution.
I'm investigating on it.

Aug 5 2016, 5:13 PM · Auto-closed, MITK
aurelien renamed T19841: The BlueBerry jobs API is unuseable from Cannot add a berry::IJobChangeListener in a berry::Job to The BlueBerry jobs API is unuseable.
Aug 5 2016, 2:20 PM · Auto-closed, MITK
aurelien added a comment to T19841: The BlueBerry jobs API is unuseable.

The fix is very simple but without it, the Job API is quite unusable.

Aug 5 2016, 2:20 PM · Auto-closed, MITK
aurelien created T19841: The BlueBerry jobs API is unuseable.
Aug 5 2016, 2:09 PM · Auto-closed, MITK

Aug 2 2016

aurelien added a comment to T19669: _App_.ini is not processed once application is deployed.

Opened this bug because the splash screen wasn't visible.
After deeper analysis, we discover that the splash screen may appear and disappear quickly, make it "unvisible".
It is configured to be closed just after BlueBerry platform is up (plugins started), and some DLL may be loaded afterward. Hence there should be a delay between splash close and actual workbench display

Aug 2 2016, 10:23 AM · Bugzilla, MITK
aurelien added projects to T19669: _App_.ini is not processed once application is deployed: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · Bugzilla, MITK
aurelien added projects to T19635: I wan't to be able to configure a pixmap used as a splashscreen while application is loading: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to T19635: I wan't to be able to configure a pixmap used as a splashscreen while application is loading.

CTK contains code for splashscreen management. I will go ahead this way

Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to T19635: I wan't to be able to configure a pixmap used as a splashscreen while application is loading.

Work ongoing on :
https://github.com/pollen-metrology/MITK/tree/19635-splashscreen_support

Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to T19635: I wan't to be able to configure a pixmap used as a splashscreen while application is loading.

Work is done and available in pull request : https://github.com/MITK/MITK/pull/131
The splashscreen is closed by CTK, and thus the code on their side has been updated too. I can provide a updated patch for CTK-in-superbuild if needed

Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to T19591: VTK-6.2.0 patch in super build is not sufficient for MSVC 14 build.

Done, thanks.

Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to T19591: VTK-6.2.0 patch in super build is not sufficient for MSVC 14 build.

Stefan,
Thanks for information. I'll stop creating bug for this topic, and wait for next release to try the upgraded build system. We were also waiting for Qt 5.6, but Digia is a bit late and we had to go ahead.

Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to F1304: pragma-warning.diff.

Patch which add /wd4180 for MSVC build in CppMicroServices

Aug 2 2016, 10:23 AM
aurelien added projects to T19590: #pragma causes warnings which cause MSVC 14 build to throw error and fail: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added projects to T19591: VTK-6.2.0 patch in super build is not sufficient for MSVC 14 build: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
aurelien added a comment to F1305: vtk-6.2.0.patch.diff.

Patch for the VTK 6.2.0 patch, allowing MSVC 14 build

Aug 2 2016, 10:23 AM
aurelien added a comment to F1300: eigen_include_dir.diff.

Extremely small patch that fixes the bug

Aug 2 2016, 10:23 AM
aurelien added projects to T19585: Eigen_INCLUDE_DIR not passed to Mitk-configure: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · Auto-closed, MITK, Bugzilla
aurelien added a comment to T18411: Support US RGB 2D+t images.

Hello all,
I am a bit novice in medical image format, i'm working with other industry devices which produce 2D images (TEM, AFM, SEM).
So, I need the 2D tiff support and will do my best to provide a fix here.

Aug 2 2016, 10:16 AM · Auto-closed, MITK, Bugzilla
aurelien added a comment to T12811: Tiff image support in MITK.

Hello,
I also have some tiff files which are not loading and even throw a segmentation fault in file vtkMitkLevelWindowFilter.cpp at line 209. We are working on this since we are using a lot of tiff images. I created a simple image with Gimp which triggers the problem.

Aug 2 2016, 9:56 AM · Bugzilla, MITK
aurelien added a comment to T12811: Tiff image support in MITK.

Forget my last comment, i just found http://bugs.mitk.org/show_bug.cgi?id=12811

Aug 2 2016, 9:56 AM · Bugzilla, MITK
aurelien added a comment to F864: test.zip.

A TIFF file which trigger a segmentation fault in WorkBench

Aug 2 2016, 9:56 AM
aurelien added a comment to T12811: Tiff image support in MITK.

A TIFF file which trigger a segmentation fault in WorkBench

Aug 2 2016, 9:56 AM · Bugzilla, MITK