Page MenuHomePhabricator

engelm (Markus Engel)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (181 w, 3 d)

Recent Activity

Aug 19 2016

engelm committed rMITK6d0527142c32: Merge remote-tracking branch 'origin/T19828-dynamic-analysis-improvements… (authored by engelm).
Merge remote-tracking branch 'origin/T19828-dynamic-analysis-improvements…
Aug 19 2016, 10:54 AM

Aug 12 2016

engelm committed rMITKb9735321c3e7: Merge remote-tracking branch 'origin/T19828-dynamic-analysis-improvements… (authored by engelm).
Merge remote-tracking branch 'origin/T19828-dynamic-analysis-improvements…
Aug 12 2016, 10:40 AM

Aug 11 2016

engelm committed rMITKb5155f3a6f47: Merge branch 'T19473-consider-triggertime-in-DICOM-loading' into… (authored by engelm).
Merge branch 'T19473-consider-triggertime-in-DICOM-loading' into…
Aug 11 2016, 2:25 PM
engelm committed rMITKb408a3be8678: initialized trigger-timebounds with 0.0 (authored by engelm).
initialized trigger-timebounds with 0.0
Aug 11 2016, 2:09 PM
engelm committed rMITK3fd7f859e466: initialized trigger-timebounds with 0.0 (authored by engelm).
initialized trigger-timebounds with 0.0
Aug 11 2016, 2:07 PM
engelm raised the priority of T19473: Incorrect time bounds with 3D+t images which only differ in TriggerTime from Low to High.
Aug 11 2016, 11:45 AM · Bugzilla, MITK
engelm added a revision to T19473: Incorrect time bounds with 3D+t images which only differ in TriggerTime: Unknown Object (Differential Revision).
Aug 11 2016, 11:42 AM · Bugzilla, MITK
engelm committed rMITKbb9e5437bf1d: fixed compile error due to rebase (authored by engelm).
fixed compile error due to rebase
Aug 11 2016, 11:41 AM
engelm committed rMITKb06b396dd050: minor improvements (authored by engelm).
minor improvements
Aug 11 2016, 11:41 AM
engelm committed rMITK9b2e01a935ca: correctly considering AquisitionTime even without AquisitionDate (authored by engelm).
correctly considering AquisitionTime even without AquisitionDate
Aug 11 2016, 11:41 AM
engelm committed rMITKe07fe5e5d196: added method that considers triggerTime in extraction of TimeBounds (authored by engelm).
added method that considers triggerTime in extraction of TimeBounds
Aug 11 2016, 11:41 AM
engelm committed rMITKa2bb9f73d83f: minor improvements (authored by engelm).
minor improvements
Aug 11 2016, 11:32 AM
engelm claimed T19473: Incorrect time bounds with 3D+t images which only differ in TriggerTime.
Aug 11 2016, 11:30 AM · Bugzilla, MITK
engelm committed rMITK27ae6d02e1d9: fixed falsely resolved merge-conflict (authored by engelm).
fixed falsely resolved merge-conflict
Aug 11 2016, 11:24 AM
engelm committed rMITK80f720ae5dad: fixed another warning as error (authored by engelm).
fixed another warning as error
Aug 11 2016, 11:24 AM
engelm added a revision to T19814: Add 4D support to PlanarFigures: Unknown Object (Differential Revision).
Aug 11 2016, 11:24 AM · MITK, Bugzilla
engelm committed rMITK44eb9b864374: fixed more warnings treated as errros (authored by engelm).
fixed more warnings treated as errros
Aug 11 2016, 11:24 AM
engelm committed rMITK0375fe600172: removed whitespaces (authored by engelm).
removed whitespaces
Aug 11 2016, 11:24 AM
engelm committed rMITKcc39fd76eacc: fixed PlanarFigure unittest (authored by engelm).
fixed PlanarFigure unittest
Aug 11 2016, 11:24 AM
engelm committed rMITKc1c006444c75: more fixes and improvements of 4d capabilities of PlanarFigures (authored by engelm).
more fixes and improvements of 4d capabilities of PlanarFigures
Aug 11 2016, 11:24 AM
engelm committed rMITKf8f2272f10ef: cleanup after review (authored by engelm).
cleanup after review
Aug 11 2016, 11:24 AM
engelm committed rMITKfa9e9bfce28e: fixed ResetNumberOfControlPoints in PlanarCross (authored by engelm).
fixed ResetNumberOfControlPoints in PlanarCross
Aug 11 2016, 11:24 AM
engelm committed rMITK0ada550ae8b7: fixed bug in clearing of HelperPolyLines (authored by engelm).
fixed bug in clearing of HelperPolyLines
Aug 11 2016, 11:24 AM
engelm committed rMITK25681d4382bd: image statistics are calculcated correctly for time-point specific PlanarFigures (authored by engelm).
image statistics are calculcated correctly for time-point specific PlanarFigures
Aug 11 2016, 11:24 AM
engelm committed rMITK0c81fb815566: added possibility to define if all timepoints shall be equal (authored by engelm).
added possibility to define if all timepoints shall be equal
Aug 11 2016, 11:24 AM
engelm committed rMITK3533f8d2ee8b: added 4d-support to PlanarFigures (authored by engelm).
added 4d-support to PlanarFigures
Aug 11 2016, 11:24 AM
engelm added a revision to T19830: Rendering timegeometry does not match image timegeometry: Unknown Object (Differential Revision).
Aug 11 2016, 11:08 AM · Bugzilla, MITK
engelm committed rMITK346cd1cec79f: fixed another warning as error (authored by engelm).
fixed another warning as error
Aug 11 2016, 10:32 AM
engelm committed rMITK92393d0c52cc: removed whitespaces (authored by engelm).
removed whitespaces
Aug 11 2016, 10:32 AM
engelm committed rMITKfc7c3d530130: correctly considering AquisitionTime even without AquisitionDate (authored by engelm).
correctly considering AquisitionTime even without AquisitionDate
Aug 11 2016, 9:06 AM
engelm committed rMITK1fd0e572d7dd: Merge remote-tracking branch 'origin/master' into T19814-4d-planarfigures-master (authored by engelm).
Merge remote-tracking branch 'origin/master' into T19814-4d-planarfigures-master
Aug 11 2016, 8:06 AM

Aug 10 2016

engelm added a comment to T19814: Add 4D support to PlanarFigures.

OK, I have pushed my changes and created a revision/pull-request .

Aug 10 2016, 1:25 PM · MITK, Bugzilla
engelm committed rMITK0a5d4ffb2e3f: improved formatting, fixed typo, defaulting c'tor and d'tor (authored by engelm).
improved formatting, fixed typo, defaulting c'tor and d'tor
Aug 10 2016, 11:24 AM
engelm committed rMITKb7561b863ff4: also checking lower bounds (authored by engelm).
also checking lower bounds
Aug 10 2016, 11:24 AM
engelm committed rMITK28bce29badda: using correct setter instead of unnecessary getter (authored by engelm).
using correct setter instead of unnecessary getter
Aug 10 2016, 11:24 AM
engelm committed rMITK1b9e3cb89175: removed todo that has been done (authored by engelm).
removed todo that has been done
Aug 10 2016, 11:24 AM
engelm committed rMITKd7b35955bb29: further improvements of arbitraryTimeGeometries and their use in rendering (authored by engelm).
further improvements of arbitraryTimeGeometries and their use in rendering
Aug 10 2016, 11:24 AM
engelm committed rMITK792388f2f19a: using correct timebounds for initializing timegeometry for rendering (authored by engelm).
using correct timebounds for initializing timegeometry for rendering
Aug 10 2016, 11:24 AM
engelm committed rMITKaf77d489a3f1: added list of lowertimepoint-bounds (authored by engelm).
added list of lowertimepoint-bounds
Aug 10 2016, 11:24 AM
engelm committed rMITKbf9fcf798237: all timesteps are correctly displayed (authored by engelm).
all timesteps are correctly displayed
Aug 10 2016, 11:24 AM
engelm changed the visibility for Mint Medical GmbH.
Aug 10 2016, 11:05 AM
engelm removed a member for Mint Medical GmbH: guethle.
Aug 10 2016, 11:04 AM
engelm removed a member for Mint Medical GmbH: martel.
Aug 10 2016, 11:04 AM
engelm removed a member for Mint Medical GmbH: nowack.
Aug 10 2016, 11:04 AM
engelm removed a member for Mint Medical GmbH: kovacheva.
Aug 10 2016, 11:04 AM
engelm removed a member for Mint Medical GmbH: grafa.
Aug 10 2016, 11:04 AM
engelm removed a member for Mint Medical GmbH: neubauer.
Aug 10 2016, 11:04 AM
engelm committed rMITK7e11f4f5fff9: fixed more warnings treated as errros (authored by engelm).
fixed more warnings treated as errros
Aug 10 2016, 10:22 AM
engelm added a comment to T19291: ContourModelGLMapper2DBase causes vtkWarnings.

As far as I know, this issue still persists as I have not worked on it yet.

Aug 10 2016, 9:31 AM · Bugzilla, MITK
engelm placed T19291: ContourModelGLMapper2DBase causes vtkWarnings up for grabs.
Aug 10 2016, 9:30 AM · Bugzilla, MITK

Aug 9 2016

engelm committed rMITK973606bd175b: added method that considers triggerTime in extraction of TimeBounds (authored by engelm).
added method that considers triggerTime in extraction of TimeBounds
Aug 9 2016, 1:37 PM
engelm committed rMITK692fd1136a01: Merge branch 'personal/engelm/fix-our-snapshots' into… (authored by engelm).
Merge branch 'personal/engelm/fix-our-snapshots' into…
Aug 9 2016, 10:10 AM
engelm committed rMITK0cae7a9f440d: removed code that breaks our snapshots (authored by engelm).
removed code that breaks our snapshots
Aug 9 2016, 10:09 AM
engelm added a comment to T19832: PlanarFigures with 0mm can be created via doubleclick.

My changes fix the bug but break a unittest. haven't had the time to fix that as well yet.

Aug 9 2016, 10:06 AM · Bugzilla, MITK

Aug 5 2016

engelm added a comment to T19830: Rendering timegeometry does not match image timegeometry.

I have indeed implemented a fix that works in our environment. I extended the SliceNavigationController to create the correct type of TimeGeometry for the rendering, depending on the data that shall be displayed.

Aug 5 2016, 2:05 PM · Bugzilla, MITK

Aug 4 2016

engelm added a comment to T19473: Incorrect time bounds with 3D+t images which only differ in TriggerTime.

Ralf, has there been any work so far? This is something we need resolved, soon.

Aug 4 2016, 12:54 PM · Bugzilla, MITK
engelm added a watcher for Mint Medical GmbH: engelm.
Aug 4 2016, 11:42 AM
engelm committed rMITK6c54f2b353f4: Merge branch 'T19830-fixing-rendering-of-arbitraryTimeGeometries-snapshot'… (authored by engelm).
Merge branch 'T19830-fixing-rendering-of-arbitraryTimeGeometries-snapshot'…
Aug 4 2016, 10:07 AM
engelm committed rMITKed7d599bab53: improved formatting, fixed typo, defaulting c'tor and d'tor (authored by engelm).
improved formatting, fixed typo, defaulting c'tor and d'tor
Aug 4 2016, 9:54 AM
engelm committed rMITKe68f62e8fa20: also checking lower bounds (authored by engelm).
also checking lower bounds
Aug 4 2016, 9:54 AM
engelm committed rMITKc769bcfb5695: using correct setter instead of unnecessary getter (authored by engelm).
using correct setter instead of unnecessary getter
Aug 4 2016, 9:54 AM
engelm committed rMITK2a78c80c74ec: removed todo that has been done (authored by engelm).
removed todo that has been done
Aug 4 2016, 8:42 AM
engelm committed rMITKa422742146e1: using correct timebounds for initializing timegeometry for rendering (authored by engelm).
using correct timebounds for initializing timegeometry for rendering
Aug 4 2016, 8:42 AM
engelm committed rMITK694c194bfb68: further improvements of arbitraryTimeGeometries and their use in rendering (authored by engelm).
further improvements of arbitraryTimeGeometries and their use in rendering
Aug 4 2016, 8:42 AM
engelm committed rMITK9f0b110d698f: added list of lowertimepoint-bounds (authored by engelm).
added list of lowertimepoint-bounds
Aug 4 2016, 8:42 AM
engelm committed rMITK8e0e78995012: all timesteps are correctly displayed (authored by engelm).
all timesteps are correctly displayed
Aug 4 2016, 8:42 AM
engelm committed rMITKce62e5ae7c4c: Merge remote-tracking branch 'origin/bug-19778-int-cast-for-histogram-wrong… (authored by engelm).
Merge remote-tracking branch 'origin/bug-19778-int-cast-for-histogram-wrong…
Aug 4 2016, 8:42 AM
engelm committed rMITKde97392afa08: Merge remote-tracking branch 'origin/bug-19828-dynamic-analysis-improvements… (authored by engelm).
Merge remote-tracking branch 'origin/bug-19828-dynamic-analysis-improvements…
Aug 4 2016, 8:42 AM

Aug 3 2016

engelm claimed T19830: Rendering timegeometry does not match image timegeometry.
Aug 3 2016, 4:02 PM · Bugzilla, MITK

Aug 2 2016

engelm added projects to T19832: PlanarFigures with 0mm can be created via doubleclick: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · Bugzilla, MITK
engelm added projects to T19830: Rendering timegeometry does not match image timegeometry: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · Bugzilla, MITK
engelm added a comment to T19832: PlanarFigures with 0mm can be created via doubleclick.

[c94a60]: COMP: Merge branch 'bug-19832-fix-0mm-planarfigure-after-doubleclick'

Merged commits:

2016-07-22 13:14:44 Markus Engel [096d77]
Revert "Finalizing PlanarFigures with double-click is only possible for figures that can be extended"

Aug 2 2016, 10:24 AM · Bugzilla, MITK
engelm added a comment to T19832: PlanarFigures with 0mm can be created via doubleclick.

[e0b9fd]: Merge branch 'bug-19832-fix-0mm-planarfigure-after-doubleclick'

Merged commits:

2016-07-21 08:05:23 Markus Engel [e4e0c9]
Finalizing PlanarFigures with double-click is only possible for figures that can be extended

Aug 2 2016, 10:24 AM · Bugzilla, MITK
engelm added projects to T19828: Improve dynamic-analysis module: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · Bugzilla, MITK
engelm added projects to T19814: Add 4D support to PlanarFigures: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · MITK, Bugzilla
engelm added a comment to T19803: Dead state in PlanarFigureInteraction for 'read-only' PlanarFigures.

[27aa70]: COMP: Merge branch 'bug-19803-fix-deadstate-in-planarfigureInteractor'

Merged commits:

2016-06-27 14:08:55 Markus Engel [93ae0b]
fixed more warnings handled as errors

Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added a comment to T19803: Dead state in PlanarFigureInteraction for 'read-only' PlanarFigures.

[494c51]: COMP: Merge branch 'bug-19803-fix-deadstate-in-planarfigureInteractor'

Merged commits:

2016-06-27 12:17:51 Markus Engel [df9d39]
fixed warnings treated as error

Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added a comment to T19803: Dead state in PlanarFigureInteraction for 'read-only' PlanarFigures.

[e06a92]: Merge branch 'bug-19803-fix-deadstate-in-planarfigureInteractor'

Merged commits:

2016-06-27 09:10:29 Markus Engel [f3a1a2]
fixed dead-state, added condition 'figure_is_editable'

Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added a comment to T19800: mitk::PlanarEllipse should calculate area.

[2a1981]: Merge branch 'bug-19800-area-calcuation-of-PlanarEllipse'

Merged commits:

2016-06-24 13:33:10 Markus Engel [127c4b]
PlanarEllipse calculates its area

Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added projects to T19803: Dead state in PlanarFigureInteraction for 'read-only' PlanarFigures: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added projects to T19795: Uneditable PlanarCross can be messed up: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added a comment to T19800: mitk::PlanarEllipse should calculate area.

PlanarEllipse now calculcates its area and stores it in Feature #2

Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added projects to T19800: mitk::PlanarEllipse should calculate area: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · MITK (2016-11), Bugzilla
engelm added projects to T19796: Uneditable PlanarCross can be messed up: MITK, Bugzilla.
Aug 2 2016, 10:24 AM · MITK, Bugzilla
engelm added projects to T19691: PlanarEllipse has an 'unnecessary' fourth control-point and a second PolyLine: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · Bugzilla, MITK
engelm added projects to T19636: Parsing of DICOM-tags is locale-dependent: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · Bugzilla, MITK
engelm added projects to T19592: EquiDistantBlocksSorter lacks configuration to create new block on first mismatch: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK, Bugzilla
engelm added projects to T19573: CameraController does not allow setting of maximum zoom-level: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK, Bugzilla
engelm added a comment to T19554: Issues with PlanarCross interation.

[77d56a]: Merge branch 'bug-19554-masterversion-planarcross-interaction-issues'

Merged commits:

2016-02-09 08:13:01 Markus Engel [e3d994]
corrected copying of itkVectorContainer

Aug 2 2016, 10:23 AM · MITK (2016-03), Bugzilla
engelm added projects to T19554: Issues with PlanarCross interation: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19554: Issues with PlanarCross interation.

[bd6f61]: COMP: Merge branch 'bug-19554-masterversion-planarcross-interaction-is

Merged commits:

2016-02-09 08:59:46 Markus Engel [6f6cd0]
fixed warning that is treated as an error

Aug 2 2016, 10:23 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19554: Issues with PlanarCross interation.

[46ec0b]: COMP: Merge branch 'bug-19554-masterversion-planarcross-interaction-is

Merged commits:

2016-02-09 10:18:05 Markus Engel [2eca0e]
using correct type to avoid warning as error

Aug 2 2016, 10:23 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19548: Update VTK to version 7.0.

Hi Stefan,

Aug 2 2016, 10:23 AM · MITK (2016-11), Bugzilla
engelm added projects to T19537: PlanarFigure annotations are misplaced when moving the figure out of the scene: MITK, Bugzilla.
Aug 2 2016, 10:23 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19537: PlanarFigure annotations are misplaced when moving the figure out of the scene.

[f8b5cc]: Merge branch 'bug-19537-misplaced-planarfigure-annotation-for-master'

Merged commits:

2016-02-04 10:38:44 Markus Engel [bdb4d9]
not rendering annotations if the anchorPoint is outside of the scene

Aug 2 2016, 10:23 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19507: DICOMITKSeriesGDCMReader is still not thread safe.

[9908cf]: Merge branch 'bug-19507-static-mutex-DICOMITKSeriesGDCMReader'

Merged commits:

2016-02-02 14:53:04 Tobias Weihs [33ea43]
removed FixupSpacing function declaration, it is not implemented

Aug 2 2016, 10:22 AM · Bugzilla, MITK
engelm added a comment to T19485: Add reader-configurations for 3D+t images.

This issue can be closed. However, as it builds on the changes made in T17819, these changes cannot be integrated into master, yet.

Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19485: Add reader-configurations for 3D+t images.

Thanks Ralf for fixing the issue with the loading. Must have missed that one somehow..

Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19485: Add reader-configurations for 3D+t images.

I have added 2 DICOM-Reader configurations that can cope with most of the 3D+t DICOM series that I came across.

Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla
engelm added a comment to T19485: Add reader-configurations for 3D+t images.

No, this sounds new to me. I have been using this code for a couple of weeks now and have not noticed anything out of the ordinary.

Aug 2 2016, 10:22 AM · MITK (2016-03), Bugzilla