Page MenuHomePhabricator

schwarzt (Tobias Schwarz)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (210 w, 4 d)
Roles
Disabled

Recent Activity

Aug 2 2016

schwarzt added a comment to T12382: MITK memory usage / leak.

Okay, just seen that the version string is much longer, and not copyable in the Help -> About dialog. So:
Bug from Git version from 14.06.2012, 13:36.

Aug 2 2016, 9:55 AM · Bugzilla, MITK
schwarzt added a comment to T12382: MITK memory usage / leak.

Same behaviour in installed 2012.06.00-x64

Aug 2 2016, 9:55 AM · Bugzilla, MITK
schwarzt added projects to T12382: MITK memory usage / leak: MITK, Bugzilla.
Aug 2 2016, 9:55 AM · Bugzilla, MITK
schwarzt added projects to T5862: Lookup tables are not used (displayed): MITK, Bugzilla.
Aug 2 2016, 9:41 AM · Bugzilla, MITK
schwarzt added projects to T5320: Documentation of MITK geometries: MITK, Bugzilla.
Aug 2 2016, 9:40 AM · Bugzilla, MITK
schwarzt added a comment to T5253: PicFileWriter does not give any feedback if no Image is set as Input.

I don't think this bug is relevant any more as IO changed anyway.
However, I don't think I will test it anymore.
Resetting to default assignee to validate or close.

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added projects to T5253: PicFileWriter does not give any feedback if no Image is set as Input: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5253: PicFileWriter does not give any feedback if no Image is set as Input.

Warning

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5253: PicFileWriter does not give any feedback if no Image is set as Input.

Not including test

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to F593: PicFileReader.patch.

Warning

Aug 2 2016, 9:39 AM
schwarzt added a comment to F592: PicFileReader.patch.

Warning

Aug 2 2016, 9:39 AM
schwarzt added projects to T5236: File overwrite dialog appears two times: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added projects to T5130: mitkImageTest does not correctly check GetPixelValueByIndex: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5130: mitkImageTest does not correctly check GetPixelValueByIndex.

[SVN revision 25559]
FIX (#5130): GetPixelValueByIndex() is not checked; instead, world coords are checked twice.

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5077: Initialize output of SurfaceToImageFilter with uchar if binary is requested.

[SVN revision 25553]
COMP (#5077): Allow unknown pixel type

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5077: Initialize output of SurfaceToImageFilter with uchar if binary is requested.

Added change request;

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added projects to T5077: Initialize output of SurfaceToImageFilter with uchar if binary is requested: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5077: Initialize output of SurfaceToImageFilter with uchar if binary is requested.

[SVN revision 25556]
COMP (#5077): Unix does not seem to resolve pixel type.. (??)

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5077: Initialize output of SurfaceToImageFilter with uchar if binary is requested.

Test only works on Windows. PixelType is always returned as "h" on Linux.
-> #ifdef WIN32; closed.

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5077: Initialize output of SurfaceToImageFilter with uchar if binary is requested.

[SVN revision 25550]
FIX (#5077): Initialize output of SurfaceToImageFilter with uchar if binary is requested; added test;

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T5050: Bug in mitk::Image::GetVtkImageData(), Origin is wrong.

Patch not a solution (only does the same, wrong thing that is done as in 2D). Correct origin needs still to be set.

Aug 2 2016, 9:39 AM · MITK, Bugzilla
schwarzt added a comment to T5050: Bug in mitk::Image::GetVtkImageData(), Origin is wrong.

Patch

Aug 2 2016, 9:39 AM · MITK, Bugzilla
schwarzt added a comment to T5050: Bug in mitk::Image::GetVtkImageData(), Origin is wrong.

Is a Bug in mitkImageDataItem.
Thx for reporting.
Will add unit test to mitkImageTest.

Aug 2 2016, 9:39 AM · MITK, Bugzilla
schwarzt added a comment to F583: mitkImageDataItem.patch.

Patch

Aug 2 2016, 9:39 AM
schwarzt added a comment to F584: mitkImageDataItem.patch.

Patch

Aug 2 2016, 9:39 AM
schwarzt added a comment to T4931: mitkPicFileWriter/Reader only saves/reads the image data from channel = 0.

No, this is definitely a bug.
Channels are supposed to hold different information for each voxel, like in RGB data or Doppler ultrasound.
So, they should all be read, not only the 0 one.

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added projects to T4860: SliceNavigationController shows way too many positions after decimal point: MITK, Bugzilla.
Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T4860: SliceNavigationController shows way too many positions after decimal point.

[SVN revision 25151]
FIX (#4860): Show only two positions after decimal point in Info bar

Aug 2 2016, 9:39 AM · Bugzilla, MITK
schwarzt added a comment to T4692: Inconsistent handling of pixel and voxel centers.

As the IsIndexInside methods get longer and longer...
-> Please move implementation to .cpp file.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4692: Inconsistent handling of pixel and voxel centers.

All info I had were from:

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4692: Inconsistent handling of pixel and voxel centers.

Are you sure with consistent center-based?
They changed to edge-based index coords just in 3.16.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4565: MITK does not recognize 4D DICOM volumes.

Actually I think it never read out the correct time information...
Only created a time step for each image. (time step = integer, time information = time in milliseconds); So at least reading as before is restored.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4357: Reading a series of image files does not work with QT4 app.

Maybe it worked 2011, but not anymore.
A single image is loaded again when opening a bitmap / jpeg etc. series.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4331: memory bug in iil4mitkPicImage::display(*).

You are absolutely right, the index goes out of bounds at direct image borders. Your suggested changes solve this issue, thanks. Will commit them soon.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4331: memory bug in iil4mitkPicImage::display(*).

Will have a look at this...

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4331: memory bug in iil4mitkPicImage::display(*).

[SVN revision 25180]
FIX (#4331): IIL4Mitk: When calculating delineation of segmentations, search index could went out of bounds.

Aug 2 2016, 9:38 AM · Bugzilla, MITK
schwarzt added a comment to T4007: BoundingObjectCutter produces offset.

You could easier try on artificial data maybe.

Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added a comment to T4007: BoundingObjectCutter produces offset.

Most likely due to coordinate system changes in ITK 3.16 and accordingly in MITK.
See #2401 for discussion, esp. comment 21.

Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added projects to T3841: Thresholding in BasicImageProcessing crashes when Lower TH > Upper TH: MITK, Bugzilla.
Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added a comment to T3839: ITK Macro problem while compiling debug with ITK 3.18.

Coming from:
mitkVirtualTrackingTool.h, ln. 54
itkGetObjectMacro(Spline, SplineType);

Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added a comment to T3841: Thresholding in BasicImageProcessing crashes when Lower TH > Upper TH.

[SVN revision 22541]
FIX (#3841): Check lower TH < upper TH

Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added a comment to T3728: Crash using Downsampling Operation.

Critical ?!?
:)

Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added a comment to T3728: Crash using Downsampling Operation.

[SVN revision 22362]
FIX (#3728): Crash when downsampling by 0

Aug 2 2016, 9:37 AM · Bugzilla, MITK
schwarzt added a comment to T3709: Rename "delete" to "remove" in DM right mouse menu.

[SVN revision 22335]
FIX (#3709): Rename delete to remove in RMB menu

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added projects to T3709: Rename "delete" to "remove" in DM right mouse menu: MITK, Bugzilla.
Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3701: Merge two versions of Statemachine XML.

See also #2840 for some details

Aug 2 2016, 9:36 AM · MITK (2013-03), Bugzilla
schwarzt added a comment to T3701: Merge two versions of Statemachine XML.

If I remeber it right, there were problems with

  • the Tutorial
  • the Statemachine Editor

so we had to copy it as a quick solution.
Not really sure what problems exactly.

Aug 2 2016, 9:36 AM · MITK (2013-03), Bugzilla
schwarzt added a comment to T3701: Merge two versions of Statemachine XML.

The activator and the loading mechanism via Qt resources was necessary for 3M3 to use a compiled-in version of Statemachine.xml

Aug 2 2016, 9:36 AM · MITK (2013-03), Bugzilla
schwarzt added a comment to T3701: Merge two versions of Statemachine XML.

Ah, right, that was the problem, thanks Daniel:
in MTIK, Statemachines are initialized via \source\mitk\CoreUI\Bundles\org.mitk.gui.qt.common\src\internal\QmitkCommonActivator.cpp

Aug 2 2016, 9:36 AM · MITK (2013-03), Bugzilla
schwarzt added a comment to T3685: Correct time output in logging.

[SVN revision 22368]
FIX (#3685): Use same format under Linux

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3685: Correct time output in logging.

[SVN revision 22323]
FIX (#3685): Insert newline after first date/time under Windows.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3671: Text overlay is not displayed correctly in the render window.

Annotation display is completely redesigned by Markus Engel in the Moment.
See T1426 for details. Testing will be created whith that.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3671: Text overlay is not displayed correctly in the render window.

[SVN revision 22544]
FIX (#3671): Move text display to center

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added projects to T3671: Text overlay is not displayed correctly in the render window: MITK, Bugzilla.
Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3671: Text overlay is not displayed correctly in the render window.

In ImageMapper2D: Volume text overlay is placed incorrect.
This is because of a wrong geometry calculation.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3651: I think there is a Memory leak.

Would be the much nicer solution, but I don't get it to work for me (just tried).
But actually I am not completely sure what happens here exactly.
I try to get one of the rendering guys to have a look at it next BSP.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3651: I think there is a Memory leak.

Not a real leak:
Objects are removed from the rendering list here, but should not be deleted.
They are still held by the actors.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3651: I think there is a Memory leak.

Just seen that text is displayed in very strange positions anyway.
Will open a new bug for that.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3651: I think there is a Memory leak.

Will take a look..

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3651: I think there is a Memory leak.

m_TextRenderer->RemoveAllViewProps(); does not release memory, but is also not the right place to do it. Not a leak in my opinion.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3469: Logging timestamp inserts newline.

[SVN revision 22077]
FIX (#3469): Remove ":"; Add start time/date for Linux

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3469: Logging timestamp inserts newline.

[SVN revision 22071]
FIX (#3469): Only use full date/time output when log file is used. Else, only print relative to start time.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3428: Application crashes when using File > Exit.

I mean the popup menu which opens when pressing on file.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3428: Application crashes when using File > Exit.

Results from a mouseReleaseEvent sent to the already destroyed file menu widget.
No idea from where.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3421: algorithms in BasicImageProcessing are abnormal slow.

??? To my knowledge nothing changed in the bundle for weeks...
Could you specify?

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3422: Missmatch GUI <-> Code Parameter in BasicImageProcessing TV Filter.

[SVN revision 21762]
FIX (#3422): Fix parameter assignment for TV filter

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3422: Missmatch GUI <-> Code Parameter in BasicImageProcessing TV Filter.

[SVN revision 21763]
FIX (#3422): Forgot non-vector image case.

Aug 2 2016, 9:36 AM · Bugzilla, MITK
schwarzt added a comment to T3413: Logging: Write command line output to log file?.

[SVN revision 21772]
FIX (#3413): Change time output to Date, Time as default.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3413: Logging: Write command line output to log file?.

Renamed bug to "Write command line output to log file". Date/Time issue is resolved.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3358: CellData Lookup table is not applied for surface meshes.

P.S. Cell data is neither drawn in 2D or in 3D.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3358: CellData Lookup table is not applied for surface meshes.

Requesting core mod.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3358: CellData Lookup table is not applied for surface meshes.

Note: When not displayed automatically, set "scalar mode" property to "CellData"

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3358: CellData Lookup table is not applied for surface meshes.

Dear xplanes,

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3358: CellData Lookup table is not applied for surface meshes.

[SVN revision 22938]
FIX (#3358): Only use vtkStripper when normals shall be drawn.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3358: CellData Lookup table is not applied for surface meshes.

Okay, fixed, was easy.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3337: Unstructured grid rendering is broken.

[SVN revision 22213]
FIX (#3337): Display of unstructured grids

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3337: Unstructured grid rendering is broken.

Crashes on windows when trying to load a UG.
-> Set severity from feature request to normal

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3286: MovieMaker S/T relation does not work.

I have no idea why I am named author for MovieMaker...
Party bug.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3285: Combined playing option ignores selected widgets.

I have no idea why I am named author for MovieMaker...
Party bug.

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3279: Widget names in the dropdown boxes are wrong.

[SVN revision 21245]
FIX (#3279): Fixed combobox list widget name order; (didn't work with insert policy)

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3279: Widget names in the dropdown boxes are wrong.

[SVN revision 21244]
FIX (#3279): Fixed combobox list widget name order

Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added projects to T3278: Diasbling and Re-enabling Image Navigator resets views: MITK, Bugzilla.
Aug 2 2016, 9:35 AM · Bugzilla, MITK
schwarzt added a comment to T3262: Insight surgery meta bug.

[SVN revision 21429]
FIX (#3262): Set VIDEOINPUT_LIB default to OFF

Aug 2 2016, 9:34 AM · Bugzilla, MITK
schwarzt added a comment to T3255: The desired behavior of mitk::PixelType::operator==(std::type_info&) is unclear.

Bug is not relevant any more because itkTypeID is not obsolete any more; for vector valued images, itkTypeID is NULL by default;

Aug 2 2016, 9:34 AM · Bugzilla, MITK
schwarzt added projects to T3232: Crash on creating a new segmentation: MITK, Bugzilla.
Aug 2 2016, 9:34 AM · Bugzilla, MITK
schwarzt added a comment to T3212: BugFix: When using an empty Itk::Image, mitk::Image crashes.

Dear Xavier,
afaik it is not valid to use memcpy with any argument = NULL.
So, using an empty, non-initialized ITK image should result in

memcpy( dst, NULL, 0 );

which simply does nothing.
Could you give a code example from where your error occurs?

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3212: BugFix: When using an empty Itk::Image, mitk::Image crashes.

There was a "not" too much in my last comment.
I mean it IS valid to use memcpy with any argument = NULL;

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3209: BugFix: When the input mitk::PointSet has no points, the computation of the bounding box is taking the 0,0,0 point.

[SVN revision 21184]
FIX (#3209): Check if time steps contain data before considering them for BoundingBox calculation. (Empty time steps have a zero bounding box).

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3209: BugFix: When the input mitk::PointSet has no points, the computation of the bounding box is taking the 0,0,0 point.

Patch for PointSet only

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3209: BugFix: When the input mitk::PointSet has no points, the computation of the bounding box is taking the 0,0,0 point.

Okay, have fixed it already; reclaiming bug...

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3209: BugFix: When the input mitk::PointSet has no points, the computation of the bounding box is taking the 0,0,0 point.

mitk::PointSet is Mathias' baby...
Mathias, could you adapt BB creation? Works for mitk::Surface::CalculateBoundungBox(), maybe can be just done parallel?

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to F424: OnlyPointSet.patch.

Patch for PointSet only

Aug 2 2016, 9:33 AM
schwarzt added a comment to T3148: Add convenience method for setting CurveStyle to QmitkPlotWidget.

[SVN revision 20787]
FIX (#3148): Added convenience method for setting CurveSymbol

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3148: Add convenience method for setting CurveStyle to QmitkPlotWidget.

[SVN revision 20786]
FIX (#3148): Added convenience method for setting CurveStyle

Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added projects to T3148: Add convenience method for setting CurveStyle to QmitkPlotWidget: MITK, Bugzilla.
Aug 2 2016, 9:33 AM · Bugzilla, MITK
schwarzt added a comment to T3120: Build up a bundle for the purpouse of using the Hough3D Algorithm.

Butter call it "using" :)

Aug 2 2016, 9:32 AM · Bugzilla, MITK
schwarzt added a comment to T3113: Basic Image Procession crashes with 2d images.

[SVN revision 20657]
FIX (#3113): 2D image cannot be selected any more.

Aug 2 2016, 9:32 AM · Bugzilla, MITK
schwarzt added a comment to T3099: Organize shape model distribution on CD.

As Michi said, the models must be unpacked to work. This is only done automatically when downloading. So maybe it would be better to distribute them unpacked on CD.

Aug 2 2016, 9:32 AM · Bugzilla, MITK
schwarzt added a comment to T3099: Organize shape model distribution on CD.

Models are downloaded to std::string downloadPath = mitk::StandardFileLocations::GetInstance()->GetOptionDirectory();

Aug 2 2016, 9:32 AM · Bugzilla, MITK
schwarzt added a comment to T3099: Organize shape model distribution on CD.

Comment from Hannes in #2979:

Aug 2 2016, 9:32 AM · Bugzilla, MITK