- User Since
- Mar 2 2020, 3:23 PM (34 w, 1 d)
Thu, Oct 15
stabilityByAlgorithmStacked is now replaced by stabilityByAlgorithm(....., stacked=TRUE)
Mon, Oct 12
disadvantage would be dependency on another package facilitating ggplot2 dendrograms
current implementation is fine. However, we said it would be nice if all plots (if directly called by users and not within the report) would have the same syntax and could be layouted with ggplot2 syntax. current implementation is using basic R graphics.
turned off in v1.0, everything else postponed
Thu, Oct 8
This was a tricky bug, thanks!
alpha is now respected, argument FUN is removed. significance ranking is considered an aggregation step, so testThenRank() is nothing else than aggregateThenRank(FUN="significance").
Note that testThenRank will pass all arguments to decision.challenge(), i.e. it will respect arguments:
Mon, Oct 5
Fri, Oct 2
Thu, Oct 1
stacked frequency plots are quite neglected. They are not mentioned in the paper. Are they interesting or should they be removed entirely?
keep S3, compareRanks and extract.workflow
but do not export (i.e. remove from namespace) compareRanks and extract.workflow. they can then only be accessed e.g. by challengeR:::compareRanks(). These might be of practical use.
Sep 25 2020
Sep 24 2020
I propose to turn off networks and exclude them from the report for now.
if this is solved, we can reintroduce them.
they are not essential I think. what do you think?
this will require a further package, put on hold for the moment
taskSubset is deprecated
there is now
subset(x, top, tasks)
- if top is specified subset to top algorithms (only applicable to single task challenges)
- if tasks is specified subset of tasks (only applicable to multi task challenges)
20 might be a sensible number
the sentence can be dropped. But wasn't it planned to revise the text in line with the paper in total?
- it won't be more that I needed for the missing data description I guess;-) I still think that this sentence should be avoided if no subset is in fact used
this is more or less what I tried, ugliness is T27326. I think a ggplot solution mentioned there would be better
report gains new argument "dpi" to change resolution
set.seed(4) strip=runif(n,.9,1) c_ideal=cbind(task="c_ideal", rbind( data.frame(alg_name="A1",value=runif(n,.9,1),case=1:n), data.frame(alg_name="A2",value=runif(n,.8,.89),case=1:n), data.frame(alg_name="A3",value=runif(n,.7,.79),case=1:n), data.frame(alg_name="A4",value=runif(n,.6,.69),case=1:n), data.frame(alg_name="A5",value=runif(n,.5,.59),case=1:n) )) challenge=as.challenge(c_ideal, algorithm="alg_name", case="case", value="value", smallBetter = T) ranking=challenge%>%aggregateThenRank(FUN = "mean", # aggregation function, na.treat="na.rm", # either "na.rm" to remove missing data, ties.method = "min" # a character string specifying )
currently It says "The top 0 out of 0 algorithms are considered." in my latest example
- I think it will be confusing if it writes "top 5 of 5 algorithms", I would put an if
- which changes? as.challenge does not have a full data attribute. The changes in subset have been done by you, see my comments in T27685.
yes I think so. maybe you have purrr (or dplyr) and ggplot loaded in the workspace.
packages in depends are loaded at startup (and we need these package to be available by the user). imports does not load the packages, functions of challengeR can however call them.
it is true that packages in depends should be minimize, but these are needed
Sep 11 2020
the first sentence refers to the fact that no missings have been found in the data set. would rephrasing to "0 missing cases entered in the data set have been found" help? the next sentence is about cases which have been inserted by the sanity check. Would adding "However, ..." in between help?
If you have any other suggestions, I would be happy to include them
Sep 7 2020
@eisenman I dont understand this task, could you give an example?
solved in T27338
networks should be replaced by some ggplot2 implementation, see