HomePhabricator
Diffusion MITK 0d7e89ce4c44

Reorder functions, improve readability
Audited0d7e89ce4c44
Actions

Description

Reorder functions, improve readability

Details

Auditors
kalali
Provenance
j762eAuthored on Nov 25 2019, 4:23 PM
j762ePushed on Nov 25 2019, 5:04 PM
Parents
rMITK461d97787618: Re-add override
Branches
Unknown
Tags
Unknown

Event Timeline

j762e committed rMITK0d7e89ce4c44: Reorder functions, improve readability (authored by j762e).Nov 25 2019, 4:23 PM
kalali raised a concern with this commit.Nov 27 2019, 10:44 AM
kalali added a subscriber: kalali.
kalali added inline comments.
/Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp
318

Can you use 'QString::compare' so you don't have to convert to std::string?

This commit now has outstanding concerns.Nov 27 2019, 10:44 AM
kalali accepted this commit.Nov 27 2019, 11:56 AM
kalali added inline comments.
/Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp
318

Never mind, you did this in 5bdfc4c4048e.

All concerns with this commit have now been addressed.Nov 27 2019, 11:56 AM

Changes (3)

PathSizePackages
Modules/
Chart/
include/
O3: MITK Reviewer Group II
Plugins/
org.mitk.gui.qt.chartExample/
src/
internal/

rMITK0d7e89ce4c44

View Options

Modules/Chart/include/QmitkChartxyData.h

Loading...
View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.h

Loading...
MITK · MIC · IMSY · DKFZ