HomePhabricator
Diffusion MITK 1dbcb6d9ec91

First fix
Audited1dbcb6d9ec91
Actions

Description

First fix

Summary:
Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed missing series info

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Added IPropertOwner/IPropertyProvider interfaces to PropertyList and DICOMImageBlockDescriptor

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed T25441 / Refactored node naming

  • removed code redundancy
  • fixed error in the property value handling
  • made DicomEventHandler aware of data name

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: Unit tests and test protocols

Reviewers: MITK Reviewer Group I, kislinsk

Reviewed By: MITK Reviewer Group I, kislinsk

Maniphest Tasks: T25441

Differential Revision: https://phabricator.mitk.org/D166

Details

Auditors
floca
nolden
Provenance
flocaAuthored on Sep 14 2018, 5:57 PM
flocaPushed on Sep 21 2018, 2:40 PM
Reviewer
MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITK4049a6933036: use QApplication instead of qapplication for linux gcc
Branches
Unknown
Tags
Unknown
Tasks
T25441: Name DataNodes with DICOM data appropriately by using dicom tags

Event Timeline

floca committed rMITK1dbcb6d9ec91: First fix (authored by floca).Sep 21 2018, 2:38 PM
floca added a task: T25441: Name DataNodes with DICOM data appropriately by using dicom tags.
nolden raised a concern with this commit.Sep 25 2018, 11:44 AM
nolden added a subscriber: nolden.

Compile errors in mitkBaseData.cpp

/Modules/Core/src/DataManagement/mitkBaseData.cpp
347

This causes "unused parameter" warnings/errors for context-related parameters and breaks master build

This commit now has outstanding concerns.Sep 25 2018, 11:44 AM
floca accepted this commit.Oct 13 2018, 3:05 PM

GCC error was fixes. Thanks for the hint.

floca added a comment.Oct 13 2018, 3:06 PM

@nolden Could you please "unraise" your concern now. It is spoiling my statistics/dashboard. Thanks ;)

nolden accepted this commit.Apr 5 2019, 3:06 PM
All concerns with this commit have now been addressed.Apr 5 2019, 3:06 PM

Changes (12)

PathSizePackages
Modules/
Core/
include/
O1: MITK Reviewer Group I
O1: MITK Reviewer Group I
src/
DataManagement/
O1: MITK Reviewer Group I
O1: MITK Reviewer Group I
IO/
O1: MITK Reviewer Group I
O1: MITK Reviewer Group I
Rendering/
O1: MITK Reviewer Group I
DICOMReader/
include/
src/
Plugins/
org.mitk.gui.qt.dicom/
src/
internal/

rMITK1dbcb6d9ec91

View Options

Modules/Core/include/mitkDataNode.h

Loading...
View Options

Modules/Core/include/mitkPropertyList.h

Loading...
View Options

Modules/Core/src/DataManagement/mitkBaseData.cpp

Loading...
View Options

Modules/Core/src/DataManagement/mitkPropertyList.cpp

Loading...
View Options

Modules/Core/src/IO/mitkAbstractFileReader.cpp

Loading...
View Options

Modules/Core/src/IO/mitkIOUtil.cpp

Loading...
View Options

Modules/Core/src/Rendering/mitkMapper.cpp

Loading...
View Options

Modules/DICOMReader/include/mitkBaseDICOMReaderService.h

Loading...
View Options

Modules/DICOMReader/include/mitkDICOMImageBlockDescriptor.h

Loading...
View Options

Modules/DICOMReader/src/mitkBaseDICOMReaderService.cpp

Loading...
View Options

Modules/DICOMReader/src/mitkDICOMImageBlockDescriptor.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.dicom/src/internal/DicomEventHandler.cpp

Loading...
MITK · MIC · IMSY · DKFZ