HomePhabricator
Diffusion MITK 1f6747197e81

Fixed T26167. ExtractSliceFilter does not clone unnecessarily the input…

Authored by floca on Dec 6 2019, 2:37 PM.

Description

Fixed T26167. ExtractSliceFilter does not clone unnecessarily the input geometry.

first draft for a fix

Summary:
Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Removed some unnecessary copying of BoundsArrays

Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Reworked ExtractSliceFilter::GenerateOutput() to remove redundant code for things already done in GenerateOutputInformation()

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Revert "Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry"

This reverts commit 1f815a9b6d981bf5769beb269ab4c9a48d30c699.

Test Plan: Unit tests

Reviewers: MITK Reviewer Group I, kislinsk

Reviewed By: MITK Reviewer Group I, kislinsk

Subscribers: kislinsk

Maniphest Tasks: T26167

Differential Revision: https://phabricator.mitk.org/D223

Merged Changes

CommitAuthorDetailsCommitted
0c068a29b4affloca
Fixed review remarks 
Dec 6 2019
c3d79c9093d2floca
Revert "Test of performance impact of simplified (unsafer)… 
Nov 27 2019
33ada1271b45floca
Reworked ExtractSliceFilter::GenerateOutput() to remove redundant code for… 
Nov 27 2019
1f815a9b6d98floca
Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry 
Nov 27 2019
83f50cd74bc2nolden
Removed some unnecessary copying of BoundsArrays 
Nov 25 2019
b6cbc120c4b7floca
first draft for a fix 
Nov 19 2019