HomePhabricator
Diffusion MITK 245fd479b821

Fixed T27435
Audited245fd479b821
Actions

Description

Fixed T27435

Details

Auditors
floca
kalali
Provenance
flocaAuthored on Apr 28 2022, 10:40 PM
flocaPushed on Apr 28 2022, 10:40 PM
Parents
rMITK2107df8f2dd8: Fixed LabelSetImageHelper documentation
Branches
Unknown
Tags
Unknown
Tasks
T27435: [Registration] Mapper does not properly support LabelSetImages

Event Timeline

kalali accepted this commit.Apr 29 2022, 12:16 PM
kalali added a subscriber: kalali.
kalali added inline comments.
/Modules/MatchPointRegistration/src/Helper/mitkImageMappingHelper.cpp
302

*was really stored

303

active layer).

314

Could you use cloneInput->GetLabelSet(layerID) here to not clone again?

All concerns with this commit have now been addressed.Apr 29 2022, 12:16 PM
floca accepted this commit.Apr 29 2022, 12:36 PM
floca marked 3 inline comments as done.
floca added inline comments.
/Modules/MatchPointRegistration/src/Helper/mitkImageMappingHelper.cpp
314

Good catch. Yes.

floca committed rMITK245fd479b821: Fixed T27435 (authored by floca).Apr 28 2022, 10:40 PM
floca added a task: T27435: [Registration] Mapper does not properly support LabelSetImages.Apr 29 2022, 1:27 PM
floca marked an inline comment as done.Apr 29 2022, 2:07 PM
floca added inline comments.
/Modules/MatchPointRegistration/src/Helper/mitkImageMappingHelper.cpp
314

No. Does not work. Leads to crashes, due to event hooks, that becom invilde.
I keep it as is, as this works properly.

Changes (3)

PathSizePackages
Modules/
MatchPointRegistration/
O3: MITK Reviewer Group II
src/
Helper/
O3: MITK Reviewer Group II
O3: MITK Reviewer Group II

rMITK245fd479b821

View Options

Modules/MatchPointRegistration/CMakeLists.txt

Loading...
View Options

Modules/MatchPointRegistration/src/Helper/mitkImageMappingHelper.cpp

Loading...
View Options

Modules/MatchPointRegistration/src/Helper/mitkRegistrationHelper.cpp

Loading...
MITK · MIC · IMSY · DKFZ