HomePhabricator
Diffusion MITK 299e4454a05b

T27553 Crash_in_DICOMReaderServiceActivator:

Description

T27553 Crash_in_DICOMReaderServiceActivator:

Summary:
Prevented race condition that can lead to a crash when creating ManualSelectingDICOMReaderService.

Used a module listner to create reader as soon as MitkDICOMReader module is loaded.

Introduce Helper to ensure adding of tags of interest view service listening

Refactored code to use the DICOMTagsOfInterestAddHelper to avoid us::ModuleContext warnings.

Fixed T27553.

Test Plan: code review and unit tests

Reviewers: O1 MITK Reviewer Group I, kalali

Reviewed By: O1 MITK Reviewer Group I, kalali

Subscribers: kislinsk, nolden, kalali

Maniphest Tasks: T27553

Differential Revision: https://phabricator.mitk.org/D347

Details

Provenance
flocaAuthored on Jul 15 2020, 1:33 PM
flocaPushed on Jul 15 2020, 2:45 PM
Reviewer
O1: MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITKe51d05dec594: Fixed review remark
rMITKf51274ea5bd9: T27462 Crash_on_loading_multiple_3D+t_images
Branches
Unknown
Tags
Unknown
Tasks
T27553: Crash in DICOMReaderServiceActivator due to uninitialized module "DICOMReader"