HomePhabricator
Diffusion MITK 2ef6a51b13de

Add emplace

Description

Add emplace

Details

Auditors
kalali
Provenance
j762eAuthored on Nov 4 2019, 4:09 PM
j762ePushed on Nov 5 2019, 1:56 PM
Parents
rMITKe93ec50c83d7: Adapt HeaderFiles and Setup
Branches
Unknown
Tags
Unknown

Event Timeline

kalali added a subscriber: kalali.
kalali added inline comments.
/Modules/Chart/src/QmitkChartWidget.cpp
32

Please use nullptr for a null pointer, not 0.

36

Please do not remove the override.

Also, our file format says that we should not have virtual and override in the same line. Any overridden method must be virtual implicitly.
That is because a virtual method in the base class is also virtual in the derived class. And override specifies that a method inside a derived class should override the same function inside the base class. To make this work, the method has to be virtual in the base class in the first place.

This commit now has outstanding concerns.Nov 15 2019, 5:38 PM
All concerns with this commit have now been addressed.Jan 17 2020, 12:29 PM