Paths

Table of Contentst

Diffusion MITK 5bdfc4c4048e

Avoid repeated converting
Audited5bdfc4c4048e
Actions

Tags

None

Referenced Files

None

Subscribers

Description

Avoid repeated converting

Details

Auditors

Provenance

j762e	Authored on Nov 25 2019, 4:49 PM
j762e	Pushed on Nov 25 2019, 5:04 PM

Parents

rMITKbe64b0e66a24: Re-add emplace functionality

Branches

Unknown

Tags

Unknown

Event Timeline

j762e committed rMITK5bdfc4c4048e: Avoid repeated converting (authored by j762e).Nov 25 2019, 4:49 PM

kalali mentioned this in rMITK0d7e89ce4c44: Reorder functions, improve readability.Nov 27 2019, 11:56 AM

kalali raised a concern with this commit.Nov 27 2019, 11:59 AM

kalali added a subscriber: kalali.

kalali added inline comments.

/Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp
137	Why is this added again? I thought you wouldn't need the XtoY-maps anymore since you are using strings?
157	You can compare (Q)strings here, as you did in `UpdateSelectedData` or `AdaptDataGUI`. No need to rely on the `ChartType`.

This commit now has outstanding concerns.Nov 27 2019, 11:59 AM

kalali accepted this commit.Jan 17 2020, 12:27 PM

All concerns with this commit have now been addressed.Jan 17 2020, 12:27 PM

Changes (2)

Path

Size

Plugins/

org.mitk.gui.qt.chartExample/

src/

internal/

ChartExample.cpp

rMITK5bdfc4c4048e

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp

Loading...

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.h

Loading...