HomePhabricator
Diffusion MITK 602d4ed34af3

Correctly disable crosshair navigation

Description

Correctly disable crosshair navigation

Summary:
Replace the legacy display interactor

Additionally the legacy-config has been replaced with a simpler one.

Remove unused legacy interaction configuration

API-breaking changes

The DisplayConfigPACSBase.xml has been changed such that the alwaysReact parameter is now set to false (<param name="alwaysReact" value="false"/>).
This will change (and possibly break) expected behavior when using this display interaction configuration in conjunction with a data interactor (e.g. PlanarFigureInteractor: A specific mouse event will now only be handled by the data interactor and not be forwarded to the display interactor.
This is now in line with MITK-interaction configuration files, where the parameter was already set to false before.

Test Plan:
manual UI testing

  1. open MITK workbench, load an image
  2. open the QmitkMeasurementView plugin
  3. create a planar figure (preferably a path or something with multiple points)
  4. see how the crosshair interaction does not work while moving points
  5. do the same for the PACS mode
  6. see how the crosshair interaction does not work while moving points

Reviewers: kislinsk, s434n, O1 MITK Reviewer Group I

Reviewed By: kislinsk, s434n, O1 MITK Reviewer Group I

Subscribers: kalali, s434n, kislinsk

Tags: Breaking Change

Maniphest Tasks: T27663

Differential Revision: https://phabricator.mitk.org/D689

Details

Provenance
kalaliAuthored on Jul 19 2022, 7:12 PM
kalaliPushed on Aug 2 2022, 3:24 PM
Reviewer
O1: MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITK665c5a6ec10f: Remove unused legacy interaction configuration
rMITKc60420825488: Correctly disconnect the time navigation controller
Branches
Unknown
Tags
Unknown
Tasks
T27663: Crosshair navigation not disabled in QmitkMeasurementView