HomePhabricator
Diffusion MITK 726b04a3e631

Refactor AddChartExampleData to avoid converting
Audited726b04a3e631
Actions

Description

Refactor AddChartExampleData to avoid converting

Details

Auditors
kalali
Provenance
j762eAuthored on Nov 25 2019, 4:42 PM
j762ePushed on Nov 25 2019, 5:04 PM
Parents
rMITK1283b8222c0e: Add setUp and tearDown functionality
Branches
Unknown
Tags
Unknown

Event Timeline

j762e committed rMITK726b04a3e631: Refactor AddChartExampleData to avoid converting (authored by j762e).Nov 25 2019, 4:49 PM
kalali raised a concern with this commit.Nov 27 2019, 11:51 AM
kalali added a subscriber: kalali.
kalali added inline comments.
/Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp
138

Do you still need this or can you compare against a string, when checking for ChartType::pie?

This commit now has outstanding concerns.Nov 27 2019, 11:51 AM
kalali accepted this commit.Jan 17 2020, 12:27 PM
All concerns with this commit have now been addressed.Jan 17 2020, 12:27 PM

Changes (3)

PathSizePackages
Modules/
Chart/
include/
O3: MITK Reviewer Group II
src/
O3: MITK Reviewer Group II
Plugins/
org.mitk.gui.qt.chartExample/
src/
internal/

rMITK726b04a3e631

View Options

Modules/Chart/include/QmitkChartWidget.h

Loading...
View Options

Modules/Chart/src/QmitkChartWidget.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp

Loading...
MITK · MIC · IMSY · DKFZ