HomePhabricator
Diffusion MITK 9993086812bb

Changed handler classes: std-handler now inherits from base class and uses…

Description

Changed handler classes: std-handler now inherits from base class and uses default functions

Details

Auditors
floca
Provenance
kalaliAuthored on Apr 11 2018, 5:21 PM
kalaliPushed on Apr 11 2018, 5:22 PM
Parents
rMITKeac8b99e0769: Added comments and refactored according to review in T24216
Branches
Unknown
Tags
Unknown

Event Timeline

/Modules/Core/include/mitkDisplayActionEventDefaultFunctions.h
24

comments are wrong; will be changed with the next commit

floca added a subscriber: floca.

think its good.

/Modules/Core/include/mitkDisplayActionEventDefaultFunctions.h
22

If you use a sub namespace I would name it differently. So that it also fits other variantes, that are not default but implemented by others.

e.g. DisplayActionEventFunctions or so.

29–47

Minor issue/nice to have:
I think, I would change the function name to express more what the action does. "default" is very subjective and not always very helpfull when reading the code.

Additionally I think the default should some thing else in the future and more locally than the old implementations.

Maybe? e.g.
DefaultMoveAction -> MoveSenderCameraAction
DefaultSetCrosshair -> SetAllNonSenderCrosshairAction

All concerns with this commit have now been addressed.Apr 11 2018, 5:43 PM